Re: [Gluster-devel] A suggestion on naming test files.
And while we're at it, may we please rename the two or three test files that don't start with bug- to be (foolishly) consistent with the rest of our tests? Feeling more ambitious? How about renaming all the bug-$sixdigit.t to bug-0$sixdigit.t for some even more foolish consistency. (That's a zero, in case your font makes it look ambiguous.) -- Kaleb ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] A suggestion on naming test files.
All, Since I've had no objections to this idea, I'm going to update the documentation with this. Jeff, Could you explain what you meant by 'arranged into subdirectories'? I didn't understand what you meant by that. ~kaushal On Wed, Aug 27, 2014 at 5:07 PM, Jeff Darcy jda...@redhat.com wrote: Currently we name tests associated with a bug with just the bug-id as 'bug-XXX.t'. This naming doesn't provide any context directly, and someone looking at just the name wouldn't know what it does. I suggest that we use slightly more descriptive names to the tests. Lets name the tests as 'bug-XXX-checking-if-feature-Y-works.t'. This provides just enough context to understand what the test is trying to do from just the name. How do you all feel about this? It's an excellent idea. While we're at it, it would also be nice if tests were arranged into subdirectories so that it's easier to find those that might be particularly useful for testing new code. BTW, it should be possible to write a script that would fetch the bug title from Bugzilla, which (properly mangled) could be a first guess at the new test name. ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] A suggestion on naming test files.
Hi all, Currently we name tests associated with a bug with just the bug-id as 'bug-XXX.t'. This naming doesn't provide any context directly, and someone looking at just the name wouldn't know what it does. I suggest that we use slightly more descriptive names to the tests. Lets name the tests as 'bug-XXX-checking-if-feature-Y-works.t'. This provides just enough context to understand what the test is trying to do from just the name. How do you all feel about this? ~kaushal ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] A suggestion on naming test files.
On 27/08/2014, at 7:56 AM, Pranith Kumar Karampuri wrote: On 08/27/2014 12:21 PM, Kaushal M wrote: Hi all, Currently we name tests associated with a bug with just the bug-id as 'bug-XXX.t'. This naming doesn't provide any context directly, and someone looking at just the name wouldn't know what it does. I suggest that we use slightly more descriptive names to the tests. Lets name the tests as 'bug-XXX-checking-if-feature-Y-works.t'. This provides just enough context to understand what the test is trying to do from just the name. How do you all feel about this? +100 Yeah, this sounds like a good idea. If I ever get around to writing test cases :, I'll try that out. ;) + Justin -- GlusterFS - http://www.gluster.org An open source, distributed file system scaling to several petabytes, and handling thousands of clients. My personal twitter: twitter.com/realjustinclift ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] A suggestion on naming test files.
On Wed, Aug 27, 2014 at 12:21:56PM +0530, Kaushal M wrote: Hi all, Currently we name tests associated with a bug with just the bug-id as 'bug-XXX.t'. This naming doesn't provide any context directly, and someone looking at just the name wouldn't know what it does. I suggest that we use slightly more descriptive names to the tests. Lets name the tests as 'bug-XXX-checking-if-feature-Y-works.t'. This provides just enough context to understand what the test is trying to do from just the name. How do you all feel about this? Sounds good to me. Please make sure to update the documentation about writing test-cases in a few days, if nobody objects. Thanks, Niels ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] A suggestion on naming test files.
I'll do that, if someone could point me to it. Is it on the community wiki or in doc/ directory in the source? ~kaushal On Wed, Aug 27, 2014 at 1:12 PM, Niels de Vos nde...@redhat.com wrote: On Wed, Aug 27, 2014 at 12:21:56PM +0530, Kaushal M wrote: Hi all, Currently we name tests associated with a bug with just the bug-id as 'bug-XXX.t'. This naming doesn't provide any context directly, and someone looking at just the name wouldn't know what it does. I suggest that we use slightly more descriptive names to the tests. Lets name the tests as 'bug-XXX-checking-if-feature-Y-works.t'. This provides just enough context to understand what the test is trying to do from just the name. How do you all feel about this? Sounds good to me. Please make sure to update the documentation about writing test-cases in a few days, if nobody objects. Thanks, Niels ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] A suggestion on naming test files.
On 08/27/2014 02:13 PM, Niels de Vos wrote: On Wed, Aug 27, 2014 at 01:50:40PM +0530, Kaushal M wrote: I'll do that, if someone could point me to it. Is it on the community wiki or in doc/ directory in the source? Seems to be only (?) on the wiki: - http://www.gluster.org/community/documentation/index.php/Using_the_Gluster_Test_Framework#Creating_your_own_tests Niels We should also update README.md file in source code i.e. glusterfs/tests. -Lala ~kaushal On Wed, Aug 27, 2014 at 1:12 PM, Niels de Vos nde...@redhat.com wrote: On Wed, Aug 27, 2014 at 12:21:56PM +0530, Kaushal M wrote: Hi all, Currently we name tests associated with a bug with just the bug-id as 'bug-XXX.t'. This naming doesn't provide any context directly, and someone looking at just the name wouldn't know what it does. I suggest that we use slightly more descriptive names to the tests. Lets name the tests as 'bug-XXX-checking-if-feature-Y-works.t'. This provides just enough context to understand what the test is trying to do from just the name. How do you all feel about this? Sounds good to me. Please make sure to update the documentation about writing test-cases in a few days, if nobody objects. Thanks, Niels ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] A suggestion on naming test files.
On 08/27/2014 03:29 PM, Lalatendu Mohanty wrote: On 08/27/2014 02:13 PM, Niels de Vos wrote: On Wed, Aug 27, 2014 at 01:50:40PM +0530, Kaushal M wrote: I'll do that, if someone could point me to it. Is it on the community wiki or in doc/ directory in the source? Seems to be only (?) on the wiki: - http://www.gluster.org/community/documentation/index.php/Using_the_Gluster_Test_Framework#Creating_your_own_tests Niels We should also update README.md file in source code i.e. glusterfs/tests. + Forgot to add that README.md does not a section about writing tests, either we add a new section or we can update the wiki page and update the wiki link in the README file. -Lala ~kaushal On Wed, Aug 27, 2014 at 1:12 PM, Niels de Vos nde...@redhat.com wrote: On Wed, Aug 27, 2014 at 12:21:56PM +0530, Kaushal M wrote: Hi all, Currently we name tests associated with a bug with just the bug-id as 'bug-XXX.t'. This naming doesn't provide any context directly, and someone looking at just the name wouldn't know what it does. I suggest that we use slightly more descriptive names to the tests. Lets name the tests as 'bug-XXX-checking-if-feature-Y-works.t'. This provides just enough context to understand what the test is trying to do from just the name. How do you all feel about this? Sounds good to me. Please make sure to update the documentation about writing test-cases in a few days, if nobody objects. Thanks, Niels ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
