Re: [Gluster-devel] Review request - patch #15036

[Amar Tumballi]

Have just 1 comment. Once you answer it, its good to go.

On Fri, May 12, 2017 at 9:48 AM, Raghavendra G 
wrote:

> I'll wait for a day on this. If there are no reviews, I'll assume that as
> a +1 and will go ahead and merge it. If anyone needs more time, please let
> me know and I can wait.
>
> On Thu, May 11, 2017 at 12:22 PM, Raghavendra Gowdappa <
> rgowd...@redhat.com> wrote:
>
>> All,
>>
>> Reviews are requested on [1]. Impact is non-trivial as it introduces more
>> concurrency in execution wrt processing of messages read from network.
>>
>> All tests are passed, though gerrit is not reflecting the last smoke
>> which was successful.
>>
>> For reference, below is the verbatim copy of commit msg:
>>
>> 
>>
>> event/epoll: Add back socket for polling of events immediately after
>> reading the entire rpc message from the wire Currently socket is added back
>> for future events after higher layers (rpc, xlators etc) have processed the
>> message. If message processing involves signficant delay (as in writev
>> replies processed by Erasure Coding), performance takes hit. Hence this
>> patch modifies transport/socket to add back the socket for polling of
>> events immediately after reading the entire rpc message, but before
>> notification to higher layers.
>>
>> credits: Thanks to "Kotresh Hiremath Ravishankar" 
>> for assitance in fixing a regression in bitrot caused by this patch.
>>
>> BUG: 1448364
>> 
>>
>> @Nigel,
>>
>> Is there a way to override -1 from smoke, as last instance of it is
>> successful?
>>
>> [1] https://review.gluster.org/#/c/15036/
>>
>> regards,
>> Raghavendra
>> ___
>> Gluster-devel mailing list
>> Gluster-devel@gluster.org
>> http://lists.gluster.org/mailman/listinfo/gluster-devel
>>
>
>
>
> --
> Raghavendra G
>
> ___
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel
>



-- 
Amar Tumballi (amarts)
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] Review request - patch #15036

[Raghavendra G]

I'll wait for a day on this. If there are no reviews, I'll assume that as a
+1 and will go ahead and merge it. If anyone needs more time, please let me
know and I can wait.

On Thu, May 11, 2017 at 12:22 PM, Raghavendra Gowdappa 
wrote:

> All,
>
> Reviews are requested on [1]. Impact is non-trivial as it introduces more
> concurrency in execution wrt processing of messages read from network.
>
> All tests are passed, though gerrit is not reflecting the last smoke which
> was successful.
>
> For reference, below is the verbatim copy of commit msg:
>
> 
>
> event/epoll: Add back socket for polling of events immediately after
> reading the entire rpc message from the wire Currently socket is added back
> for future events after higher layers (rpc, xlators etc) have processed the
> message. If message processing involves signficant delay (as in writev
> replies processed by Erasure Coding), performance takes hit. Hence this
> patch modifies transport/socket to add back the socket for polling of
> events immediately after reading the entire rpc message, but before
> notification to higher layers.
>
> credits: Thanks to "Kotresh Hiremath Ravishankar" 
> for assitance in fixing a regression in bitrot caused by this patch.
>
> BUG: 1448364
> 
>
> @Nigel,
>
> Is there a way to override -1 from smoke, as last instance of it is
> successful?
>
> [1] https://review.gluster.org/#/c/15036/
>
> regards,
> Raghavendra
> ___
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel
>



-- 
Raghavendra G
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] Review request - patch #15036

[Raghavendra Gowdappa]

All,

Reviews are requested on [1]. Impact is non-trivial as it introduces more 
concurrency in execution wrt processing of messages read from network.

All tests are passed, though gerrit is not reflecting the last smoke which was 
successful.

For reference, below is the verbatim copy of commit msg:



event/epoll: Add back socket for polling of events immediately after reading 
the entire rpc message from the wire Currently socket is added back for future 
events after higher layers (rpc, xlators etc) have processed the message. If 
message processing involves signficant delay (as in writev replies processed by 
Erasure Coding), performance takes hit. Hence this patch modifies 
transport/socket to add back the socket for polling of events immediately after 
reading the entire rpc message, but before notification to higher layers. 

credits: Thanks to "Kotresh Hiremath Ravishankar"  for 
assitance in fixing a regression in bitrot caused by this patch.

BUG: 1448364


@Nigel,

Is there a way to override -1 from smoke, as last instance of it is successful?

[1] https://review.gluster.org/#/c/15036/

regards,
Raghavendra
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel