Re: [Gluster-devel] tier: breaking down the monolith processing function

2016-07-21 Thread Milind Changire 

On 07/21/2016 03:03 AM, Vijay Bellur wrote:

On 07/19/2016 07:54 AM, Milind Changire wrote:

I've attempted to break the tier_migrate_using_query_file() function
into relatively smaller functions. The important one is
tier_migrate_link().




Can tier_migrate_link() be broken down further? Having more than 80-100
LOC in a function does normally look excessive to me.

Thanks,
Vijay



I've broken it [1] down some more ... please take a look.

1. http://review.gluster.org/14957

--
Milind
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] tier: breaking down the monolith processing function

2016-07-20 Thread Vijay Bellur 

On 07/19/2016 07:54 AM, Milind Changire wrote:

I've attempted to break the tier_migrate_using_query_file() function
into relatively smaller functions. The important one is
tier_migrate_link().




Can tier_migrate_link() be broken down further? Having more than 80-100 
LOC in a function does normally look excessive to me.


Thanks,
Vijay

___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] tier: breaking down the monolith processing function for glusterfs-3.9.0

2016-07-19 Thread Milind Changire 

I'm planning to get this into the upstream 3.9 release.

Milind

On 07/19/2016 05:24 PM, Milind Changire wrote:

I've attempted to break the tier_migrate_using_query_file() function
into relatively smaller functions. The important one is
tier_migrate_link().

Please take a look at http://review.gluster.org/14957 and voice your
opinions.

A prelude to this effort is similar work as part of
http://review.gluster.org/14780


___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] tier: breaking down the monolith processing function

2016-07-19 Thread Milind Changire 

I've attempted to break the tier_migrate_using_query_file() function
into relatively smaller functions. The important one is
tier_migrate_link().

Please take a look at http://review.gluster.org/14957 and voice your
opinions.

A prelude to this effort is similar work as part of
http://review.gluster.org/14780

--
Milind
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel