Re: [Gluster-devel] Flooding of client logs with JSON fop statistics under DEBUG log-level
On Sun, 2016-03-20 at 12:42 +0100, Niels de Vos wrote: > On Fri, Mar 18, 2016 at 03:14:08PM -0400, Jeff Darcy wrote: > > > > > > > > Since we have a volume set option(diagnostics.stats-dump- > > > interval) to > > > increase/decrease the dump interval can't we make its default > > > value to 0 > > > which will disable dumping statistics at first place? > > I don't have a particularly strong opinion on the matter. My > > *personal* > > preference is to disable periodic stats, but I'm a > > developer. What's most > > convenient for me might not be what's best for users/operators. > We have not broadly advertised this feature. I do not know if it is > in > the documentation at all? (Search is broken, so that's difficult to > check.) > > Disabling by default sounds good to me, users that want to enable it > can > then select the right interval for their use-case. Just make sure the > documentation is updated/added too. Thanks for your responses. For now I have filed a BZ[1] and have sent a one liner fix[2] to disable it by default. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1320101 [2] http://review.gluster.org/#/c/13808/ --Anoop C S. ___ Gluster-devel mailing list Gluster-devel@gluster.org http://www.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Flooding of client logs with JSON fop statistics under DEBUG log-level
On Fri, Mar 18, 2016 at 03:14:08PM -0400, Jeff Darcy wrote: > > Since we have a volume set option(diagnostics.stats-dump-interval) to > > increase/decrease the dump interval can't we make its default value to 0 > > which will disable dumping statistics at first place? > > I don't have a particularly strong opinion on the matter. My *personal* > preference is to disable periodic stats, but I'm a developer. What's most > convenient for me might not be what's best for users/operators. We have not broadly advertised this feature. I do not know if it is in the documentation at all? (Search is broken, so that's difficult to check.) Disabling by default sounds good to me, users that want to enable it can then select the right interval for their use-case. Just make sure the documentation is updated/added too. Niels signature.asc Description: PGP signature ___ Gluster-devel mailing list Gluster-devel@gluster.org http://www.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Flooding of client logs with JSON fop statistics under DEBUG log-level
> Since we have a volume set option(diagnostics.stats-dump-interval) to > increase/decrease the dump interval can't we make its default value to 0 > which will disable dumping statistics at first place? I don't have a particularly strong opinion on the matter. My *personal* preference is to disable periodic stats, but I'm a developer. What's most convenient for me might not be what's best for users/operators. > On the other side diagnostics.stats-dump-interval lacks OPT_FLAG_CLIENT_OPT > flag[2] to notify clients on the fly about the change in value which means > that this change will take effect only after umount and re-mount of the > volume (glusterd folks can correct me if I am wrong here). Sounds like a bug and patch are called for. ___ Gluster-devel mailing list Gluster-devel@gluster.org http://www.gluster.org/mailman/listinfo/gluster-devel
