[Gluster-infra] [Bug 1440810] Update rfc.sh to check Change-Id consistency for backports

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440810

Niels de Vos  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=OMJXkYyRMf=cc_unsubscribe
___
Gluster-infra mailing list
Gluster-infra@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-infra

[Gluster-infra] [Bug 1440810] Update rfc.sh to check Change-Id consistency for backports

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440810



--- Comment #2 from Worker Ant  ---
COMMIT: https://review.gluster.org/17031 committed in release-3.8 by Niels de
Vos (nde...@redhat.com) 
--
commit ddf3d4d3785bbd4f964e54ebc72fd445662f21a5
Author: Shyam 
Date:   Wed Apr 5 14:22:57 2017 -0400

scripts: Update rfc.sh to check existance of Change-Id in backports

Addition to this script is a no-op on master.

This would need to be backported to active release branches to be
effective.

This check is not smart proof, in that someone could proceed knowing
that the Change-Id differs from master, but this is not expected to
catch that, instead it is to serve more as a reminder that we need
the same Change-Id across branches.

Contributors not using rfc.sh would not see this, but they are few
and possibly far in between. Also contributors using gerrit to
cherry-pick changes will not see this. For both cases a server side
solution to catch any changes are needed.

There is a possiblilty that we will follow this up with a check
on the gerrit end and add a comment to the reviews, to aid reviewers
to quickly check the sanity of the Change-Id when it differs.

> BUG: 1428047
> Signed-off-by: Shyam 
> Reviewed-on: https://review.gluster.org/17004
> Smoke: Gluster Build System 
> Reviewed-by: Niels de Vos 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: Amar Tumballi 

Change-Id: I11e371489a4a3cf2ff96d9892256986cd535998b
BUG: 1440810
Signed-off-by: Shyam 
Reviewed-on: https://review.gluster.org/17031
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kuCnf7siaj=cc_unsubscribe
___
Gluster-infra mailing list
Gluster-infra@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-infra