Re: [Gluster-infra] Issue in locks xlators

[Xavier Hernandez]

Hi Nigel,

On 10/03/17 10:11, Nigel Babu wrote:

We don't currently save the logs for aborted jos, but I can set that up
for you. What files do you want logged?


I would need the mount point and brick logs.

Thanks,

Xavi



On Fri, Mar 10, 2017 at 1:15 PM, Xavier Hernandez mailto:xhernan...@datalab.es>> wrote:

Hi,

I've posted a patch [1] to fix a memory leak in locks xlator. The
fix seems quite straightforward, however I've seen a deadlock in the
centos regression twice [2] [3] on the locks_revocation.t test,
causing the test to timeout and be aborted.

At first sight I haven't seen other failures of this kind for other
patches, so it seems that the spurious failure has been introduced
by my patch.

Anyone with deeper knowledge on locks xlator can help me identify
the cause ? I'm unable to see how the change can interfere with lock
revocation.

I've tried to reproduce it locally, but the test passed successfully
all times.

@Nigel, is it possible to get the logs generated by an aborted job
from some place ? I have looked into the place where failed jobs
store their logs, but aren't there. It seems that the slave node is
restarted after an abort, but logs are not saved.

Thanks,

Xavi

[1] https://review.gluster.org/16838/

[2] https://build.gluster.org/job/centos6-regression/3563/console

[3] https://build.gluster.org/job/centos6-regression/3579/console





--
nigelb


___
Gluster-infra mailing list
Gluster-infra@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-infra

Re: [Gluster-infra] Issue in locks xlators

[Nigel Babu]

We don't currently save the logs for aborted jos, but I can set that up for
you. What files do you want logged?

On Fri, Mar 10, 2017 at 1:15 PM, Xavier Hernandez 
wrote:

> Hi,
>
> I've posted a patch [1] to fix a memory leak in locks xlator. The fix
> seems quite straightforward, however I've seen a deadlock in the centos
> regression twice [2] [3] on the locks_revocation.t test, causing the test
> to timeout and be aborted.
>
> At first sight I haven't seen other failures of this kind for other
> patches, so it seems that the spurious failure has been introduced by my
> patch.
>
> Anyone with deeper knowledge on locks xlator can help me identify the
> cause ? I'm unable to see how the change can interfere with lock revocation.
>
> I've tried to reproduce it locally, but the test passed successfully all
> times.
>
> @Nigel, is it possible to get the logs generated by an aborted job from
> some place ? I have looked into the place where failed jobs store their
> logs, but aren't there. It seems that the slave node is restarted after an
> abort, but logs are not saved.
>
> Thanks,
>
> Xavi
>
> [1] https://review.gluster.org/16838/
> [2] https://build.gluster.org/job/centos6-regression/3563/console
> [3] https://build.gluster.org/job/centos6-regression/3579/console
>



-- 
nigelb
___
Gluster-infra mailing list
Gluster-infra@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-infra

[Gluster-infra] Issue in locks xlators

[Xavier Hernandez]

Hi,

I've posted a patch [1] to fix a memory leak in locks xlator. The fix 
seems quite straightforward, however I've seen a deadlock in the centos 
regression twice [2] [3] on the locks_revocation.t test, causing the 
test to timeout and be aborted.


At first sight I haven't seen other failures of this kind for other 
patches, so it seems that the spurious failure has been introduced by my 
patch.


Anyone with deeper knowledge on locks xlator can help me identify the 
cause ? I'm unable to see how the change can interfere with lock revocation.


I've tried to reproduce it locally, but the test passed successfully all 
times.


@Nigel, is it possible to get the logs generated by an aborted job from 
some place ? I have looked into the place where failed jobs store their 
logs, but aren't there. It seems that the slave node is restarted after 
an abort, but logs are not saved.


Thanks,

Xavi

[1] https://review.gluster.org/16838/
[2] https://build.gluster.org/job/centos6-regression/3563/console
[3] https://build.gluster.org/job/centos6-regression/3579/console
___
Gluster-infra mailing list
Gluster-infra@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-infra