Re: [Gluster-infra] [Gluster-devel] Gerrit Access Control

[Niels de Vos]

On Tue, Sep 06, 2016 at 12:32:42PM +0530, Nigel Babu wrote:
> On Thu, Sep 01, 2016 at 12:43:06PM +0530, Nigel Babu wrote:
> > > > Just need a clarification. Does a "commit in the last 90 days" means
> > > > merging a patch sent by someone else by maintainer or maintainer 
> > > > sending a
> > > > patch to be merged?
> > >
> >
> > Your email needs to either be in Reviewed-By or Author in git log. So you
> > either need to send patches or review patches. Ideally, I'm looking for
> > activity on Gerrit and this is the easiest way to figure that out. Yes, I'm
> > checking across all active branches.
> >
> > As an additional bonus, this will also give us a list of people who should 
> > be
> > on the maintainers team, but aren't.
> >
> > > Interesting question. I was wondering about something similar as well.
> > > What about commits/permissions for the different repositories we host on
> > > Gerrit? Does each repository has its own maintainers, or is it one group
> > > of maintainers that has merge permissions for all repos?
> > >
> >
> > Each repo on Gerrit seems to mostly have it's own permissions. That's
> > a sensible way to go about it. Some of them are unused a clean up is coming
> > along, but that's later.
> 
> I've answered everyone's concerns on this thread. If nobody is opposed to the
> idea, shall I go ahead with this?

If you mean "removing+emailing maintainers that are not active in Gerrit
anymore", I guess that should be fine. However, before you do this, make
sure the requirements to be counted as 'active' are included in our
contributors guide. You can then easily add the link to the page in your
emails.

Niels


signature.asc
Description: PGP signature
___
Gluster-infra mailing list
Gluster-infra@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-infra

Re: [Gluster-infra] [Gluster-devel] Gerrit Access Control

[Nigel Babu]

On Mon, Aug 29, 2016 at 08:42:22PM +0200, Niels de Vos wrote:
> On Mon, Aug 29, 2016 at 09:18:05PM +0530, Pranith Kumar Karampuri wrote:
> > On Mon, Aug 29, 2016 at 12:25 PM, Nigel Babu  wrote:
> >
> > > Hello folks,
> > >
> > > We have not pruned our Gerrit maintainers list ever as far as I can see.
> > > We've
> > > only added people. For security reasons, I'd like to propose that we do 
> > > the
> > > following:
> > >
> > > If you do not have a commit in the last 90 days, your membership from
> > > gluster-maintainers team on Gerrit will be revoked. This means you won't
> > > have
> > > permission to merge patches. This does not mean you're no longer
> > > maintainer.
> > > This is only a security measure. To gain access again, all you have to do
> > > is
> > > file a bug against gluster-infra and I'll grant you access immediately.
> > >
> >
> > Just need a clarification. Does a "commit in the last 90 days" means
> > merging a patch sent by someone else by maintainer or maintainer sending a
> > patch to be merged?
>

Your email needs to either be in Reviewed-By or Author in git log. So you
either need to send patches or review patches. Ideally, I'm looking for
activity on Gerrit and this is the easiest way to figure that out. Yes, I'm
checking across all active branches.

As an additional bonus, this will also give us a list of people who should be
on the maintainers team, but aren't.

> Interesting question. I was wondering about something similar as well.
> What about commits/permissions for the different repositories we host on
> Gerrit? Does each repository has its own maintainers, or is it one group
> of maintainers that has merge permissions for all repos?
>

Each repo on Gerrit seems to mostly have it's own permissions. That's
a sensible way to go about it. Some of them are unused a clean up is coming
along, but that's later.

> Niels
>
> >
> >
> > >
> > > When I remove someone's access, I'll send an invidual email about it.
> > > Again,
> > > your membership on gluster-maintainers has no say on your maintainer
> > > status.
> > > This is only for security reasons.
> > >
> > > Thoughts on implementing this policy?
> > >
> > > --
> > > nigelb
> > > ___
> > > Gluster-devel mailing list
> > > gluster-de...@gluster.org
> > > http://www.gluster.org/mailman/listinfo/gluster-devel
> > >
> >
> >
> >
> > --
> > Pranith
>
> > ___
> > Gluster-devel mailing list
> > gluster-de...@gluster.org
> > http://www.gluster.org/mailman/listinfo/gluster-devel
>



--
nigelb
___
Gluster-infra mailing list
Gluster-infra@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-infra

Re: [Gluster-infra] [Gluster-devel] Gerrit Access Control

[Niels de Vos]

On Mon, Aug 29, 2016 at 09:18:05PM +0530, Pranith Kumar Karampuri wrote:
> On Mon, Aug 29, 2016 at 12:25 PM, Nigel Babu  wrote:
> 
> > Hello folks,
> >
> > We have not pruned our Gerrit maintainers list ever as far as I can see.
> > We've
> > only added people. For security reasons, I'd like to propose that we do the
> > following:
> >
> > If you do not have a commit in the last 90 days, your membership from
> > gluster-maintainers team on Gerrit will be revoked. This means you won't
> > have
> > permission to merge patches. This does not mean you're no longer
> > maintainer.
> > This is only a security measure. To gain access again, all you have to do
> > is
> > file a bug against gluster-infra and I'll grant you access immediately.
> >
> 
> Just need a clarification. Does a "commit in the last 90 days" means
> merging a patch sent by someone else by maintainer or maintainer sending a
> patch to be merged?

Interesting question. I was wondering about something similar as well.
What about commits/permissions for the different repositories we host on
Gerrit? Does each repository has its own maintainers, or is it one group
of maintainers that has merge permissions for all repos?

Niels

> 
> 
> >
> > When I remove someone's access, I'll send an invidual email about it.
> > Again,
> > your membership on gluster-maintainers has no say on your maintainer
> > status.
> > This is only for security reasons.
> >
> > Thoughts on implementing this policy?
> >
> > --
> > nigelb
> > ___
> > Gluster-devel mailing list
> > gluster-de...@gluster.org
> > http://www.gluster.org/mailman/listinfo/gluster-devel
> >
> 
> 
> 
> -- 
> Pranith

> ___
> Gluster-devel mailing list
> gluster-de...@gluster.org
> http://www.gluster.org/mailman/listinfo/gluster-devel



signature.asc
Description: PGP signature
___
Gluster-infra mailing list
Gluster-infra@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-infra

Re: [Gluster-infra] [Gluster-devel] Gerrit Access Control

[Pranith Kumar Karampuri]

On Mon, Aug 29, 2016 at 12:25 PM, Nigel Babu  wrote:

> Hello folks,
>
> We have not pruned our Gerrit maintainers list ever as far as I can see.
> We've
> only added people. For security reasons, I'd like to propose that we do the
> following:
>
> If you do not have a commit in the last 90 days, your membership from
> gluster-maintainers team on Gerrit will be revoked. This means you won't
> have
> permission to merge patches. This does not mean you're no longer
> maintainer.
> This is only a security measure. To gain access again, all you have to do
> is
> file a bug against gluster-infra and I'll grant you access immediately.
>

Just need a clarification. Does a "commit in the last 90 days" means
merging a patch sent by someone else by maintainer or maintainer sending a
patch to be merged?


>
> When I remove someone's access, I'll send an invidual email about it.
> Again,
> your membership on gluster-maintainers has no say on your maintainer
> status.
> This is only for security reasons.
>
> Thoughts on implementing this policy?
>
> --
> nigelb
> ___
> Gluster-devel mailing list
> gluster-de...@gluster.org
> http://www.gluster.org/mailman/listinfo/gluster-devel
>



-- 
Pranith
___
Gluster-infra mailing list
Gluster-infra@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-infra