Re: [Gluster-infra] Can I update /opt/qa for NetBSD?
Nigel Babu wrote: > Practically, I only need someone to look at one line: Where is this fs used? For instance, mount(8) knows about ffs, not UFS: $ mount /dev/raid0a on / type ffs (log, local) /dev/raid0e on /mail type ffs (log, nodev, nosuid, local, with quotas) /dev/raid1a on /ssd type ffs (log, nodev, nosuid, local) kernfs on /kern type kernfs (local) -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz m...@netbsd.org ___ Gluster-infra mailing list Gluster-infra@gluster.org http://www.gluster.org/mailman/listinfo/gluster-infra
Re: [Gluster-infra] Can I update /opt/qa for NetBSD?
Hello folks, I've been thinking about a different approach here. I'd like to fork the build.sh/regression.sh/smoke.sh scripts for NetBSD until we unify them. This seems to be the approach with most gains at this point. This way, I can make smaller bite sized changes that can be tested in production (as a separate test job). This also means what's in the repo is what's currently running. So, I'd have netbsd-smoke.sh, netbsd-regression.sh, and netbsd-build.sh for a while. I will work on merging the changes into one script. Watch out for me nagging you for reviews :) Speaking of harassing for reviews: https://github.com/gluster/glusterfs-patch-acceptance-tests/pull/50 Practically, I only need someone to look at one line: https://github.com/gluster/glusterfs-patch-acceptance-tests/pull/50/files#diff-db1659608ae45b2644416de2b9a76d3cR8 -- nigelb ___ Gluster-infra mailing list Gluster-infra@gluster.org http://www.gluster.org/mailman/listinfo/gluster-infra
Re: [Gluster-infra] Can I update /opt/qa for NetBSD?
Nigel Babu wrote: > I'll definitely appreciate any feedback you can have in terms > of code when it's ready for review. No problem. But regresson infrastructure will catch any issue better that I would, anyway. :-) -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz m...@netbsd.org ___ Gluster-infra mailing list Gluster-infra@gluster.org http://www.gluster.org/mailman/listinfo/gluster-infra
Re: [Gluster-infra] Can I update /opt/qa for NetBSD?
On Sun, Aug 07, 2016 at 06:41:49AM +0200, Emmanuel Dreyfus wrote: > Nigel Babu wrote: > > > * A bunch of cleanup scripts are in build.sh. I think they can move into the > > Jenkins job itself. That's what we do for linux boxes. > > Feel free to do it, but is there a benefit? If it is not broken, do not > fix it... Originally, I was trying to fix two small things - Routinely clear up the archives folder and fix the link to the logs. > > > * Some test files have been made to 0644. Is this relevant or are these > > accidental changes? > > Probable accidental change. Excellent, I'll revert them and merge them. > > > * Can the Python path and stuff be declared before the build.sh script is > > called in the Jenkins script? I don't know if this will work, I'll have to > > test. > > You need to run build.sh so that configure is invoked and env.rc is > created with appropriate @BUILD_PYTHON_SITE_PACKAGES@ set > (see tests/env.rc.in) > Yeah, this is the bit where I'm unsure if I can set it in Jenkins or only on this particular script. > > > * I think we now have a standard way of skipping tests in the test runner > > itself rather than deleting the tests from the checkout. If not, I'll > > drive > > these fixes. > > It may not scale when you want to skip all the bugs directory. Aha. > > > * The check for whether there's two jobs assigned to the same machine can > > be controlled from Jenkins and I plan to do that, so we can probably > > remove that code as well. > > That seems better, as the current setting bugs when a job is manually > cancelled and retriggered (here is a point to fix!) > This is my primary reason for doing the merge so we know exactly what needs fixing! I'll get the Jenkins config changes necessary this week so we don't have to hack our way around it :) Thanks a bunch for your comments. I'll dig into this some more and start fixing things up slowly. I'll definitely appreciate any feedback you can have in terms of code when it's ready for review. > > > -- > Emmanuel Dreyfus > http://hcpnet.free.fr/pubz > m...@netbsd.org -- nigelb ___ Gluster-infra mailing list Gluster-infra@gluster.org http://www.gluster.org/mailman/listinfo/gluster-infra
Re: [Gluster-infra] Can I update /opt/qa for NetBSD?
Nigel Babu wrote: > * A bunch of cleanup scripts are in build.sh. I think they can move into the > Jenkins job itself. That's what we do for linux boxes. Feel free to do it, but is there a benefit? If it is not broken, do not fix it... > * Some test files have been made to 0644. Is this relevant or are these > accidental changes? Probable accidental change. > * Can the Python path and stuff be declared before the build.sh script is > called in the Jenkins script? I don't know if this will work, I'll have to > test. You need to run build.sh so that configure is invoked and env.rc is created with appropriate @BUILD_PYTHON_SITE_PACKAGES@ set (see tests/env.rc.in) > * I think we now have a standard way of skipping tests in the test runner > itself rather than deleting the tests from the checkout. If not, I'll drive > these fixes. It may not scale when you want to skip all the bugs directory. > * The check for whether there's two jobs assigned to the same machine can > be controlled from Jenkins and I plan to do that, so we can probably > remove that code as well. That seems better, as the current setting bugs when a job is manually cancelled and retriggered (here is a point to fix!) -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz m...@netbsd.org ___ Gluster-infra mailing list Gluster-infra@gluster.org http://www.gluster.org/mailman/listinfo/gluster-infra
Re: [Gluster-infra] Can I update /opt/qa for NetBSD?
On Tue, Aug 02, 2016 at 03:50:41PM +0530, Nigel Babu wrote: > We have quite a lot of local changes. I'm working on merging that into our > repo. If anyone is curious, the pull request is here: > > https://github.com/gluster/glusterfs-patch-acceptance-tests/pull/47 > Hi Emmanuel, Can you help me understand some of these changes? * A bunch of cleanup scripts are in build.sh. I think they can move into the Jenkins job itself. That's what we do for linux boxes. * Some test files have been made to 0644. Is this relevant or are these accidental changes? * Can the Python path and stuff be declared before the build.sh script is called in the Jenkins script? I don't know if this will work, I'll have to test. * I think we now have a standard way of skipping tests in the test runner itself rather than deleting the tests from the checkout. If not, I'll drive these fixes. * The check for whether there's two jobs assigned to the same machine can be controlled from Jenkins and I plan to do that, so we can probably remove that code as well. Does this sound okay? -- nigelb ___ Gluster-infra mailing list Gluster-infra@gluster.org http://www.gluster.org/mailman/listinfo/gluster-infra
Re: [Gluster-infra] Can I update /opt/qa for NetBSD?
On Tue, Aug 02, 2016 at 09:43:30AM +0200, Niels de Vos wrote: > On Tue, Aug 02, 2016 at 12:08:03PM +0530, Nigel Babu wrote: > > Hello folks, > > > > The /opt/qa folder on NetBSD nodes are on quite an old commit[1]. This means > > the URL to the logs and cores do not work. The script in master generates > > the > > correct URL. Is it safe to update this repo to the latest git master? > > I dont know. Just make sure there are no local modifications and record > the current commit-id that is used. It should be easy to revert in case > errors pop up. > > HTH, > Niels > > > > > > [1]: > > https://github.com/gluster/glusterfs-patch-acceptance-tests/commit/931157d3db4c48a985c3874c2d4ccf2ebb2fbd5f > > > > -- > > nigelb > > ___ > > Gluster-infra mailing list > > Gluster-infra@gluster.org > > http://www.gluster.org/mailman/listinfo/gluster-infra We have quite a lot of local changes. I'm working on merging that into our repo. If anyone is curious, the pull request is here: https://github.com/gluster/glusterfs-patch-acceptance-tests/pull/47 -- nigelb ___ Gluster-infra mailing list Gluster-infra@gluster.org http://www.gluster.org/mailman/listinfo/gluster-infra
Re: [Gluster-infra] Can I update /opt/qa for NetBSD?
On Tue, Aug 02, 2016 at 12:08:03PM +0530, Nigel Babu wrote: > Hello folks, > > The /opt/qa folder on NetBSD nodes are on quite an old commit[1]. This means > the URL to the logs and cores do not work. The script in master generates the > correct URL. Is it safe to update this repo to the latest git master? I dont know. Just make sure there are no local modifications and record the current commit-id that is used. It should be easy to revert in case errors pop up. HTH, Niels > > [1]: > https://github.com/gluster/glusterfs-patch-acceptance-tests/commit/931157d3db4c48a985c3874c2d4ccf2ebb2fbd5f > > -- > nigelb > ___ > Gluster-infra mailing list > Gluster-infra@gluster.org > http://www.gluster.org/mailman/listinfo/gluster-infra signature.asc Description: PGP signature ___ Gluster-infra mailing list Gluster-infra@gluster.org http://www.gluster.org/mailman/listinfo/gluster-infra
