Re: [PATCH] tune: fix spurious clock_gettime reference

[Torbjörn Granlund]

Mike Frysinger  writes:

  ../gmp-mparam.h:1:1: error: unknown type name 'clock_gettime'
   clock_gettime is 1.000ns accurate
  
  This is because the tune source has one printf that is not protected
  by the verbose flag leading it to be written to the output.
  
Patch applied, thanks.

-- 
Torbjörn
Please encrypt, key id 0xC8601622
___
gmp-bugs mailing list
gmp-bugs@gmplib.org
https://gmplib.org/mailman/listinfo/gmp-bugs

Re: building gmp-6.1 for s390 (31-bit) w/asm disabled failing with undefined sdiv_qrnnd

[Torbjörn Granlund]

Mike Frysinger  writes:

  building gmp-6.1.0 & gmp-6.1.1 like so:
  ./configure \
--build=s390-ibm-linux-gnu --host=s390-ibm-linux-gnu \
--enable-shared --disable-assembly --enable-cxx --disable-static
  
  triggers this warning:
  udiv_w_sdiv.c: In function ‘__gmpn_udiv_w_sdiv’:
  udiv_w_sdiv.c:58:4: warning: implicit declaration of function ‘sdiv_qrnnd’ 
[-Wimplicit-function-declaration]
  sdiv_qrnnd (q, r, a1, a0, d);
  
  and the final lib has an undefined ref to the sdiv_qrnnd symbol.

Please try this https://gmplib.org/repo/gmp/rev/1890de258348 and comment
back.
  
  Torbjorn: you should have access to this system to reproduce -- lgentoo3.

I do indeed, and I added this case to the night builds.

-- 
Torbjörn
Please encrypt, key id 0xC8601622
___
gmp-bugs mailing list
gmp-bugs@gmplib.org
https://gmplib.org/mailman/listinfo/gmp-bugs

[PATCH] tune: fix spurious clock_gettime reference

[Mike Frysinger]

When running the tune program, the generated gmp-mparam.h header might
include an invalid line leading to build failures like so:
In file included from .../gmp-impl.h:145:0,
 from mp_bases.c:4:
../gmp-mparam.h:1:1: error: unknown type name 'clock_gettime'
 clock_gettime is 1.000ns accurate

This is because the tune source has one printf that is not protected
by the verbose flag leading it to be written to the output.

Credit to Conrad Kostecki for analysis.

URL: https://bugs.gentoo.org/568320
---
 tune/time.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tune/time.c b/tune/time.c
index e0d262096396..d1efb0a6d35d 100644
--- a/tune/time.c
+++ b/tune/time.c
@@ -773,8 +773,9 @@ cgt_works_p (void)
 }
 
   cgt_unittime = unit.tv_sec + unit.tv_nsec * 1e-9;
-  printf ("clock_gettime is %s accurate\n",
- unittime_string (cgt_unittime));
+  if (speed_option_verbose)
+printf ("clock_gettime is %s accurate\n",
+   unittime_string (cgt_unittime));
 
   if (cgt_unittime < 10e-9)
 {
-- 
2.11.0.rc2

___
gmp-bugs mailing list
gmp-bugs@gmplib.org
https://gmplib.org/mailman/listinfo/gmp-bugs