Re: small patch to suppress a warning

[Stephan Pleines]

So what is the verdict in this patch please?

On Thu, Feb 11, 2021 at 5:06 AM Hans Åberg  wrote:

>
> > On 11 Feb 2021, at 11:45, Torbjörn Granlund  wrote:
> >
> > I think there might be better places to discuss compiler warnings than
> > the gmp-bugs list.
> >
> > I think most of us agree that compiler warnings for valid C code are
> > sometimes useful.  For example, valid warnings about unitialised
> > variables seem pretty uncontroversial.
>
> Actually not, on Bison.
>
>
>
___
gmp-bugs mailing list
gmp-bugs@gmplib.org
https://gmplib.org/mailman/listinfo/gmp-bugs

Re: small patch to suppress a warning

[Stephan Pleines]

Can you please elaborate why it is a compiler bug?

On Wed, Feb 10, 2021 at 2:00 PM Hans Åberg  wrote:

> You do not say which compiler it is, but it looks like a clang bug.
>
>
> > On 10 Feb 2021, at 17:26, Stephan Pleines 
> wrote:
> >
> > Hi,
> >
> > This is a tiny patch to suppress a warning about operator precedence.
> >
> > Thank you,
> > Stephan
> >
> > diff -r 925753a1f950 mpz/pprime_p.c
> > --- a/mpz/pprime_p.cMon Dec 21 00:48:03 2020 +0100
> > +++ b/mpz/pprime_p.cWed Feb 10 08:21:36 2021 -0800
> > @@ -60,7 +60,7 @@
> >  int is_prime;
> >  unsigned long n0;
> >  n0 = mpz_get_ui (n);
> > - is_prime = n0 & (n0 > 1) ? isprime (n0) : n0 == 2;
> > + is_prime = (n0 & (n0 > 1)) ? isprime (n0) : n0 == 2;
> >  return is_prime ? 2 : 0;
> >}
> >   /* Negative number.  Negate and fall out.  */
> > ___
> > gmp-bugs mailing list
> > gmp-bugs@gmplib.org
> > https://gmplib.org/mailman/listinfo/gmp-bugs
>
>
___
gmp-bugs mailing list
gmp-bugs@gmplib.org
https://gmplib.org/mailman/listinfo/gmp-bugs

small patch to suppress a warning

[Stephan Pleines]

Hi,

This is a tiny patch to suppress a warning about operator precedence.

Thank you,
Stephan

diff -r 925753a1f950 mpz/pprime_p.c
--- a/mpz/pprime_p.cMon Dec 21 00:48:03 2020 +0100
+++ b/mpz/pprime_p.cWed Feb 10 08:21:36 2021 -0800
@@ -60,7 +60,7 @@
  int is_prime;
  unsigned long n0;
  n0 = mpz_get_ui (n);
- is_prime = n0 & (n0 > 1) ? isprime (n0) : n0 == 2;
+ is_prime = (n0 & (n0 > 1)) ? isprime (n0) : n0 == 2;
  return is_prime ? 2 : 0;
}
   /* Negative number.  Negate and fall out.  */
diff -r 925753a1f950 mpz/pprime_p.c
--- a/mpz/pprime_p.cMon Dec 21 00:48:03 2020 +0100
+++ b/mpz/pprime_p.cWed Feb 10 08:21:55 2021 -0800
@@ -60,7 +60,7 @@
  int is_prime;
  unsigned long n0;
  n0 = mpz_get_ui (n);
- is_prime = n0 & (n0 > 1) ? isprime (n0) : n0 == 2;
+ is_prime = (n0 & (n0 > 1)) ? isprime (n0) : n0 == 2;
  return is_prime ? 2 : 0;
}
   /* Negative number.  Negate and fall out.  */
___
gmp-bugs mailing list
gmp-bugs@gmplib.org
https://gmplib.org/mailman/listinfo/gmp-bugs