Re: String freeze break request for Nautilus

[Daniel Mustieles García]

2/2 from i18n

2018-03-02 17:08 GMT+01:00 Piotr Drąg :

> 2018-03-02 16:31 GMT+01:00 Ernestas Kulik :
> > Hello,
> >
> > This kind of bad to not have dealt with earlier, but I’d like modify a
> > string in the settings schema and add a string to the preferences
> > window. Both pertain to size limits for thumbnailable files.
> >
> > Here’s the MR with the changes visible: https://gitlab.gnome.org/
> GNOME/nautilus/merge_requests/126/diffs
> >
> > Also attaching a screenshot from the preferences window with the new
> > string.
> >
>
> 1/2 from i18n.
>
> --
> Piotr Drąg
> https://piotrdrag.fedorapeople.org
> ___
> release-t...@gnome.org
> https://mail.gnome.org/mailman/listinfo/release-team
> Release-team lurker? Do NOT participate in discussions.
>
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: String freeze break request for Nautilus

[Piotr Drąg]

2018-03-02 16:31 GMT+01:00 Ernestas Kulik :
> Hello,
>
> This kind of bad to not have dealt with earlier, but I’d like modify a
> string in the settings schema and add a string to the preferences
> window. Both pertain to size limits for thumbnailable files.
>
> Here’s the MR with the changes visible: 
> https://gitlab.gnome.org/GNOME/nautilus/merge_requests/126/diffs
>
> Also attaching a screenshot from the preferences window with the new
> string.
>

1/2 from i18n.

-- 
Piotr Drąg
https://piotrdrag.fedorapeople.org
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-photos: String freeze break request (GNOME/gnome-photos!28)

[Debarshi Ray]

On Fri, Mar 02, 2018 at 11:55:45AM +0100, Alexandre Franke wrote:
> On Fri, Mar 2, 2018 at 11:52 AM, Debarshi Ray  wrote:
> 
> > We'd have (a), (b) and (c) from my earlier email, where (b) and (c)
> > would use ngettext.
> >
> 
> You have my 2/2 if you make that change.

Thanks. Merged with those changes.
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-photos: String freeze break request (GNOME/gnome-photos!28)

[Alexandre Franke]

On Fri, Mar 2, 2018 at 11:52 AM, Debarshi Ray  wrote:

> We'd have (a), (b) and (c) from my earlier email, where (b) and (c)
> would use ngettext.
>

You have my 2/2 if you make that change.

-- 
Alexandre Franke
GNOME Hacker & Foundation Director
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-photos: String freeze break request (GNOME/gnome-photos!28)

[Debarshi Ray]

On Fri, Mar 02, 2018 at 11:49:06AM +0100, Alexandre Franke wrote:
> On Fri, Mar 2, 2018 at 11:36 AM, Debarshi Ray  wrote:
> 
> > However, on second thoughts, since the new strings under discussion
> > don't have any markup, it's probably better to avoid any composition
> > and spell them out.
> >
> 
> Yes. So you???d have:
>  (a) "Select items for import"
>  (b) "Select items for import (%u selected)"
> and the latter one would use ngettext, right?

Yes.

We'd have (a), (b) and (c) from my earlier email, where (b) and (c)
would use ngettext.
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-photos: String freeze break request (GNOME/gnome-photos!28)

[Alexandre Franke]

On Fri, Mar 2, 2018 at 11:36 AM, Debarshi Ray  wrote:

> However, on second thoughts, since the new strings under discussion
> don't have any markup, it's probably better to avoid any composition
> and spell them out.
>

Yes. So you’d have:
 (a) "Select items for import"
 (b) "Select items for import (%u selected)"
and the latter one would use ngettext, right?

-- 
Alexandre Franke
GNOME Hacker & Foundation Director
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-photos: String freeze break request (GNOME/gnome-photos!28)

[Debarshi Ray]

Hey Alexandre,

On Fri, Mar 02, 2018 at 10:59:56AM +0100, Alexandre Franke wrote:
> On Thu, Mar 1, 2018 at 9:12 PM, Debarshi Ray  wrote:
>> The strings and accompanying screenshots can be found in this merge
>> request:
>>   https://gitlab.gnome.org/GNOME/gnome-photos/merge_requests/28
>>
> 
> The handling of that parenthesis with a plural form looks dubious to me.
> Are you sure that???s the correct way to do it?

The short answer is that I am now considering using three strings:
 (a) "Select items for import"
 (b) "Select items for import (%u selected)"
 (c) "Select items for import (%u selected)" - plural form of (b)

That would also avoid the need to deal with context-sensitive
ngettext.

The longer answer is that these strings originate from the title of the
generic selection mode [1] header bar. See:
https://gitlab.gnome.org/GNOME/gnome-photos/blob/wip/rishi/import-string-changes-1/src/photos-main-toolbar.c#L71

That pattern was inherited from gnome-documents:
https://git.gnome.org/browse/gnome-documents/tree/src/overview.js#n587

I didn't come up with it, but I assumed that the rationale was to
avoid exposing the ... markup to translators. However, I fear
that the composed string has been wrong for right-to-left locales. So,
maybe, the code should compose the parts differently for such locales?

Note that the "%d selected" string used for the selection mode title
is actually wrong in C. It should be "%u selected" because the length
argument is an unsigned int. We can let it slide for 3.28, but that's
the reason I wanted to use a context for the new "%u selected" string
- to avoid mixing up bits from different titles when we fix that bug
[2].

However, on second thoughts, since the new strings under discussion
don't have any markup, it's probably better to avoid any composition
and spell them out.

Cheers,
Rishi

[1] https://developer.gnome.org/hig/stable/selection-mode.html.en
[2] Piotr was asking about it on IRC, but I was AFK.
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-photos: String freeze break request (GNOME/gnome-photos!28)

[Alexandre Franke]

On Thu, Mar 1, 2018 at 9:12 PM, Debarshi Ray  wrote:

> Hey,
>

Hi,


> The strings and accompanying screenshots can be found in this merge
> request:
>   https://gitlab.gnome.org/GNOME/gnome-photos/merge_requests/28
>

The handling of that parenthesis with a plural form looks dubious to me.
Are you sure that’s the correct way to do it?

-- 
Alexandre Franke
GNOME Hacker & Foundation Director
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Strings addition and UI change in g-s-d/printing

[Marek Kasik]

Hi,

I've pushed a new notification to gnome-settings-daemon. It informs user 
that a print job which needs authentication was sent to a printer (see 
https://bugzilla.gnome.org/show_bug.cgi?id=766563#c10). Clicking on it 
will open gnome-control-center's Printers panel with opened Jobs dialog 
where user can authenticate such jobs.


The new strings are:

"%s Requires Authentication"
"Credentials required in order to print"

The freeze exceptions were approved by Piotr Drąg, Alexandre Franke, 
Michael Catanzaro and Olav Vitters.


Thank you all for your help with this and I'm sorry for such late addition

Marek
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-photos: String freeze break request (GNOME/gnome-photos!28)

[Daniel Mustieles García]

1/2 from i18n

Regards

2018-03-01 21:12 GMT+01:00 Debarshi Ray :

> Hey,
>
> I'd like to add three new user-visible strings to Photos to make the
> UI for importing content work well with different kinds of devices.
> Testing with SD cards has revealed that some of them may not present a
> decent user-visible string. Therefore, it's necessary to find an
> alternative title for the header bar.
>
> The strings and accompanying screenshots can be found in this merge
> request:
>   https://gitlab.gnome.org/GNOME/gnome-photos/merge_requests/28
>
> I was hoping to send this request a few days earlier, but I ran into
> an unexpected snafu with internationalizing strings with plural forms
> across different contexts. Therefore, it took a little more effort on
> my part than is usually required for such changes. Sorry about that.
>
> Cheers,
> Rishi
> ___
> gnome-i18n mailing list
> gnome-i...@gnome.org
> https://mail.gnome.org/mailman/listinfo/gnome-i18n
>
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list