Re: [URGENT] wrong gconf key description in gnome-session
Il giorno ven, 13/02/2009 alle 16.27 -0500, Dan Winship ha scritto: > Besides the "-" -> "_" fix, I'd just change the end to "will > automatically add the required components back to the session at login > time if they do get removed". (ie, add "at login time") Applied on svn, thanks. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [URGENT] wrong gconf key description in gnome-session
Luca Ferretti wrote:
> Il giorno ven, 13/02/2009 alle 09.14 -0500, Dan Winship ha scritto:
>
>> No, "gets restarted automatically if it exits" and "gets started when
>> you log in even if it's not part of the session" are completely
>> independent, and the problem was that the required-components key was
>> implying that it controlled the former, when actually it controls the
>> latter. ("Gets restarted when it exits" is controlled by the autorestart
>> key, as Matthias noted.)
>
> Hmmm, so the change I've committed is wrong??!!???
>
> List of components that are required as part of the session.
> (Each element names a key under
> "/desktop/gnome/session/required_components"). To be a required
> component of the session means that removing a required
> component from a running session (for instance killing related
> process), gnome-session will start it next time you log in
> anyway.
It's... not totally wrong, but it's not great. The 2.24 text was:
List of components that are required as part of the session. (Each
element names a key under
"/desktop/gnome/session/required-components".) The Session
Preferences will not normally allow users to remove a required
component from the session, and the session manager will
automatically add the required components back to the session if
they do get removed.
Besides the "-" -> "_" fix, I'd just change the end to "will
automatically add the required components back to the session at login
time if they do get removed". (ie, add "at login time")
-- Dan
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [URGENT] wrong gconf key description in gnome-session
Il giorno ven, 13/02/2009 alle 09.14 -0500, Dan Winship ha scritto:
> No, "gets restarted automatically if it exits" and "gets started when
> you log in even if it's not part of the session" are completely
> independent, and the problem was that the required-components key was
> implying that it controlled the former, when actually it controls the
> latter. ("Gets restarted when it exits" is controlled by the autorestart
> key, as Matthias noted.)
Hmmm, so the change I've committed is wrong??!!???
List of components that are required as part of the session.
(Each element names a key under
"/desktop/gnome/session/required_components"). To be a required
component of the session means that removing a required
component from a running session (for instance killing related
process), gnome-session will start it next time you log in
anyway.
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [URGENT] wrong gconf key description in gnome-session
Ghee Teo wrote:
> Dan Winship wrote:
>> Matthias Clasen wrote:
>>
>>> Sounds fine to me to change the wrong key name. But is the description
>>> factually true ? The last time I checked, gnome-session would not
>>> bring
>>> nautilus back when I killed it, until I added the autorestart key to
>>> the nautilus desktop file.
>>>
>>
>> It's poorly-worded. It's supposed to mean "even if you remove nautilus
>> from your session, gnome-session will start it next time you log in
>> anyway".
>>
> You meant, nautilus will not restart itself before re-login itself. If
> it is, this is serious regression.
No, "gets restarted automatically if it exits" and "gets started when
you log in even if it's not part of the session" are completely
independent, and the problem was that the required-components key was
implying that it controlled the former, when actually it controls the
latter. ("Gets restarted when it exits" is controlled by the autorestart
key, as Matthias noted.)
-- Dan
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [URGENT] wrong gconf key description in gnome-session
Dan Winship wrote: Matthias Clasen wrote: Sounds fine to me to change the wrong key name. But is the description factually true ? The last time I checked, gnome-session would not bring nautilus back when I killed it, until I added the autorestart key to the nautilus desktop file. It's poorly-worded. It's supposed to mean "even if you remove nautilus from your session, gnome-session will start it next time you log in anyway". You meant, nautilus will not restart itself before re-login itself. If it is, this is serious regression. nautilus, metacity, gnome-panel are 3 major component of the GNOME desktop that is special. It should always restart itself when they crashed. One simply reason for that is: there is no simple way of starting manually, they are not on any of the menu. The only way to statr them manually is through command line, and that really SUCKS! -Ghee -- Dan ___ desktop-devel-list mailing list desktop-devel-l...@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
String change in gnome-session [was Re: [URGENT] wrong gconf key description in gnome-session]
Il giorno gio, 12/02/2009 alle 22.37 +, Lucas Rocha ha scritto: > Feel free to commit (taking into account the danw's suggested change). Thanks, I've just committed following changes . Index: data/gnome-session.schemas.in === --- data/gnome-session.schemas.in (revisione 5252) +++ data/gnome-session.schemas.in (copia locale) @@ -47,18 +47,6 @@ - /schemas/apps/gnome-session/options/logout_option - /apps/gnome-session/options/logout_option - gnome - string - Logout - -Selected option in the log out dialog -This is the option that will be selected in the logout dialog, valid values are "logout" for logging out, "shutdown" for halting the system and "restart" for restarting the system. - - - - /schemas/desktop/gnome/session/idle_delay /desktop/gnome/session/idle_delay gnome @@ -92,10 +80,9 @@ list string [windowmanager,panel,filemanager] - Required session components -List of components that are required as part of the session. (Each element names a key under "/desktop/gnome/session/required-components".) The Session Preferences will not normally allow users to remove a required component from the session, and the session manager will automatically add the required components back to the session if they do get removed. +List of components that are required as part of the session. (Each element names a key under "/desktop/gnome/session/required_components"). To be a required component of the session means that removing a required component from a running session (for instance killing related process), gnome-session will start it next time you log in anyway. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [URGENT] wrong gconf key description in gnome-session
Hi, 2009/2/12 Luca Ferretti : > In gnome-session schema file there is a string that we forgot to fix: > >List of components that are required as part of the session. >(Each element names a key under >"/desktop/gnome/session/required-components".) The Session >Preferences will not normally allow users to remove a required >component from the session, and the session manager will >automatically add the required components back to the session if >they do get removed. > > The actual key name is required_components: there is a FIXME comment > from 2.24 claiming this should be fixed while not in string freeze. > > OK to commit attached patch ASAP? Feel free to commit (taking into account the danw's suggested change). > PS also note that /schemas/apps/gnome-session/options/logout_option > GConf key is no longer used (it refers to old, all-in-one logout > dialog). Should we add a "deprecated" label in short description and > change the long to "This key is no longer used by gnome-session" or > could we simply remove it from schema.in file? Ah, ok, you can remove this one. :-) --lucasr ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [URGENT] wrong gconf key description in gnome-session
Hi. 2009/2/12 Luca Ferretti : > Il giorno gio, 12/02/2009 alle 14.49 -0500, Matthias Clasen ha scritto: >> 2009/2/12 Luca Ferretti : >> > In gnome-session schema file there is a string that we forgot to fix: >> > >> >List of components that are required as part of the session. >> >(Each element names a key under >> >"/desktop/gnome/session/required-components".) The Session > >> Sounds fine to me to change the wrong key name. But is the description >> factually true ? The last time I checked, gnome-session would not >> bring >> nautilus back when I killed it, until I added the autorestart key to >> the nautilus desktop file. > > Tried in my jhbuild sandbox > * nautilus - X-GNOME-AutoRestart=true X-GNOME-Provides=filemanager >- is restarted > * gnome-panel - no AutoRestart, no Provides - is restarted > * metacity - X-GNOME-Provides=windowmanager - is not restated > > hmmm... we have a problem... This happens because apps can set their restart style using xsmp (most likely with GnomeClient api). So, even if you remove the key from gnome-panel .desktop file, gnome-panel is still doing gnome_client_set_restart_style. Yes, this is a bit confusing (well, XSMP per se is quite confusing). >> > PS also note that /schemas/apps/gnome-session/options/logout_option >> > GConf key is no longer used (it refers to old, all-in-one logout > >> I don't see any reason to keep the schema around if gnome-session is >> no longer using it. Why would you ? > > Dunno, here is a policy about no longer used gconf keys? Nautilus still > provides its own old and deprecated key for icon theme, but maybe there > is some kind of versioning in nautilus gconf keys. > > If remove the gnome-session key is hurtless, I'm for remove it Which key do you want to remove? If it's auto_save_session, you shouldn't. Thanks, --lucasr ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [URGENT] wrong gconf key description in gnome-session
Hi, 2009/2/12 Luca Ferretti : > Il giorno gio, 12/02/2009 alle 20.42 +0100, Luca Ferretti ha scritto: > >> PS also note that /schemas/apps/gnome-session/options/logout_option >> GConf key is no longer used (it refers to old, all-in-one logout >> dialog). Should we add a "deprecated" label in short description and >> change the long to "This key is no longer used by gnome-session" or >> could we simply remove it from schema.in file? >> > > Two more strings to change: > > /schemas/apps/gnome-session/options/auto_save_session > >If enabled, gnome-session will save the session automatically. >Otherwise, the logout dialog will have an option to save the >session. > > (current status: no more save option in logout dialog) This one should stay as I'm working on restoring the session saving (at least I should be working on this). > /schemas/desktop/gnome/session/default_session > >List of applications that are part of the default session. > > (from file schema.in itself: "FIXME when not string frozen: mention that > required components are added to the default session") Yep. --lucasr ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [URGENT] wrong gconf key description in gnome-session
Matthias Clasen wrote: > Sounds fine to me to change the wrong key name. But is the description > factually true ? The last time I checked, gnome-session would not > bring > nautilus back when I killed it, until I added the autorestart key to > the nautilus desktop file. It's poorly-worded. It's supposed to mean "even if you remove nautilus from your session, gnome-session will start it next time you log in anyway". -- Dan ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [URGENT] wrong gconf key description in gnome-session
Il giorno gio, 12/02/2009 alle 14.49 -0500, Matthias Clasen ha scritto: > 2009/2/12 Luca Ferretti : > > In gnome-session schema file there is a string that we forgot to fix: > > > >List of components that are required as part of the session. > >(Each element names a key under > >"/desktop/gnome/session/required-components".) The Session > Sounds fine to me to change the wrong key name. But is the description > factually true ? The last time I checked, gnome-session would not > bring > nautilus back when I killed it, until I added the autorestart key to > the nautilus desktop file. Tried in my jhbuild sandbox * nautilus - X-GNOME-AutoRestart=true X-GNOME-Provides=filemanager - is restarted * gnome-panel - no AutoRestart, no Provides - is restarted * metacity - X-GNOME-Provides=windowmanager - is not restated hmmm... we have a problem... > > PS also note that /schemas/apps/gnome-session/options/logout_option > > GConf key is no longer used (it refers to old, all-in-one logout > I don't see any reason to keep the schema around if gnome-session is > no longer using it. Why would you ? Dunno, here is a policy about no longer used gconf keys? Nautilus still provides its own old and deprecated key for icon theme, but maybe there is some kind of versioning in nautilus gconf keys. If remove the gnome-session key is hurtless, I'm for remove it ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [URGENT] wrong gconf key description in gnome-session
2009/2/12 Luca Ferretti : > In gnome-session schema file there is a string that we forgot to fix: > > List of components that are required as part of the session. > (Each element names a key under > "/desktop/gnome/session/required-components".) The Session > Preferences will not normally allow users to remove a required > component from the session, and the session manager will > automatically add the required components back to the session if > they do get removed. > > The actual key name is required_components: there is a FIXME comment > from 2.24 claiming this should be fixed while not in string freeze. > > OK to commit attached patch ASAP? Sounds fine to me to change the wrong key name. But is the description factually true ? The last time I checked, gnome-session would not bring nautilus back when I killed it, until I added the autorestart key to the nautilus desktop file. > PS also note that /schemas/apps/gnome-session/options/logout_option > GConf key is no longer used (it refers to old, all-in-one logout > dialog). Should we add a "deprecated" label in short description and > change the long to "This key is no longer used by gnome-session" or > could we simply remove it from schema.in file? I don't see any reason to keep the schema around if gnome-session is no longer using it. Why would you ? ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [URGENT] wrong gconf key description in gnome-session
Il giorno gio, 12/02/2009 alle 20.42 +0100, Luca Ferretti ha scritto: > PS also note that /schemas/apps/gnome-session/options/logout_option > GConf key is no longer used (it refers to old, all-in-one logout > dialog). Should we add a "deprecated" label in short description and > change the long to "This key is no longer used by gnome-session" or > could we simply remove it from schema.in file? > Two more strings to change: /schemas/apps/gnome-session/options/auto_save_session If enabled, gnome-session will save the session automatically. Otherwise, the logout dialog will have an option to save the session. (current status: no more save option in logout dialog) /schemas/desktop/gnome/session/default_session List of applications that are part of the default session. (from file schema.in itself: "FIXME when not string frozen: mention that required components are added to the default session") ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
[URGENT] wrong gconf key description in gnome-session
In gnome-session schema file there is a string that we forgot to fix: List of components that are required as part of the session. (Each element names a key under "/desktop/gnome/session/required-components".) The Session Preferences will not normally allow users to remove a required component from the session, and the session manager will automatically add the required components back to the session if they do get removed. The actual key name is required_components: there is a FIXME comment from 2.24 claiming this should be fixed while not in string freeze. OK to commit attached patch ASAP? PS also note that /schemas/apps/gnome-session/options/logout_option GConf key is no longer used (it refers to old, all-in-one logout dialog). Should we add a "deprecated" label in short description and change the long to "This key is no longer used by gnome-session" or could we simply remove it from schema.in file? Index: data/gnome-session.schemas.in === --- data/gnome-session.schemas.in (revisione 5249) +++ data/gnome-session.schemas.in (copia locale) @@ -92,10 +92,9 @@ list string [windowmanager,panel,filemanager] - Required session components -List of components that are required as part of the session. (Each element names a key under "/desktop/gnome/session/required-components".) The Session Preferences will not normally allow users to remove a required component from the session, and the session manager will automatically add the required components back to the session if they do get removed. +List of components that are required as part of the session. (Each element names a key under "/desktop/gnome/session/required_components".) The Session Preferences will not normally allow users to remove a required component from the session, and the session manager will automatically add the required components back to the session if they do get removed. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
