[vertimus] Merge uploaded file?
Hi, I'd like to know your opinion about the following matter: - Should files uploaded by translators on the Vertimus section of l10n.gnome.org be always merged with the latest pot file? This would have the advantage of being able to do a better comparison between files (same wrap policy, same line numbers, etc.) On the downside, I'm always reluctant to modify files that claimed to be 'owned' by a specific user. Do you see major drawbacks to this updating? Claude ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
It would be really nice to have this feature :) Maybe updating with the latest pot, diff'ing with the current version in the $VCS (also updated with the lastest pot file) and then made this file available. Placing it below the current file link for example would be really useful. Actually I'm not using DL updated po files just because of this. My 5 cents, Cheers, El dl 19 de 01 de 2009 a les 22:36 +0100, en/na Claude Paroz va escriure: > Hi, > > I'd like to know your opinion about the following matter: > - Should files uploaded by translators on the Vertimus section of > l10n.gnome.org be always merged with the latest pot file? > > This would have the advantage of being able to do a better comparison > between files (same wrap policy, same line numbers, etc.) > On the downside, I'm always reluctant to modify files that claimed to be > 'owned' by a specific user. > Do you see major drawbacks to this updating? > > Claude > > ___ > gnome-i18n mailing list > gnome-i18n@gnome.org > http://mail.gnome.org/mailman/listinfo/gnome-i18n -- gil forcada [ca] guifi.net - una xarxa lliure que no para de créixer [en] guifi.net - a non-stopping free network bloc: http://gil.badall.net ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
Le lundi 19 janvier 2009, à 22:36 +0100, Claude Paroz a écrit : > Hi, > > I'd like to know your opinion about the following matter: > - Should files uploaded by translators on the Vertimus section of > l10n.gnome.org be always merged with the latest pot file? Maybe just provide the original file uploaded by the translator and the merged file? Vincent -- Les gens heureux ne sont pas pressés. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
Vincent Untz , Mon, 19 Jan 2009 23:19:44 +0100: > Le lundi 19 janvier 2009, à 22:36 +0100, Claude Paroz a écrit : > > Hi, > > > > I'd like to know your opinion about the following matter: > > - Should files uploaded by translators on the Vertimus section of > > l10n.gnome.org be always merged with the latest pot file? > > Maybe just provide the original file uploaded by the translator and the > merged file? Or provide an option when uploading... Best, Petr Kovar ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
I like this too. El dt 20 de 01 de 2009 a les 03:18 +0100, en/na Petr Kovar va escriure: > Vincent Untz , Mon, 19 Jan 2009 23:19:44 +0100: > > > Le lundi 19 janvier 2009, à 22:36 +0100, Claude Paroz a écrit : > > > Hi, > > > > > > I'd like to know your opinion about the following matter: > > > - Should files uploaded by translators on the Vertimus section of > > > l10n.gnome.org be always merged with the latest pot file? > > > > Maybe just provide the original file uploaded by the translator and the > > merged file? > > Or provide an option when uploading... > > Best, > Petr Kovar > ___ > gnome-i18n mailing list > gnome-i18n@gnome.org > http://mail.gnome.org/mailman/listinfo/gnome-i18n -- gil forcada [ca] guifi.net - una xarxa lliure que no para de créixer [en] guifi.net - a non-stopping free network bloc: http://gil.badall.net ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
On Tue, Jan 20, 2009 at 12:19 AM, Vincent Untz wrote: > Le lundi 19 janvier 2009, à 22:36 +0100, Claude Paroz a écrit : >> Hi, >> >> I'd like to know your opinion about the following matter: >> - Should files uploaded by translators on the Vertimus section of >> l10n.gnome.org be always merged with the latest pot file? > > Maybe just provide the original file uploaded by the translator and the > merged file? > I agree. It is very practical to merge the uploaded po file with the pot one, but in the meanwhile a translators "uploaded" po file may be kept too. It may be useful for a translator to see his/her own history. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
Il giorno lun, 19/01/2009 alle 22.36 +0100, Claude Paroz ha scritto: > Hi, > > I'd like to know your opinion about the following matter: > - Should files uploaded by translators on the Vertimus section of > l10n.gnome.org be always merged with the latest pot file? Well, the l10n.g.o workflow is: * grab the updated PO * work on it * upload PO with changes While you are working on PO, original messages could be changed by developers, so we need a way to check and compare uploaded PO against latest available POT. If you don't want to change uploaded stuff, you could add a warning like in attached screenshot: hovering the mouse on warning message could show a tooltip explaing the reason of the warning, something like: "The translation you uploaded was checked against latest POT files. It seems that some messages was changes while you was working on it. The uploaded translation compared against latest POT files reports X fuzzy and Y untranslated". I'm speaking about changed messages, not changed source/line references. Then you could: A. add a "Update" button near warning message - translator can click on it to force the merge B. provide two links, one for original uploaded file, one for the merged one C. other? any idea? <>___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
On Mon, Jan 19, 2009 at 10:52:53PM +0100, Gil Forcada wrote: > It would be really nice to have this feature :) > > Maybe updating with the latest pot, diff'ing with the current version in > the $VCS (also updated with the lastest pot file) and then made this > file available. I would like to see the diff too! It would be very usefull feature for reviewers. Please... :-) -- +---+ | Marcel Telka e-mail: mar...@telka.sk | |homepage: http://telka.sk/ | |jabber: mar...@jabber.sk | +---+ ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
Le mardi 20 janvier 2009 à 11:17 +0100, Luca Ferretti a écrit : > Il giorno lun, 19/01/2009 alle 22.36 +0100, Claude Paroz ha scritto: > > Hi, > > > > I'd like to know your opinion about the following matter: > > - Should files uploaded by translators on the Vertimus section of > > l10n.gnome.org be always merged with the latest pot file? > > Well, the l10n.g.o workflow is: > * grab the updated PO > * work on it > * upload PO with changes > > While you are working on PO, original messages could be changed by > developers, so we need a way to check and compare uploaded PO against > latest available POT. > > If you don't want to change uploaded stuff, you could add a warning like > in attached screenshot: hovering the mouse on warning message could show > a tooltip explaing the reason of the warning, something like: "The > translation you uploaded was checked against latest POT files. It seems > that some messages was changes while you was working on it. The uploaded > translation compared against latest POT files reports X fuzzy and Y > untranslated". I'm speaking about changed messages, not changed > source/line references. > > Then you could: > A. add a "Update" button near warning message - translator can > click on it to force the merge > B. provide two links, one for original uploaded file, one for the > merged one > C. other? any idea? Thanks Luca for your ideas. I finally choose B (as Vincent also suggested), even if this is a little heavy in my opinion. We can always improve it later. I just put in production the merged/diff functionalities. There is still a patch from Og in Bugzilla to provide a classical diff. I'll see if I can add an option somewhere for accessing it. http://bugzilla.gnome.org/show_bug.cgi?id=566060 And we also have to provide means to show diff with other files. Hope you'll find this useful. Claude ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
just saw your commits Claude, and it is with great pleasure I'm following the progress of this project! You guys are doing a great job indeed! Cheers, -- Og B. Maciel omac...@foresightlinux.org ogmac...@gnome.org ogmac...@ubuntu.com GPG Keys: D5CFC202 http://www.ogmaciel.com (en_US) http://blog.ogmaciel.com (pt_BR) ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
Please make the diff work per string, in such a sense that you always have the entire section (including comments) belonging toa string as context and not just a fixed number of lines. I, at some point, became tired of dealing with ordinary diffs, so a wrote a podiff tool that works in exactly that way and that the Danish team uses, but the code is old and ugly so it is not useable for this. Regards Kenneth 2009/1/20 Claude Paroz : > Le mardi 20 janvier 2009 à 11:17 +0100, Luca Ferretti a écrit : >> Il giorno lun, 19/01/2009 alle 22.36 +0100, Claude Paroz ha scritto: >> > Hi, >> > >> > I'd like to know your opinion about the following matter: >> > - Should files uploaded by translators on the Vertimus section of >> > l10n.gnome.org be always merged with the latest pot file? >> >> Well, the l10n.g.o workflow is: >> * grab the updated PO >> * work on it >> * upload PO with changes >> >> While you are working on PO, original messages could be changed by >> developers, so we need a way to check and compare uploaded PO against >> latest available POT. >> >> If you don't want to change uploaded stuff, you could add a warning like >> in attached screenshot: hovering the mouse on warning message could show >> a tooltip explaing the reason of the warning, something like: "The >> translation you uploaded was checked against latest POT files. It seems >> that some messages was changes while you was working on it. The uploaded >> translation compared against latest POT files reports X fuzzy and Y >> untranslated". I'm speaking about changed messages, not changed >> source/line references. >> >> Then you could: >> A. add a "Update" button near warning message - translator can >> click on it to force the merge >> B. provide two links, one for original uploaded file, one for the >> merged one >> C. other? any idea? > > Thanks Luca for your ideas. I finally choose B (as Vincent also > suggested), even if this is a little heavy in my opinion. We can always > improve it later. > > I just put in production the merged/diff functionalities. There is still > a patch from Og in Bugzilla to provide a classical diff. I'll see if I > can add an option somewhere for accessing it. > http://bugzilla.gnome.org/show_bug.cgi?id=566060 > > And we also have to provide means to show diff with other files. > > Hope you'll find this useful. > > Claude > > ___ > gnome-i18n mailing list > gnome-i18n@gnome.org > http://mail.gnome.org/mailman/listinfo/gnome-i18n > ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
Hi Claude, On Tue, Jan 20, 2009 at 04:17:46PM +0100, Claude Paroz wrote: > > Then you could: > > A. add a "Update" button near warning message - translator can > > click on it to force the merge > > B. provide two links, one for original uploaded file, one for the > > merged one > > C. other? any idea? > > Thanks Luca for your ideas. I finally choose B (as Vincent also > suggested), even if this is a little heavy in my opinion. We can always > improve it later. > > I just put in production the merged/diff functionalities. There is still It is just coool! Thanks a lot! This makes reviewing doable! > a patch from Og in Bugzilla to provide a classical diff. I'll see if I > can add an option somewhere for accessing it. > http://bugzilla.gnome.org/show_bug.cgi?id=566060 > > And we also have to provide means to show diff with other files. To have diff against the commited revision (as an addition to diff to previous file in Vertimus) would be really great improvement too. Sometimes it would be handy to view all changes in one diff (for example for final review). > > Hope you'll find this useful. Sure! Thanks. -- +---+ | Marcel Telka e-mail: mar...@telka.sk | |homepage: http://telka.sk/ | |jabber: mar...@jabber.sk | +---+ ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
Le mardi 20 janvier 2009 à 16:33 +0100, Kenneth Nielsen a écrit : > Please make the diff work per string, in such a sense that you always > have the entire section (including comments) belonging toa string as > context and not just a fixed number of lines. I, at some point, became > tired of dealing with ordinary diffs, so a wrote a podiff tool that > works in exactly that way and that the Danish team uses, but the code > is old and ugly so it is not useable for this. We're currently using standard Python difflib.HtmlDiff() [1] class, and there is no such option (only number of context lines can be given). We could however give the choice to show full files. Feel free to open a bug report. Claude [1] http://docs.python.org/library/difflib.html > > 2009/1/20 Claude Paroz : > > Le mardi 20 janvier 2009 à 11:17 +0100, Luca Ferretti a écrit : > >> Il giorno lun, 19/01/2009 alle 22.36 +0100, Claude Paroz ha scritto: > >> > Hi, > >> > > >> > I'd like to know your opinion about the following matter: > >> > - Should files uploaded by translators on the Vertimus section of > >> > l10n.gnome.org be always merged with the latest pot file? > >> > >> Well, the l10n.g.o workflow is: > >> * grab the updated PO > >> * work on it > >> * upload PO with changes > >> > >> While you are working on PO, original messages could be changed by > >> developers, so we need a way to check and compare uploaded PO against > >> latest available POT. > >> > >> If you don't want to change uploaded stuff, you could add a warning like > >> in attached screenshot: hovering the mouse on warning message could show > >> a tooltip explaing the reason of the warning, something like: "The > >> translation you uploaded was checked against latest POT files. It seems > >> that some messages was changes while you was working on it. The uploaded > >> translation compared against latest POT files reports X fuzzy and Y > >> untranslated". I'm speaking about changed messages, not changed > >> source/line references. > >> > >> Then you could: > >> A. add a "Update" button near warning message - translator can > >> click on it to force the merge > >> B. provide two links, one for original uploaded file, one for the > >> merged one > >> C. other? any idea? > > > > Thanks Luca for your ideas. I finally choose B (as Vincent also > > suggested), even if this is a little heavy in my opinion. We can always > > improve it later. > > > > I just put in production the merged/diff functionalities. There is still > > a patch from Og in Bugzilla to provide a classical diff. I'll see if I > > can add an option somewhere for accessing it. > > http://bugzilla.gnome.org/show_bug.cgi?id=566060 > > > > And we also have to provide means to show diff with other files. > > > > Hope you'll find this useful. > > > > Claude > > > > ___ > > gnome-i18n mailing list > > gnome-i18n@gnome.org > > http://mail.gnome.org/mailman/listinfo/gnome-i18n > > > ___ > gnome-i18n mailing list > gnome-i18n@gnome.org > http://mail.gnome.org/mailman/listinfo/gnome-i18n -- www.2xlibre.net ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
Em Seg, 2009-01-19 às 22:36 +0100, Claude Paroz escreveu: > Hi, > > I'd like to know your opinion about the following matter: > - Should files uploaded by translators on the Vertimus section of > l10n.gnome.org be always merged with the latest pot file? > > This would have the advantage of being able to do a better comparison > between files (same wrap policy, same line numbers, etc.) > On the downside, I'm always reluctant to modify files that claimed to be > 'owned' by a specific user. > Do you see major drawbacks to this updating? > I only see advantages. The only changes are in automatically extracted comments, which are not important if they are obsolete. I already do that (merge with latest POT) when I rview a translation (mine included. I'm not sure if you're going to use python libs or command line for that; msgmerge doesn't seem to fix the lkine lenght for PO files edited with poEdit, so you might need msgcat file.po -o file.po -- Leonardo Fontenelle http://leonardof.org ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
Le mardi 20 janvier 2009 à 17:37 -0200, Leonardo F. Fontenelle a écrit : > Em Seg, 2009-01-19 às 22:36 +0100, Claude Paroz escreveu: > > Hi, > > > > I'd like to know your opinion about the following matter: > > - Should files uploaded by translators on the Vertimus section of > > l10n.gnome.org be always merged with the latest pot file? > > > > This would have the advantage of being able to do a better comparison > > between files (same wrap policy, same line numbers, etc.) > > On the downside, I'm always reluctant to modify files that claimed to be > > 'owned' by a specific user. > > Do you see major drawbacks to this updating? > > > > I only see advantages. The only changes are in automatically extracted > comments, which are not important if they are obsolete. I already do > that (merge with latest POT) when I rview a translation (mine included. > > I'm not sure if you're going to use python libs or command line for > that; msgmerge doesn't seem to fix the lkine lenght for PO files edited > with poEdit, so you might need msgcat file.po -o file.po Thanks for the hint. Currently we're using a simple msgmerge. If you find an example where this is not sufficient, open a bug report and point us to the problematic case. Claude ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
2009/1/20 Claude Paroz : > Le mardi 20 janvier 2009 à 16:33 +0100, Kenneth Nielsen a écrit : >> Please make the diff work per string, in such a sense that you always >> have the entire section (including comments) belonging toa string as >> context and not just a fixed number of lines. I, at some point, became >> tired of dealing with ordinary diffs, so a wrote a podiff tool that >> works in exactly that way and that the Danish team uses, but the code >> is old and ugly so it is not useable for this. > > We're currently using standard Python difflib.HtmlDiff() [1] class, and > there is no such option (only number of context lines can be given). We > could however give the choice to show full files. > Feel free to open a bug report. Ok. If I write a better python program (than the one I have) for it, will you then consider using it and adding the feature? > > Claude > > > [1] http://docs.python.org/library/difflib.html > >> >> 2009/1/20 Claude Paroz : >> > Le mardi 20 janvier 2009 à 11:17 +0100, Luca Ferretti a écrit : >> >> Il giorno lun, 19/01/2009 alle 22.36 +0100, Claude Paroz ha scritto: >> >> > Hi, >> >> > >> >> > I'd like to know your opinion about the following matter: >> >> > - Should files uploaded by translators on the Vertimus section of >> >> > l10n.gnome.org be always merged with the latest pot file? >> >> >> >> Well, the l10n.g.o workflow is: >> >> * grab the updated PO >> >> * work on it >> >> * upload PO with changes >> >> >> >> While you are working on PO, original messages could be changed by >> >> developers, so we need a way to check and compare uploaded PO against >> >> latest available POT. >> >> >> >> If you don't want to change uploaded stuff, you could add a warning like >> >> in attached screenshot: hovering the mouse on warning message could show >> >> a tooltip explaing the reason of the warning, something like: "The >> >> translation you uploaded was checked against latest POT files. It seems >> >> that some messages was changes while you was working on it. The uploaded >> >> translation compared against latest POT files reports X fuzzy and Y >> >> untranslated". I'm speaking about changed messages, not changed >> >> source/line references. >> >> >> >> Then you could: >> >> A. add a "Update" button near warning message - translator can >> >> click on it to force the merge >> >> B. provide two links, one for original uploaded file, one for the >> >> merged one >> >> C. other? any idea? >> > >> > Thanks Luca for your ideas. I finally choose B (as Vincent also >> > suggested), even if this is a little heavy in my opinion. We can always >> > improve it later. >> > >> > I just put in production the merged/diff functionalities. There is still >> > a patch from Og in Bugzilla to provide a classical diff. I'll see if I >> > can add an option somewhere for accessing it. >> > http://bugzilla.gnome.org/show_bug.cgi?id=566060 >> > >> > And we also have to provide means to show diff with other files. >> > >> > Hope you'll find this useful. >> > >> > Claude >> > >> > ___ >> > gnome-i18n mailing list >> > gnome-i18n@gnome.org >> > http://mail.gnome.org/mailman/listinfo/gnome-i18n >> > >> ___ >> gnome-i18n mailing list >> gnome-i18n@gnome.org >> http://mail.gnome.org/mailman/listinfo/gnome-i18n > -- > www.2xlibre.net > > ___ > gnome-i18n mailing list > gnome-i18n@gnome.org > http://mail.gnome.org/mailman/listinfo/gnome-i18n > ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
Il giorno mar, 20/01/2009 alle 16.17 +0100, Claude Paroz ha scritto: > Le mardi 20 janvier 2009 à 11:17 +0100, Luca Ferretti a écrit : > > Then you could: > > A. add a "Update" button near warning message - translator can > > click on it to force the merge > > B. provide two links, one for original uploaded file, one for the > > merged one > > C. other? any idea? > > Thanks Luca for your ideas. I finally choose B (as Vincent also > suggested), even if this is a little heavy in my opinion. We can always > improve it later. Just to make this more heavy, what about add tooltips[1] with translation status for uploaded and merged (translated, fuzzy, untranslated)? This could be helpful to immediately visually check if you have to translate new stuff. A tooltip to explain the "diff with previous" link could be good too. BTW this message don't appear in damned-lies PO file :( [1] i.e. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: [vertimus] Merge uploaded file?
Le dimanche 25 janvier 2009 à 21:23 +0100, Luca Ferretti a écrit : > Il giorno mar, 20/01/2009 alle 16.17 +0100, Claude Paroz ha scritto: > > Le mardi 20 janvier 2009 à 11:17 +0100, Luca Ferretti a écrit : > > > Then you could: > > > A. add a "Update" button near warning message - translator can > > > click on it to force the merge > > > B. provide two links, one for original uploaded file, one for the > > > merged one > > > C. other? any idea? > > > > Thanks Luca for your ideas. I finally choose B (as Vincent also > > suggested), even if this is a little heavy in my opinion. We can always > > improve it later. > > Just to make this more heavy, what about add tooltips[1] with > translation status for uploaded and merged (translated, fuzzy, > untranslated)? > > This could be helpful to immediately visually check if you have to > translate new stuff. Yes, good suggestion. http://bugzilla.gnome.org/show_bug.cgi?id=569377 > A tooltip to explain the "diff with previous" link could be good too. > BTW this message don't appear in damned-lies PO file :( This has been changed today while introducing "multi-diff" support. Claude ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
