Re: Boxes string change
On Fri, Mar 1, 2013 at 2:20 PM, Zeeshan Ali (Khattak) wrote: > Hi, >Just to inform that we changed a string in Boxes: > > https://bugzilla.gnome.org/show_bug.cgi?id=694875 > http://git.gnome.org/browse/gnome-boxes/commit/?id=422a74e220d2d03bd4a9c9ca86ffba59de1a87f4 And another one immediately after :) https://bugzilla.gnome.org/show_bug.cgi?id=694846 http://git.gnome.org/browse/gnome-boxes/commit/?id=7be01cb48d7d6f0f32347b031060286a19655693 -- Regards, Zeeshan Ali (Khattak) FSF member#5124 ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Boxes string change
2013/3/4 Zeeshan Ali (Khattak) :
> Hi,
> We changed some string in Boxes just before 3.7.91:
>
> https://bugzilla.gnome.org/show_bug.cgi?id=695111
> http://git.gnome.org/browse/gnome-boxes/commit/?id=1411ba951cf51443f4e4e26a0fa0ef0584585764
> http://git.gnome.org/browse/gnome-boxes/commit/?id=f0f3d771a8ba0d4353aa7a78a5a14311fe83fdf6
>
Hi,
Please don't split string like this:
machine.got_error (_("Insertion of '%s' as a CD/DVD " +
"into '%s' failed").printf (path_basename,
This way only the first part of the string ends being translated.
(Some more info:
https://live.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences)
Thanks in advance,
--
Piotr Drąg
http://raven.fedorapeople.org/
___
gnome-i18n mailing list
gnome-i18n@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Boxes string change
On Mon, Mar 4, 2013 at 11:53 PM, Piotr Drąg wrote:
> 2013/3/4 Zeeshan Ali (Khattak) :
>> Hi,
>> We changed some string in Boxes just before 3.7.91:
>>
>> https://bugzilla.gnome.org/show_bug.cgi?id=695111
>> http://git.gnome.org/browse/gnome-boxes/commit/?id=1411ba951cf51443f4e4e26a0fa0ef0584585764
>> http://git.gnome.org/browse/gnome-boxes/commit/?id=f0f3d771a8ba0d4353aa7a78a5a14311fe83fdf6
>>
>
> Hi,
>
> Please don't split string like this:
>
> machine.got_error (_("Insertion of '%s' as a CD/DVD " +
> "into '%s' failed").printf (path_basename,
>
> This way only the first part of the string ends being translated.
Yikes, I only remembered that vala automatically puts them together in
generated C files but forgot the fact that we scan .vala files from
translations, not C. :(
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
___
gnome-i18n mailing list
gnome-i18n@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Boxes string change
On Mon, Mar 4, 2013 at 11:57 PM, Zeeshan Ali (Khattak)
wrote:
> On Mon, Mar 4, 2013 at 11:53 PM, Piotr Drąg wrote:
>> 2013/3/4 Zeeshan Ali (Khattak) :
>>> Hi,
>>> We changed some string in Boxes just before 3.7.91:
>>>
>>> https://bugzilla.gnome.org/show_bug.cgi?id=695111
>>> http://git.gnome.org/browse/gnome-boxes/commit/?id=1411ba951cf51443f4e4e26a0fa0ef0584585764
>>> http://git.gnome.org/browse/gnome-boxes/commit/?id=f0f3d771a8ba0d4353aa7a78a5a14311fe83fdf6
>>>
>>
>> Hi,
>>
>> Please don't split string like this:
>>
>> machine.got_error (_("Insertion of '%s' as a CD/DVD " +
>> "into '%s' failed").printf (path_basename,
>>
>> This way only the first part of the string ends being translated.
>
> Yikes, I only remembered that vala automatically puts them together in
> generated C files but forgot the fact that we scan .vala files from
> translations, not C. :(
Fixed in git master:
http://git.gnome.org/browse/gnome-boxes/commit/?id=f818eac57a22e3cfa77252ee35a944a13fac5e86
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
___
gnome-i18n mailing list
gnome-i18n@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Boxes string change
Hi, A now we merged patches to add preliminary user docs that adds one string in UI and some doc pages to translate: https://bugzilla.gnome.org/show_bug.cgi?id=695212 https://git.gnome.org/browse/gnome-boxes/commit/?id=98d3cab79990ae7bd4a9845608ff814198f73797 https://bugzilla.gnome.org/show_bug.cgi?id=670766 https://git.gnome.org/browse/gnome-boxes/tree/help/C (Too many patches to provide a link to commits themselves). -- Regards, Zeeshan Ali (Khattak) FSF member#5124 ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
