Re: Requesting Freeze Breaks for Orca 3.0.0
On Mon, Apr 4, 2011 at 2:15 PM, Joanmarie Diggs wrote: > Hi Release Team (and i18n Team): > > The Orca team has three changes which we'd really like to include in the > 3.0.0 release today: > > 1. Bug 646547 - typo in src/orca/orca_gui_prefs.py > https://bugzilla.gnome.org/show_bug.cgi?id=646547 > Silly typo and grammar mistake. I suspect the i18n team got it > right in their languages. :-) We failed in English, however. For this change, you should do the necessary .po file gymnastics to update all msgids, to keep translations from breaking. > 2. Bug 646475 - Traceback seen with gnome-speech > https://bugzilla.gnome.org/show_bug.cgi?id=646475 > It's a two-line, safe change. And while gnome-speech is deprecated > you still find it out there in the distros. This one I cannot really judge without knowing what ACSS is or does. But I will point out that Cosimo reported orca tracebacks after I removed the gnome-speech dependency from our package - is that the same issue ? > 3. Bug 646288 - Orca needs to set and respond to the appropriate > gsettings keys > https://bugzilla.gnome.org/show_bug.cgi?id=646288 > This will cause Orca to shut itself off when the UAP screen > reader off-switch is turned off as well as to change the > appropriate gsettings key so that the aforementioned switch > displays the right thing when users launch Orca via some other > means. In addition, we caught a couple of instances where we > were still checking/setting gconf keys. While this is a bigger > change, it's not huge. And while it will not solve all the > current accessibility issues, it will make them somewhat less > pronounced. ;-) I must say this one should have landed shortly after we added the switch back. But better late than never. I'm willing to accept this one, since it makes the switch work properly. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Requesting Freeze Breaks for Orca 3.0.0
Le lundi 04 avril 2011, à 14:15 -0400, Joanmarie Diggs a écrit : > Hi Release Team (and i18n Team): > > The Orca team has three changes which we'd really like to include in the > 3.0.0 release today: > > 1. Bug 646547 - typo in src/orca/orca_gui_prefs.py >https://bugzilla.gnome.org/show_bug.cgi?id=646547 >Silly typo and grammar mistake. I suspect the i18n team got it >right in their languages. :-) We failed in English, however. Approval 1 of 2, only if you fix all .po files at the same time, to not break translations. > 2. Bug 646475 - Traceback seen with gnome-speech >https://bugzilla.gnome.org/show_bug.cgi?id=646475 >It's a two-line, safe change. And while gnome-speech is deprecated >you still find it out there in the distros. Approval 1 of 2. > 3. Bug 646288 - Orca needs to set and respond to the appropriate >gsettings keys >https://bugzilla.gnome.org/show_bug.cgi?id=646288 I'm not sure I understand well: in init(), you are changing the screen-reader-enabled key to True. I'd expect init() to work only if screen-reader-enabled is set to True, not init() to set the key. Is this really right? Vincent -- Les gens heureux ne sont pas pressés. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Requesting Freeze Breaks for Orca 3.0.0
On Mon, 2011-04-04 at 14:24 -0400, Matthias Clasen wrote: > On Mon, Apr 4, 2011 at 2:15 PM, Joanmarie Diggs wrote: > > Hi Release Team (and i18n Team): > > > > The Orca team has three changes which we'd really like to include in the > > 3.0.0 release today: > > > > 1. Bug 646547 - typo in src/orca/orca_gui_prefs.py > > https://bugzilla.gnome.org/show_bug.cgi?id=646547 > > Silly typo and grammar mistake. I suspect the i18n team got it > > right in their languages. :-) We failed in English, however. > > For this change, you should do the necessary .po file gymnastics to > update all msgids, to keep translations from breaking. Okay, if I get my +2 I will check with the i18n team to be sure I know what those gymnastics are. > > 2. Bug 646475 - Traceback seen with gnome-speech > > https://bugzilla.gnome.org/show_bug.cgi?id=646475 > > It's a two-line, safe change. And while gnome-speech is deprecated > > you still find it out there in the distros. > > This one I cannot really judge without knowing what ACSS is or does. > But I will point out that Cosimo reported orca tracebacks after I > removed the gnome-speech dependency from our package - is that the > same issue ? Dunno. I'd have to see what the tracebacks are. ACSS is just a voice definition. http://git.gnome.org/browse/orca/tree/src/orca/acss.py > > 3. Bug 646288 - Orca needs to set and respond to the appropriate > > gsettings keys > > https://bugzilla.gnome.org/show_bug.cgi?id=646288 > > This will cause Orca to shut itself off when the UAP screen > > reader off-switch is turned off as well as to change the > > appropriate gsettings key so that the aforementioned switch > > displays the right thing when users launch Orca via some other > > means. In addition, we caught a couple of instances where we > > were still checking/setting gconf keys. While this is a bigger > > change, it's not huge. And while it will not solve all the > > current accessibility issues, it will make them somewhat less > > pronounced. ;-) > > I must say this one should have landed shortly after we added the > switch back. But better late than never. I'm willing to accept this > one, since it makes the switch work properly. Understood. Apologies for that. --joanie ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Requesting Freeze Breaks for Orca 3.0.0
> > 3. Bug 646288 - Orca needs to set and respond to the appropriate > >gsettings keys > >https://bugzilla.gnome.org/show_bug.cgi?id=646288 > > I'm not sure I understand well: in init(), you are changing the > screen-reader-enabled key to True. I'd expect init() to work only if > screen-reader-enabled is set to True, not init() to set the key. Is this > really right? Most Orca users who are blind will not be using the UAP to toggle the screen reader on: In order to access the switch to turn the screen reader on, a user who is blind must have a screen reader on already. Bit of a cart/horse chicken/egg situation at the moment. When the switch is turned on by other users in the UAP, an autostart file launches Orca. When the user launches Orca via terminal window or run dialog, should we fail to set the key, the UAP switch will say 'off' even though the screen reader is 'on'. --joanie ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Requesting Freeze Breaks for Orca 3.0.0
Sorry to be so spammy today. On Mon, 2011-04-04 at 14:24 -0400, Matthias Clasen wrote: > On Mon, Apr 4, 2011 at 2:15 PM, Joanmarie Diggs wrote: [...] > > 1. Bug 646547 - typo in src/orca/orca_gui_prefs.py > > https://bugzilla.gnome.org/show_bug.cgi?id=646547 > > Silly typo and grammar mistake. I suspect the i18n team got it > > right in their languages. :-) We failed in English, however. > > For this change, you should do the necessary .po file gymnastics to > update all msgids, to keep translations from breaking. I believe I have done so thanks to the advice of the wonderful people in #i18n: http://bugzilla-attachments.gnome.org/attachment.cgi?id=185150 As I read the freeze break rules for strings, I need one more approval from the i18n team (correct?) Thanks again! --joanie ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Requesting Freeze Breaks for Orca 3.0.0
On Mon, Apr 4, 2011 at 5:20 PM, Joanmarie Diggs wrote: > Sorry to be so spammy today. > > On Mon, 2011-04-04 at 14:24 -0400, Matthias Clasen wrote: >> On Mon, Apr 4, 2011 at 2:15 PM, Joanmarie Diggs wrote: > > [...] > >> > 1. Bug 646547 - typo in src/orca/orca_gui_prefs.py >> > https://bugzilla.gnome.org/show_bug.cgi?id=646547 >> > Silly typo and grammar mistake. I suspect the i18n team got it >> > right in their languages. :-) We failed in English, however. >> >> For this change, you should do the necessary .po file gymnastics to >> update all msgids, to keep translations from breaking. > > I believe I have done so thanks to the advice of the wonderful people in > #i18n: http://bugzilla-attachments.gnome.org/attachment.cgi?id=185150 > > As I read the freeze break rules for strings, I need one more approval > from the i18n team (correct?) since you're now updating the msgids to avoid breaking translations, its no longer a string break... so you are good to go. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
