Re: [Gnome-zeitgeist-users] [Gnome Activity Journal] Today button UI suggestion
Hello guys, I've made some tweaks to the today button, like I suggested, and proposed a branch for review. I've noticed GAJ is using a gtk.DrawingArea for the forward and backward buttons. I believe a comparable effect might be achieved by using normal gtk.Buttons with RELIEF_NONE and focus_on_click == False. In fact, I think using buttons for buttons is a good idea overall, for several reasons (like clarity of code, elegance of implementation, UI consistency, etc). The buttons would look the same at rest, but maybe a little differently when hovered and being pushed; however, it would allow GAJ to shed some basically redundant code (like hooking the hover signal in the forward button, to light up the today button) and would allow, for instance, the today button to be focused by keyboard (not happening right now, since it's a part of the forward button). To summarize: if I switched the forward and backward button implementations to gtk.Buttons, would you guys be willing to try out the change? Cheers, Tin ___ Mailing list: https://launchpad.net/~gnome-zeitgeist-users Post to : gnome-zeitgeist-users@lists.launchpad.net Unsubscribe : https://launchpad.net/~gnome-zeitgeist-users More help : https://help.launchpad.net/ListHelp
Re: [Gnome-zeitgeist-users] [Gnome Activity Journal] Today button UI suggestion
Awesome..good luck!:) 2010/12/19 Tin Tvrtković tinches...@gmail.com Thanks for the kind words. :) I'll look into it, will propose a merge in the next few hours for review. Cheers On 18.12.2010 20:52, Siegfried Gevatter wrote: Forwarding to the list since it seems only I received the reply: 2010/12/18 stefano.cand...@gmail.com stefano.cand...@gmail.com: Hi Tin, You're on fire...very good idea! :):) Well, if you have time and desire for fixing that, patches are welcome. Otherwise i'll be happy to fix that. Cheers, ___ Mailing list: https://launchpad.net/~gnome-zeitgeist-users Post to : gnome-zeitgeist-users@lists.launchpad.net Unsubscribe : https://launchpad.net/~gnome-zeitgeist-users More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~gnome-zeitgeist-users Post to : gnome-zeitgeist-users@lists.launchpad.net Unsubscribe : https://launchpad.net/~gnome-zeitgeist-users More help : https://help.launchpad.net/ListHelp
Re: [Gnome-zeitgeist-users] [Gnome Activity Journal] Today button UI suggestion
Forwarding to the list since it seems only I received the reply: 2010/12/18 stefano.cand...@gmail.com stefano.cand...@gmail.com: Hi Tin, You're on fire...very good idea! :):) Well, if you have time and desire for fixing that, patches are welcome. Otherwise i'll be happy to fix that. Cheers, ___ Mailing list: https://launchpad.net/~gnome-zeitgeist-users Post to : gnome-zeitgeist-users@lists.launchpad.net Unsubscribe : https://launchpad.net/~gnome-zeitgeist-users More help : https://help.launchpad.net/ListHelp
