Re: [PATCH] silence startup with guile-1.8
Chris Shoemaker ([EMAIL PROTECTED]) said: > Can you please check r13984? I moved this after the (define-module > ...) and wrapped it in a version-check. 13985 is quiet for me w/guile-1.8. (Don't have a guile-1.6 box right now to test against.) Bill ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [PATCH] [RFC] fixes for guile-1.8
Derek Atkins ([EMAIL PROTECTED]) said: > Quoting Bill Nottingham <[EMAIL PROTECTED]>: > > >Derek Atkins ([EMAIL PROTECTED]) said: > >>Thanks! > > > >BTW, Miroslav Lichvar (<[EMAIL PROTECTED]>) is the originator of > >this patch, > >just to get the attribution right. > > Oh. Too late. Already attributed it to you. ;) Looks like src/import-export/qif-io-core/qif-parse.scm needs the same fix. Bill ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Make Check
Derek Atkins wrote: Quoting Josh Sled <[EMAIL PROTECTED]>: (Please remember to CC: the list on replies...) On Tue, 2006-05-09 at 09:52 -0700, Bernie du Breuil wrote: I'm pretty sure it was 1.9.5. I'll try again, but probably not until Thursday, with 1.9.6. Ah, hopefully 1.9.6 will be out by then. :/ We still need to get one test working again before 1.9.6 can be released. -derek Hear, hear...waiting to hear ;-) Chris ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [PATCH] silence startup with guile-1.8
On Tue, May 09, 2006 at 09:18:44PM -0400, Bill Nottingham wrote: > If you want the old behavior back without replacements or warnings you > can add the line: > > (default-duplicate-binding-handler 'last) > > to your .guile init file. > -- > > ... so, that's what I do in the attached patch. Arguably, some of this > could be cleaned up in the modules themselves, as some of the warnings > are from included-with-guile ice9 or srfi themselves. But the hammer > approach is simpler. > > Bill Can you please check r13984? I moved this after the (define-module ...) and wrapped it in a version-check. -chris ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
[PATCH] silence startup with guile-1.8
Starting up gnucash with guile-1.8 yields the following noise: WARNING: (srfi srfi-35): `every' imported from both (oop goops util) and (srfi srfi-1) WARNING: (srfi srfi-35): `any' imported from both (oop goops util) and (srfi srfi-1) WARNING: (g-wrap util): imported module (srfi srfi-34) overrides core binding `raise' WARNING: (g-wrap): imported module (srfi srfi-34) overrides core binding `raise' WARNING: (g-wrap rti): imported module (srfi srfi-34) overrides core binding `raise' WARNING: (g-wrap rti): `class-name' imported from both (oop goops) and (g-wrap) WARNING: (g-wrap c-types): imported module (srfi srfi-34) overrides core binding `raise' WARNING: (g-wrap c-types): `class-name' imported from both (oop goops) and (g-wrap) WARNING: (g-wrap enumeration): `class-name' imported from both (oop goops) and (g-wrap) WARNING: (g-wrap guile): `class-name' imported from both (oop goops) and (g-wrap) WARNING: (g-wrap compat): `class-name' imported from both (oop goops) and (g-wrap) WARNING: (g-wrap ws standard): `class-name' imported from both (oop goops) and (g-wrap) WARNING: (g-wrap guile ws standard): `class-name' imported from both (oop goops) and (g-wrap) WARNING: (gnucash app-utils): imported module (gnucash main) overrides core binding `string-join' WARNING: (gnucash app-utils): imported module (ice-9 slib) overrides core binding `string-capitalize!' WARNING: (gnucash app-utils): imported module (ice-9 slib) overrides core binding `string-capitalize' WARNING: (gnucash app-utils): imported module (ice-9 slib) overrides core binding `string-upcase!' ... ~ 500 lines suppressed ... WARNING: (gnucash business-gnome): imported module (gnucash main) overrides core binding `string-join' WARNING: (gnucash price-quotes): imported module (gnucash main) overrides core binding `string-join' gnucash: [M] "Found Finance::Quote version "1.08 Obviously, it's a few more warnings than we'd like. From the guile-1.8.0 NEWS file: -- ** The module system now checks for duplicate bindings. The module system now can check for name conflicts among imported bindings. The behavior can be controlled by specifying one or more 'duplicates' handlers. For example, to make Guile return an error for every name collision, write: (define-module (foo) :use-module (bar) :use-module (baz) :duplicates check) The new default behavior of the module system when a name collision has been detected is to 1. Give priority to bindings marked as a replacement. 2. Issue a warning (different warning if overriding core binding). 3. Give priority to the last encountered binding (this corresponds to the old behavior). If you want the old behavior back without replacements or warnings you can add the line: (default-duplicate-binding-handler 'last) to your .guile init file. -- ... so, that's what I do in the attached patch. Arguably, some of this could be cleaned up in the modules themselves, as some of the warnings are from included-with-guile ice9 or srfi themselves. But the hammer approach is simpler. Bill --- gnucash-1.9.5/src/scm/main.scm.foo 2006-05-09 21:09:19.0 -0400 +++ gnucash-1.9.5/src/scm/main.scm 2006-05-09 21:09:55.0 -0400 @@ -15,6 +15,8 @@ ;; 51 Franklin Street, Fifth FloorFax:+1-617-542-2652 ;; Boston, MA 02110-1301, USA [EMAIL PROTECTED] +(default-duplicate-binding-handler 'last) + (define-module (gnucash main)) (use-modules (ice-9 slib)) ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Display of USD as fractions
David V Herman <[EMAIL PROTECTED]> writes: > Bugzilla ?? yes, please. And attach the picture. > Dave Herman -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: GC website - problems
"Stewart V. Wright" <[EMAIL PROTECTED]> writes: > Hi, > > It looks like there is a permissions screwed up on gnucash.org at the > moment. > > Whenever I go to the website (main page or others...) I get: > >Not Found >The requested URL / was not found on this server. > >Apache/1.3.31 Server at www.gnucash.org Port 80 > > > This is reminiscent of when I set the perms wrong on my webpage. :-) > > > Is this an indication of the/an update website coming online? FYI, www.gnucash.org should be back online. -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [PATCH] [RFC] fixes for guile-1.8
Quoting Bill Nottingham <[EMAIL PROTECTED]>: In the NEWS file of guile-1.8.0: ** The GC can no longer be blocked. The global flags scm_gc_heap_lock and scm_block_gc have been removed. The GC can now run (partially) concurrently with other code and thus blocking it is not well defined. So, I'd read that as 'no'. (I'm in no way an expert on guile internals.) Yeah, I'm not an expert, either. From reading that note I would suspect that the reasons we tried to block the GC aren't /as/ relevent in 1.8.. So perhaps a guile-version-based compile-time flag would be appropriate. I know at build-time if we've got 1.6 or 1.8, so we can just put those blocks within #ifdef GUILE_BLOCK_GC and define /that/ based on a configure test. Bill -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [PATCH] [RFC] fixes for guile-1.8
Derek Atkins ([EMAIL PROTECTED]) said: > Thanks! BTW, Miroslav Lichvar (<[EMAIL PROTECTED]>) is the originator of this patch, just to get the attribution right. Bill ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [PATCH] [RFC] fixes for guile-1.8
Quoting Bill Nottingham <[EMAIL PROTECTED]>: Derek Atkins ([EMAIL PROTECTED]) said: Thanks! BTW, Miroslav Lichvar (<[EMAIL PROTECTED]>) is the originator of this patch, just to get the attribution right. Oh. Too late. Already attributed it to you. ;) Bill -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [PATCH] [RFC] fixes for guile-1.8
Derek Atkins ([EMAIL PROTECTED]) said: > >engine-helpers.c: scm_block_gc no longer exists in guile-1.8. > > > >The engine-helpers.c probably needs wrapped in a version-check, which > >is why this is a RFC... > > Yeah, this is a bit more of a problem. This particular operation can > really beat on the guile garbage collector. Does guile 1.8 have some > API we could use to manually turn the garbage collection on and off? > With the GC on it's a huge performance hit during these particular > operations. > So I'd really prefer not to just outright remove this if we can find > some other way to do what we want. In the NEWS file of guile-1.8.0: ** The GC can no longer be blocked. The global flags scm_gc_heap_lock and scm_block_gc have been removed. The GC can now run (partially) concurrently with other code and thus blocking it is not well defined. So, I'd read that as 'no'. (I'm in no way an expert on guile internals.) Bill ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [PATCH] [RFC] fixes for guile-1.8
Quoting Bill Nottingham <[EMAIL PROTECTED]>: It still spews a huge pile of warnings on startup that I haven't tracked down yet, but this is the start of some work to get gnucash going with guile-1.8. What this patch changes: qif-parse.scm: Fixes: ERROR: In procedure scm_lreadr: ERROR: /usr/src/build/746034-x86_64/BUILD/gnucash-1.9.5/intl-scm/../src/import-export/qif-import/qif-parse.scm:9:50: illegal character in escape sequence: #\| make[2]: *** [guile-strings.c] Error 1 during build. Ahh, thank you for this!! Someone else reported this and, well, I just didn't see the problem. (sometimes I hate regex!) Yeah, this one can (and should) be committed. Indeed I'll go do that shortly.. engine-helpers.c: scm_block_gc no longer exists in guile-1.8. The engine-helpers.c probably needs wrapped in a version-check, which is why this is a RFC... Yeah, this is a bit more of a problem. This particular operation can really beat on the guile garbage collector. Does guile 1.8 have some API we could use to manually turn the garbage collection on and off? With the GC on it's a huge performance hit during these particular operations. So I'd really prefer not to just outright remove this if we can find some other way to do what we want. Bill Thanks! -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
[PATCH] [RFC] fixes for guile-1.8
It still spews a huge pile of warnings on startup that I haven't tracked down yet, but this is the start of some work to get gnucash going with guile-1.8. What this patch changes: qif-parse.scm: Fixes: ERROR: In procedure scm_lreadr: ERROR: /usr/src/build/746034-x86_64/BUILD/gnucash-1.9.5/intl-scm/../src/import-export/qif-import/qif-parse.scm:9:50: illegal character in escape sequence: #\| make[2]: *** [guile-strings.c] Error 1 during build. engine-helpers.c: scm_block_gc no longer exists in guile-1.8. The engine-helpers.c probably needs wrapped in a version-check, which is why this is a RFC... Bill --- gnucash-1.9.5/src/engine/engine-helpers.c.foo 2006-05-09 17:08:56.0 -0400 +++ gnucash-1.9.5/src/engine/engine-helpers.c 2006-05-09 17:09:05.0 -0400 @@ -1686,8 +1686,6 @@ if (!q) return SCM_BOOL_F; - ++scm_block_gc; - /* terms */ pair = scm_cons (gnc_query_terms2scm (qof_query_get_terms (q)), SCM_EOL); pair = scm_cons (scm_str2symbol ("terms"), pair); @@ -1723,7 +1721,6 @@ /* Reverse this list; tag it as 'query-v2' */ pair = scm_reverse (query_scm); - --scm_block_gc; return scm_cons (scm_str2symbol ("query-v2"), pair); } @@ -1928,8 +1925,6 @@ gboolean si1 = TRUE, si2 = TRUE, si3 = TRUE; int max_results = -1; - ++scm_block_gc; - while (!SCM_NULLP (query_scm)) { const gchar *symbol; @@ -2008,8 +2003,6 @@ } } - --scm_block_gc; - if (ok && search_for) { qof_query_search_for (q, search_for); qof_query_set_sort_order (q, sp1, sp2, sp3); --- gnucash-1.8.12/src/import-export/qif-import/qif-parse.scm.guile18 2006-03-16 12:56:35.0 +0100 +++ gnucash-1.8.12/src/import-export/qif-import/qif-parse.scm 2006-03-16 12:56:43.0 +0100 @@ -7,7 +7,7 @@ ; (define qif-category-compiled-rexp - (make-regexp "^ *(\\[)?([^]/\\|]*)(]?)(/?)([^\|]*)(\\|(\\[)?([^]/]*)(]?)(/?)(.*))? *$")) + (make-regexp "^ *(\\[)?([^]/\\|]*)(]?)(/?)([^\\|]*)(\\|(\\[)?([^]/]*)(]?)(/?)(.*))? *$")) (define qif-date-compiled-rexp (make-regexp "^ *([0-9]+) *[-/.'] *([0-9]+) *[-/.'] *([0-9]+).*$|^ *([0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]).*$")) ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Make Check
Quoting Josh Sled <[EMAIL PROTECTED]>: (Please remember to CC: the list on replies...) On Tue, 2006-05-09 at 09:52 -0700, Bernie du Breuil wrote: I'm pretty sure it was 1.9.5. I'll try again, but probably not until Thursday, with 1.9.6. Ah, hopefully 1.9.6 will be out by then. :/ We still need to get one test working again before 1.9.6 can be released. -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Make Check
(Please remember to CC: the list on replies...) On Tue, 2006-05-09 at 09:52 -0700, Bernie du Breuil wrote: > I'm pretty sure it was 1.9.5. I'll try again, but probably not > until Thursday, with 1.9.6. Ah, hopefully 1.9.6 will be out by then. :/ -- ...jsled http://asynchronous.org/ - `a=jsled; b=asynchronous.org; echo [EMAIL PROTECTED] ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: GC website - problems
On Tue, 2006-05-09 at 10:26 -0500, Stewart V. Wright wrote: > It looks like there is a permissions screwed up on gnucash.org at the > moment. Linas is doing some disk maintenance on www.gnucash.org. > Is this an indication of the/an update website coming online? Not directly, but hopefully one will be coming soon. :) -- ...jsled http://asynchronous.org/ - `a=jsled; b=asynchronous.org; echo [EMAIL PROTECTED] ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
GC website - problems
Hi, It looks like there is a permissions screwed up on gnucash.org at the moment. Whenever I go to the website (main page or others...) I get: Not Found The requested URL / was not found on this server. Apache/1.3.31 Server at www.gnucash.org Port 80 This is reminiscent of when I set the perms wrong on my webpage. :-) Is this an indication of the/an update website coming online? Cheers, S. pgpUnnJHq7cl3.pgp Description: PGP signature ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: gnucash-docs/doc-tools/dbadd.c:97: undefined reference to `__db185_open'
On Tue, May 9, 2006 4:43 pm, Derek Atkins wrote: > This should be fixed soon with Chris Lyttle's gnucash-docs updates. > Just wait a few days. When it's done you have a willing tester :) Regards, Graham -- ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Make Check
On Mon, 2006-04-24 at 00:25 -0700, Bernie du Breuil wrote: > Here is my output from 'make check.' It failed on only one > test. This is on Ubuntu Dapper beta 6.06, gcc 4.0.3, glib > 2.10.2, guile 1.6.7. Let me know if this is helpful. What version of gnucash is this from? This failed in a place no on else is seeing, and the tests that others see as failing aren't in your output. Can you re-try with current SVN? -- ...jsled http://asynchronous.org/ - `a=jsled; b=asynchronous.org; echo [EMAIL PROTECTED] ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: gnucash-docs changes
Chris Lyttle <[EMAIL PROTECTED]> writes: > Hi all, > > I've been working here on updating the -docs build for a release. I've > so far made the following changes (not committed yet); > > a) removed checks for anything to do with using the doc-tools directory. > b) removed the making of html files from 'make' and made a new target > called 'make html' to make and install those files still. > > I haven't committed this to svn yet as I still have some tweaks to get > it to work properly, but I wanted to let you all know and solicit > feedback on these changes. Just let me know when this second change goes in so I can change the daily rebuild to use the new make command. The 'doc-tools' directory was all about dbadd, right? I don't think we need that at all anymore, so I think you could probably just completely remove it, but removing references to it, first, is a decent first step. > Chris -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: gnucash-docs/doc-tools/dbadd.c:97: undefined reference to `__db185_open'
This should be fixed soon with Chris Lyttle's gnucash-docs updates. Just wait a few days. -derek Graham Leggett <[EMAIL PROTECTED]> writes: > Hi all, > > While trying to build gnucash v1.9.5 under RHEL4 (with various packages > upgraded as gnucash dependancies), I am getting the build error below. > > Is there any reason why dbadd.c would be using the v1.85 interface of db? > > Is there a workaround for this? My system contains the library file, I > am confused why the symbol isn't found: > > [EMAIL PROTECTED] Desktop]$ ls -al /usr/lib/libdb1.so* > lrwxrwxrwx 1 root root11 Aug 27 2004 /usr/lib/libdb1.so -> libdb1.so.2 > -rwxr-xr-x 1 root root 53500 Nov 30 2004 /usr/lib/libdb1.so.2 > > The error is: > > /bin/sh ../libtool --mode=link --tag=CC gcc -O2 -g -pipe -m32 > -march=i386 -mtune=pentium4 -o dbadd dbadd.o -ldb1 > mkdir .libs > gcc -O2 -g -pipe -m32 -march=i386 -mtune=pentium4 -o dbadd dbadd.o -ldb1 > dbadd.o(.text+0xc5): In function `main': > /home/gatekeeper/minfrin/rpm/BUILD/gnucash-1.9.5/gnucash-docs/doc-tools/dbadd.c:97: > > undefined reference to `__db185_open' > collect2: ld returned 1 exit status > make[2]: *** [dbadd] Error 1 > make[2]: Leaving directory > `/home/gatekeeper/minfrin/rpm/BUILD/gnucash-1.9.5/gnucash-docs/doc-tools' > make[1]: *** [all-recursive] Error 1 > > Regards, > Graham > -- > ___ > gnucash-devel mailing list > gnucash-devel@gnucash.org > https://lists.gnucash.org/mailman/listinfo/gnucash-devel -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Splash Screen Revisited
Chris Shoemaker <[EMAIL PROTECTED]> writes: >> What do you think? > > My honest first impression is negative: I can't quite tell what that > object in the foreground is. At first, I thought it was a knife! Wow, that was my first impression, too! "Why do we have a dagger in the splash screen?" LOL. I'll note that we CAN update the website logo when we release, so don't necessarily worry about keeping them consistent when you design a new splash screen. Just make sure we get a new logo too ;) -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Error building 1.9.5 on sparc64
Adrian Urquhart <[EMAIL PROTECTED]> writes: > Hi > > I'm trying to build gnucash 1.9.5 from source but I get an error (shown > below). Configure completed without error. System details are: > > uname says: > > Linux sparc64 2.4.32-sparc #1 SMP Mon Dec 12 17:18:03 GMT 2005 sparc64 > sun4u TI UltraSparc II (BlackBird) GNU/Linux > > Gnome version: 2.12.3 > Guile version: 1.6.7 > > And the relevant error message from gmake (sorry about the line wrap): What version of g-wrap? I couldn't get g-wrap to build on my sparc system -- it was giving me errors in the libffi code. Also, what version of gcc are you using? -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [Gnucash-changes] r13919 - gnucash/trunk/src/engine/test-core - Correctly ensure that the amount and value of test Splits have the same sign
Chris Shoemaker <[EMAIL PROTECTED]> writes: > Hopefully C99's _Bool will eventually make my habit appear obsolete > and paranoid. (or does glib already #define TRUE ((_Bool)1)?) No, it just defines TRUE as 1. If you really care, you could use: if (!x == !y) and then it doesn't matter what non-zero value you use for TRUE. The xor is just... weird. And it still wont help you if you're comparing 1 and 2. 1 ^ 2 is non-zero, but you would want to consider them equivalent, whereas 0 ^ 0 is also non-zero. > -chris -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel