Re: gnucash master: Multiple changes pushed

2017-02-02 Thread Geert Janssens
Op donderdag 2 februari 2017 16:35:02 CET schreef Alex Aycinena:
> Geert,
> 
> I build on Fedora 25 and after this commit configure fails with:
> 
> checking for main in -lgtest_main... no
> checking for /usr/src/gtest/src/gtest-all.cc... no
> checking for /usr/src/gtest/gtest-main.cc... no
> checking for /usr/src/gmock/src/gmock-all.cc... no
> checking for /usr/include/gtest/gtest.h... no
> checking for /usr/include/gmock/gmock.h... no
> checking whether Google Test is available... No gtest-root
> No gmock-root
> configure: error:
> 
>  Unable to find the Google test framework. Either install gtest/gmock
>  packages or point to the base directories of the sources using
>  GTEST_ROOT and GMOCK_ROOT environment variables.
> 
> I install gtest and gmock and get the same failure. I believe you build on
> Fedora 25 as well. Can you (or anyone else) give me some guidance as to
> what I need to do to successfully configure, make and make check after this
> commit after having installed the packages?

I do build in Fedora 25 indeed. When I install gtest-devel and gmock-devel 
configure properly finds them. Did you install the development packages or 
just plain gmock & gtest ?

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: gnucash master: Multiple changes pushed

2017-02-02 Thread John Ralls

> On Feb 2, 2017, at 4:35 PM, Alex Aycinena  wrote:
> 
> On Thu, Feb 2, 2017 at 10:03 AM, Geert Janssens 
> wrote:
> 
>> Updated  via  https://github.com/Gnucash/gnucash/commit/659c96eb (commit)
>> via  https://github.com/Gnucash/gnucash/commit/4fdacb9b (commit)
>> via  https://github.com/Gnucash/gnucash/commit/0a8d7a21 (commit)
>>from  https://github.com/Gnucash/gnucash/commit/aeb04e1d (commit)
>> 
>> 
>> 
>> commit 659c96eb1bb8c6cc4a4eab6de0b2ee3f82bd50af
>> Author: Geert Janssens 
>> Date:   Thu Feb 2 18:48:15 2017 +0100
>> 
>>Optionally locate boost via environment variable BOOST_ROOT
>> 
>>This was already the case for our autotools based build
>>and simplifies the build setup for our Windows build system.
>> 
>> commit 4fdacb9b2a614c62ee8c03e2035a1cb800417bcf
>> Author: Geert Janssens 
>> Date:   Thu Feb 2 18:31:54 2017 +0100
>> 
>>Fix building gtest library on mingw
>> 
>>See https://github.com/google/googletest/issues/893
>> 
>> commit 0a8d7a2142419c9494bf40324936a31b380d2161
>> Author: Geert Janssens 
>> Date:   Thu Feb 2 17:20:39 2017 +0100
>> 
>>Make google test framework a mandatory build dependency
>> 
>>All c++ unit tests will be written with it, and testing
>>should be possible out of the box.
>>We could make it optional, but then lots of tests will
>>be skipped. This creates an illusion of all tests passing
>>while many are simply not run. This confusion should be
>>avoided.
>>This change depends on a second commit for the windows build
>>in the gnucash-on-windows repository. This commit will be
>>pushed at the same time.
>> 
>> 
>> 
>> Summary of changes:
>> CMakeLists.txt |   9 +-
>> configure.ac   | 197 +++---
>> ---
>> src/cmake_modules/GncAddTest.cmake |  66 +++--
>> src/engine/test/Makefile.am|   2 -
>> src/libqof/qof/test/CMakeLists.txt |  89 -
>> src/libqof/qof/test/Makefile.am|   2 -
>> src/test-core/CMakeLists.txt   |  22 ++---
>> src/test-core/Makefile.am  |   2 -
>> 8 files changed, 195 insertions(+), 194 deletions(-)
>> 
>> ___
>> gnucash-patches mailing list
>> gnucash-patc...@gnucash.org
>> https://lists.gnucash.org/mailman/listinfo/gnucash-patches
>> 
> 
> Geert,
> 
> I build on Fedora 25 and after this commit configure fails with:
> 
> checking for main in -lgtest_main... no
> checking for /usr/src/gtest/src/gtest-all.cc... no
> checking for /usr/src/gtest/gtest-main.cc... no
> checking for /usr/src/gmock/src/gmock-all.cc... no
> checking for /usr/include/gtest/gtest.h... no
> checking for /usr/include/gmock/gmock.h... no
> checking whether Google Test is available... No gtest-root
> No gmock-root
> configure: error:
> 
> Unable to find the Google test framework. Either install gtest/gmock
> packages or point to the base directories of the sources using
> GTEST_ROOT and GMOCK_ROOT environment variables.
> 
> I install gtest and gmock and get the same failure. I believe you build on
> Fedora 25 as well. Can you (or anyone else) give me some guidance as to
> what I need to do to successfully configure, make and make check after this
> commit after having installed the packages?

Alex,

The configure script used to know where the gtest and gmock modules were 
installed on Fedora, but perhaps that's changed. The simplest solution is to 
clone https://github.com/google/googletest 
 -b revision_1.18.0 and then pass 
--with-gtest-root=/path/to/googletest/googletest 
--with-gmock-root=/path/to/googletest/googlemock to configure. Be sure to use 
absolute paths in those args, recursive make will fail if you give it relative 
paths.

Regards,
John Ralls

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: gnucash master: Multiple changes pushed

2017-02-02 Thread Alex Aycinena
On Thu, Feb 2, 2017 at 10:03 AM, Geert Janssens 
wrote:

> Updated  via  https://github.com/Gnucash/gnucash/commit/659c96eb (commit)
>  via  https://github.com/Gnucash/gnucash/commit/4fdacb9b (commit)
>  via  https://github.com/Gnucash/gnucash/commit/0a8d7a21 (commit)
> from  https://github.com/Gnucash/gnucash/commit/aeb04e1d (commit)
>
>
>
> commit 659c96eb1bb8c6cc4a4eab6de0b2ee3f82bd50af
> Author: Geert Janssens 
> Date:   Thu Feb 2 18:48:15 2017 +0100
>
> Optionally locate boost via environment variable BOOST_ROOT
>
> This was already the case for our autotools based build
> and simplifies the build setup for our Windows build system.
>
> commit 4fdacb9b2a614c62ee8c03e2035a1cb800417bcf
> Author: Geert Janssens 
> Date:   Thu Feb 2 18:31:54 2017 +0100
>
> Fix building gtest library on mingw
>
> See https://github.com/google/googletest/issues/893
>
> commit 0a8d7a2142419c9494bf40324936a31b380d2161
> Author: Geert Janssens 
> Date:   Thu Feb 2 17:20:39 2017 +0100
>
> Make google test framework a mandatory build dependency
>
> All c++ unit tests will be written with it, and testing
> should be possible out of the box.
> We could make it optional, but then lots of tests will
> be skipped. This creates an illusion of all tests passing
> while many are simply not run. This confusion should be
> avoided.
> This change depends on a second commit for the windows build
> in the gnucash-on-windows repository. This commit will be
> pushed at the same time.
>
>
>
> Summary of changes:
>  CMakeLists.txt |   9 +-
>  configure.ac   | 197 +++---
> ---
>  src/cmake_modules/GncAddTest.cmake |  66 +++--
>  src/engine/test/Makefile.am|   2 -
>  src/libqof/qof/test/CMakeLists.txt |  89 -
>  src/libqof/qof/test/Makefile.am|   2 -
>  src/test-core/CMakeLists.txt   |  22 ++---
>  src/test-core/Makefile.am  |   2 -
>  8 files changed, 195 insertions(+), 194 deletions(-)
>
> ___
> gnucash-patches mailing list
> gnucash-patc...@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches
>

Geert,

I build on Fedora 25 and after this commit configure fails with:

checking for main in -lgtest_main... no
checking for /usr/src/gtest/src/gtest-all.cc... no
checking for /usr/src/gtest/gtest-main.cc... no
checking for /usr/src/gmock/src/gmock-all.cc... no
checking for /usr/include/gtest/gtest.h... no
checking for /usr/include/gmock/gmock.h... no
checking whether Google Test is available... No gtest-root
No gmock-root
configure: error:

 Unable to find the Google test framework. Either install gtest/gmock
 packages or point to the base directories of the sources using
 GTEST_ROOT and GMOCK_ROOT environment variables.

I install gtest and gmock and get the same failure. I believe you build on
Fedora 25 as well. Can you (or anyone else) give me some guidance as to
what I need to do to successfully configure, make and make check after this
commit after having installed the packages?

Thanks,

Alex
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: gtk3 + webkit

2017-02-02 Thread Bill Nottingham
John Ralls (jra...@ceridwen.us) said: 
> Geert noted in IRC that
> https://bugzilla.redhat.com/show_bug.cgi?id=1375812 indicates that we need
> to lose the dependency on WebKit1 ASAP, as Fedora intends to drop it from
> distribution in F27.  As Geert notes, WebKit2 is Gtk3-only.  Note, though,
> that on the bug Bill Nottingham suggests that he might flatpack WebKitGtk1
> and request a waiver, and Catanzaro seems to receive that well enough.

In terms of Fedora/EPEL - yes, I'll just bundle in webkitgtk as needed for
2.6.x, and maybe look at flatpak if I get the spare time to do so.

Bill
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: gtk3 + webkit

2017-02-02 Thread John Ralls

> On Feb 2, 2017, at 7:01 AM, Geert Janssens  wrote:
> 
> Bob,
> 
> Thanks for bringing this up.
> 
> While I thought of it, I didn't mention this third option as I didn't feel 
> like maintaining gnome-canvas as part of gnucash.
> 
> As you have done a big chunk of the work we may as well evaluate this avenue 
> anyway, perhaps only as a short term interim solution.
> 
> I'll look at it when I'm ready to take on the Gtk3 work. Note that I have my 
> own local gtk3 branch with several patches to migrate parts over that 
> couldn't 
> be migrated as long as we also supported gtk2.
> 
> I had forgotten to consider our external dependencies. Glad you bring that up.
> 
> * LibOFX is not using gtk at all. It's a non-gui library.
> * Aqbanking depends on Gtk2 indeed via its own dependency on gwenhywfar. I'd 
> need to investigate how difficult it would be to port that to Gtk3.
> * As you suggested goffice will soon be eliminated from our dependency list
> * WebkitGtk2 is Gtk3 only (there's even talk of Gtk4 only soon...). For 
> Win32, 
> we have been building Webkit ourselves from the beginning. From what I've 
> heard it's hard, but both Phill Longstaff and John Ralls have managed this in 
> the past. I assume we will be able to build a newer version ourselves as 
> well. 
> 
> Note that for the Windows build I have been wanting to evaluate Mingw64 for 
> some time now, which does come with a prebuilt version of WebkitGtk2 and 
> several other of our dependencies.The missing ones are isocodes, opensp, 
> libofx, gwenhywfar, ktoblzcheck, aqbanking and dbi. But that's ok, we have 
> been building those ourselves for ages. This experiment will have to wait 
> though until the other priorities have been sorted out.
> 
> Regards,
> 
> Geert
> 
> Op donderdag 2 februari 2017 13:48:32 CET schreef Robert Fewell:
>> Hi,
>> 
>> I was looking at the irc logs and see that gtk3 / webkit upgrade was
>> mentioned and that there were two options mentioned, one was change to some
>> thing like goo-canvas, the other was to complete register2 which I started
>> awhile back and failed to complete.
>> 
>> There is an other option that I came across in planner when I was thinking
>> about trying to convert my attempt to use gtk3 to see if that would solve
>> some issues after I had reverted the later changes. They had incorporated a
>> cut down version of gnome-canvas in there source that works with gtk3 and I
>> decided to give that a go.
>> 
>> If you look at https://github.com/Bob-IT/gnucash/commits/gtk3 you will see
>> that I have added a further reduced version of gnome-canvas along with
>> commits to fix first run compile errors and a converted register using it
>> and cairo.
>> 
>> This uses gtk3, I think a gtk3 version of webkit2 (I get confused about
>> versions), gtk3 version of goffice (this may not be needed with Geerts
>> changes), no aquabanking / ofx as I think that uses gtk2 and there is no
>> gtk3 versions and I believe you can not mix them. To build this you need to
>> disable warnings as errors which should give you a running version of
>> GnuCash with a working register, some things still needed to be changed,
>> namely the size of the drop down arrow on the calendar and to revert some
>> colour changes for testing.
>> 
>> I have made further changes to fix depreciated warnings and glade file
>> changes but I would need to check these against the current master, a lot
>> this was find and replace with gtk3 functions / widgets.
>> 
>> What I have observed is the following..,
>> 
>> Most glade files needed changing to eliminate spaces in the
>> add_builder_from_file line along with changing the depreciated widgets and
>> then realign to match existing layout
>> Gtk stock is depreciated and that changes images / buttons to icon names,
>> to get over this I just removed all images from buttons and to use text
>> only as a start.
>> You need to use inline CSS to achieve bits like the tab colours.
>> 
>> The main thing I could not get my head round was the change in toolbars /
>> menus / accelerator keys. Menu's can not have images on them and the way
>> they are created is totally different.
>> 
>> This was just a look at when I felt like it but may be some thing useful or
>> not worth while. I did have a look to see if I could get this to run on
>> Windows to make sure the changes I made worked but I could only find a gtk3
>> version 3.10.6 and no webkit version but I may not of been looking in the
>> right place.

Geert noted in IRC that https://bugzilla.redhat.com/show_bug.cgi?id=1375812 
indicates that we need to lose the dependency on WebKit1 ASAP, as Fedora 
intends to drop it from distribution in F27. As Geert notes, WebKit2 is 
Gtk3-only. Note, though, that on the bug Bill Nottingham suggests that he might 
flatpack WebKitGtk1 and request a waiver, and Catanzaro seems to receive that 
well enough.

I'm not keen on creating our own version of libgnomecanvas. We use only 19 

Re: gncEntryComputeValue exported to python?

2017-02-02 Thread Christoph R
Hi Derek,

Yeah, I am on that track already. 

So far I focused on the reporting side only. Goal was to show the price before 
taxes in taxinvoice.scm instead of the typed in price. I have a working version 
by adding (and calling) a gncEntryGetInvNetPrice function which calculates this 
from the existing struct entry. Just working out how to provide that patch for 
review.

My next step will be figuring about good ways to solve the original problem of 
correctly adding purchase entries to invoices with differing tax rates. And I 
that without modifying struct entry.

Cheers,
Christoph

> Am 02.02.2017 um 17:57 schrieb Derek Atkins :
> 
> Hi,
> 
> Christoph R  writes:
> 
>> Hi,
>> 
>> while trying to find a way to solve Bug 776380 – Gross value of bills
>> charged back instead of net value
>>  I digged into
>> gncEntry.c.
>> My idea is to add a ?_net_price variable to struct _gncEntry and
>> modify gncEntryComputeValue to calculate the net price.
> 
> Is there any particular reason not to use the TaxIncluded flag?  Is
> there some reason where the setting of TaxIncluded and your new proposed
> netPrice flags wouldn't be equivalent?
> 
> -derek
> 
> -- 
>   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>   Member, MIT Student Information Processing Board  (SIPB)
>   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
>   warl...@mit.eduPGP key available

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: gncEntryComputeValue exported to python?

2017-02-02 Thread Derek Atkins
Hi,

Christoph R  writes:

> Hi,
>
> while trying to find a way to solve Bug 776380 – Gross value of bills
> charged back instead of net value
>  I digged into
> gncEntry.c.
> My idea is to add a ?_net_price variable to struct _gncEntry and
> modify gncEntryComputeValue to calculate the net price.

Is there any particular reason not to use the TaxIncluded flag?  Is
there some reason where the setting of TaxIncluded and your new proposed
netPrice flags wouldn't be equivalent?

-derek

-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   warl...@mit.eduPGP key available
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: gtk3 + webkit

2017-02-02 Thread Geert Janssens
Bob,

Thanks for bringing this up.

While I thought of it, I didn't mention this third option as I didn't feel 
like maintaining gnome-canvas as part of gnucash.

As you have done a big chunk of the work we may as well evaluate this avenue 
anyway, perhaps only as a short term interim solution.

I'll look at it when I'm ready to take on the Gtk3 work. Note that I have my 
own local gtk3 branch with several patches to migrate parts over that couldn't 
be migrated as long as we also supported gtk2.

I had forgotten to consider our external dependencies. Glad you bring that up.

* LibOFX is not using gtk at all. It's a non-gui library.
* Aqbanking depends on Gtk2 indeed via its own dependency on gwenhywfar. I'd 
need to investigate how difficult it would be to port that to Gtk3.
* As you suggested goffice will soon be eliminated from our dependency list
* WebkitGtk2 is Gtk3 only (there's even talk of Gtk4 only soon...). For Win32, 
we have been building Webkit ourselves from the beginning. From what I've 
heard it's hard, but both Phill Longstaff and John Ralls have managed this in 
the past. I assume we will be able to build a newer version ourselves as well. 

Note that for the Windows build I have been wanting to evaluate Mingw64 for 
some time now, which does come with a prebuilt version of WebkitGtk2 and 
several other of our dependencies.The missing ones are isocodes, opensp, 
libofx, gwenhywfar, ktoblzcheck, aqbanking and dbi. But that's ok, we have 
been building those ourselves for ages. This experiment will have to wait 
though until the other priorities have been sorted out.

Regards,

Geert

Op donderdag 2 februari 2017 13:48:32 CET schreef Robert Fewell:
> Hi,
> 
> I was looking at the irc logs and see that gtk3 / webkit upgrade was
> mentioned and that there were two options mentioned, one was change to some
> thing like goo-canvas, the other was to complete register2 which I started
> awhile back and failed to complete.
> 
> There is an other option that I came across in planner when I was thinking
> about trying to convert my attempt to use gtk3 to see if that would solve
> some issues after I had reverted the later changes. They had incorporated a
> cut down version of gnome-canvas in there source that works with gtk3 and I
> decided to give that a go.
> 
> If you look at https://github.com/Bob-IT/gnucash/commits/gtk3 you will see
> that I have added a further reduced version of gnome-canvas along with
> commits to fix first run compile errors and a converted register using it
> and cairo.
> 
> This uses gtk3, I think a gtk3 version of webkit2 (I get confused about
> versions), gtk3 version of goffice (this may not be needed with Geerts
> changes), no aquabanking / ofx as I think that uses gtk2 and there is no
> gtk3 versions and I believe you can not mix them. To build this you need to
> disable warnings as errors which should give you a running version of
> GnuCash with a working register, some things still needed to be changed,
> namely the size of the drop down arrow on the calendar and to revert some
> colour changes for testing.
> 
> I have made further changes to fix depreciated warnings and glade file
> changes but I would need to check these against the current master, a lot
> this was find and replace with gtk3 functions / widgets.
> 
> What I have observed is the following..,
> 
> Most glade files needed changing to eliminate spaces in the
> add_builder_from_file line along with changing the depreciated widgets and
> then realign to match existing layout
> Gtk stock is depreciated and that changes images / buttons to icon names,
> to get over this I just removed all images from buttons and to use text
> only as a start.
> You need to use inline CSS to achieve bits like the tab colours.
> 
> The main thing I could not get my head round was the change in toolbars /
> menus / accelerator keys. Menu's can not have images on them and the way
> they are created is totally different.
> 
> This was just a look at when I felt like it but may be some thing useful or
> not worth while. I did have a look to see if I could get this to run on
> Windows to make sure the changes I made worked but I could only find a gtk3
> version 3.10.6 and no webkit version but I may not of been looking in the
> right place.
> 
> 
> Regards,
> Bob
> ___
> gnucash-devel mailing list
> gnucash-devel@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel


___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


gtk3 + webkit

2017-02-02 Thread Robert Fewell
Hi,

I was looking at the irc logs and see that gtk3 / webkit upgrade was
mentioned and that there were two options mentioned, one was change to some
thing like goo-canvas, the other was to complete register2 which I started
awhile back and failed to complete.

There is an other option that I came across in planner when I was thinking
about trying to convert my attempt to use gtk3 to see if that would solve
some issues after I had reverted the later changes. They had incorporated a
cut down version of gnome-canvas in there source that works with gtk3 and I
decided to give that a go.

If you look at https://github.com/Bob-IT/gnucash/commits/gtk3 you will see
that I have added a further reduced version of gnome-canvas along with
commits to fix first run compile errors and a converted register using it
and cairo.

This uses gtk3, I think a gtk3 version of webkit2 (I get confused about
versions), gtk3 version of goffice (this may not be needed with Geerts
changes), no aquabanking / ofx as I think that uses gtk2 and there is no
gtk3 versions and I believe you can not mix them. To build this you need to
disable warnings as errors which should give you a running version of
GnuCash with a working register, some things still needed to be changed,
namely the size of the drop down arrow on the calendar and to revert some
colour changes for testing.

I have made further changes to fix depreciated warnings and glade file
changes but I would need to check these against the current master, a lot
this was find and replace with gtk3 functions / widgets.

What I have observed is the following..,

Most glade files needed changing to eliminate spaces in the
add_builder_from_file line along with changing the depreciated widgets and
then realign to match existing layout
Gtk stock is depreciated and that changes images / buttons to icon names,
to get over this I just removed all images from buttons and to use text
only as a start.
You need to use inline CSS to achieve bits like the tab colours.

The main thing I could not get my head round was the change in toolbars /
menus / accelerator keys. Menu's can not have images on them and the way
they are created is totally different.

This was just a look at when I felt like it but may be some thing useful or
not worth while. I did have a look to see if I could get this to run on
Windows to make sure the changes I made worked but I could only find a gtk3
version 3.10.6 and no webkit version but I may not of been looking in the
right place.


Regards,
Bob
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: gncEntryComputeValue exported to python?

2017-02-02 Thread Geert Janssens
Op dinsdag 31 januari 2017 17:13:43 CET schreef Christoph R:
> Hi,
> 
> while trying to find a way to solve  Bug 776380 – Gross value of bills
> charged back instead of net value
>  I digged into
> gncEntry.c. My idea is to add a ?_net_price variable to struct _gncEntry
> and modify gncEntryComputeValue to calculate the net price.
> 
> To my big surprise I found gncEntryComputeValue exported as a python
> binding. Since gncEntryComputeValue operates on a private struct in
> gncEntry I cannot believe that it should be exported to python.
> 
> Anything I missed?
> 
Well, to be nitpicking it doesn't work directly on a gncEntry. It works with 
values passed in and it will optionally return 3 other values. You are correct 
though that in all sensible uses of the function the values passed in and out 
are essentially internal to a gncEntry and it would be an internal function in 
a proper OO design.

The reason for this function to appear in the language bindings is it's 
declared in a public header file and the whole file is being wrapped. I don't 
think this happened intentionally, so you can probably configure swig to 
ignore this function.

On the other hand be careful when changing the function's signature, because 
it's also used by the EntryLedger (src/business/business-ledger/
gncEntryLedger.c).

Happy hacking!

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


gncEntryComputeValue exported to python?

2017-02-02 Thread Christoph R
Hi,

while trying to find a way to solve  Bug 776380 – Gross value of bills charged 
back instead of net value  I 
digged into gncEntry.c.
My idea is to add a ?_net_price variable to struct _gncEntry and modify 
gncEntryComputeValue to calculate the net price.

To my big surprise I found gncEntryComputeValue exported as a python binding. 
Since gncEntryComputeValue operates on a private struct in gncEntry I cannot 
believe that it should be exported to python.

Anything I missed?

Cheers,
Christoph

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel