Re: Attempt to build gnucash(master) via Msys2/jhbuild

2017-09-02 Thread John Ralls


> On Sep 2, 2017, at 12:57 PM, Geert Janssens  
> wrote:
> 
> So I revived a Windows 7 Professional 64bit PC that was collecting dust in 
> the 
> corner to become a test builder for Gnucash on Windows (master).
> 
> In the process of getting this set up and running I ran into a number of 
> issues. I've duly written bug reports to track them all:
> https://bugzilla.gnome.org/show_bug.cgi?id=787176
> https://bugzilla.gnome.org/show_bug.cgi?id=787177
> https://bugzilla.gnome.org/show_bug.cgi?id=787179
> https://bugzilla.gnome.org/show_bug.cgi?id=787190
> https://bugzilla.gnome.org/show_bug.cgi?id=787192
> 
> I managed to get past most of them (though they're not fixed yet), but I'm 
> stuck on the last one: MSys2/Jhbuild fails to find swig in gnucash configure 
> step
> 
> I'll need some help understanding why this is happening and how to get past 
> it. The full output of the configure step is in the bug report.
> 
> I know John is afk so I may have to wait for his return, but I figured to 
> report my effort so far.

Geert,

IIRC that was affected by which shell one uses. In July I was using a Win7 VM 
(and BTW don’t remember any trouble with the Powershell version) and the MSYS2 
shell did the right thing. This last week I’ve been working in a Win10 VM and 
the MINGW32 shell is the one that works right. I’d put that down to MinGW64 
updates between creating the two environments but I suppose that it’s also 
possible that it depends on the OS version.

Bottom line, try the other one from what you’ve been using.

Regards,
John Ralls

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Change Boost dependency to 1.54 or above?

2017-09-02 Thread Leon Taylor
Centos focuses on being ultra-stable, so all of centos' packages are
very old. I think centos 6 is still using the 2.6 linux kernel.
Thanks, Leon

On Sat, 2017-09-02 at 14:36 -0700, Sumit Bhardwaj wrote:
> Sounds good. I didn't realize Centos 7 was that far behind.
> 
> Thanks,
> Sumit
> 
> On Sat, Sep 2, 2017 at 1:19 PM, Geert Janssens  it.be>
> wrote:
> 
> > On zaterdag 2 september 2017 09:35:17 CEST Sumit Bhardwaj wrote:
> > > Some time back, John had asked if we can move our Boost
> > > dependency to
> > 
> > 1.54
> > > or above so we can use Boost::log. I wanted to check back to see
> > > if we
> > 
> > are
> > > at a point where we can move Boost from 1.53 which is where we
> > > have it
> > 
> > now.
> > > 
> > > For reference, Fedora 22 shipped on May 26, 2015 with Boost
> > > version 1.58.
> > > Fedora 26 has version 1.63 and Boost's latest version is 1.65.
> > > 
> > 
> > Fedora is not a very good reference to determine the lower limit of
> > package
> > versions. It generally is very close to upstream.
> > 
> > The distros to check are the long-term supported ones: RHEL/Centos,
> > Ubuntu
> > LTS, Debian stable,...
> > 
> > For Ubuntu we currently still have to support 14.04LTS (Trusty),
> > because
> > that's what our test environment on Travis uses. That platform
> > however is
> > ok.
> > It has boost 1.54 and 1.55 is available as well.
> > 
> > Debian stable was at 1.55 last time I checked.
> > 
> > RHEL/Centos 7 unfortunately are only at boost 1.53. There are ways
> > to get
> > more
> > recent versions of boost there, but that would mean either building
> > from
> > scratch or configuring a foreign repository. If we require that we
> > essentially
> > state we're no longer supporting RHEL/Centos 7.
> > 
> > I'm inclined not to do that and stick with 1.53 instead.
> > 
> > Regards,
> > 
> > Geert
> > 
> 
> ___
> gnucash-devel mailing list
> gnucash-devel@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Change Boost dependency to 1.54 or above?

2017-09-02 Thread Sumit Bhardwaj
Sounds good. I didn't realize Centos 7 was that far behind.

​Thanks,
Sumit​

On Sat, Sep 2, 2017 at 1:19 PM, Geert Janssens 
wrote:

> On zaterdag 2 september 2017 09:35:17 CEST Sumit Bhardwaj wrote:
> > Some time back, John had asked if we can move our Boost dependency to
> 1.54
> > or above so we can use Boost::log. I wanted to check back to see if we
> are
> > at a point where we can move Boost from 1.53 which is where we have it
> now.
> >
> > For reference, Fedora 22 shipped on May 26, 2015 with Boost version 1.58.
> > Fedora 26 has version 1.63 and Boost's latest version is 1.65.
> >
> Fedora is not a very good reference to determine the lower limit of package
> versions. It generally is very close to upstream.
>
> The distros to check are the long-term supported ones: RHEL/Centos, Ubuntu
> LTS, Debian stable,...
>
> For Ubuntu we currently still have to support 14.04LTS (Trusty), because
> that's what our test environment on Travis uses. That platform however is
> ok.
> It has boost 1.54 and 1.55 is available as well.
>
> Debian stable was at 1.55 last time I checked.
>
> RHEL/Centos 7 unfortunately are only at boost 1.53. There are ways to get
> more
> recent versions of boost there, but that would mean either building from
> scratch or configuring a foreign repository. If we require that we
> essentially
> state we're no longer supporting RHEL/Centos 7.
>
> I'm inclined not to do that and stick with 1.53 instead.
>
> Regards,
>
> Geert
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: CMake failure with LIB_OFX OFF

2017-09-02 Thread Sumit Bhardwaj
You meant second. Right? :)

https://github.com/Gnucash/gnucash/pull/181

Thanks,
Sumit

On Sat, Sep 2, 2017 at 6:46 AM, John Ralls  wrote:

>
>
> > On Sep 2, 2017, at 12:22 AM, Sumit Bhardwaj  wrote:
> >
> > After pulling the latest master, I was able to make and make check using
> > autotools. However, cmake failed.
> >
> > With the command:
> >> cmake -D WITH_AQBANKING=OFF -D WITH_OFX=OFF -G Ninja ../gnucash/ &&
> ninja
> > check && ninja install
> >
> > The error at the end is:
> > FAILED:
> > gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.
> dir/test-link.c.o
> > /usr/bin/cc -DHAVE_CONFIG_H -DHAVE_GUILE20  -Werror
> > -Wdeclaration-after-statement -Wno-pointer-sign -Wall -Wunused
> > -Wmissing-prototypes -Wmissing-declarations  -Wno-unused
> > -Wno-deprecated-declarations -std=gnu11 -MD -MT
> > gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.
> dir/test-link.c.o
> > -MF
> > gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.
> dir/test-link.c.o.d
> > -o
> > gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.
> dir/test-link.c.o
> > -c
> > /home/bhardwajs/ac/devel/gnucash/gnucash/import-export/
> ofx/test/test-link.c
> > /home/bhardwajs/ac/devel/gnucash/gnucash/import-export/
> ofx/test/test-link.c:21:10:
> > fatal error: libofx/libofx.h: No such file or directory
> > #include 
> >  ^
> > compilation terminated.
> > [745/1002] Building CXX object
> > gnucash/import-export/csv-imp/CMakeFiles/gncmod-csv-import.
> dir/gnc-tx-import.cpp.o
> > ninja: build stopped: subcommand failed.
> >
> > Environment: Fedora 26
>
>
> Looks like an opportunity for your first PR! Obviously if WITH_OFX is off
> import-export/ofx shouldn’t build.
>
> Regards,
> John Ralls
>
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Change Boost dependency to 1.54 or above?

2017-09-02 Thread Geert Janssens
On zaterdag 2 september 2017 09:35:17 CEST Sumit Bhardwaj wrote:
> Some time back, John had asked if we can move our Boost dependency to 1.54
> or above so we can use Boost::log. I wanted to check back to see if we are
> at a point where we can move Boost from 1.53 which is where we have it now.
> 
> For reference, Fedora 22 shipped on May 26, 2015 with Boost version 1.58.
> Fedora 26 has version 1.63 and Boost's latest version is 1.65.
> 
Fedora is not a very good reference to determine the lower limit of package 
versions. It generally is very close to upstream.

The distros to check are the long-term supported ones: RHEL/Centos, Ubuntu 
LTS, Debian stable,...

For Ubuntu we currently still have to support 14.04LTS (Trusty), because 
that's what our test environment on Travis uses. That platform however is ok. 
It has boost 1.54 and 1.55 is available as well.

Debian stable was at 1.55 last time I checked.

RHEL/Centos 7 unfortunately are only at boost 1.53. There are ways to get more 
recent versions of boost there, but that would mean either building from 
scratch or configuring a foreign repository. If we require that we essentially 
state we're no longer supporting RHEL/Centos 7.

I'm inclined not to do that and stick with 1.53 instead.

Regards,

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Attempt to build gnucash(master) via Msys2/jhbuild

2017-09-02 Thread Geert Janssens
So I revived a Windows 7 Professional 64bit PC that was collecting dust in the 
corner to become a test builder for Gnucash on Windows (master).

In the process of getting this set up and running I ran into a number of 
issues. I've duly written bug reports to track them all:
https://bugzilla.gnome.org/show_bug.cgi?id=787176
https://bugzilla.gnome.org/show_bug.cgi?id=787177
https://bugzilla.gnome.org/show_bug.cgi?id=787179
https://bugzilla.gnome.org/show_bug.cgi?id=787190
https://bugzilla.gnome.org/show_bug.cgi?id=787192

I managed to get past most of them (though they're not fixed yet), but I'm 
stuck on the last one: MSys2/Jhbuild fails to find swig in gnucash configure 
step

I'll need some help understanding why this is happening and how to get past 
it. The full output of the configure step is in the bug report.

I know John is afk so I may have to wait for his return, but I figured to 
report my effort so far.

Regards,

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Travis test failure in test-import-map

2017-09-02 Thread Geert Janssens
On zaterdag 11 maart 2017 13:57:52 CEST Robert Fewell wrote:
> For information I have added this to my test branch travis.yml file...
> 
> after_failure: for file in $( find . -name 'test*.log' ); do echo -e
> "\n## $file"$'\n\n'"$(cat -- "$file")" >> all.txt; done && cat all.txt

FYI

Since I was working on the Travis script anyway, I have added a variant of 
this code that will output LastTest.log (for cmake based builds) or all the 
test*.log files (for autotools based builds) on failure.

And yes it looks like there's a race condition somewhere in the acount-imap 
code or the test. That part isn't solved yet unfortunately.

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: CMake failure with LIB_OFX OFF

2017-09-02 Thread John Ralls


> On Sep 2, 2017, at 12:22 AM, Sumit Bhardwaj  wrote:
> 
> After pulling the latest master, I was able to make and make check using
> autotools. However, cmake failed.
> 
> With the command:
>> cmake -D WITH_AQBANKING=OFF -D WITH_OFX=OFF -G Ninja ../gnucash/ && ninja
> check && ninja install
> 
> The error at the end is:
> FAILED:
> gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.dir/test-link.c.o
> /usr/bin/cc -DHAVE_CONFIG_H -DHAVE_GUILE20  -Werror
> -Wdeclaration-after-statement -Wno-pointer-sign -Wall -Wunused
> -Wmissing-prototypes -Wmissing-declarations  -Wno-unused
> -Wno-deprecated-declarations -std=gnu11 -MD -MT
> gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.dir/test-link.c.o
> -MF
> gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.dir/test-link.c.o.d
> -o
> gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.dir/test-link.c.o
> -c
> /home/bhardwajs/ac/devel/gnucash/gnucash/import-export/ofx/test/test-link.c
> /home/bhardwajs/ac/devel/gnucash/gnucash/import-export/ofx/test/test-link.c:21:10:
> fatal error: libofx/libofx.h: No such file or directory
> #include 
>  ^
> compilation terminated.
> [745/1002] Building CXX object
> gnucash/import-export/csv-imp/CMakeFiles/gncmod-csv-import.dir/gnc-tx-import.cpp.o
> ninja: build stopped: subcommand failed.
> 
> Environment: Fedora 26

Looks like an opportunity for your first PR! Obviously if WITH_OFX is off 
import-export/ofx shouldn’t build.

Regards,
John Ralls

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: dialog-invoice

2017-09-02 Thread Robert Fewell
Mike,
Thanks for that, it looks like I reverted your change, possibly used an out
of date file, will make changes and add it to a PR.
Bob

On 2 September 2017 at 13:48, Mike Evans  wrote:

> On Sat, 2 Sep 2017 13:42:56 +0100
> Robert Fewell <14ubo...@gmail.com> wrote:
>
> > I have noticed some invalid casts which trace back to dialog-invoice but
> > not sure what has changed, so here is what I have found...
> >
> > Looking at a local pre gtk3/master dialog-invoice.glade, you have
> > page_terms_menu being a GtkEntry and dialog_terms_menu being a
> GtkComboBox
> > with no Entry.
> >
> > Looking at master now dialog-invoice.glade, you have page_terms_menu
> being
> > a GtkComboBox with no Entry and dialog_terms_menu being a GtkComboBox
> with
> > no Entry.
> >
> > What I do not know is did I make a mistake in the conversion, seems
> strange
> > I would of changed widgets or was there a change made that was not
> correct ?
> >
> > Tried looking at the history of dialog-invoice.glade on GitHub but that
> has
> > no history before the directory changes, any other way to find out
> > what/when changed ?
> >
> > Bob
> > ___
> > gnucash-devel mailing list
> > gnucash-devel@gnucash.org
> > https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
> git log --follow will get previous you history
>
> Mike E
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: dialog-invoice

2017-09-02 Thread Mike Evans
On Sat, 2 Sep 2017 13:42:56 +0100
Robert Fewell <14ubo...@gmail.com> wrote:

> I have noticed some invalid casts which trace back to dialog-invoice but
> not sure what has changed, so here is what I have found...
> 
> Looking at a local pre gtk3/master dialog-invoice.glade, you have
> page_terms_menu being a GtkEntry and dialog_terms_menu being a GtkComboBox
> with no Entry.
> 
> Looking at master now dialog-invoice.glade, you have page_terms_menu being
> a GtkComboBox with no Entry and dialog_terms_menu being a GtkComboBox with
> no Entry.
> 
> What I do not know is did I make a mistake in the conversion, seems strange
> I would of changed widgets or was there a change made that was not correct ?
> 
> Tried looking at the history of dialog-invoice.glade on GitHub but that has
> no history before the directory changes, any other way to find out
> what/when changed ?
> 
> Bob
> ___
> gnucash-devel mailing list
> gnucash-devel@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel

git log --follow will get previous you history

Mike E
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


dialog-invoice

2017-09-02 Thread Robert Fewell
I have noticed some invalid casts which trace back to dialog-invoice but
not sure what has changed, so here is what I have found...

Looking at a local pre gtk3/master dialog-invoice.glade, you have
page_terms_menu being a GtkEntry and dialog_terms_menu being a GtkComboBox
with no Entry.

Looking at master now dialog-invoice.glade, you have page_terms_menu being
a GtkComboBox with no Entry and dialog_terms_menu being a GtkComboBox with
no Entry.

What I do not know is did I make a mistake in the conversion, seems strange
I would of changed widgets or was there a change made that was not correct ?

Tried looking at the history of dialog-invoice.glade on GitHub but that has
no history before the directory changes, any other way to find out
what/when changed ?

Bob
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: New Account Dialog

2017-09-02 Thread Geert Janssens
On zaterdag 2 september 2017 02:23:54 CEST John Ralls wrote:
> > On Sep 1, 2017, at 4:25 PM, Alex Aycinena  wrote:
> 
> > (note: I used an 'edit account' dialog instead of a 'new account' dialog, 
without thinking, but it shouldn't make any difference, it just doesn't have 
an opening balance notebook tab):
> It also has a label instead of a combo box for commodity.
> 
Only if the account already has splits. But that appears to be the case in the 
account Alex used as example.

> Since GtkComboBoxes can display tree views as well as list views, how about
> making the parent account a combo box too?
> 
Good idea.

I also think David C makes a good point about the sequence in which one would 
expect to enter the info.

I think Account type and currency are more important than account color or 
notes, but less important than name, code and description. So for me they 
could fit there. Since parent account must be set before account type can be 
set, it would then have to go between description and account type. If it does 
become a combo box, it can be part of the identification group IMO, where 
account type and friends can stay in their own group as you have done.
The remaining bits would then become yet another group (Miscellaneous or 
something like that). I'm open to better suggestions as well :)

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Change Boost dependency to 1.54 or above?

2017-09-02 Thread Sumit Bhardwaj
Some time back, John had asked if we can move our Boost dependency to 1.54
or above so we can use Boost::log. I wanted to check back to see if we are
at a point where we can move Boost from 1.53 which is where we have it now.

For reference, Fedora 22 shipped on May 26, 2015 with Boost version 1.58.
Fedora 26 has version 1.63 and Boost's latest version is 1.65.

Thanks,
Sumit
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


CMake failure with LIB_OFX OFF

2017-09-02 Thread Sumit Bhardwaj
After pulling the latest master, I was able to make and make check using
autotools. However, cmake failed.

With the command:
>cmake -D WITH_AQBANKING=OFF -D WITH_OFX=OFF -G Ninja ../gnucash/ && ninja
check && ninja install

The error at the end is:
FAILED:
gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.dir/test-link.c.o
/usr/bin/cc -DHAVE_CONFIG_H -DHAVE_GUILE20  -Werror
-Wdeclaration-after-statement -Wno-pointer-sign -Wall -Wunused
-Wmissing-prototypes -Wmissing-declarations  -Wno-unused
-Wno-deprecated-declarations -std=gnu11 -MD -MT
gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.dir/test-link.c.o
-MF
gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.dir/test-link.c.o.d
-o
gnucash/import-export/ofx/test/CMakeFiles/test-link-ofx.dir/test-link.c.o
-c
/home/bhardwajs/ac/devel/gnucash/gnucash/import-export/ofx/test/test-link.c
/home/bhardwajs/ac/devel/gnucash/gnucash/import-export/ofx/test/test-link.c:21:10:
fatal error: libofx/libofx.h: No such file or directory
 #include 
  ^
compilation terminated.
[745/1002] Building CXX object
gnucash/import-export/csv-imp/CMakeFiles/gncmod-csv-import.dir/gnc-tx-import.cpp.o
ninja: build stopped: subcommand failed.

Environment: Fedora 26

Thanks,
Sumit
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel