Re: [GNC-dev] How to contribute to GnuCash?
Op zaterdag 27 april 2019 01:01:38 CEST schreef John Ralls: > What Geert meant is that our current engine code *isn't* particularly > portable, though I think that since it compiles OK on MacOS it shouldn't > have too much trouble with iOS either. It's a mix of C and C++ and the main > dependencies are Boost and Gnome Glib; the XML file backend also depends on > libxml2 and the SQL backend depends on libdbi. > > The public mirror for our git repository is at > https://github.com/gnucash/gnucash. Note that the stable branch is "maint". > Doxygen API docs are at https://code.gnucash.org/docs/MAINT. > > Regards, > John Ralls > The devil is in the details... The engine code currently still depends on guile as well, which is a scripting language. Doesn't Apple impose restrictions on that ? I currently don't have a full overview of where guile is used in the engine code. I know the option system is heavily dependent on it, but that's primarily used by the report system. Regards, Geert > > On Apr 26, 2019, at 12:56 PM, John wrote: > > > > Thanks for bringing it up. A portable engine code is definitely more > > meaningful. Can you point me at some document or source code on portable > > engine code? we just want to get more details and estimate the work load. > > > > Thanks, > > John > > > > On Fri, Apr 26, 2019 at 9:33 AM Geert Janssens > > wrote: Hi, > > > > An iOS companion app would be great. > > > > The android app took the approach of reimplementing all the business logic > > required to read (and write?) a gnucash data file rather than using the > > gnucash engine code. > > > > I can understand why as the engine code is currently difficult to port to > > different platforms. It is one of our goals to make this easier, but > > there's still a lot of work ahead to get to that state. > > > > If you feel like joining that effort it would be very welcome as a > > portable > > engine would greatly benefit gnucash and all derived apps on all platforms > > (including the android app and a future ios app). > > > > Don't feel obliged of course. I did want to bring it up anyway so you know > > this goal exists and may be useful for your app in the future. > > > > Regards, > > > > geert > > > > Op donderdag 25 april 2019 17:41:00 CEST schreef John Ralls: > > > > On Apr 24, 2019, at 10:13 PM, John wrote: > > > > > > > > Hello, > > > > > > > > I am the founder of a mobile app startup and a big fan of GnuCash. My > > > > team > > > > has some free time now. I wonder if we can contribute to develop an > > > > iOS > > > > companion app like current Android one. Can you let me know if you > > > > think > > > > that's a good idea? and if yes, how to start? > > > > > > > > Thanks, > > > > John > > > > > > It's a good idea if you're going to commit to maintaining and supporting > > > it > > > for a reasonable value of forever. The GnuCash team hasn't the time nor > > > expertise to accept such an app as a contribution. > > > > > > To get started I'd think it best to contact Ngewi via the > > > GnuCash-for-Android support channels and discuss whether his design is > > > portable to iOS and what lessons he's learned and improvements he might > > > make. > > > > > > Once you're ready to start work I expect you'll want to recruit users > > > for > > > usability testing of your UI mockups and later for beta-testing. I'm > > > sure > > > some of our users will be interested in helping, though if you're > > > contemplating a commercial product you'll need to figure out the right > > > way > > > to engage with a FLOSS community. > > > > > > Regards, > > > John Ralls > > > ___ > > > gnucash-devel mailing list > > > gnucash-devel@gnucash.org > > > https://lists.gnucash.org/mailman/listinfo/gnucash-devel ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Bug796872 Multiple selection feature in import matcher
Thanks John, I took the fresh fork route. There should be a pull request for the files for the Multiple selection waiting for you. I'll go through the commands though to mprove my education. David - David Cousens -- Sent from: http://gnucash.1415818.n4.nabble.com/GnuCash-Dev-f1435356.html ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Building 3.5 package for Disco
> On Apr 26, 2019, at 10:04 AM, Stephen M. Butler wrote: > > Based on the following, have I run into a problem with googletest on > Disco? Additional Guidance sure appreciated. > Just point GnuCash at the source directories with -DGTEST_ROOT and -DGMOCK_ROOT. It will take care of building them. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] How to contribute to GnuCash?
What Geert meant is that our current engine code *isn't* particularly portable, though I think that since it compiles OK on MacOS it shouldn't have too much trouble with iOS either. It's a mix of C and C++ and the main dependencies are Boost and Gnome Glib; the XML file backend also depends on libxml2 and the SQL backend depends on libdbi. The public mirror for our git repository is at https://github.com/gnucash/gnucash. Note that the stable branch is "maint". Doxygen API docs are at https://code.gnucash.org/docs/MAINT. Regards, John Ralls > On Apr 26, 2019, at 12:56 PM, John wrote: > > Thanks for bringing it up. A portable engine code is definitely more > meaningful. Can you point me at some document or source code on portable > engine code? we just want to get more details and estimate the work load. > > Thanks, > John > > On Fri, Apr 26, 2019 at 9:33 AM Geert Janssens > wrote: > Hi, > > An iOS companion app would be great. > > The android app took the approach of reimplementing all the business logic > required to read (and write?) a gnucash data file rather than using the > gnucash engine code. > > I can understand why as the engine code is currently difficult to port to > different platforms. It is one of our goals to make this easier, but there's > still a lot of work ahead to get to that state. > > If you feel like joining that effort it would be very welcome as a portable > engine would greatly benefit gnucash and all derived apps on all platforms > (including the android app and a future ios app). > > Don't feel obliged of course. I did want to bring it up anyway so you know > this goal exists and may be useful for your app in the future. > > Regards, > > geert > > Op donderdag 25 april 2019 17:41:00 CEST schreef John Ralls: > > > On Apr 24, 2019, at 10:13 PM, John wrote: > > > > > > Hello, > > > > > > I am the founder of a mobile app startup and a big fan of GnuCash. My > > > team > > > has some free time now. I wonder if we can contribute to develop an iOS > > > companion app like current Android one. Can you let me know if you think > > > that's a good idea? and if yes, how to start? > > > > > > Thanks, > > > John > > > > It's a good idea if you're going to commit to maintaining and supporting it > > for a reasonable value of forever. The GnuCash team hasn't the time nor > > expertise to accept such an app as a contribution. > > > > To get started I'd think it best to contact Ngewi via the > > GnuCash-for-Android support channels and discuss whether his design is > > portable to iOS and what lessons he's learned and improvements he might > > make. > > > > Once you're ready to start work I expect you'll want to recruit users for > > usability testing of your UI mockups and later for beta-testing. I'm sure > > some of our users will be interested in helping, though if you're > > contemplating a commercial product you'll need to figure out the right way > > to engage with a FLOSS community. > > > > Regards, > > John Ralls > > ___ > > gnucash-devel mailing list > > gnucash-devel@gnucash.org > > https://lists.gnucash.org/mailman/listinfo/gnucash-devel > > > > > > > -- > > Thanks for choosing our apps, > Vicinno, > www.vicinno.com > > Like us on Facebook or Follow us on Twitter ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
[GNC-dev] Cleanup of .gitignore list
Hi, I have just removed a number of files from our .gitignore list. These files were all artifacts of our old autotools based build system. We no longer have that build system in our source code, so none of these artifacts should still pop up. However if you are working from a source directory already existed in the 2.6 era, some of these files may still be around. And when you pull in my changes these files may suddenly appear in the untracked files list of a "git status" command. If they do, please remove them from your source directory to avoid accidentally committing them in a future commit. This is the list of files I'm talking about: .autotools .deps .libs COPYING INSTALL aclocal.m4 autom4te.cache compile config.guess config.h.in config.log config.status config.sub configure depcomp install-sh intltool-extract intltool-extract.in intltool-merge intltool-merge.in intltool-update intltool-update.in libtool ltmain.sh macros/intltool.m4 macros/libtool.m4 macros/ltmain.sh macros/ltoptions.m4 macros/ltsugar.m4 macros/ltversion.m4 macros/lt~obsolete.m4 make-gnucash-potfiles missing mkinstalldirs po/.intltool-merge-cache po/Makefile.in.in po/stamp-it gnucash/gnucash-ddd gnucash/gnucash-env gnucash/gnucash-gdb gnucash/gnucash-launcher gnucash/gnucash-make-guids gnucash/gnucash-setup-env stamp-h1 Finally, I'm working from memory and testing in my own source trees. I may have missed a corner case where the current build system still produces one of these files. In that case, we may have to add it again in .gitignore. Please let me know when you have files that keep on re-appearing in your untracked files list. Regards, Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Building 3.5 package for Disco
Based on the following, have I run into a problem with googletest on
Disco? Additional Guidance sure appreciated.
Attempted to install googletest and was told "googletest is already the
newest version (1.8.1-3)". Verified that the environmental variables
were not defined, implies using shared library:
env | grep GTEST
env | grep GMOCK
Figured that maybe I just need to recompile them per
https://wiki.gnucash.org/wiki/Google_Test, I attempted to follow the
wiki but ran into this snag:
cd /usr/src/googletest
sudo mkdir mybuild
cd mybuild
sudo cmake -DCAMKE_INSTALL_PREFIX=/usr/local -DBUILD_SHARED_LIBS=ON
-DBUILD_GMOCK=ON -DINSTALL_GTEST=ON -DINSTALL_GMOCK=ON ../
CMake Warning at CMakeLists.txt:47 (project):
VERSION keyword not followed by a value or was followed by a value
that expanded to nothing.
-- The CXX compiler identification is GNU 8.3.0
-- The C compiler identification is GNU 8.3.0
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Found PythonInterp: /usr/bin/python (found version "2.7.16")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
CMake Error at
/usr/share/cmake-3.13/Modules/WriteBasicConfigVersionFile.cmake:40
(message):
No VERSION specified for WRITE_BASIC_CONFIG_VERSION_FILE()
Call Stack (most recent call first):
/usr/share/cmake-3.13/Modules/CMakePackageConfigHelpers.cmake:211
(write_basic_config_version_file)
CMakeLists.txt:96 (write_basic_package_version_file)
-- Configuring incomplete, errors occurred!
See also
"/usr/src/googletest/googletest/mybuild/CMakeFiles/CMakeOutput.log".
See also "/usr/src/googletest/googletest/mybuild/CMakeFiles/CMakeError.log".
cat CMakeE*.log
Determining if the pthread_create exist failed with the following output:
Change Dir: /usr/src/googletest/googletest/mybuild/CMakeFiles/CMakeTmp
Run Build Command:"/usr/bin/make" "cmTC_a80ab/fast"
/usr/bin/make -f CMakeFiles/cmTC_a80ab.dir/build.make
CMakeFiles/cmTC_a80ab.dir/build
make[1]: Entering directory
'/usr/src/googletest/googletest/mybuild/CMakeFiles/CMakeTmp'
Building C object CMakeFiles/cmTC_a80ab.dir/CheckSymbolExists.c.o
/usr/bin/cc -o CMakeFiles/cmTC_a80ab.dir/CheckSymbolExists.c.o -c
/usr/src/googletest/googletest/mybuild/CMakeFiles/CMakeTmp/CheckSymbolExists.c
Linking C executable cmTC_a80ab
/usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_a80ab.dir/link.txt
--verbose=1
/usr/bin/cc -rdynamic
CMakeFiles/cmTC_a80ab.dir/CheckSymbolExists.c.o -o cmTC_a80ab
/usr/bin/ld: CMakeFiles/cmTC_a80ab.dir/CheckSymbolExists.c.o: in
function `main':
CheckSymbolExists.c:(.text+0x1b): undefined reference to `pthread_create'
collect2: error: ld returned 1 exit status
make[1]: *** [CMakeFiles/cmTC_a80ab.dir/build.make:87: cmTC_a80ab] Error 1
make[1]: Leaving directory
'/usr/src/googletest/googletest/mybuild/CMakeFiles/CMakeTmp'
make: *** [Makefile:121: cmTC_a80ab/fast] Error 2
File
/usr/src/googletest/googletest/mybuild/CMakeFiles/CMakeTmp/CheckSymbolExists.c:
/* */
#include
int main(int argc, char** argv)
{
(void)argv;
#ifndef pthread_create
return ((int*)(_create))[argc];
#else
(void)argc;
return 0;
#endif
}
cat CMakeO*.log
The system is: Linux - 5.0.0-13-generic - x86_64
Compiling the CXX compiler identification source file
"CMakeCXXCompilerId.cpp" succeeded.
Compiler: /usr/bin/c++
Build flags:
Id flags:
The output was:
0
Compilation of the CXX compiler identification source
"CMakeCXXCompilerId.cpp" produced "a.out"
The CXX compiler identification is GNU, found in
"/usr/src/googletest/googletest/mybuild/CMakeFiles/3.13.4/CompilerIdCXX/a.out"
Compiling the C compiler identification source file "CMakeCCompilerId.c"
succeeded.
Compiler: /usr/bin/cc
Build flags:
Id flags:
The output was:
0
Compilation of the C compiler identification source "CMakeCCompilerId.c"
produced "a.out"
The C compiler identification is GNU, found in
"/usr/src/googletest/googletest/mybuild/CMakeFiles/3.13.4/CompilerIdC/a.out"
Determining if the CXX compiler works passed with the following output:
Change Dir: /usr/src/googletest/googletest/mybuild/CMakeFiles/CMakeTmp
Run Build Command:"/usr/bin/make" "cmTC_d37f4/fast"
/usr/bin/make -f CMakeFiles/cmTC_d37f4.dir/build.make
CMakeFiles/cmTC_d37f4.dir/build
make[1]: Entering directory
'/usr/src/googletest/googletest/mybuild/CMakeFiles/CMakeTmp'
Building CXX object CMakeFiles/cmTC_d37f4.dir/testCXXCompiler.cxx.o
Re: [GNC-dev] Building 3.5 package for Disco
Keep up the good work, it is very much appreciated. Colin On Fri, 26 Apr 2019 at 17:30, Stephen M. Butler wrote: > > Just upgraded to 19.04 from 18.04 (had to apply 18.10 in the process). > I figured the upgrade would handle all items, but I found this note > today (https://launchpad.net/ubuntu/disco/+source/gtest) that says gtest > source isn't available for 19.10. > > Listing the packages on this box shows: > dpkg -l | grep gtest > ii autopkgtest > 5.10ubuntu1 all automatic as-installed > testing for Debian packages > ii libgtest-dev:amd64 > 1.8.1-3 amd64Google's framework for > writing C++ tests > > dpkg -l | grep mock > ii google-mock:amd64 > 1.8.1-3 amd64Google's framework for > writing and using C++ mock classes > ii libnunit-mocks2.6.3-cil > 2.6.4+dfsg-1 all Unit test framework > for CLI - Assemblies > > Then I found this note > (https://askubuntu.com/questions/219516/howto-install-google-mock-on-ubuntu-12-10) > about needing to compile google test with the same flags as the subject > (in this case GnC) else get strange results. > > I'm headed back to the wiki for building GnC on Linux to verify the > dependencies (and cross check to what 19.04 loaded). I think there was > a note there about building google test and mock. > > I will report back once I've done that. > > --Steve > > [but it did work on 18.04!!] > > > > On 4/26/19 12:26 AM, Geert Janssens wrote: > > The error seems to have something to do with GTtest. Do you have > > google_test/ > > google_mock properly installed ? > > > > Regards, > > > > Geert > > > > Op vrijdag 26 april 2019 04:37:04 CEST schreef Stephen M. Butler: > >> Anybody here can help with dpkg-buildpackage -rfakeroot -b -uc? > >> > >> I received this error message (snippet copied): > >> > >> Scanning dependencies of target test-tx_import > >> make[5]: Leaving directory '/home/steve/Projects/GnuCash/gnucash/.build' > >> /usr/bin/make -f > >> gnucash/import-export/csv-imp/test/CMakeFiles/test-tx_import.dir/build.make > >> gnucash/import-export/csv-imp/test/CMakeFiles/test-tx_import.dir/build > >> make[5]: Entering directory '/home/steve/Projects/GnuCash/gnucash/.build' > >> [ 87%] Building CXX object > >> gnucash/import-export/csv-imp/test/CMakeFiles/test-tx_import.dir/test-tx-imp > >> ort.cpp.o cd > >> /home/steve/Projects/GnuCash/gnucash/.build/gnucash/import-export/csv-imp/te > >> st && /usr/bin/c++ -DHAVE_CONFIG_H -DHAVE_GUILE20 -D_GNU_SOURCE > >> -I/home/steve/Projects/GnuCash/gnucash/gnucash/import-export/csv-imp > >> -I/home/steve/Projects/GnuCash/gnucash/.build/common > >> -I/home/steve/Projects/GnuCash/gnucash/common > >> -I/home/steve/Projects/GnuCash/gnucash/libgnucash/engine > >> -I/home/steve/Projects/GnuCash/gnucash/common/test-core > >> -I/home/steve/Projects/GnuCash/gnucash/lib -I/usr/include/glib-2.0 > >> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include > >> -I/home/steve/Projects/GnuCash/gnucash/.build/__gtest/googletest/include > >> -I/home/steve/Projects/GnuCash/gnucash/gnucash/import-export > >> -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 > >> -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 > >> -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gio-unix-2.0 > >> -I/usr/include/cairo -I/usr/include/libdrm -I/usr/include/pango-1.0 > >> -I/usr/include/harfbuzz -I/usr/include/fribidi -I/usr/include/atk-1.0 > >> -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 > >> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount > >> -I/usr/include/blkid -I/usr/include/uuid > >> -I/home/steve/Projects/GnuCash/gnucash/gnucash/gnome-utils > >> -I/home/steve/Projects/GnuCash/gnucash/libgnucash/app-utils > >> -I/home/steve/Projects/GnuCash/gnucash/borrowed/libc > >> -I/home/steve/Projects/GnuCash/gnucash/.build/libgnucash/core-utils > >> -I/home/steve/Projects/GnuCash/gnucash/libgnucash/core-utils > >> -I/usr/include/guile/2.0 > >> -I/home/steve/Projects/GnuCash/gnucash/libgnucash/gnc-module > >> -I/usr/include/libxml2 > >> -I/home/steve/Projects/GnuCash/gnucash/libgnucash/backend/xml > >> -Wno-error=deprecated-declarations -Werror -Wall -Wmissing-declarations > >> -Wno-unused -Wno-error=parentheses -std=gnu++11 -g -O2 > >> -fdebug-prefix-map=/home/steve/Projects/GnuCash/gnucash=. > >> -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time > >> -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -o > >> CMakeFiles/test-tx_import.dir/test-tx-import.cpp.o -c > >> /home/steve/Projects/GnuCash/gnucash/gnucash/import-export/csv-imp/test/test > >> -tx-import.cpp [ 87%] Linking CXX executable ../../../../bin/test-tx_import > >> cd > >> /home/steve/Projects/GnuCash/gnucash/.build/gnucash/import-export/csv-imp/te > >> st && /usr/bin/cmake -E cmake_link_script > >> CMakeFiles/test-tx_import.dir/link.txt --verbose=1 > >> /usr/bin/c++ -Wno-error=deprecated-declarations -Werror -Wall > >>
Re: [GNC-dev] How to contribute to GnuCash?
Hi, An iOS companion app would be great. The android app took the approach of reimplementing all the business logic required to read (and write?) a gnucash data file rather than using the gnucash engine code. I can understand why as the engine code is currently difficult to port to different platforms. It is one of our goals to make this easier, but there's still a lot of work ahead to get to that state. If you feel like joining that effort it would be very welcome as a portable engine would greatly benefit gnucash and all derived apps on all platforms (including the android app and a future ios app). Don't feel obliged of course. I did want to bring it up anyway so you know this goal exists and may be useful for your app in the future. Regards, geert Op donderdag 25 april 2019 17:41:00 CEST schreef John Ralls: > > On Apr 24, 2019, at 10:13 PM, John wrote: > > > > Hello, > > > > I am the founder of a mobile app startup and a big fan of GnuCash. My > > team > > has some free time now. I wonder if we can contribute to develop an iOS > > companion app like current Android one. Can you let me know if you think > > that's a good idea? and if yes, how to start? > > > > Thanks, > > John > > It's a good idea if you're going to commit to maintaining and supporting it > for a reasonable value of forever. The GnuCash team hasn't the time nor > expertise to accept such an app as a contribution. > > To get started I'd think it best to contact Ngewi via the > GnuCash-for-Android support channels and discuss whether his design is > portable to iOS and what lessons he's learned and improvements he might > make. > > Once you're ready to start work I expect you'll want to recruit users for > usability testing of your UI mockups and later for beta-testing. I'm sure > some of our users will be interested in helping, though if you're > contemplating a commercial product you'll need to figure out the right way > to engage with a FLOSS community. > > Regards, > John Ralls > ___ > gnucash-devel mailing list > gnucash-devel@gnucash.org > https://lists.gnucash.org/mailman/listinfo/gnucash-devel ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Building 3.5 package for Disco
Just upgraded to 19.04 from 18.04 (had to apply 18.10 in the process). I figured the upgrade would handle all items, but I found this note today (https://launchpad.net/ubuntu/disco/+source/gtest) that says gtest source isn't available for 19.10. Listing the packages on this box shows: dpkg -l | grep gtest ii autopkgtest 5.10ubuntu1 all automatic as-installed testing for Debian packages ii libgtest-dev:amd64 1.8.1-3 amd64 Google's framework for writing C++ tests dpkg -l | grep mock ii google-mock:amd64 1.8.1-3 amd64 Google's framework for writing and using C++ mock classes ii libnunit-mocks2.6.3-cil 2.6.4+dfsg-1 all Unit test framework for CLI - Assemblies Then I found this note (https://askubuntu.com/questions/219516/howto-install-google-mock-on-ubuntu-12-10) about needing to compile google test with the same flags as the subject (in this case GnC) else get strange results. I'm headed back to the wiki for building GnC on Linux to verify the dependencies (and cross check to what 19.04 loaded). I think there was a note there about building google test and mock. I will report back once I've done that. --Steve [but it did work on 18.04!!] On 4/26/19 12:26 AM, Geert Janssens wrote: > The error seems to have something to do with GTtest. Do you have google_test/ > google_mock properly installed ? > > Regards, > > Geert > > Op vrijdag 26 april 2019 04:37:04 CEST schreef Stephen M. Butler: >> Anybody here can help with dpkg-buildpackage -rfakeroot -b -uc? >> >> I received this error message (snippet copied): >> >> Scanning dependencies of target test-tx_import >> make[5]: Leaving directory '/home/steve/Projects/GnuCash/gnucash/.build' >> /usr/bin/make -f >> gnucash/import-export/csv-imp/test/CMakeFiles/test-tx_import.dir/build.make >> gnucash/import-export/csv-imp/test/CMakeFiles/test-tx_import.dir/build >> make[5]: Entering directory '/home/steve/Projects/GnuCash/gnucash/.build' >> [ 87%] Building CXX object >> gnucash/import-export/csv-imp/test/CMakeFiles/test-tx_import.dir/test-tx-imp >> ort.cpp.o cd >> /home/steve/Projects/GnuCash/gnucash/.build/gnucash/import-export/csv-imp/te >> st && /usr/bin/c++ -DHAVE_CONFIG_H -DHAVE_GUILE20 -D_GNU_SOURCE >> -I/home/steve/Projects/GnuCash/gnucash/gnucash/import-export/csv-imp >> -I/home/steve/Projects/GnuCash/gnucash/.build/common >> -I/home/steve/Projects/GnuCash/gnucash/common >> -I/home/steve/Projects/GnuCash/gnucash/libgnucash/engine >> -I/home/steve/Projects/GnuCash/gnucash/common/test-core >> -I/home/steve/Projects/GnuCash/gnucash/lib -I/usr/include/glib-2.0 >> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include >> -I/home/steve/Projects/GnuCash/gnucash/.build/__gtest/googletest/include >> -I/home/steve/Projects/GnuCash/gnucash/gnucash/import-export >> -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 >> -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 >> -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gio-unix-2.0 >> -I/usr/include/cairo -I/usr/include/libdrm -I/usr/include/pango-1.0 >> -I/usr/include/harfbuzz -I/usr/include/fribidi -I/usr/include/atk-1.0 >> -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 >> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount >> -I/usr/include/blkid -I/usr/include/uuid >> -I/home/steve/Projects/GnuCash/gnucash/gnucash/gnome-utils >> -I/home/steve/Projects/GnuCash/gnucash/libgnucash/app-utils >> -I/home/steve/Projects/GnuCash/gnucash/borrowed/libc >> -I/home/steve/Projects/GnuCash/gnucash/.build/libgnucash/core-utils >> -I/home/steve/Projects/GnuCash/gnucash/libgnucash/core-utils >> -I/usr/include/guile/2.0 >> -I/home/steve/Projects/GnuCash/gnucash/libgnucash/gnc-module >> -I/usr/include/libxml2 >> -I/home/steve/Projects/GnuCash/gnucash/libgnucash/backend/xml >> -Wno-error=deprecated-declarations -Werror -Wall -Wmissing-declarations >> -Wno-unused -Wno-error=parentheses -std=gnu++11 -g -O2 >> -fdebug-prefix-map=/home/steve/Projects/GnuCash/gnucash=. >> -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time >> -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -o >> CMakeFiles/test-tx_import.dir/test-tx-import.cpp.o -c >> /home/steve/Projects/GnuCash/gnucash/gnucash/import-export/csv-imp/test/test >> -tx-import.cpp [ 87%] Linking CXX executable ../../../../bin/test-tx_import >> cd >> /home/steve/Projects/GnuCash/gnucash/.build/gnucash/import-export/csv-imp/te >> st && /usr/bin/cmake -E cmake_link_script >> CMakeFiles/test-tx_import.dir/link.txt --verbose=1 >> /usr/bin/c++ -Wno-error=deprecated-declarations -Werror -Wall >> -Wmissing-declarations -Wno-unused -Wno-error=parentheses -std=gnu++11 >> -g -O2 -fdebug-prefix-map=/home/steve/Projects/GnuCash/gnucash=. >>
Re: [GNC-dev] gnucash-on-windows master: Guile 2.2 for Windows.
Op vrijdag 26 april 2019 16:44:03 CEST schreef John Ralls: > > I am aware I suggested on irc to put the tarball on sourceforge. However > > while seeing this commit I wonder if there's a reason not to do as we did > > for guile 2.0: start from the upstream tarball and apply patches during > > the build ? That would mean storing the patches in our gnucash-on-windows > > repo. > The last Guile release was almost a year ago and I'm not able to get it to > build, so the patch set to that tarball would have to incorporate all of > the commits to bring it current with stable-2.2. If the Guile team would do > a release then we could reasonably use that tarball. In an ideal world it > would include my patches [1][2] and we could use it unmodified. > Oh, in that case, let's just stick with our own guile tarball until the guile team does another release. Perhaps make a note of this somewhere so we remember in a year or so why we did this. Geert > Regards, > John Ralls > > [1] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35405 > [2] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35430 ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] How to contribute to GnuCash?
John, Sounds great. No problem with promoting it on the website, and you're welcome to use our mailing lists for support if you like, you'll just need to have your support folks subscribe to and monitor the lists. Do you also want to use our Bugzilla (https://bugs.gnucash.org)? We can easily set up a new project to take your bugs. Your support folks will need to create accounts there and then identify themselves to us so that we can give them the necessary privileges. Regards, John Ralls > On Apr 25, 2019, at 9:39 PM, John wrote: > > Thanks for quick response. > > Yes, we will commit to maintaining and supporting it for a reasonable time of > forever. Thanks for your suggestion too, we will contact the Android > developer for advice before we start. > > To be clear: we won't do it commercially. The iOS app will be published as a > free app in App Store. Our company is the contributor, which means we will do > the followings under the name of our company: App Store publishing, GitHub > repo, support/maintenance in your email list or forum, name in your > contributor list, and others, not limited to the above. > Also, we expect you guys list it as an official iOS companion app for > GnuCash, same as you do to Android app, basically promoting the iOS app in > your email list and home page link, maybe next to Android app, to let more > users to use it, or no point to do it. > > If you guys agree with the above, we will start to plan the dev work. > > Thanks, > John > > > On Thu, Apr 25, 2019 at 8:41 AM John Ralls wrote: > > > > On Apr 24, 2019, at 10:13 PM, John wrote: > > > > Hello, > > > > I am the founder of a mobile app startup and a big fan of GnuCash. My team > > has some free time now. I wonder if we can contribute to develop an iOS > > companion app like current Android one. Can you let me know if you think > > that's a good idea? and if yes, how to start? > > > > Thanks, > > John > > It's a good idea if you're going to commit to maintaining and supporting it > for a reasonable value of forever. The GnuCash team hasn't the time nor > expertise to accept such an app as a contribution. > > To get started I'd think it best to contact Ngewi via the GnuCash-for-Android > support channels and discuss whether his design is portable to iOS and what > lessons he's learned and improvements he might make. > > Once you're ready to start work I expect you'll want to recruit users for > usability testing of your UI mockups and later for beta-testing. I'm sure > some of our users will be interested in helping, though if you're > contemplating a commercial product you'll need to figure out the right way to > engage with a FLOSS community. > > Regards, > John Ralls > > > -- > > Thanks for choosing our apps, > Vicinno, > www.vicinno.com > > Like us on Facebook or Follow us on Twitter ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] gnucash-on-windows master: Guile 2.2 for Windows.
> On Apr 26, 2019, at 12:22 AM, Geert Janssens via gnucash-devel > wrote: > > Op donderdag 25 april 2019 23:54:01 CEST schreef John Ralls: >> Updated via >> https://github.com/Gnucash/gnucash-on-windows/commit/c739d231 >> (commit) from >> https://github.com/Gnucash/gnucash-on-windows/commit/fe22df60 (commit) >> >> >> >> commit c739d231b5dc4775d40433d3148979a4a4d4c7ab >> Author: John Ralls >> Date: Thu Apr 25 14:53:28 2019 -0700 >> >>Guile 2.2 for Windows. >> >> diff --git a/gnucash.modules b/gnucash.modules >> index 04c3856..29b8c62 100644 >> --- a/gnucash.modules >> +++ b/gnucash.modules >> @@ -119,11 +119,9 @@ >> >> >> >> - > autogen-sh="autoreconf" autogenargs="--without-threads"> >> -> repo="ftp.gnu.org" module="guile/guile-2.0.14.tar.gz" - >> version="2.0.14"> >> - > file="https://raw.githubusercontent.com/Gnucash/gnucash-on-windows/master/p >> atches/guile-2.0.14-mingw64-fixups.patch" strip="1"/> >> - > file="https://raw.githubusercontent.com/Gnucash/gnucash-on-windows/master/p >> atches/guile-2.0.14-Fix-mktime-test.patch" strip="1"/> >> + > id="guile2" autogen-sh="configure" autogenargs="--disable-rpath >> --enable-networking --enable-nls --enable-posix --enable-regex >> --with-threads --with-modules --disable-static"> >> +> repo="sourceforge" module="gnucash/Dependencies/guile-2.2.4+mingw.tar.bz2" >> +version="2.2.4+mingw"> > > I am aware I suggested on irc to put the tarball on sourceforge. However > while > seeing this commit I wonder if there's a reason not to do as we did for guile > 2.0: start from the upstream tarball and apply patches during the build ? > That would mean storing the patches in our gnucash-on-windows repo. The last Guile release was almost a year ago and I'm not able to get it to build, so the patch set to that tarball would have to incorporate all of the commits to bring it current with stable-2.2. If the Guile team would do a release then we could reasonably use that tarball. In an ideal world it would include my patches [1][2] and we could use it unmodified. Regards, John Ralls [1] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35405 [2] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35430 ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Bug796872 Multiple selection feature in import matcher
> On Apr 25, 2019, at 11:24 PM, David Cousens wrote: > > And the wrong bug report again again. I think the original was possibly > closed before moving from the original bugzilla.org version. My only excuse > is I was getting over a trip to Singapore and an overnight flight back > yesterday. > > For some reason the changes in the commits > https://github.com/Gnucash/gnucash/commit/01339a782c91a8d931cc9d7462ddce19afc60635 > and > https://github.com/Gnucash/gnucash/commit/cae8ecde8f9ddd615ff47c783ce8136395bd71a9 > don't seem to have made it into v 3.3 on or if they did they didn't have the > correct files. Due to my inexperience with git and github at the time you > had to fix up a pull request from my github repository so that may have > caused the problem. > > To get the multiple selection to work for myself, I have been patching 3.2, > 3.3, 3.4 and 3.5 after downloading the sources before building. The version > of import-main-matcher.c and dialog-import.glade which were in 3.2, 3.3,3.4 > and 3.5 didn't contain the changes (file size of import-main-matcher.c in > the gnucash-3..tar.bz2 in each case was 37.2kB for 3.5, 37.2kB for 3.4, > 35.2kB for 3.3, 35.2kB for 3.2 for example, and my modified version of that > file wass 43.8kB. I had the original source archives I downloaded for each > version and have just freshly unpacked them to check that the code changes > are not in the files.) I rebuilt 3.5 today with the modified files after > adding in another patch to replace gtk_menu_popup with > gtk_menu_popup_at_pointer to eliminate a warning coming up about deprecation > of gtk_menu_popup and it is all working OK. > > I am inclined to clear out my github repository and my local repository copy > on my computer and refork from GnuCash/gnucash to remove any consequences of > my previous inexperience using git and github. I have and will retain > separate copies of the altered files of course. If I then create a new > feature branch off the maint branch and copy the altered files into that, > push it to my repository and then create a new pull request, you should then > get the right files which should fix things for the next release. If anyone > wants to incorporate it before then I can send them copies of the patched > files. David, A clean start seems like a good idea. There's no need to re-fork. Just do git fetch from the GnuCash repo, reset your local branches to those, and force-push to your personal GitHub repo. Suppose that you've called the GnuCash remote "origin" and your personal one "github": git fetch origin git checkout master git reset --hard origin/master git push -f github master git checkout maint git reset --hard origin/maint git push -f github maint That will discard everything you've done, so you might want to first git checkout -b my_master master git checkout -b my_maint maint before resetting master and maint. Then you can look at the diffs between e.g. my_maint and maint to see what if anything hasn't been committed upstream. Regards John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] How to contribute to GnuCash?
On Thu, 25 Apr 2019 08:41:00 -0700 John Ralls wrote: > > On Apr 24, 2019, at 10:13 PM, John wrote: > > > > Hello, > > > > I am the founder of a mobile app startup and a big fan of GnuCash. > > My team has some free time now. I wonder if we can contribute to > > develop an iOS companion app like current Android one. Can you let > > me know if you think that's a good idea? and if yes, how to start? > > > > Thanks, > > John > > It's a good idea if you're going to commit to maintaining and > supporting it for a reasonable value of forever. The GnuCash team > hasn't the time nor expertise to accept such an app as a contribution. > > To get started I'd think it best to contact Ngewi via the > GnuCash-for-Android support channels and discuss whether his design > is portable to iOS and what lessons he's learned and improvements he > might make. > > Once you're ready to start work I expect you'll want to recruit users > for usability testing of your UI mockups and later for beta-testing. > I'm sure some of our users will be interested in helping, though if > you're contemplating a commercial product you'll need to figure out > the right way to engage with a FLOSS community. > > Regards, > John Ralls > ___ > gnucash-devel mailing list > gnucash-devel@gnucash.org > https://lists.gnucash.org/mailman/listinfo/gnucash-devel j...@vicinno.com's reply is below. I have indicated that to continue contributions to the list he needs to join the list. === Thanks for quick response. Yes, we will commit to maintaining and supporting it for a reasonable time of forever. Thanks for your suggestion too, we will contact the Android developer for advice before we start. To be clear: we won't do it commercially. The iOS app will be published as a free app in App Store. Our company is the contributor, which means we will do the followings under the name of our company: App Store publishing, GitHub repo, support/maintenance in your email list or forum, name in your contributor list, and others, not limited to the above. Also, we expect you guys list it as an official iOS companion app for GnuCash, same as you do to Android app, basically promoting the iOS app in your email list and home page link, maybe next to Android app, to let more users to use it, or no point to do it. If you guys agree with the above, we will start to plan the dev work. Thanks, John ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Building 3.5 package for Disco
The error seems to have something to do with GTtest. Do you have google_test/ google_mock properly installed ? Regards, Geert Op vrijdag 26 april 2019 04:37:04 CEST schreef Stephen M. Butler: > Anybody here can help with dpkg-buildpackage -rfakeroot -b -uc? > > I received this error message (snippet copied): > > Scanning dependencies of target test-tx_import > make[5]: Leaving directory '/home/steve/Projects/GnuCash/gnucash/.build' > /usr/bin/make -f > gnucash/import-export/csv-imp/test/CMakeFiles/test-tx_import.dir/build.make > gnucash/import-export/csv-imp/test/CMakeFiles/test-tx_import.dir/build > make[5]: Entering directory '/home/steve/Projects/GnuCash/gnucash/.build' > [ 87%] Building CXX object > gnucash/import-export/csv-imp/test/CMakeFiles/test-tx_import.dir/test-tx-imp > ort.cpp.o cd > /home/steve/Projects/GnuCash/gnucash/.build/gnucash/import-export/csv-imp/te > st && /usr/bin/c++ -DHAVE_CONFIG_H -DHAVE_GUILE20 -D_GNU_SOURCE > -I/home/steve/Projects/GnuCash/gnucash/gnucash/import-export/csv-imp > -I/home/steve/Projects/GnuCash/gnucash/.build/common > -I/home/steve/Projects/GnuCash/gnucash/common > -I/home/steve/Projects/GnuCash/gnucash/libgnucash/engine > -I/home/steve/Projects/GnuCash/gnucash/common/test-core > -I/home/steve/Projects/GnuCash/gnucash/lib -I/usr/include/glib-2.0 > -I/usr/lib/x86_64-linux-gnu/glib-2.0/include > -I/home/steve/Projects/GnuCash/gnucash/.build/__gtest/googletest/include > -I/home/steve/Projects/GnuCash/gnucash/gnucash/import-export > -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 > -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 > -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gio-unix-2.0 > -I/usr/include/cairo -I/usr/include/libdrm -I/usr/include/pango-1.0 > -I/usr/include/harfbuzz -I/usr/include/fribidi -I/usr/include/atk-1.0 > -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 > -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount > -I/usr/include/blkid -I/usr/include/uuid > -I/home/steve/Projects/GnuCash/gnucash/gnucash/gnome-utils > -I/home/steve/Projects/GnuCash/gnucash/libgnucash/app-utils > -I/home/steve/Projects/GnuCash/gnucash/borrowed/libc > -I/home/steve/Projects/GnuCash/gnucash/.build/libgnucash/core-utils > -I/home/steve/Projects/GnuCash/gnucash/libgnucash/core-utils > -I/usr/include/guile/2.0 > -I/home/steve/Projects/GnuCash/gnucash/libgnucash/gnc-module > -I/usr/include/libxml2 > -I/home/steve/Projects/GnuCash/gnucash/libgnucash/backend/xml > -Wno-error=deprecated-declarations -Werror -Wall -Wmissing-declarations > -Wno-unused -Wno-error=parentheses -std=gnu++11 -g -O2 > -fdebug-prefix-map=/home/steve/Projects/GnuCash/gnucash=. > -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time > -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -o > CMakeFiles/test-tx_import.dir/test-tx-import.cpp.o -c > /home/steve/Projects/GnuCash/gnucash/gnucash/import-export/csv-imp/test/test > -tx-import.cpp [ 87%] Linking CXX executable ../../../../bin/test-tx_import > cd > /home/steve/Projects/GnuCash/gnucash/.build/gnucash/import-export/csv-imp/te > st && /usr/bin/cmake -E cmake_link_script > CMakeFiles/test-tx_import.dir/link.txt --verbose=1 > /usr/bin/c++ -Wno-error=deprecated-declarations -Werror -Wall > -Wmissing-declarations -Wno-unused -Wno-error=parentheses -std=gnu++11 > -g -O2 -fdebug-prefix-map=/home/steve/Projects/GnuCash/gnucash=. > -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time > -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -Wl,-Bsymbolic-functions -Wl,-z,relro > -Wl,-z,now -rdynamic CMakeFiles/test-tx_import.dir/test-tx-import.cpp.o > -o ../../../../bin/test-tx_import > -Wl,-rpath,/home/steve/Projects/GnuCash/gnucash/.build/lib/x86_64-linux-gnu/ > gnucash/gnucash:/home/steve/Projects/GnuCash/gnucash/.build/lib/x86_64-linux > -gnu/gnucash > ../../../../lib/x86_64-linux-gnu/gnucash/gnucash/libgncmod-csv-import.so > -lglib-2.0 -Wl,-Bstatic -lgtest -lgtest_main -Wl,-Bdynamic -licui18n > -licuuc -licudata > ../../../../lib/x86_64-linux-gnu/gnucash/gnucash/libgncmod-generic-import.so > ../../../../lib/x86_64-linux-gnu/gnucash/gnucash/libgncmod-gnome-utils.so > ../../../../lib/x86_64-linux-gnu/gnucash/libgnc-backend-xml-utils.so -lz > -ldl -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 > -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lsecret-1 > ../../../../lib/x86_64-linux-gnu/gnucash/gnucash/libgncmod-app-utils.so > -lgio-2.0 -lxslt -lxml2 > ../../../../lib/x86_64-linux-gnu/gnucash/gnucash/libgncmod-engine.so > ../../../../lib/x86_64-linux-gnu/gnucash/libgnc-core-utils.so > -lboost_date_time -lboost_regex -lboost_locale -lboost_filesystem > -lboost_system -lgobject-2.0 > ../../../../lib/x86_64-linux-gnu/gnucash/libgnc-module.so > -Wl,--export-dynamic -lgmodule-2.0 -lglib-2.0 -pthread -lguile-2.0 -lgc > /usr/bin/ld: > /usr/lib/gcc/x86_64-linux-gnu/8/../../../x86_64-linux-gnu/libgtest_main.a(gt > est_main.cc.o): in function `main': > (.text.startup+0x2f): undefined reference to >
Re: [GNC-dev] gnucash-on-windows master: Guile 2.2 for Windows.
Op donderdag 25 april 2019 23:54:01 CEST schreef John Ralls: > Updatedvia > https://github.com/Gnucash/gnucash-on-windows/commit/c739d231 > (commit) from > https://github.com/Gnucash/gnucash-on-windows/commit/fe22df60 (commit) > > > > commit c739d231b5dc4775d40433d3148979a4a4d4c7ab > Author: John Ralls > Date: Thu Apr 25 14:53:28 2019 -0700 > > Guile 2.2 for Windows. > > diff --git a/gnucash.modules b/gnucash.modules > index 04c3856..29b8c62 100644 > --- a/gnucash.modules > +++ b/gnucash.modules > @@ -119,11 +119,9 @@ > > > > - autogen-sh="autoreconf" autogenargs="--without-threads"> > - repo="ftp.gnu.org" module="guile/guile-2.0.14.tar.gz" - > version="2.0.14"> > - file="https://raw.githubusercontent.com/Gnucash/gnucash-on-windows/master/p > atches/guile-2.0.14-mingw64-fixups.patch" strip="1"/> > - file="https://raw.githubusercontent.com/Gnucash/gnucash-on-windows/master/p > atches/guile-2.0.14-Fix-mktime-test.patch" strip="1"/> > + id="guile2" autogen-sh="configure" autogenargs="--disable-rpath > --enable-networking --enable-nls --enable-posix --enable-regex > --with-threads --with-modules --disable-static"> > + repo="sourceforge" module="gnucash/Dependencies/guile-2.2.4+mingw.tar.bz2" > + version="2.2.4+mingw"> I am aware I suggested on irc to put the tarball on sourceforge. However while seeing this commit I wonder if there's a reason not to do as we did for guile 2.0: start from the upstream tarball and apply patches during the build ? That would mean storing the patches in our gnucash-on-windows repo. Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Bug796872 Multiple selection feature in import matcher
And the wrong bug report again again. I think the original was possibly closed before moving from the original bugzilla.org version. My only excuse is I was getting over a trip to Singapore and an overnight flight back yesterday. For some reason the changes in the commits https://github.com/Gnucash/gnucash/commit/01339a782c91a8d931cc9d7462ddce19afc60635 and https://github.com/Gnucash/gnucash/commit/cae8ecde8f9ddd615ff47c783ce8136395bd71a9 don't seem to have made it into v 3.3 on or if they did they didn't have the correct files. Due to my inexperience with git and github at the time you had to fix up a pull request from my github repository so that may have caused the problem. To get the multiple selection to work for myself, I have been patching 3.2, 3.3, 3.4 and 3.5 after downloading the sources before building. The version of import-main-matcher.c and dialog-import.glade which were in 3.2, 3.3,3.4 and 3.5 didn't contain the changes (file size of import-main-matcher.c in the gnucash-3..tar.bz2 in each case was 37.2kB for 3.5, 37.2kB for 3.4, 35.2kB for 3.3, 35.2kB for 3.2 for example, and my modified version of that file wass 43.8kB. I had the original source archives I downloaded for each version and have just freshly unpacked them to check that the code changes are not in the files.) I rebuilt 3.5 today with the modified files after adding in another patch to replace gtk_menu_popup with gtk_menu_popup_at_pointer to eliminate a warning coming up about deprecation of gtk_menu_popup and it is all working OK. I am inclined to clear out my github repository and my local repository copy on my computer and refork from GnuCash/gnucash to remove any consequences of my previous inexperience using git and github. I have and will retain separate copies of the altered files of course. If I then create a new feature branch off the maint branch and copy the altered files into that, push it to my repository and then create a new pull request, you should then get the right files which should fix things for the next release. If anyone wants to incorporate it before then I can send them copies of the patched files. David - David Cousens -- Sent from: http://gnucash.1415818.n4.nabble.com/GnuCash-Dev-f1435356.html ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
