Re: [GNC-dev] Static locale commit unfortunately buggy
Am Samstag, 19. Januar 2019, 23:21:58 CET schrieb John Ralls: > Christian, > > Thanks for noticing. It seems that the std::locale objects created by > boost::locale aren't quite compatible. I've resolved the problem, at least > for maint, by using boost::locale to format date-times instead of > boost::date_time. Dear John, thanks for working on this. Now it is fine again and all fixed. Thank you very much. Regards, Christian > > For the future we can consider another reimplementation of GncDateTime. > boost::date_time is an oldish library and hasn't been improved much since > it was accepted into boost. It's a bit quirky and doesn't perform very > well. std::chrono in C++20 has calendar and timezone functions, so that's > one possible replacement, though not until at least llvm and gcc implement > the expanded std::chrono and those implementations are widely available. > There's also ICU as wrapped by boost::locale. I demurred from that when I > picked boost::date_time because it's huge, but if we're pulling it in > anyway it's worth reconsidering. > > Regards, > John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Static locale commit unfortunately buggy
> On Jan 12, 2019, at 3:31 AM, Christian Stimming > wrote: > > Dear John, > > unfortunately your commit b4fedff9 of last weekend breaks the correct locale > treatment. I didn't investigate this in detail, but the date status bar > message changed to english with this commit instead of sticking to my local > language. This is with LANG=de_DE.UTF-8 > Could you have a look into this? Thanks a lot! Christian, Thanks for noticing. It seems that the std::locale objects created by boost::locale aren't quite compatible. I've resolved the problem, at least for maint, by using boost::locale to format date-times instead of boost::date_time. For the future we can consider another reimplementation of GncDateTime. boost::date_time is an oldish library and hasn't been improved much since it was accepted into boost. It's a bit quirky and doesn't perform very well. std::chrono in C++20 has calendar and timezone functions, so that's one possible replacement, though not until at least llvm and gcc implement the expanded std::chrono and those implementations are widely available. There's also ICU as wrapped by boost::locale. I demurred from that when I picked boost::date_time because it's huge, but if we're pulling it in anyway it's worth reconsidering. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
[GNC-dev] Static locale commit unfortunately buggy
Dear John, unfortunately your commit b4fedff9 of last weekend breaks the correct locale treatment. I didn't investigate this in detail, but the date status bar message changed to english with this commit instead of sticking to my local language. This is with LANG=de_DE.UTF-8 Could you have a look into this? Thanks a lot! Regards, Christian ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
