Re: [GNC-dev] gnucash maint: Set the SWIG minimum version to 2.0.11 now that we require Guile-2.0.

2018-08-11 Thread John Ralls


> On Aug 11, 2018, at 1:27 AM, Geert Janssens  
> wrote:
> 
> Op vrijdag 10 augustus 2018 22:02:28 CEST schreef John Ralls:
>> Updated   via  https://github.com/Gnucash/gnucash/commit/22dd716b 
>> (commit)
>>  from  https://github.com/Gnucash/gnucash/commit/2f861bc2 (commit)
>> 
>> 
>> 
>> commit 22dd716b58a6a9c424a71268f78af37b972ab23b
>> Author: John Ralls 
>> Date:   Fri Aug 10 12:57:46 2018 -0700
>> 
>>Set the SWIG minimum version to 2.0.11 now that we require Guile-2.0.
>> 
>> diff --git a/CMakeLists.txt b/CMakeLists.txt
>> index f5d372e..42a23b6 100644
>> --- a/CMakeLists.txt
>> +++ b/CMakeLists.txt
>> @@ -285,7 +285,7 @@ endif (WIN32)
>> 
>> # SWIG
>> if(GENERATE_SWIG_WRAPPERS)
>> -  find_package (SWIG REQUIRED)
>> +  find_package (SWIG 2.0.10 REQUIRED)
> 
> Interestingly your comment says to require 2.0.11 but you enforce only 2.0.10
> 
> Which version is the correct minimum one ?

Darn. It should be 2.0.10, according to your code from 2.6’s configure.ac.

Regards,
John Ralls

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: [GNC-dev] gnucash maint: Set the SWIG minimum version to 2.0.11 now that we require Guile-2.0.

2018-08-11 Thread Geert Janssens
Op vrijdag 10 augustus 2018 22:02:28 CEST schreef John Ralls:
> Updatedvia  https://github.com/Gnucash/gnucash/commit/22dd716b 
> (commit)
>   from  https://github.com/Gnucash/gnucash/commit/2f861bc2 (commit)
> 
> 
> 
> commit 22dd716b58a6a9c424a71268f78af37b972ab23b
> Author: John Ralls 
> Date:   Fri Aug 10 12:57:46 2018 -0700
> 
> Set the SWIG minimum version to 2.0.11 now that we require Guile-2.0.
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index f5d372e..42a23b6 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -285,7 +285,7 @@ endif (WIN32)
> 
>  # SWIG
>  if(GENERATE_SWIG_WRAPPERS)
> -  find_package (SWIG REQUIRED)
> +  find_package (SWIG 2.0.10 REQUIRED)

Interestingly your comment says to require 2.0.11 but you enforce only 2.0.10

Which version is the correct minimum one ?

Geert


___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel