Re: AUDIT: r15088 - gnucash/trunk - Fix some scheme inexact errors. Fixes 347462.

2006-11-06 Thread Chris Shoemaker 
On Sun, Nov 05, 2006 at 11:45:29PM -0500, David Hampton wrote:
 Author: hampton
 Date: 2006-11-05 23:45:27 -0500 (Sun, 05 Nov 2006)
 New Revision: 15088
 Trac: http://svn.gnucash.org/trac/changeset/15088
 
 Modified:
gnucash/trunk/ChangeLog
gnucash/trunk/src/report/standard-reports/account-piecharts.scm
gnucash/trunk/src/report/standard-reports/category-barchart.scm
 Log:
 Fix some scheme inexact errors.  Fixes 347462.
 BP
 

Perhaps it's better to fix this inside options.scm,
in gnc:make-number-range-option.

-chris

 
 Modified: gnucash/trunk/ChangeLog
 ===
 --- gnucash/trunk/ChangeLog   2006-11-05 06:58:09 UTC (rev 15087)
 +++ gnucash/trunk/ChangeLog   2006-11-06 04:45:27 UTC (rev 15088)
 @@ -1,3 +1,9 @@
 +2006-11-05  David Hampton  [EMAIL PROTECTED]
 +
 + * src/report/standard-reports/category-barchart.scm:
 + * src/report/standard-reports/account-piecharts.scm: Fix some
 + scheme inexact errors.  Fixes 347462.
 +
  2006-10-09  Josh Sled [EMAIL PROTECTED]
  
   * art/: Add, with 2.0 {banner,icon,logo,splash} art.
 
 Modified: gnucash/trunk/src/report/standard-reports/account-piecharts.scm
 ===
 --- gnucash/trunk/src/report/standard-reports/account-piecharts.scm   
 2006-11-05 06:58:09 UTC (rev 15087)
 +++ gnucash/trunk/src/report/standard-reports/account-piecharts.scm   
 2006-11-06 04:45:27 UTC (rev 15088)
 @@ -188,7 +188,8 @@
  
  (show-fullname? (get-option gnc:pagename-display optname-fullname))
  (show-total? (get-option gnc:pagename-display optname-show-total))
 -(max-slices (get-option gnc:pagename-display optname-slices))
 +(max-slices (inexact-exact
 +  (get-option gnc:pagename-display optname-slices)))
  (height (get-option gnc:pagename-display optname-plot-height))
  (width (get-option gnc:pagename-display optname-plot-width))
   (sort-method (get-option gnc:pagename-display optname-sort-method))
 
 Modified: gnucash/trunk/src/report/standard-reports/category-barchart.scm
 ===
 --- gnucash/trunk/src/report/standard-reports/category-barchart.scm   
 2006-11-05 06:58:09 UTC (rev 15087)
 +++ gnucash/trunk/src/report/standard-reports/category-barchart.scm   
 2006-11-06 04:45:27 UTC (rev 15088)
 @@ -200,7 +200,8 @@
  
  (stacked? (get-option gnc:pagename-display optname-stacked))
  (show-fullname? (get-option gnc:pagename-display optname-fullname))
 -(max-slices (get-option gnc:pagename-display optname-slices))
 +(max-slices (inexact-exact
 +  (get-option gnc:pagename-display optname-slices)))
  (height (get-option gnc:pagename-display optname-plot-height))
  (width (get-option gnc:pagename-display optname-plot-width))
   (sort-method (get-option gnc:pagename-display optname-sort-method))
 
 ___
 gnucash-changes mailing list
 [EMAIL PROTECTED]
 https://lists.gnucash.org/mailman/listinfo/gnucash-changes
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: AUDIT: r15088 - gnucash/trunk - Fix some scheme inexact errors. Fixes 347462.

2006-11-06 Thread David Hampton 
On Mon, 2006-11-06 at 09:41 -0500, Chris Shoemaker wrote:
 On Sun, Nov 05, 2006 at 11:45:29PM -0500, David Hampton wrote:
  Author: hampton
  Date: 2006-11-05 23:45:27 -0500 (Sun, 05 Nov 2006)
  New Revision: 15088
  Trac: http://svn.gnucash.org/trac/changeset/15088
  
  Modified:
 gnucash/trunk/ChangeLog
 gnucash/trunk/src/report/standard-reports/account-piecharts.scm
 gnucash/trunk/src/report/standard-reports/category-barchart.scm
  Log:
  Fix some scheme inexact errors.  Fixes 347462.
  BP
  
 
 Perhaps it's better to fix this inside options.scm,
 in gnc:make-number-range-option.

That function specifically allows for non-integer values.  One of the
parameters to the function is the number of decimal places to use in the
display to the user.  That said, the only report that currently uses the
capability to input non-integer numbers is the Hello World report.

David


___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: AUDIT: r15088 - gnucash/trunk - Fix some scheme inexact errors. Fixes 347462.

2006-11-06 Thread Derek Atkins 
Quoting David Hampton [EMAIL PROTECTED]:

 

 Perhaps it's better to fix this inside options.scm,
 in gnc:make-number-range-option.

 That function specifically allows for non-integer values.  One of the
 parameters to the function is the number of decimal places to use in the
 display to the user.  That said, the only report that currently uses the
 capability to input non-integer numbers is the Hello World report.

Perhaps we should still make the change in the option definition, and
call the inexact-exact if num-decimal == 0?

 David

-derek

-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   [EMAIL PROTECTED]PGP key available

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel