Boost Version Required ?
Hi Guys, Tried to build from master and my setup failed at the following... kvp-value.hpp:31:60: fatal error: boost/type_traits/is_nothrow_move_assignable.hpp: No such file or directory I have boost version 1.52.0-r6 and I think this function was added in 1.54. Are you sticking to a boost version or will a more recent one always be required ? Regards, Bob ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Boost Version Required ?
Oops. Officially we target 1.48, but apparently some more recent features got used in the last commits. John, Aaron: how do we deal with this ? Geert On Thursday 09 October 2014 12:36:03 Robert Fewell wrote: Hi Guys, Tried to build from master and my setup failed at the following... kvp-value.hpp:31:60: fatal error: boost/type_traits/is_nothrow_move_assignable.hpp: No such file or directory I have boost version 1.52.0-r6 and I think this function was added in 1.54. Are you sticking to a boost version or will a more recent one always be required ? Regards, Bob ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Boost Version Required ?
On Thu, Oct 9, 2014 at 8:11 AM, Geert Janssens geert.gnuc...@kobaltwit.be wrote: Oops. Officially we target 1.48, but apparently some more recent features got used in the last commits. John, Aaron: how do we deal with this ? Good question. Something like the full story can be found at https://bugzilla.gnome.org/show_bug.cgi?id=736687 . In short, that include was added because of a bug identified in jralls's build environment: his boost/variant.hpp didn't include the file, so there was a compilation issue which was fixed by including it ourselves. My version built properly without the include, and we're using the same boost version: 1.56.0. Since we target 1.48, perhaps I should get that version of boost to make sure to avoid this type of thing. Of course, boost 1.56.0 *is* freely available :-). Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Boost Version Required ?
On Oct 9, 2014, at 6:23 AM, Geert Janssens geert.gnuc...@kobaltwit.be wrote: On Thursday 09 October 2014 09:12:15 Aaron Laws wrote: On Thu, Oct 9, 2014 at 8:11 AM, Geert Janssens geert.gnuc...@kobaltwit.be wrote: Oops. Officially we target 1.48, but apparently some more recent features got used in the last commits. John, Aaron: how do we deal with this ? Good question. Something like the full story can be found at https://bugzilla.gnome.org/show_bug.cgi?id=736687 . In short, that include was added because of a bug identified in jralls's build environment: his boost/variant.hpp didn't include the file, so there was a compilation issue which was fixed by including it ourselves. My version built properly without the include, and we're using the same boost version: 1.56.0. Since we target 1.48, perhaps I should get that version of boost to make sure to avoid this type of thing. Of course, boost 1.56.0 *is* freely available :-). Freely available, yes. In source code. Prepackaged in linux distributions, no. We are usually conservative in our version requirements to keep it relatively simple for others to build gnucash without also having to build its dependencies. Current master will not ship for some time to come. By then boost 1.56 is probably pretty common. However requiring it now already however will make it more difficult for others to jump in. Since that include is a workaround for a boost bug in 1.56 -- the function is used in boost/variant/variant.hpp but the header isn't included -- we can guard the include in kvp-value.hpp with BOOST_VERSION, which is found in boost/version.h. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Boost Version Required ?
On Oct 9, 2014, at 7:10 AM, John Ralls jra...@ceridwen.us wrote: On Oct 9, 2014, at 6:23 AM, Geert Janssens geert.gnuc...@kobaltwit.be wrote: On Thursday 09 October 2014 09:12:15 Aaron Laws wrote: On Thu, Oct 9, 2014 at 8:11 AM, Geert Janssens geert.gnuc...@kobaltwit.be wrote: Oops. Officially we target 1.48, but apparently some more recent features got used in the last commits. John, Aaron: how do we deal with this ? Good question. Something like the full story can be found at https://bugzilla.gnome.org/show_bug.cgi?id=736687 . In short, that include was added because of a bug identified in jralls's build environment: his boost/variant.hpp didn't include the file, so there was a compilation issue which was fixed by including it ourselves. My version built properly without the include, and we're using the same boost version: 1.56.0. Since we target 1.48, perhaps I should get that version of boost to make sure to avoid this type of thing. Of course, boost 1.56.0 *is* freely available :-). Freely available, yes. In source code. Prepackaged in linux distributions, no. We are usually conservative in our version requirements to keep it relatively simple for others to build gnucash without also having to build its dependencies. Current master will not ship for some time to come. By then boost 1.56 is probably pretty common. However requiring it now already however will make it more difficult for others to jump in. Since that include is a workaround for a boost bug in 1.56 -- the function is used in boost/variant/variant.hpp but the header isn't included -- we can guard the include in kvp-value.hpp with BOOST_VERSION, which is found in boost/version.h. I’ve pushed this. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
