Odd message from git post-receive hook
Introduction: I'm currently the only one receiving mails from our gitolite's post-receive hook for commits pushed to the gnucash svn repository. But when we drop svn in favour of git, everybody will be receiving these messages. So any problem I come across in this internal test is important for our future list messaging. So I got this weird message sent today after I pushed a backporting commit to the 2.4 branch. Notice the mail subject: it talks about a patch for libgoffice, which I pushed to trunk earlier today. However that's not what I pushed to 2.4. You can see that in the actual commit message: I pushed [22070] Fix memory leak: Missing regfree() after regcomp(). So how come the mail script whips up the wrong subject ? Geert -- Forwarded Message -- Subject: gnucash 2.4: Report the proper minimum version for libgoffice when not found at configure time Date: Tuesday 26 November 2013, 11:57:04 From: GIT SVN Migration User git-...@code.gnucash.org To: i...@kobaltwit.be Updated via https://github.com/Gnucash/gnucash/commit/907e9112 (commit) from https://github.com/Gnucash/gnucash/commit/7b7e57a6 (commit) commit 907e911251e091076f1a3ee061059d479d56a4fa Author: Geert Janssens janssens-ge...@telenet.be Date: Tue Nov 26 16:55:55 2013 + [22070] Fix memory leak: Missing regfree() after regcomp(). This fix is backported because it solves this bug: Bug 681907 - Save operation is leaking seriously, eventually GnuCash uses 6.4 GB RAM git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/branches/2.4@23446 57a11ea4-9604-0410-9ed3-97b8803252fd Summary of changes: src/backend/xml/gnc-backend-xml.c |1 + src/html/gnc-html.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) - ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Odd message from git post-receive hook
On Nov 26, 2013, at 9:08 AM, Geert Janssens janssens-ge...@telenet.be wrote: Introduction: I'm currently the only one receiving mails from our gitolite's post-receive hook for commits pushed to the gnucash svn repository. But when we drop svn in favour of git, everybody will be receiving these messages. So any problem I come across in this internal test is important for our future list messaging. So I got this weird message sent today after I pushed a backporting commit to the 2.4 branch. Notice the mail subject: it talks about a patch for libgoffice, which I pushed to trunk earlier today. However that's not what I pushed to 2.4. You can see that in the actual commit message: I pushed [22070] Fix memory leak: Missing regfree() after regcomp(). So how come the mail script whips up the wrong subject ? Geert -- Forwarded Message -- Subject: gnucash 2.4: Report the proper minimum version for libgoffice when not found at configure time Date: Tuesday 26 November 2013, 11:57:04 From: GIT SVN Migration User git-...@code.gnucash.org To: i...@kobaltwit.be Updatedvia https://github.com/Gnucash/gnucash/commit/907e9112 (commit) from https://github.com/Gnucash/gnucash/commit/7b7e57a6 (commit) Because line 232 says: subject=$projectdesc $short_refname: $(git log -n 1 --format=%s $newref)” Which is the right answer only when git is checked out in the right branch. We could make it if [ “x$refname_type” = “xbranch” ]; then subject=$projectdesc $short_refname: $(git log -b $refname -n 1 --format=%s $newref)” else subject=$projectdesc $short_refname: $(git log -n 1 --format=%s $newref)” fi Which would fix most instances. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Odd message from git post-receive hook
On Tuesday 26 November 2013 11:59:05 John Ralls wrote: On Nov 26, 2013, at 9:08 AM, Geert Janssens janssens-ge...@telenet.be wrote: So how come the mail script whips up the wrong subject ? Geert -- Forwarded Message -- Subject: gnucash 2.4: Report the proper minimum version for libgoffice when not found at configure time Date: Tuesday 26 November 2013, 11:57:04 From: GIT SVN Migration User git-...@code.gnucash.org To: i...@kobaltwit.be Updated via https://github.com/Gnucash/gnucash/commit/907e9112 (commit) from https://github.com/Gnucash/gnucash/commit/7b7e57a6 (commit) Because line 232 says: subject=$projectdesc $short_refname: $(git log -n 1 --format=%s $newref)” Which is the right answer only when git is checked out in the right branch. We could make it if [ “x$refname_type” = “xbranch” ]; then subject=$projectdesc $short_refname: $(git log -b $refname -n 1 --format=%s $newref)” else subject=$projectdesc $short_refname: $(git log -n 1 --format=%s $newref)” fi Which would fix most instances. Regards, John Ralls That's worth a try. Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Odd message from git post-receive hook
On Nov 26, 2013, at 12:06 PM, Geert Janssens janssens-ge...@telenet.be wrote: On Tuesday 26 November 2013 11:59:05 John Ralls wrote: On Nov 26, 2013, at 9:08 AM, Geert Janssens janssens-ge...@telenet.be wrote: So how come the mail script whips up the wrong subject ? Geert -- Forwarded Message -- Subject: gnucash 2.4: Report the proper minimum version for libgoffice when not found at configure time Date: Tuesday 26 November 2013, 11:57:04 From: GIT SVN Migration User git-...@code.gnucash.org To: i...@kobaltwit.be Updatedvia https://github.com/Gnucash/gnucash/commit/907e9112 (commit) from https://github.com/Gnucash/gnucash/commit/7b7e57a6 (commit) Because line 232 says: subject=$projectdesc $short_refname: $(git log -n 1 --format=%s $newref)” Which is the right answer only when git is checked out in the right branch. We could make it if [ “x$refname_type” = “xbranch” ]; then subject=$projectdesc $short_refname: $(git log -b $refname -n 1 --format=%s $newref)” else subject=$projectdesc $short_refname: $(git log -n 1 --format=%s $newref)” fi Which would fix most instances. Regards, John Ralls That's worth a try. Geert Pushed. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
