Re: [GNC-dev] gnucash-on-windows master: Guile 2.2 for Windows.
Op vrijdag 26 april 2019 16:44:03 CEST schreef John Ralls: > > I am aware I suggested on irc to put the tarball on sourceforge. However > > while seeing this commit I wonder if there's a reason not to do as we did > > for guile 2.0: start from the upstream tarball and apply patches during > > the build ? That would mean storing the patches in our gnucash-on-windows > > repo. > The last Guile release was almost a year ago and I'm not able to get it to > build, so the patch set to that tarball would have to incorporate all of > the commits to bring it current with stable-2.2. If the Guile team would do > a release then we could reasonably use that tarball. In an ideal world it > would include my patches [1][2] and we could use it unmodified. > Oh, in that case, let's just stick with our own guile tarball until the guile team does another release. Perhaps make a note of this somewhere so we remember in a year or so why we did this. Geert > Regards, > John Ralls > > [1] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35405 > [2] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35430 ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] gnucash-on-windows master: Guile 2.2 for Windows.
> On Apr 26, 2019, at 12:22 AM, Geert Janssens via gnucash-devel > wrote: > > Op donderdag 25 april 2019 23:54:01 CEST schreef John Ralls: >> Updated via >> https://github.com/Gnucash/gnucash-on-windows/commit/c739d231 >> (commit) from >> https://github.com/Gnucash/gnucash-on-windows/commit/fe22df60 (commit) >> >> >> >> commit c739d231b5dc4775d40433d3148979a4a4d4c7ab >> Author: John Ralls >> Date: Thu Apr 25 14:53:28 2019 -0700 >> >>Guile 2.2 for Windows. >> >> diff --git a/gnucash.modules b/gnucash.modules >> index 04c3856..29b8c62 100644 >> --- a/gnucash.modules >> +++ b/gnucash.modules >> @@ -119,11 +119,9 @@ >> >> >> >> - > autogen-sh="autoreconf" autogenargs="--without-threads"> >> -> repo="ftp.gnu.org" module="guile/guile-2.0.14.tar.gz" - >> version="2.0.14"> >> - > file="https://raw.githubusercontent.com/Gnucash/gnucash-on-windows/master/p >> atches/guile-2.0.14-mingw64-fixups.patch" strip="1"/> >> - > file="https://raw.githubusercontent.com/Gnucash/gnucash-on-windows/master/p >> atches/guile-2.0.14-Fix-mktime-test.patch" strip="1"/> >> + > id="guile2" autogen-sh="configure" autogenargs="--disable-rpath >> --enable-networking --enable-nls --enable-posix --enable-regex >> --with-threads --with-modules --disable-static"> >> +> repo="sourceforge" module="gnucash/Dependencies/guile-2.2.4+mingw.tar.bz2" >> +version="2.2.4+mingw"> > > I am aware I suggested on irc to put the tarball on sourceforge. However > while > seeing this commit I wonder if there's a reason not to do as we did for guile > 2.0: start from the upstream tarball and apply patches during the build ? > That would mean storing the patches in our gnucash-on-windows repo. The last Guile release was almost a year ago and I'm not able to get it to build, so the patch set to that tarball would have to incorporate all of the commits to bring it current with stable-2.2. If the Guile team would do a release then we could reasonably use that tarball. In an ideal world it would include my patches [1][2] and we could use it unmodified. Regards, John Ralls [1] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35405 [2] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35430 ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] gnucash-on-windows master: Guile 2.2 for Windows.
Op donderdag 25 april 2019 23:54:01 CEST schreef John Ralls: > Updatedvia > https://github.com/Gnucash/gnucash-on-windows/commit/c739d231 > (commit) from > https://github.com/Gnucash/gnucash-on-windows/commit/fe22df60 (commit) > > > > commit c739d231b5dc4775d40433d3148979a4a4d4c7ab > Author: John Ralls > Date: Thu Apr 25 14:53:28 2019 -0700 > > Guile 2.2 for Windows. > > diff --git a/gnucash.modules b/gnucash.modules > index 04c3856..29b8c62 100644 > --- a/gnucash.modules > +++ b/gnucash.modules > @@ -119,11 +119,9 @@ > > > > - autogen-sh="autoreconf" autogenargs="--without-threads"> > - repo="ftp.gnu.org" module="guile/guile-2.0.14.tar.gz" - > version="2.0.14"> > - file="https://raw.githubusercontent.com/Gnucash/gnucash-on-windows/master/p > atches/guile-2.0.14-mingw64-fixups.patch" strip="1"/> > - file="https://raw.githubusercontent.com/Gnucash/gnucash-on-windows/master/p > atches/guile-2.0.14-Fix-mktime-test.patch" strip="1"/> > + id="guile2" autogen-sh="configure" autogenargs="--disable-rpath > --enable-networking --enable-nls --enable-posix --enable-regex > --with-threads --with-modules --disable-static"> > + repo="sourceforge" module="gnucash/Dependencies/guile-2.2.4+mingw.tar.bz2" > + version="2.2.4+mingw"> I am aware I suggested on irc to put the tarball on sourceforge. However while seeing this commit I wonder if there's a reason not to do as we did for guile 2.0: start from the upstream tarball and apply patches during the build ? That would mean storing the patches in our gnucash-on-windows repo. Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
