Re: [Gnucash-changes] Remove guile - cashutil sync.
On Sat, 2005-01-10 at 17:27 -0400, Chris Shoemaker wrote:
> On Sat, Oct 01, 2005 at 09:43:29PM +0100, Neil Williams wrote:
> > On Saturday 01 October 2005 8:58 pm, Chris Shoemaker wrote:
> > > > +int
> > > > +main (int argc, char **argv)
> > > > {
> > > > + qof_init();
> > > > + if(cashobjects_register()) {
> > > >test_query_core();
> > > >test_class();
> > > >test_querynew();
> >
> > Displays inline in each of the editors I use.
> > src/engine/test/test-querynew.c
> >
> > qof_init();
> > if(cashobjects_register()) {
> > test_query_core();
> > test_class();
> > test_querynew();
> > }
>
> Um, nobody cares what your editor shows you except you. What matters
> is what's in the file. When I said "please fix your editor" I meant:
> make it easier for you to detect when your change is inconsistent with
> the surrounding code. Your patch will clearly produce a file with
> inconsistent indentation. Readability matters.
>
> I realize that it will be difficult for you to fix this
> after-the-fact. I suggest reverting the patch until you can verify
> that your patches don't screw up indentation.
>
> (BTW, consistent treatment of whitespace is necessary for
> collaboration in almost any software project.)
>
> -chris
> ___
Neil, Try changing the default tab size and see how YOUR editor shows
the inconsistencies. I have been using scite for my main editor, it
shows when tabs are mixed with spaces in the same code block. It also
has the option to use spaces in place of tabs when you use the tab key.
It helps keep things consistent.
--
Brian <[EMAIL PROTECTED]>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [Gnucash-changes] Remove guile - cashutil sync.
On Sat, Oct 01, 2005 at 09:43:29PM +0100, Neil Williams wrote:
> On Saturday 01 October 2005 8:58 pm, Chris Shoemaker wrote:
> > > +int
> > > +main (int argc, char **argv)
> > > {
> > > + qof_init();
> > > + if(cashobjects_register()) {
> > >test_query_core();
> > >test_class();
> > >test_querynew();
>
> Displays inline in each of the editors I use.
> src/engine/test/test-querynew.c
>
> qof_init();
> if(cashobjects_register()) {
> test_query_core();
> test_class();
> test_querynew();
> }
Um, nobody cares what your editor shows you except you. What matters
is what's in the file. When I said "please fix your editor" I meant:
make it easier for you to detect when your change is inconsistent with
the surrounding code. Your patch will clearly produce a file with
inconsistent indentation. Readability matters.
I realize that it will be difficult for you to fix this
after-the-fact. I suggest reverting the patch until you can verify
that your patches don't screw up indentation.
(BTW, consistent treatment of whitespace is necessary for
collaboration in almost any software project.)
-chris
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [Gnucash-changes] Remove guile - cashutil sync.
On Saturday 01 October 2005 8:58 pm, Chris Shoemaker wrote:
> > +int
> > +main (int argc, char **argv)
> > {
> > + qof_init();
> > + if(cashobjects_register()) {
> >test_query_core();
> >test_class();
> >test_querynew();
Displays inline in each of the editors I use.
src/engine/test/test-querynew.c
qof_init();
if(cashobjects_register()) {
test_query_core();
test_class();
test_querynew();
}
> Neil,
> This is not good. Please fix your editor.
There's nothing showing at this end.
> I'm starting to
> see this in more and more places you're patching. After you've fixed
> your editor please restore the indentation.
All my editors are fine - again, three different installations have tested
these files - FC3, OSX and Debian unstable. Not much I can do at this end if
the effects you see are not showing up on ANY of my systems.
--
Neil Williams
=
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/
pgpU9CFy7NSwq.pgp
Description: PGP signature
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [Gnucash-changes] Remove guile - cashutil sync.
On Sat, Oct 01, 2005 at 01:49:43PM -0400, Neil Williams wrote:
> -static void
> -main_helper (void *closure, int argc, char **argv)
> +int
> +main (int argc, char **argv)
> {
> - gnc_module_load("gnucash/engine", 0);
> + qof_init();
> + if(cashobjects_register()) {
>test_query_core();
>test_class();
>test_querynew();
> + }
> + qof_close();
>print_test_results();
Neil,
This is not good. Please fix your editor. I'm starting to
see this in more and more places you're patching. After you've fixed
your editor please restore the indentation.
-chris
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
