Re: [GNC] [Finance-quote-news] Finance-Quote 1.56 released!

2023-05-31 Thread Vincent Lucarelli
This error is rooted in needing an AlphaVantage API key for any FQ fetch 
because that’s the default Currency module and the code is setup to ensure we 
can do a currency conversion if needed.

You can verify that by setting the environment variable DEBUG=1 and repeating 
the gnucash-cli command.  You should see the AlphaVantage key error.

I don’t think we’ve clearly documented this requirement anywhere and maybe we 
should change the code to error out only if currency conversion is actually 
necessary and the Currency module API key isn’t set.  We can move this part of 
the discussion to our GitHub project.

Best,

Vince

> On May 30, 2023, at 11:25 AM, Bruce Schuck  wrote:
> 
> On 5/30/23 7:59 AM, Fross, Michael wrote:
> 
>> Running directly via the rest api works:
>> https://api.twelvedata.com/quote?symbol=acn&apikey=xx 
>>  
>> (I've hidden the actual key)
> 
>> But when I run:
>> 
>> C:\Program Files (x86)\gnucash\bin>gnucash-cli.exe --verbose --extra -Q dump 
>> twelvedata aapl
>> Finance::Quote reported a failure for symbol aapl: TwevleData return and 
>> unexpected json result
> 
>> I have the environment variable set:
>> C:\>echo %TWELVEDATA_API_KEY
>> xx  (I've hidden the actual key)
> 
>> Something seems off and it's probably on my part.
> 
> Michael,
> 
> I am not sure if it is on your end. Please open an issue on 
> https://github.com/finance-quote/finance-quote/issues.
> 
> Vincent, you just contributed this mmodule, could you please look at this?
> 
> Thank you.
> 
> Bruce S

___
gnucash-user mailing list
gnucash-user@gnucash.org
To update your subscription preferences or to unsubscribe:
https://lists.gnucash.org/mailman/listinfo/gnucash-user
-
Please remember to CC this list on all your replies.
You can do this by using Reply-To-List or Reply-All.


Re: [GNC] [Finance-quote-news] Finance-Quote 1.56 released!

2023-05-30 Thread Bruce Schuck

On 5/30/23 12:59 PM, Vincent Lucarelli wrote:


You can verify that by setting the environment variable DEBUG=1 and
repeating the gnucash-cli command.  You should see the AlphaVantage
key error.



I don’t think we’ve clearly documented this requirement anywhere and
maybe we should change the code to error out only if currency
conversion is actually necessary and the Currency module API key
isn’t set.  We can move this part of the discussion to our GitHub
project.


Skipping the currency conversion when it's not needed does indeed sound 
like a good idea. And as long as Yahoo does not block the 
query1.finance.yahoo.com/v11/finance/... URL, there is now a 
CurrencyRates::YahooJSON currency module. Not sure if want to make it 
the default, but currently users can set an environment variable "export 
FQ_CURRENCY=YahooJSON" to use it instead of AlphaVantage.


Thanks.

Bruce S.
___
gnucash-user mailing list
gnucash-user@gnucash.org
To update your subscription preferences or to unsubscribe:
https://lists.gnucash.org/mailman/listinfo/gnucash-user
-
Please remember to CC this list on all your replies.
You can do this by using Reply-To-List or Reply-All.


Re: [GNC] [Finance-quote-news] Finance-Quote 1.56 released!

2023-05-30 Thread Bruce Schuck

On 5/30/23 7:59 AM, Fross, Michael wrote:


Running directly via the rest api works:
https://api.twelvedata.com/quote?symbol=acn&apikey=xx 
 
(I've hidden the actual key)



But when I run:

C:\Program Files (x86)\gnucash\bin>gnucash-cli.exe --verbose --extra -Q 
dump twelvedata aapl
Finance::Quote reported a failure for symbol aapl: TwevleData return and 
unexpected json result



I have the environment variable set:
C:\>echo %TWELVEDATA_API_KEY
xx  (I've hidden the actual key)



Something seems off and it's probably on my part.


Michael,

I am not sure if it is on your end. Please open an issue on 
https://github.com/finance-quote/finance-quote/issues.


Vincent, you just contributed this mmodule, could you please look at this?

Thank you.

Bruce S
___
gnucash-user mailing list
gnucash-user@gnucash.org
To update your subscription preferences or to unsubscribe:
https://lists.gnucash.org/mailman/listinfo/gnucash-user
-
Please remember to CC this list on all your replies.
You can do this by using Reply-To-List or Reply-All.