Re: [GNC] CSV import crash in 5.0+

2023-04-25 Thread Geert Janssens
Op vrijdag 21 april 2023 04:59:40 CEST schreef John Ralls:
> > On Apr 20, 2023, at 6:52 AM, Joseph Vernice  wrote:
> > 
> > I am using the nightly build 5.0.77 on Windows 11.  Ever since upgrading
> > to
> > 5.0 (and above nightly builds) I am unable to import transactions from
> > CSV.  The system crashes when I select the CSV import profile or when I
> > try
> > to create a new one.  The crash accors immediately after selecting the
> > profile OR after assigning the AMOUNT column. I have resorted to the
> > latest
> > pre-5.0 build in order to import from CSV.  Unfortunately, my Fidelity
> > checking account only allows for CSV export, so this is an essential means
> > for me to import into gnucash. Thank you everyone for all your help.
> 
> There are two open CSV crashers,
> https://bugs.gnucash.org/show_bug.cgi?id=798799 and
> https://bugs.gnucash.org/show_bug.cgi?id=798830. The first is about the CSV
> having fewer fields in the first line than in the second and while GnuCash
> shouldn't crash in that case IMO it should reject the file as ill-formed.
> The second involves entries having a '/' character.
> 
> If your problem file matches neither of those please file a new bug report.
> Be sure to attach the trace file[1] and if possible a stack trace[2].
> 
> Regards,
> John Ralls
> 
> [1] https://wiki.gnucash.org/wiki/Tracefile
> [2] https://wiki.gnucash.org/wiki/Stack_Trace
> 
> 
If GnuCash crashes then this is very likely the same issues as
https://bugs.gnucash.org/show_bug.cgi?id=798877
(https://bugs.gnucash.org/show_bug.cgi?id=798799 is a duplicate of this one)

That issue has now been fixed and will appear in tomorrow's nightly. You can 
try that one to 
test if you like.

Regards,

Geert
___
gnucash-user mailing list
gnucash-user@gnucash.org
To update your subscription preferences or to unsubscribe:
https://lists.gnucash.org/mailman/listinfo/gnucash-user
-
Please remember to CC this list on all your replies.
You can do this by using Reply-To-List or Reply-All.


Re: [GNC] CSV import crash in 5.0+

2023-04-21 Thread R Losey
Also speaking as a pro, this topic of error checking causes quite a lot of
debate at work.

We all agree that input from users (and other untrusted sources) should be
fully error-checked (and, for this case of CSV import data, I agree it
should be considered untrusted).

But when there is an agreed-upon machine interface from A to B, if A
violates the interface and crashes B, that is A's problem [this is my
position, and many support it; however, the other position is that B should
not crash and should always do sufficient checking so that it does not
crash]. Likewise, calls to system services are considered trustworthy, so
the results are not error-checked... (the status may be checked for a
problem, but the data is generally considered safe; for example, I don't
know of anyone who error-checks the call to get the current time.)


On Thu, Apr 20, 2023 at 6:12 PM Michael or Penny Novack <
stepbystepf...@comcast.net> wrote:

> However, speaking as a retired pro, I would consider a program crashing
> on ANY bad input to be a bug << a failure of its "input editing" >>
>
> It is (should be) the responsibility of a program to check incoming data
> and reject any data that is bad (preferably with a meaningful error
> message). Programs should NOT trust that they will always be given good
> input.
>
>
> Michael D Novack
>
>
> ___
> gnucash-user mailing list
> gnucash-user@gnucash.org
> To update your subscription preferences or to unsubscribe:
> https://lists.gnucash.org/mailman/listinfo/gnucash-user
> -
> Please remember to CC this list on all your replies.
> You can do this by using Reply-To-List or Reply-All.
>


-- 
_
Richard Losey
rlo...@gmail.com
Micah 6:8
___
gnucash-user mailing list
gnucash-user@gnucash.org
To update your subscription preferences or to unsubscribe:
https://lists.gnucash.org/mailman/listinfo/gnucash-user
-
Please remember to CC this list on all your replies.
You can do this by using Reply-To-List or Reply-All.


Re: [GNC] CSV import crash in 5.0+

2023-04-20 Thread John Ralls



> On Apr 20, 2023, at 6:52 AM, Joseph Vernice  wrote:
> 
> I am using the nightly build 5.0.77 on Windows 11.  Ever since upgrading to
> 5.0 (and above nightly builds) I am unable to import transactions from
> CSV.  The system crashes when I select the CSV import profile or when I try
> to create a new one.  The crash accors immediately after selecting the
> profile OR after assigning the AMOUNT column. I have resorted to the latest
> pre-5.0 build in order to import from CSV.  Unfortunately, my Fidelity
> checking account only allows for CSV export, so this is an essential means
> for me to import into gnucash. Thank you everyone for all your help.

There are two open CSV crashers, 
https://bugs.gnucash.org/show_bug.cgi?id=798799 and 
https://bugs.gnucash.org/show_bug.cgi?id=798830. The first is about the CSV 
having fewer fields
in the first line than in the second and while GnuCash shouldn't crash in that 
case IMO it should
reject the file as ill-formed. The second involves entries having a '/' 
character.

If your problem file matches neither of those please file a new bug report. Be 
sure to attach
the trace file[1] and if possible a stack trace[2].

Regards,
John Ralls

[1] https://wiki.gnucash.org/wiki/Tracefile
[2] https://wiki.gnucash.org/wiki/Stack_Trace


___
gnucash-user mailing list
gnucash-user@gnucash.org
To update your subscription preferences or to unsubscribe:
https://lists.gnucash.org/mailman/listinfo/gnucash-user
-
Please remember to CC this list on all your replies.
You can do this by using Reply-To-List or Reply-All.


Re: [GNC] CSV import crash in 5.0+

2023-04-20 Thread Michael or Penny Novack

On 4/20/2023 6:58 PM, Stephen M. Butler wrote:
I have been running 5.0.77 on Ubuntu and importing CSV transactions 
without problems.  So this may be tied to Windows. 


However, speaking as a retired pro, I would consider a program crashing 
on ANY bad input to be a bug << a failure of its "input editing" >>


It is (should be) the responsibility of a program to check incoming data 
and reject any data that is bad (preferably with a meaningful error 
message). Programs should NOT trust that they will always be given good 
input.



Michael D Novack


___
gnucash-user mailing list
gnucash-user@gnucash.org
To update your subscription preferences or to unsubscribe:
https://lists.gnucash.org/mailman/listinfo/gnucash-user
-
Please remember to CC this list on all your replies.
You can do this by using Reply-To-List or Reply-All.


Re: [GNC] CSV import crash in 5.0+

2023-04-20 Thread Stephen M. Butler
I have been running 5.0.77 on Ubuntu and importing CSV transactions 
without problems.  So this may be tied to Windows.



Stephen M Butler, PMP, PSM
stephen.m.butle...@gmail.com
kg...@arrl.net
253-350-0166
---
GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8

On 4/20/23 06:52, Joseph Vernice wrote:

I am using the nightly build 5.0.77 on Windows 11.  Ever since upgrading to
5.0 (and above nightly builds) I am unable to import transactions from
CSV.  The system crashes when I select the CSV import profile or when I try
to create a new one.  The crash accors immediately after selecting the
profile OR after assigning the AMOUNT column. I have resorted to the latest
pre-5.0 build in order to import from CSV.  Unfortunately, my Fidelity
checking account only allows for CSV export, so this is an essential means
for me to import into gnucash. Thank you everyone for all your help.
___
gnucash-user mailing list
gnucash-user@gnucash.org
To update your subscription preferences or to unsubscribe:
https://lists.gnucash.org/mailman/listinfo/gnucash-user
-
Please remember to CC this list on all your replies.
You can do this by using Reply-To-List or Reply-All.


___
gnucash-user mailing list
gnucash-user@gnucash.org
To update your subscription preferences or to unsubscribe:
https://lists.gnucash.org/mailman/listinfo/gnucash-user
-
Please remember to CC this list on all your replies.
You can do this by using Reply-To-List or Reply-All.