Re: [Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSTableView.m
--- Enrico Sersale <[EMAIL PROTECTED]> wrote:
> On 2005-05-26 16:38:12 +0300 Fred Kiefer
> <[EMAIL PROTECTED]> wrote:
>
> > CVSROOT:/cvsroot/gnustep
> > Module name:gnustep
> > Branch:
> > Changes by: Fred Kiefer
> <[EMAIL PROTECTED]> 05/05/26 13:38:11
> >
> > Modified files:
> > core/gui : ChangeLog core/gui/Source:
> NSTableView.m
> > Log message:
> > Improved mouseDown call handling for table view.
> >
> > CVSWeb URLs:
> >
>
http://savannah.gnu.org/cgi-bin/viewcvs/gnustep/gnustep/core/gui/ChangeLog.diff?tr1=1.2528&tr2=1.2529&r1=text&r2=text
> >
>
http://savannah.gnu.org/cgi-bin/viewcvs/gnustep/gnustep/core/gui/Source/NSTableView.m.diff?tr1=1.116&tr2=1.117&r1=text&r2=text
>
> I think that it would be a good habit to try to run
> one or two of the (few) GNUstep applications before
> committing changes that can break things...
>
just to elaborate.. this breaks (at least)
gworkspace's
view->list segfaults when selecting a row.
anyhow the culprit being cell copy, which was added
because NSComboBoxCell caches the cellFrame so it can
pop up the window through a NSButtonCell's action...
though it was causing multiple drawWithFrame: calls
for the combobox cells with its setNeedsDisplay: then
popping up in the wrong place...
anyhow this seems to work in both cases..
matt
__
Do you Yahoo!?
Yahoo! Small Business - Try our new Resources site
http://smallbusiness.yahoo.com/resources/Index: NSTableView.m
===
RCS file: /cvsroot/gnustep/gnustep/core/gui/Source/NSTableView.m,v
retrieving revision 1.117
diff -u -r1.117 NSTableView.m
--- NSTableView.m 26 May 2005 13:38:11 - 1.117
+++ NSTableView.m 28 May 2005 03:16:39 -
@@ -3460,7 +3460,7 @@
// Prepare the cell
tb = [_tableColumns objectAtIndex: _clickedColumn];
- cell = [[tb dataCellForRow: _clickedRow] copy];
+ cell = [tb dataCellForRow: _clickedRow];
originalValue = RETAIN([self _objectValueForTableColumn:tb
row:_clickedRow]);
[cell setObjectValue: originalValue];
cellFrame = [self frameOfCellAtColumn: _clickedColumn
@@ -3497,7 +3497,6 @@
}
RELEASE(originalValue);
[cell setHighlighted: NO];
- RELEASE(cell);
[self setNeedsDisplayInRect: cellFrame];
lastEvent = [NSApp currentEvent];
}
Index: NSComboBoxCell.m
===
RCS file: /cvsroot/gnustep/gnustep/core/gui/Source/NSComboBoxCell.m,v
retrieving revision 1.38
diff -u -r1.38 NSComboBoxCell.m
--- NSComboBoxCell.m26 May 2005 02:52:43 - 1.38
+++ NSComboBoxCell.m28 May 2005 03:16:42 -
@@ -1603,7 +1603,7 @@
if (NSMouseInRect(location, buttonRect, isFlipped))
{
[_buttonCell setHighlighted: YES];
- [controlView setNeedsDisplay: YES];
+ [controlView setNeedsDisplayInRect: cellFrame];
result = [_buttonCell trackMouse: e
inRect: buttonRect
@@ -1612,7 +1612,7 @@
isMouseUp = result;
[_buttonCell setHighlighted: NO];
- [controlView setNeedsDisplay: YES];
+ [controlView setNeedsDisplayInRect: cellFrame];
}
if (isMouseUp == NO)
___
Gnustep-dev mailing list
Gnustep-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Building in a separate directory
BTW, first they moved to JAM, then they internalized JAM's code into Xcode so it's not invoked as a separate process. It's possible that JAM is able to handle spaces, though maybe Apple had to modify it for this. Jam handles spaces (and a number of other things) Regards, Sheldon ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSTableView.m
On 2005-05-26 16:38:12 +0300 Fred Kiefer <[EMAIL PROTECTED]> wrote: CVSROOT:/cvsroot/gnustep Module name:gnustep Branch: Changes by: Fred Kiefer <[EMAIL PROTECTED]> 05/05/26 13:38:11 Modified files: core/gui : ChangeLog core/gui/Source: NSTableView.m Log message: Improved mouseDown call handling for table view. CVSWeb URLs: http://savannah.gnu.org/cgi-bin/viewcvs/gnustep/gnustep/core/gui/ChangeLog.diff?tr1=1.2528&tr2=1.2529&r1=text&r2=text http://savannah.gnu.org/cgi-bin/viewcvs/gnustep/gnustep/core/gui/Source/NSTableView.m.diff?tr1=1.116&tr2=1.117&r1=text&r2=text I think that it would be a good habit to try to run one or two of the (few) GNUstep applications before committing changes that can break things... ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
[Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSAffineTrans...
CVSROOT:/cvsroot/gnustep Module name:gnustep Branch: Changes by: Adam Fedor <[EMAIL PROTECTED]> 05/05/27 20:49:12 Modified files: core/gui : ChangeLog core/gui/Source: NSAffineTransform.m Log message: * Source/NSAffineTransform.m (matrix_multiply): New function. (appendTransform:, prependTransform:, rotateByRadians:, scaleBy:, scaleXBy:yBy:, translateXBy:yBy:, concatenateWithMatrix:): Use it. (rotateByDegrees:) Use rotateByRadians:. Fixes bug #13181. CVSWeb URLs: http://savannah.gnu.org/cgi-bin/viewcvs/gnustep/gnustep/core/gui/ChangeLog.diff?tr1=1.2530&tr2=1.2531&r1=text&r2=text http://savannah.gnu.org/cgi-bin/viewcvs/gnustep/gnustep/core/gui/Source/NSAffineTransform.m.diff?tr1=1.35&tr2=1.36&r1=text&r2=text
Re: Building in a separate directory
On May 27, 2005, at 9:34 AM, David Lázaro Saz wrote: On 27/05/2005, at 13:54, Nicola Pero wrote: The make syntax uses spaces to separate filenames in list of targets or requisites, or everywhere really ... it's a basic design decision in the make syntax. Thanks for the explanation. This also explains why Apple developed a completely new build system for Xcode (xcodebuild). I've tried compiling a Hello World/Hello World.c in my usual (separate) build directory and everything worked. BTW, first they moved to JAM, then they internalized JAM's code into Xcode so it's not invoked as a separate process. It's possible that JAM is able to handle spaces, though maybe Apple had to modify it for this. ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
[Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSPopUpButton...
CVSROOT:/cvsroot/gnustep Module name:gnustep Branch: Changes by: Fred Kiefer <[EMAIL PROTECTED]> 05/05/27 13:41:46 Modified files: core/gui : ChangeLog core/gui/Source: NSPopUpButtonCell.m Log message: Make sure popup button cells wont get notifications after being dealloceated. CVSWeb URLs: http://savannah.gnu.org/cgi-bin/viewcvs/gnustep/gnustep/core/gui/ChangeLog.diff?tr1=1.2529&tr2=1.2530&r1=text&r2=text http://savannah.gnu.org/cgi-bin/viewcvs/gnustep/gnustep/core/gui/Source/NSPopUpButtonCell.m.diff?tr1=1.67&tr2=1.68&r1=text&r2=text
Re: Building in a separate directory
On 27/05/2005, at 13:54, Nicola Pero wrote: The make syntax uses spaces to separate filenames in list of targets or requisites, or everywhere really ... it's a basic design decision in the make syntax. Thanks for the explanation. This also explains why Apple developed a completely new build system for Xcode (xcodebuild). I've tried compiling a Hello World/Hello World.c in my usual (separate) build directory and everything worked. This being a limitation only for developers seems like an easy to do compromise. Cheers, David. ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Building in a separate directory
> > It might be nice to fix autoconf, but then you'll run into make. > > 'make' doesn't like spaces in directories either - and this is a > > fundamental design issue. > > But doesn't make always run in the same directory? Anyway I'm > placing this on the back burner for some time, and it's been a long > time since I read the GNU make manual. But I think that this issue > needs to be solved someday because directories with spaces are very > common this days (Windows' "C:\Program Files", for example). There is nothing you can do to solve the issue of directories with spaces in it, really. The make syntax uses spaces to separate filenames in list of targets or requisites, or everywhere really ... it's a basic design decision in the make syntax. The problem should be limited to the building process though; meaning if you are building stuff using make, then you need to avoid directories with spaces in it. Once the stuff is built, you should be able to run it anywhere. So end-users should not be affected ... they can run the stuff anywhere. Developers need to avoid compiling inside directories that contain spaces. Thanks ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
[Gnustep-cvs] GNUstep Testfarm Results
Test results for GNUstep as of Fri May 27 06:34:08 EDT 2005 If a particular system failed compilation, the logs for that system will be placed at ftp://ftp.gnustep.org/pub/testfarm If you would like to add your machine to this list, set up a cron job (make sure you set up your PATH and other environment variables correctly) to run the Startup/scripts/test-gnustep script (see the script comments for more info). Success Compile i386-unknown-netbsdelf2.0.2 Fri May 27 03:58:09 CEST 2005 Success Compile powerpc-apple-darwin7.9.0 Fri May 27 04:25:03 MDT 2005 Success Compile sparc-sun-solaris2.7 Fri May 27 02:09:03 EDT 2005
[Gnustep-cvs] gnustep/usr-apps/gworkspace/GWorkspace/FileView...
CVSROOT:/cvsroot/gnustep Module name:gnustep Branch: Changes by: Enrico Sersale <[EMAIL PROTECTED]> 05/05/27 10:29:21 Modified files: usr-apps/gworkspace/GWorkspace/FileViewer: GWSpatialViewer.m Log message: CVSWeb URLs: http://savannah.gnu.org/cgi-bin/viewcvs/gnustep/gnustep/usr-apps/gworkspace/GWorkspace/FileViewer/GWSpatialViewer.m.diff?tr1=1.26&tr2=1.27&r1=text&r2=text
