[Gnustep-cvs] gnustep/core/gui ChangeLog Source/GSNibCompatib... [NibCompatibility]
CVSROOT:/sources/gnustep Module name:gnustep Branch: NibCompatibility Changes by: Gregory John Casamento <[EMAIL PROTECTED]> 05/12/31 22:26:15 Modified files: core/gui : ChangeLog core/gui/Source: GSNibCompatibility.m Log message: Initialization of maptables. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/ChangeLog.diff?only_with_tag=NibCompatibility&tr1=1.2640.2.6&tr2=1.2640.2.7&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Source/GSNibCompatibility.m.diff?only_with_tag=NibCompatibility&tr1=1.8.2.4&tr2=1.8.2.5&r1=text&r2=text
[Gnustep-cvs] gnustep/core/gui ChangeLog Headers/Additions/GN... [NibCompatibility]
CVSROOT:/sources/gnustep Module name:gnustep Branch: NibCompatibility Changes by: Gregory John Casamento <[EMAIL PROTECTED]> 05/12/31 21:12:59 Modified files: core/gui : ChangeLog core/gui/Headers/Additions/GNUstepGUI: GSNibCompatibility.h core/gui/Source: GNUmakefile GSGormLoader.m GSNibCompatibility.m Added files: core/gui/Source: GSNibLoader.m Log message: Loader for nib files, as well as changes to existing model loader and GSNibCompatibility classes. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/ChangeLog.diff?only_with_tag=NibCompatibility&tr1=1.2640.2.5&tr2=1.2640.2.6&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Headers/Additions/GNUstepGUI/GSNibCompatibility.h.diff?only_with_tag=NibCompatibility&tr1=1.2.4.3&tr2=1.2.4.4&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Source/GNUmakefile.diff?only_with_tag=NibCompatibility&tr1=1.133.4.1&tr2=1.133.4.2&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Source/GSGormLoader.m.diff?only_with_tag=NibCompatibility&tr1=1.1.2.2&tr2=1.1.2.3&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Source/GSNibCompatibility.m.diff?only_with_tag=NibCompatibility&tr1=1.8.2.3&tr2=1.8.2.4&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Source/GSNibLoader.m?only_with_tag=NibCompatibility&rev=1.1.2.1
[Gnustep-cvs] gnustep/core/gui ChangeLog Headers/Additions/GN... [NibCompatibility]
CVSROOT:/sources/gnustep Module name:gnustep Branch: NibCompatibility Changes by: Gregory John Casamento <[EMAIL PROTECTED]> 05/12/31 16:52:17 Modified files: core/gui : ChangeLog core/gui/Headers/Additions/GNUstepGUI: GSModelLoaderFactory.h core/gui/Source: GSGModelLoader.m GSGormLoader.m GSModelLoaderFactory.m NSBundleAdditions.m Log message: Refactored a little bit of the new model loading framework. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/ChangeLog.diff?only_with_tag=NibCompatibility&tr1=1.2640.2.4&tr2=1.2640.2.5&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Headers/Additions/GNUstepGUI/GSModelLoaderFactory.h.diff?only_with_tag=NibCompatibility&tr1=1.1.2.1&tr2=1.1.2.2&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Source/GSGModelLoader.m.diff?only_with_tag=NibCompatibility&tr1=1.1.2.1&tr2=1.1.2.2&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Source/GSGormLoader.m.diff?only_with_tag=NibCompatibility&tr1=1.1.2.1&tr2=1.1.2.2&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Source/GSModelLoaderFactory.m.diff?only_with_tag=NibCompatibility&tr1=1.1.2.1&tr2=1.1.2.2&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Source/NSBundleAdditions.m.diff?only_with_tag=NibCompatibility&tr1=1.66.2.1&tr2=1.66.2.2&r1=text&r2=text
Re: [Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSTableView.m
--- Fred Kiefer <[EMAIL PROTECTED]> wrote: > Hi Matt, > > matt rice wrote: > > Log message: > > * Source/NSTableView.m (-mouseDown:): Copy the > selected cell before > > tracking mouse, add comment. (patch previously > reverted 2005-05-30) > > (-mouseDown:): Check for pointer equality in > addition to isEqual: > > which doesn't work with nil. (fix for bug #15316) > > > > did you test this new code with GNUmail and > Gworkspace? I had to revert > the copying the last time because of problems with > these two > applications. I agree fully on cell copying, but we > need to asure that > it has no negative effects on these widely used > applications. > i did test GWorkspace, and lightly tested GNUmail, but don't have an email server so couldn't really test it well, and tested my application which had previously had problems with the cell copying, and didn't see any issues, i also felt that in this case isolated issues with a few apps would be better than issue that effects all editable table views. so with GNUMail being another issue and GWorkspace fixed, i'm hoping the previous sentance will be a worst case scenerio (and cocoa seems to copy the cell in this case with some light testing if that means anything).. i believe that the issue with GNUMail was... if ([cell trackMouse:) { done = YES; } while (done != YES) { .. implement dragging source } which is backwards, cell tracking needs to happen after initializing a dragging operation has been ruled out. __ Yahoo! DSL Something to write home about. Just $16.99/mo. or less. dsl.yahoo.com ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSTableView.m
Enrico Sersale wrote: > On 2005-12-31 17:54:35 +0200 Fred Kiefer <[EMAIL PROTECTED]> wrote: >> >> matt rice wrote: >>> Log message: >>> * Source/NSTableView.m (-mouseDown:): Copy the selected cell before >>> tracking mouse, add comment. (patch previously reverted 2005-05-30) >>> (-mouseDown:): Check for pointer equality in addition to isEqual: >>> which doesn't work with nil. (fix for bug #15316) >>> >> >> did you test this new code with GNUmail and Gworkspace? I had to revert >> the copying the last time because of problems with these two >> applications. I agree fully on cell copying, but we need to asure that >> it has no negative effects on these widely used applications. > > It seems that both the apps have no problems. > Great to hear. Sorry for asking at all. I did only see your previous mail on the subject after sending mine :-( I had to catch up with a bigger backlog of mails and I tend to read the CVS changes first. ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSTableView.m
On 2005-12-31 17:54:35 +0200 Fred Kiefer <[EMAIL PROTECTED]> wrote: Hi Matt, matt rice wrote: Log message: * Source/NSTableView.m (-mouseDown:): Copy the selected cell before tracking mouse, add comment. (patch previously reverted 2005-05-30) (-mouseDown:): Check for pointer equality in addition to isEqual: which doesn't work with nil. (fix for bug #15316) did you test this new code with GNUmail and Gworkspace? I had to revert the copying the last time because of problems with these two applications. I agree fully on cell copying, but we need to asure that it has no negative effects on these widely used applications. Fred It seems that both the apps have no problems. ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSTableView.m
Hi Matt, matt rice wrote: > Log message: > * Source/NSTableView.m (-mouseDown:): Copy the selected cell before > tracking mouse, add comment. (patch previously reverted 2005-05-30) > (-mouseDown:): Check for pointer equality in addition to isEqual: > which doesn't work with nil. (fix for bug #15316) > did you test this new code with GNUmail and Gworkspace? I had to revert the copying the last time because of problems with these two applications. I agree fully on cell copying, but we need to asure that it has no negative effects on these widely used applications. Fred ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSTableView.m
--- Fred Kiefer <[EMAIL PROTECTED]> wrote: > Enrico Sersale wrote: > > On 2005-05-28 06:34:22 +0300 Matt Rice > <[EMAIL PROTECTED]> wrote: > > > >> --- Enrico Sersale <[EMAIL PROTECTED]> wrote: > >> > >>> On 2005-05-26 16:38:12 +0300 Fred Kiefer > >>> <[EMAIL PROTECTED]> wrote: > >>> > CVSROOT:/cvsroot/gnustep > Module name:gnustep > Branch: > Changes by:Fred Kiefer > >>> > >>> <[EMAIL PROTECTED]>05/05/26 > 13:38:11 > >>> > > Modified files: > > core/gui : ChangeLog > core/gui/Source: > >>> > >>> NSTableView.m > >>> > Log message: > Improved mouseDown call handling for table > view. > > > CVSWeb URLs: > > > >>> I think that it would be a good habit to try to > run > >>> one or two of the (few) GNUstep applications > before > >>> committing changes that can break things... > >>> > >> > >> just to elaborate.. this breaks (at least) > >> gworkspace's > >> view->list segfaults when selecting a row. > > > > > > Just to be more precise :) ... I'm not referring > to this; I've fixed it > > implementing -copyWithZone: in my cell class when > I've seen that > > gworkspace segfaults trying to release an ivar of > this class. > > The real problem is that it is not possible > anymore to start a drag from > > a cell (this is visible in GNUMail, too). Making > > -startTrackingAt:inView: to return NO in the cell > class fixes this > > problem too, but I think that there is something > wrong in -mouseDown: > > because, before theese changes, both the apps > worked well. > > > > Enrico, > It is not always bad to break things. If in this > case my change showed > some memory problem in GWorkspace and GNUMail this > is a good thing. > Provided we are able to fix it before the next > offical release of > course. So there was at least one benefit from > applying the patch. :-) > > We should work together to track down the actual > problems and fix them. > GNUstep is stil full of hacks to get partial > functionality working. We > need to try to get it correct completely. > > >> anyhow the culprit being cell copy, which was > added > >> because NSComboBoxCell caches the cellFrame so it > can > >> pop up the window through a NSButtonCell's > action... > >> > >> though it was causing multiple drawWithFrame: > calls > >> for the combobox cells with its setNeedsDisplay: > then > >> popping up in the wrong place... > >> > >> anyhow this seems to work in both cases.. > >> > > Matt, > You are surely correct about the fix for > NSComboBoxCell, it should only > mark its onl´e frame for a redraw. I am not totally > convinced about the > copy of the active cell in NSTableView. Copying the > cell also gets done > when editing is started for a cell. So cells that > don't handle it > correctly will also pose problems when edited. > > I will test this myself and propably apply it as > well, to get GWorkspace > and GNUMail working again. But my feeling is still > that there is another > problem hidden here, which we need to resolve. > > considering that GWorkspace was fixed wrt the cell copy, not copying the cell introduced a nasty bug, and GNUMail had a different issue altogether i recommited this cell copy, and cleared up the comment. to reproduce: edit a cell, select the same cell in a different row, selected cells object value becomes previously edited cells object value which has to do with selecting the new cell causing validation to occur on the edited cell. __ Yahoo! for Good - Make a difference this year. http://brand.yahoo.com/cybergivingweek2005/ ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
[Gnustep-cvs] gnustep/core/gui ChangeLog Source/NSTableView.m
CVSROOT:/cvsroot/gnustep Module name:gnustep Branch: Changes by: matt rice <[EMAIL PROTECTED]> 05/12/31 13:50:30 Modified files: core/gui : ChangeLog core/gui/Source: NSTableView.m Log message: * Source/NSTableView.m (-mouseDown:): Copy the selected cell before tracking mouse, add comment. (patch previously reverted 2005-05-30) (-mouseDown:): Check for pointer equality in addition to isEqual: which doesn't work with nil. (fix for bug #15316) CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/ChangeLog.diff?tr1=1.2640&tr2=1.2641&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/gui/Source/NSTableView.m.diff?tr1=1.119&tr2=1.120&r1=text&r2=text
[Gnustep-cvs] gnustep/usr-apps/gworkspace ClipBook/ClipBookWi...
CVSROOT:/cvsroot/gnustep Module name:gnustep Branch: Changes by: Enrico Sersale <[EMAIL PROTECTED]> 05/12/31 13:12:22 Modified files: usr-apps/gworkspace/ClipBook: ClipBookWindow.h ClipBookWindow.m usr-apps/gworkspace/FSNode: FSNBrowserCell.m FSNIcon.m usr-apps/gworkspace/GWorkspace: GWProtocol.h GWorkspace.m usr-apps/gworkspace/GWorkspace/Desktop: GWDesktopView.m usr-apps/gworkspace/GWorkspace/Desktop/Dock: Dock.m usr-apps/gworkspace/GWorkspace/Dialogs: OpenWithController.h RunExternalController.h usr-apps/gworkspace/GWorkspace/FileViewer: GWSpatialViewer.h GWSpatialViewer.m GWViewer.h GWViewer.m GWViewerIconsPath.m GWViewerShelf.m GWViewersManager.h GWViewersManager.m usr-apps/gworkspace/GWorkspace/Finder: FindModuleView.h FindModuleView.m Finder.h Finder.m usr-apps/gworkspace/GWorkspace/Finder/LiveSearch: LSFEditor.h LSFEditor.m LSFolder.h LSFolder.m usr-apps/gworkspace/GWorkspace/Finder/Modules/FModuleCrDate: FModuleCrDate.m usr-apps/gworkspace/GWorkspace/Finder/Modules/FModuleModDate: FModuleModDate.m usr-apps/gworkspace/GWorkspace/Finder/Modules/FModuleSize: FModuleSize.m usr-apps/gworkspace/GWorkspace/Finder/SearchResults: SearchResults.h SearchResults.m usr-apps/gworkspace/GWorkspace/Preferences: BrowserViewerPref.h BrowserViewerPref.m DesktopPref.h DesktopPref.m usr-apps/gworkspace/Inspector: Annotations.h Annotations.m Contents.h Contents.m Inspector.h Inspector.m Tools.h usr-apps/gworkspace/Inspector/ContentViewers/AppViewer: AppViewer.m usr-apps/gworkspace/Operation: FileOpInfo.h FileOpInfo.m usr-apps/gworkspace/Tools/fswatcher: fswatcher.h fswatcher.m usr-apps/gworkspace/Tools/fswatcher/system-specific/fswatcher-linux-2.4: fswatcher.h fswatcher.m usr-apps/gworkspace/Tools/fswatcher/system-specific/fswatcher-linux-2.6: fswatcher.h fswatcher.m Log message: CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/usr-apps/gworkspace/ClipBook/ClipBookWindow.h.diff?tr1=1.4&tr2=1.5&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/usr-apps/gworkspace/ClipBook/ClipBookWindow.m.diff?tr1=1.7&tr2=1.8&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/usr-apps/gworkspace/FSNode/FSNBrowserCell.m.diff?tr1=1.34&tr2=1.35&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/usr-apps/gworkspace/FSNode/FSNIcon.m.diff?tr1=1.61&tr2=1.62&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/usr-apps/gworkspace/GWorkspace/GWProtocol.h.diff?tr1=1.3&tr2=1.4&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/usr-apps/gworkspace/GWorkspace/GWorkspace.m.diff?tr1=1.102&tr2=1.103&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/usr-apps/gworkspace/GWorkspace/Desktop/GWDesktopView.m.diff?tr1=1.12&tr2=1.13&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/usr-apps/gworkspace/GWorkspace/Desktop/Dock/Dock.m.diff?tr1=1.7&tr2=1.8&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/usr-apps/gworkspace/GWorkspace/Dialogs/OpenWithController.h.diff?tr1=1.3&tr2=1.4&r1=text&r2=text http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/usr-apps/gworkspace/GWorkspace/Dialogs/RunExternalController.h.diff?
[Gnustep-cvs] GNUstep Testfarm Results
Test results for GNUstep as of Sat Dec 31 06:34:16 EST 2005 If a particular system failed compilation, the logs for that system will be placed at ftp://ftp.gnustep.org/pub/testfarm If you would like to add your machine to this list, set up a cron job (make sure you set up your PATH and other environment variables correctly) to run the Startup/scripts/test-gnustep script (see the script comments for more info). Success Compile i386-unknown-netbsdelf3.0 Sat Dec 31 03:58:12 CET 2005 Success Compile powerpc-apple-darwin7.9.0 Sat Dec 31 03:22:26 MST 2005 Success Compile sparc-sun-solaris2.7 Sat Dec 31 02:07:55 EST 2005