Re: [Gnustep-cvs] r22843 - in /libs/gui/trunk: ChangeLog Source/NSMenu.m
Hi Richard, I just checked this change and found that you have hard coded the value of NSCommandKeyMask as the modifier. If I see correctly, the modifier could be changed on the menu item, so it looks better to use [item keyEquivalentModifierMask]. Most likely this error was already in the old code and you just moved it around. Cheers Fred Richard Frith-Macdonald wrote: > Author: rfm > Date: Sun Apr 30 22:29:30 2006 > New Revision: 22843 > > URL: http://svn.gna.org/viewcvs/gnustep?rev=22843&view=rev > Log: > Fix longstanding bug in key equivalents handling which was previously masked > by a bug in NSApplication. > > Modified: > libs/gui/trunk/ChangeLog > libs/gui/trunk/Source/NSMenu.m > > > ___ > Gnustep-cvs mailing list > Gnustep-cvs@gna.org > https://mail.gna.org/listinfo/gnustep-cvs > > ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] r22843 - in /libs/gui/trunk: ChangeLog Source/NSMenu.m
Fred Kiefer wrote: Hi Richard, I just checked this change and found that you have hard coded the value of NSCommandKeyMask as the modifier. If I see correctly, the modifier could be changed on the menu item, so it looks better to use [item keyEquivalentModifierMask]. Most likely this error was already in the old code and you just moved it around. Cheers Fred Many thanks for fixing this, Fred! ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
