Re: [Gnustep-cvs] r28488 - /libs/gui/branches/testplant_1/
Fred, On Fri, Aug 21, 2009 at 3:57 PM, Fred Kiefer wrote: > Gregory Casamento schrieb: >> I've been taking selected fixes, currently only the deadlock fixes >> from NSUserDefaults. > > Great. > >> I'd appreciate any detailed feedback you have on the others before >> inclusion into the trunk. > > Patches that look ok to me: > > 28492 GSLayoutManager.m > Okay, I'll go ahead and pull this one into the trunk. > Patches that will need a bit more explanation/rework: > > 28498 NSOpenPanel.m > Why not change the method _shouldShowExtension: or what is the difference? I'll forward this concern. > 28494 NSFont.m > The user default is fine, but will need documentation too. Okay. >> With respect to the GSContext change, it has helped prevent some >> issues with multi-threaded apps in GUI. I would like to make it less >> coarse grained so that it can be brought to the trunk as well. > > As I already explained: This change is working around the problem that > we use the same graphic context for a window in different threads. What > we should do is create a specific context for each thread. Yes, I agree. Ideally I would like to make it per window identifier/device. GC -- Gregory Casamento Open Logic Corporation, Principal Consultant ## GNUstep Chief Maintainer yahoo/skype: greg_casamento, aol: gjcasa (240)274-9630 (Cell), (301)362-9640 (Home) ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: problem about writeInBackgroundAndNotify
Hi Richard Thank you very much for your answer. But I have tried it again at a different machine which also have Windows7 Build 7127 platform. All my computer have platform of Windows7, I don't test on any other environment. What about your environment? The program of GNUstep I used is downloaded from http://www.gnustep.org/experience/Windows.html, the latest stable version. It can reproduce the problem with any browser ( Firefox, Chrome ). I think the async socket function of GNUstep maybe have some problem on Windows7. 2009/8/22 Richard Frith-Macdonald > > On 21 Aug 2009, at 18:17, Guo Xu wrote: > > Hi everyone, >> I have downloaded the WebServer-1.2.1 example program from >> http://wiki.gnustep.org/index.php/WebServer. I got a problem. >> When the browser client visit the server page, like http://localhost, the >> server didn't give any response, until timeout. >> > > I can't reproduce that ... when I run the testWebServer program and connect > to it using firefox the response in instant. > > I checked the program, I found that if I change the >> "[[connection handle] writeInBackgroundAndNotify: result]" in Line 1480 >> to"[[connection handle] writeData: result]" >> it can work. >> >> Does anyone known why the method writeInBackgroundAndNotify cannot work in >> this example? >> > > I have no idea why that would make any difference (possibly it was just a > coincidence?). > > Are you using an up to date version of GNUstep? Not that the version of > the libraries is likely to make any difference ... this code has been > running 24*7 in high volume applications for years without any trouble. > > ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] r28488 - /libs/gui/branches/testplant_1/
Gregory Casamento schrieb: > I've been taking selected fixes, currently only the deadlock fixes > from NSUserDefaults. Great. > I'd appreciate any detailed feedback you have on the others before > inclusion into the trunk. Patches that look ok to me: 28492 GSLayoutManager.m Patches that will need a bit more explanation/rework: 28498 NSOpenPanel.m Why not change the method _shouldShowExtension: or what is the difference? 28494 NSFont.m The user default is fine, but will need documentation too. > With respect to the GSContext change, it has helped prevent some > issues with multi-threaded apps in GUI. I would like to make it less > coarse grained so that it can be brought to the trunk as well. As I already explained: This change is working around the problem that we use the same graphic context for a window in different threads. What we should do is create a specific context for each thread. ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] r28488 - /libs/gui/branches/testplant_1/
Fred, The Testplant guys are doing a maintenance release. The branch is based on 28233 which was the last version their software was released against. They didn't want to take all of the changes from the trunk just yet for the maintenance release since there is some instability there with their app. I've been taking selected fixes, currently only the deadlock fixes from NSUserDefaults. I'd appreciate any detailed feedback you have on the others before inclusion into the trunk. With respect to the GSContext change, it has helped prevent some issues with multi-threaded apps in GUI. I would like to make it less coarse grained so that it can be brought to the trunk as well. Greg On Fri, Aug 21, 2009 at 7:20 AM, Fred Kiefer wrote: > Gregory Casamento schrieb: >> Author: gcasa >> Date: Thu Aug 20 00:25:33 2009 >> New Revision: 28488 >> >> URL: http://svn.gna.org/viewcvs/gnustep?rev=28488&view=rev >> Log: >> Add new branch with corrected revision number. >> >> Added: >> libs/gui/branches/testplant_1/ >> - copied from r28233, libs/gui/trunk/ >> > Hi Greg, > > could you please explain the purpose of this new branch? I can see that > Doug and Jonathan have started using it. Most of the changes they made > up to now are perfectly legitimate for trunk (Apart from those already > in trunk and that GSContext change. I am unsure about the NSOpenPanel patch) > Who will be porting these changes back to trunk? Currently the commits > on the branch are without Change log entries, how are we going to add these? > > Fred > > > ___ > Gnustep-dev mailing list > Gnustep-dev@gnu.org > http://lists.gnu.org/mailman/listinfo/gnustep-dev > -- Gregory Casamento Open Logic Corporation, Principal Consultant ## GNUstep Chief Maintainer yahoo/skype: greg_casamento, aol: gjcasa (240)274-9630 (Cell), (301)362-9640 (Home) ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: problem about writeInBackgroundAndNotify
On 21 Aug 2009, at 18:17, Guo Xu wrote: Hi everyone, I have downloaded the WebServer-1.2.1 example program from http://wiki.gnustep.org/index.php/WebServer . I got a problem. When the browser client visit the server page, like http:// localhost, the server didn't give any response, until timeout. I can't reproduce that ... when I run the testWebServer program and connect to it using firefox the response in instant. I checked the program, I found that if I change the "[[connection handle] writeInBackgroundAndNotify: result]" in Line 1480 to"[[connection handle] writeData: result]" it can work. Does anyone known why the method writeInBackgroundAndNotify cannot work in this example? I have no idea why that would make any difference (possibly it was just a coincidence?). Are you using an up to date version of GNUstep? Not that the version of the libraries is likely to make any difference ... this code has been running 24*7 in high volume applications for years without any trouble. ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
problem about writeInBackgroundAndNotify
Hi everyone, I have downloaded the WebServer-1.2.1 example program from http://wiki.gnustep.org/index.php/WebServer. I got a problem. When the browser client visit the server page, like http://localhost, the server didn't give any response, until timeout. I checked the program, I found that if I change the "[[connection handle] writeInBackgroundAndNotify: result]" in Line 1480 to"[[connection handle] writeData: result]" it can work. Does anyone known why the method writeInBackgroundAndNotify cannot work in this example? ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] r28488 - /libs/gui/branches/testplant_1/
Fred Kiefer wrote: Gregory Casamento schrieb: Author: gcasa Date: Thu Aug 20 00:25:33 2009 New Revision: 28488 URL: http://svn.gna.org/viewcvs/gnustep?rev=28488&view=rev Log: Add new branch with corrected revision number. Added: libs/gui/branches/testplant_1/ - copied from r28233, libs/gui/trunk/ Hi Greg, could you please explain the purpose of this new branch? I can see that Doug and Jonathan have started using it. Most of the changes they made up to now are perfectly legitimate for trunk (Apart from those already in trunk and that GSContext change. I am unsure about the NSOpenPanel patch) Who will be porting these changes back to trunk? Currently the commits on the branch are without Change log entries, how are we going to add these? I think I can agree with Fred here, keeping the ChangeLog would make things much easier in the futuere event of a merge. Riccardo ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] r28488 - /libs/gui/branches/testplant_1/
Gregory Casamento schrieb: > Author: gcasa > Date: Thu Aug 20 00:25:33 2009 > New Revision: 28488 > > URL: http://svn.gna.org/viewcvs/gnustep?rev=28488&view=rev > Log: > Add new branch with corrected revision number. > > Added: > libs/gui/branches/testplant_1/ > - copied from r28233, libs/gui/trunk/ > Hi Greg, could you please explain the purpose of this new branch? I can see that Doug and Jonathan have started using it. Most of the changes they made up to now are perfectly legitimate for trunk (Apart from those already in trunk and that GSContext change. I am unsure about the NSOpenPanel patch) Who will be porting these changes back to trunk? Currently the commits on the branch are without Change log entries, how are we going to add these? Fred ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
