Re: base: running make in Documentation subdir broken

2021-04-22 Thread Richard Frith-Macdonald



> On 22 Apr 2021, at 22:32, Ivan Vučica  wrote:
> 
> Hi,
> 
> when running "Generating reference documentation...", the output is
> now full of screenfuls upon screenfuls of:
> 
> ../Headers/Foundation/NSNumberFormatter.h:501 Unexpected char (-) in 
> declaration
> ../Headers/Foundation/NSNumberFormatter.h:502 Unexpected char (-) in 
> declaration
> ../Headers/Foundation/NSNumberFormatter.h:504 Unexpected char (-) in 
> declaration
> ../Headers/Foundation/NSNumberFormatter.h:505 Unexpected char (-) in 
> declaration
> ../Headers/Foundation/NSNumberFormatter.h:507 Unexpected char (-) in 
> declaration
> ../Headers/Foundation/NSNumberFormatter.h:508 Unexpected char (-) in 
> declaration
> ../Headers/Foundation/NSNumberFormatter.h:510 Unexpected char (-) in 
> declaration
> ../Headers/Foundation/NSNumberFormatter.h:511 Unexpected char (-) in 
> declaration
> ../Headers/Foundation/NSNumberFormatter.h:515 Unexpected char (+) in 
> declaration
> ../Headers/Foundation/NSNumberFormatter.h:523 Argh ... read '}' when
> looking for ';'
> ../Headers/Foundation/NSObject.h:292 Unexpected char (@) in declaration
> ../Headers/Foundation/NSObject.h:308 Unexpected char (-) in declaration
> ../Headers/Foundation/NSObject.h:312 Unexpected char (-) in declaration
> ../Headers/Foundation/NSObject.h:315 Unexpected char (+) in declaration
> ../Headers/Foundation/NSObject.h:316 Unexpected char (+) in declaration
> ../Headers/Foundation/NSObject.h:317 Unexpected char (+) in declaration
> ../Headers/Foundation/NSObject.h:339 Unexpected char (+) in declaration
> ../Headers/Foundation/NSObject.h:364 Unexpected char (+) in declaration
> 
> 
> I'm unfamiliar with how our doc generators work. What could we have
> done to break them? Could this be releated to DLLEXPORT changes for
> Windows?
> 
> Richard, is this a release stopper?

I suppose, but fortunately easy to fix;  I added GS_EXPORT_CLASS to the set of 
'words' the automatic generation should ignore when building base and base 
additions documentation.


Re: base: running make in Documentation subdir broken

2021-04-22 Thread Ivan Vučica
On Thu, Apr 22, 2021 at 10:38 PM Ivan Vučica  wrote:
>
> Actually, I'm calling it:
>
> the generated documentation is useless hence this is a show stopper. Most 
> classes are affected and don't generate any documentation.
>
> I will commit the work for this evening, but I will not tag the release. 
> Someone please address the broken doc generator.

This has been filed as https://github.com/gnustep/libs-base/issues/182.



base: running make in Documentation subdir broken

2021-04-22 Thread Ivan Vučica
Hi,

when running "Generating reference documentation...", the output is
now full of screenfuls upon screenfuls of:

../Headers/Foundation/NSNumberFormatter.h:501 Unexpected char (-) in declaration
../Headers/Foundation/NSNumberFormatter.h:502 Unexpected char (-) in declaration
../Headers/Foundation/NSNumberFormatter.h:504 Unexpected char (-) in declaration
../Headers/Foundation/NSNumberFormatter.h:505 Unexpected char (-) in declaration
../Headers/Foundation/NSNumberFormatter.h:507 Unexpected char (-) in declaration
../Headers/Foundation/NSNumberFormatter.h:508 Unexpected char (-) in declaration
../Headers/Foundation/NSNumberFormatter.h:510 Unexpected char (-) in declaration
../Headers/Foundation/NSNumberFormatter.h:511 Unexpected char (-) in declaration
../Headers/Foundation/NSNumberFormatter.h:515 Unexpected char (+) in declaration
../Headers/Foundation/NSNumberFormatter.h:523 Argh ... read '}' when
looking for ';'
../Headers/Foundation/NSObject.h:292 Unexpected char (@) in declaration
../Headers/Foundation/NSObject.h:308 Unexpected char (-) in declaration
../Headers/Foundation/NSObject.h:312 Unexpected char (-) in declaration
../Headers/Foundation/NSObject.h:315 Unexpected char (+) in declaration
../Headers/Foundation/NSObject.h:316 Unexpected char (+) in declaration
../Headers/Foundation/NSObject.h:317 Unexpected char (+) in declaration
../Headers/Foundation/NSObject.h:339 Unexpected char (+) in declaration
../Headers/Foundation/NSObject.h:364 Unexpected char (+) in declaration


I'm unfamiliar with how our doc generators work. What could we have
done to break them? Could this be releated to DLLEXPORT changes for
Windows?

Richard, is this a release stopper?



Re: [gnustep/libs-base] 79f738: Merge pull request #10 from gnustep/master

2021-04-22 Thread Ivan Vučica
Can we please all rebase commits before merging, rather than merging
merge commits?

On Fri, Nov 13, 2020 at 2:31 PM 'rfm' via gnustep-commits
 wrote:
>
>   Branch: refs/heads/master
>   Home:   https://github.com/gnustep/libs-base
>   Commit: 79f738ceb1dc9ebd4b39db1914faca61f5b175e7
>   
> https://github.com/gnustep/libs-base/commit/79f738ceb1dc9ebd4b39db1914faca61f5b175e7
>   Author: Adam Fox 
>   Date:   2020-10-12 (Mon, 12 Oct 2020)
>
>   Changed paths:
> M .gitignore
> M .travis.yml
> M ANNOUNCE
> M ChangeLog
> M Documentation/ReleaseNotes.gsdoc
> M Documentation/announce.texi
> M Documentation/news.texi
> M Examples/dictionary.m
> M Examples/nsconnection_client.m
> R Headers/Foundation/MISSING
> M Headers/Foundation/NSAttributedString.h
> M Headers/Foundation/NSCalendar.h
> M Headers/Foundation/NSError.h
> M Headers/Foundation/NSException.h
> M Headers/Foundation/NSFilePresenter.h
> M Headers/Foundation/NSKeyedArchiver.h
> M Headers/Foundation/NSLocale.h
> M Headers/Foundation/NSNotification.h
> M Headers/Foundation/NSObjCRuntime.h
> M Headers/Foundation/NSOperation.h
> M Headers/Foundation/NSPropertyList.h
> M Headers/Foundation/NSURL.h
> M Headers/Foundation/NSURLProtocol.h
> M Headers/Foundation/NSURLRequest.h
> M Headers/Foundation/NSUUID.h
> M Headers/Foundation/NSXMLParser.h
> M Headers/Foundation/NSXPCConnection.h
> M Headers/GNUstepBase/GNUstep.h
> M Headers/GNUstepBase/GSConfig.h.in
> M Headers/GNUstepBase/GSIMap.h
> M Headers/GNUstepBase/GSVersionMacros.h
> M Headers/GNUstepBase/GSXML.h
> M Headers/GNUstepBase/config.h.in
> A MISSING
> M NEWS
> M README.initialize
> M Resources/Languages/Locale.canonical
> M Resources/Languages/README
> M Source/Additions/GSInsensitiveDictionary.m
> M Source/Additions/GSMime.m
> M Source/Additions/GSObjCRuntime.m
> M Source/Additions/GSXML.m
> M Source/Additions/NSArray+GNUstepBase.m
> M Source/Additions/NSData+GNUstepBase.m
> M Source/Additions/NSObject+GNUstepBase.m
> M Source/Additions/NSProcessInfo+GNUstepBase.m
> M Source/Additions/NSPropertyList+GNUstepBase.m
> M Source/Additions/NSURL+GNUstepBase.m
> R Source/CharSets/URLFragmentAllowedCharSet.h
> R Source/CharSets/URLHostAllowedCharSet.h
> R Source/CharSets/URLPasswordAllowedCharSet.h
> R Source/CharSets/URLPathAllowedCharSet.h
> R Source/CharSets/URLQueryAllowedCharSet.h
> R Source/CharSets/URLUserAllowedCharSet.h
> M Source/GSAttributedString.m
> M Source/GSDictionary.m
> M Source/GSNetwork.h
> M Source/GSSocketStream.m
> M Source/GSString.m
> M Source/GSTLS.m
> M Source/NSBundle.m
> M Source/NSCalendar.m
> M Source/NSCharacterSet.m
> M Source/NSCharacterSetData.h
> M Source/NSConcreteMapTable.m
> M Source/NSConnection.m
> M Source/NSData.m
> M Source/NSDateComponentsFormatter.m
> M Source/NSDictionary.m
> M Source/NSError.m
> M Source/NSException.m
> M Source/NSFileManager.m
> M Source/NSFileWrapper.m
> M Source/NSHTTPCookie.m
> M Source/NSHost.m
> M Source/NSISO8601DateFormatter.m
> M Source/NSInvocationOperation.m
> M Source/NSJSONSerialization.m
> M Source/NSKeyValueObserving.m
> M Source/NSKeyedArchiver.m
> M Source/NSKeyedUnarchiver.m
> M Source/NSLocale.m
> M Source/NSLog.m
> M Source/NSNotification.m
> M Source/NSObject.m
> M Source/NSOperation.m
> M Source/NSOrthography.m
> M Source/NSPersonNameComponentsFormatter.m
> M Source/NSPortCoder.m
> M Source/NSPredicate.m
> M Source/NSProcessInfo.m
> M Source/NSSocketPortNameServer.m
> M Source/NSString.m
> M Source/NSTask.m
> M Source/NSThread.m
> M Source/NSTimer.m
> M Source/NSURL.m
> M Source/NSURLProtocol.m
> M Source/NSURLRequest.m
> M Source/NSURLResponse.m
> M Source/NSUUID.m
> M Source/NSUnarchiver.m
> M Source/NSUserDefaults.m
> M Source/NSValueTransformer.m
> M Source/NSXMLParser.m
> M Source/NSXPCConnection.m
> M Source/inet_ntop.m
> M Source/inet_pton.m
> M Source/objc-load.m
> M Source/unix/NSStream.m
> M Source/win32/GSFileHandle.m
> M Source/win32/NSMessagePort.m
> M Tests/GNUmakefile
> M Tests/base/GSTLS/basic.m
> M Tests/base/NSBundle/GNUmakefile.preamble
> M Tests/base/NSBundle/Resources/GNUmakefile
> M Tests/base/NSBundle/resources2.m
> M Tests/base/NSCalendar/features-10-7.m
> M Tests/base/NSCharacterSet/general.m
> M Tests/base/NSDictionary/general.m
> M Tests/base/NSFileManager/general.m
> M Tests/base/NSHTTPCookie/basic.m
> M Tests/base/NSLocale/general.m
> M Tests/base/NSMapTable/weakObjects.m
> M Tests/base/NSNotification/basic.m
> M Tests/base/NSProxy/test00.m
> M Tests/base/NSProxy/test01.m
> M 

Re: GNUstep releases this month?

2021-04-22 Thread Ivan Vučica
I am resuming work on releases today and hope to prepare at least
-base tarball today.

On Fri, Mar 26, 2021 at 11:43 AM Frederik Seiffert
 wrote:
>
>
> Am 22.03.2021 um 19:03 schrieb Richard Frith-Macdonald 
> :
>
> IIRC the standard/historic behavior is that an object can retain itself in 
> the -dealloc method, to extend its own lifetime, and I guess that the 
> singletons do that (I haven't checked).
> I think that behavior changed for ARC, so it could be that the runtime is 
> performing an ARC style deallocation when it should be calling 
> NSDeallocateObject() (or something odd is going on in the 
> NSDeallocateObject() function).
>
>
> I’ve pushed a change in the following PR that fixes the test failure:
> https://github.com/gnustep/libs-base/pull/177/commits/e1e661286a6b9d717dc0312bed5f8b4b5e549d6f
>
> Frederik
>