Getting reviews and submitting patches
Sorry for the newbie question, but I want to make sure I get it right ;-) I've got a couple of patches that I'd like to submit to gnustep-base. Google has signed off on having them submitted to the project, so the legal steps are taken care of already. a) Is there a coding standard for gnustep somewhere that I missed? Right now I'm guessing no. b) How do people normally handle reviews? c) Anything else I should know before diving into the world of submitting patches? Cheers (and thanks), Dave ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Bad Undefines in NSKeyedArchiver and NSKeyedArchiver?
Excuse me if this is a silly question, but I just ran into problems compiling these two headers (Foundation/NSKeyedArchiver.h and Foundation/NSArchiver.h) and the fix looks obvious, but it's also obvious that these files have been this way for years. In both cases they have code that looks similar to this: #ifndef _IN_NSKEYEDUNARCHIVER_M #define GSIArrayvoid* #endif GSIArray _objMap; /* Decoded objects.*/ #ifndef _IN_NSKEYEDUNARCHIVER_M #undef GSUnarchiverArray #endif and #ifndef _IN_NSUNARCHIVER_M #define GSIArrayvoid* #endif GSIArray clsMap; /* Class crossreference map.*/ GSIArray objMap; /* Object crossreference map. */ GSIArray ptrMap; /* Pointer crossreference map. */ #ifndef _IN_NSUNARCHIVER_M #undef GSUnarchiverArray #endif It would seem to me that the #undef should be #undef GSIArray in both cases, and not GSUnarchiverArray. Am I missing something? Making this change cleaned up compilation for me. Otherwise I was getting errors about GSIArray being redefined. Cheers, Dave ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Bad Undefines in NSKeyedArchiver and NSKeyedArchiver?
On Jun 13, 2009, at 01:19 , Richard Frith-Macdonald wrote: On 13 Jun 2009, at 07:26, Dave MacLachlan wrote: Excuse me if this is a silly question, but I just ran into problems compiling these two headers (Foundation/NSKeyedArchiver.h and Foundation/NSArchiver.h) and the fix looks obvious, but it's also obvious that these files have been this way for years. Thanks ... I fixed that ... though it's clearly harmless normally, as the macro is defined to the same thing twice and the compiler doesn't even warn when a macro is being defined to the same value twice. If you are encountering compiler warnings/errors then I guess you must be redefining GSIArray yourself, which you probably shouldn't be doing. Maybe you want to look into using the new NSPointerArray class instead? Obviously NSPointerArray is new, relatively untested code, but it's MacOS-X/Cocoa compatible. Great thanks. Cheers, Dave ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
NSCalendar and NSLocale support
Hey there... I'm looking to add NSCalendar and NSLocale to Foundation. I'm happy to implement them, but I was hoping to do it on top of ICU (http://site.icu-project.org/ ). Are we willing to add a dependency on ICU to gnustep? The ICU license is GNU GPL compatible... http://userguide.icu-project.org/icufaq#TOC-How-is-the-ICU-licensed- Or perhaps I should be looking somewhere else? Cheers, Dave ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
