[Gnustep-cvs] gnustep/core/back ChangeLog Source/art/ARTConte...

2005-12-20 Thread Adam Fedor 
CVSROOT:/cvsroot/gnustep
Module name:gnustep
Branch: 
Changes by: Adam Fedor [EMAIL PROTECTED]  05/12/20 20:36:59

Modified files:
core/back  : ChangeLog 
core/back/Source/art: ARTContext.m 
core/back/Source/x11: XGServer.m 
core/back/Source/xdps: NSDPSContext.m 

Log message:
* Source/art/ARTContext.m ([ARTContext -beep]): Respect user setting
of bell volume.
* Source/x11/XGServe.m: Idem.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/back/ChangeLog.diff?tr1=1.402tr2=1.403r1=textr2=text
http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/back/Source/art/ARTContext.m.diff?tr1=1.30tr2=1.31r1=textr2=text
http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/back/Source/x11/XGServer.m.diff?tr1=1.18tr2=1.19r1=textr2=text
http://cvs.savannah.gnu.org/viewcvs/gnustep/gnustep/core/back/Source/xdps/NSDPSContext.m.diff?tr1=1.5tr2=1.6r1=textr2=text

Re: [Gnustep-cvs] gnustep/core/back ChangeLog Source/art/ARTConte...

2005-12-20 Thread Fred Kiefer 
Adam Fedor wrote:
 CVSROOT:  /cvsroot/gnustep
 Module name:  gnustep
 Branch:   
 Changes by:   Adam Fedor [EMAIL PROTECTED]  05/12/20 20:36:59
 
 Modified files:
   core/back  : ChangeLog 
   core/back/Source/art: ARTContext.m 
   core/back/Source/x11: XGServer.m 
   core/back/Source/xdps: NSDPSContext.m 
 
 Log message:
   * Source/art/ARTContext.m ([ARTContext -beep]): Respect user setting
   of bell volume.
   * Source/x11/XGServe.m: Idem.

Hi Adam,

I am surprised that you had to change all these places. Judging from the
code in NSGraphicsContext.m,

/** Play the System Beep */
- (void) NSBeep
{
  [GSCurrentServer() beep];
}

I would expect that it is the obligation of the display server, not the
display context to handle the beep. From this reasoning I would call the
art method totally obsolete, as it will never be called and the one in
NSDPSContext a duplicate, as it copies code from the super class
implementation (although optimised).

Looks to me like this is one of the places in GNUstep, where the origin
of the code goes too far back to be easily touched any more. Even by
you, who probably wrote most of it :-)

Cheers
Fred


___
Gnustep-dev mailing list
Gnustep-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/gnustep-dev

Re: [Gnustep-cvs] gnustep/core/back ChangeLog Source/art/ARTConte...

2005-12-20 Thread Adam Fedor 

On Dec 20, 2005, at 4:17 PM, Fred Kiefer wrote:
Looks to me like this is one of the places in GNUstep, where the origin 
of the code goes too far back to be easily touched any more. Even by 
you, who probably wrote most of it :-) 



Yes, I think I was being lazy. Perhaps I should go back and fix that...
___
Gnustep-dev mailing list
Gnustep-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/gnustep-dev