Getting reviews and submitting patches
Sorry for the newbie question, but I want to make sure I get it right ;-) I've got a couple of patches that I'd like to submit to gnustep-base. Google has signed off on having them submitted to the project, so the legal steps are taken care of already. a) Is there a coding standard for gnustep somewhere that I missed? Right now I'm guessing no. b) How do people normally handle reviews? c) Anything else I should know before diving into the world of submitting patches? Cheers (and thanks), Dave ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Getting reviews and submitting patches
On 14 Jun 2009, at 17:20, Dave MacLachlan wrote: Sorry for the newbie question, but I want to make sure I get it right ;-) I've got a couple of patches that I'd like to submit to gnustep- base. Google has signed off on having them submitted to the project, so the legal steps are taken care of already. Have you filed a copyright assignment form with the FSF? As a GNU project, contributors to GNUstep are required to do this. The FSF still owes me $1 from mine though... a) Is there a coding standard for gnustep somewhere that I missed? Right now I'm guessing no. GNUstep is a GNU project, so the GNU coding styles apply. These are widely ignored in GNUstep, however, because they are absolutely atrocious (worse than Google's, but not quite as bad as LLVM's). They were originally created as a 'compromise' between the BSD and AT&T coding conventions, and managed to combine the worst aspects of both. b) How do people normally handle reviews? Post patches to the list, and if no one reviews / commits them, complain until they do (well, that's how I do it...). As far as I know, there is no formal code review system (yet...). c) Anything else I should know before diving into the world of submitting patches? Nothing springs to mind. The first step is doing the copyright assignment. David ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Getting reviews and submitting patches
On 14 Jun 2009, at 17:20, Dave MacLachlan wrote: Sorry for the newbie question, but I want to make sure I get it right ;-) I've got a couple of patches that I'd like to submit to gnustep- base. Google has signed off on having them submitted to the project, so the legal steps are taken care of already. Including copyright assignment to the FSF? That's a requirement for anything substantial. a) Is there a coding standard for gnustep somewhere that I missed? Right now I'm guessing no. If you don't know, then yes, you missed them. The coding standards are the GNU coding standards, but with some modifications for Objective-C (since the GNU ones are basically for C)... http://www.gnustep.org/resources/documentation/Developer/CodingStandards/coding-standards.pdf We try to keep coding style fairly rigorously consistent in GNUstep (certainly in GNUstep proper ... the core libraries) as an aid to general readability/maintainability, but a lot of the associated projects and non-code packages are left pretty much as the person who originally wrote them happened to do things. b) How do people normally handle reviews? We have a project page at https://savannah.gnu.org/projects/gnustep/ where tracking of bug reports and patches is done. One a patch or bug report is added there, there's a good chance that core developers will look at it :-) There aren't many of us though, so a follow-up to the developer or discussion mailing list is good if nobody has commented within a few days. c) Anything else I should know before diving into the world of submitting patches? General principles ... try to keep patches small so that they can be reviewed easily/quickly, and so that changes can be done/tested in stages with each patch leaving the main code working. Implementation of new classes is simpler ... because that's normally highly localised and unlikely to break anything. Ideally, present testcases. The gnustep testsuite is available from subversion at http://svn.gna.org/viewcvs/gnustep/tests/testsuite/trunk/ It's really simple to produce testcases to fit into this testsuite, and they give you a way of demonstrating that what your code is supposed to do (and verifying that it works the same way on MacOS-X as on GNUstep, since the testsuite can largely be run under MacOS-X). ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Getting reviews and submitting patches
Hi Dave, lookign forward for your patches already! Dave MacLachlan wrote: Sorry for the newbie question, but I want to make sure I get it right ;-) questions like that save hassle... and make sure you get well introduced in this somewhat elitarian group, so ti is good to ask. I've got a couple of patches that I'd like to submit to gnustep-base. Google has signed off on having them submitted to the project, so the legal steps are taken care of already. for small stuff there is no need for the FSF stuff, else you need to do that legal stuff. a) Is there a coding standard for gnustep somewhere that I missed? Right now I'm guessing no. There is. It is the GNU one. Being objc... it is a mix of "NeXT" tradition in naming the classes and methods and GNU code style. Emacs/xemacs have a good standard style for it. Vim sadly has a not perfectly adherent there. core stuff like base, gui, back are decent examples to follow. Some of the applications are less. To sum up - spaces, not tabs - two space indent - braces on new line - gnu style: for IF, indent the braces, then the block isnide again (so it looks the block is 4 spaces, like most code standards) - whe have autogsdoc comments b) How do people normally handle reviews? there is no formal process. Usually you seek assistance of the maintainer (base- Richard, gui- Fred...) although people try to help in a cooperative way on the list. Some of the applications currently have no formal maintainer. c) Anything else I should know before diving into the world of submitting patches? for small stuff usually it is fine. Before adding dependencies, ask. A last note, we still are gcc 2.95 compatible so please, avoid c-99isms and some of the known limitations of that compiler. I will try my best to correct them, but if you avoid me the hassle, I'll thank you. Have fun, Riccardo ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: Getting reviews and submitting patches
В Sun, 14 Jun 2009 18:56:40 +0100, Richard Frith-Macdonald написа: > On 14 Jun 2009, at 17:20, Dave MacLachlan wrote: >> Google has signed off on having them submitted to the project, so the >> legal steps are taken care of already. > > Including copyright assignment to the FSF? That's a requirement for > anything substantial. Some companies (e.g. Red Hat, Google) have blanket copyright assignment which is valid for all employees (and all GNU packages). So if the contribution is made on behalf of Google and Dave is an employee, no personal assignment is necessary. ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
