Re: [Gnustep-cvs] r26307 - /libs/gui/trunk/Source/NSApplication.m
Fabien Vallon wrote: On Wed, 26 Mar 2008, Fred Kiefer wrote: Riccardo Mottola wrote: Author: rmottola Date: Sun Mar 16 02:02:52 2008 New Revision: 26307 URL: http://svn.gna.org/viewcvs/gnustep?rev=26307view=rev Log: changed terminate type to BOOL since it is one and the value froma delegate got wrongly cast Modified: libs/gui/trunk/Source/NSApplication.m No it is not. The return value of applicationShouldTerminate: is of type NSApplicationTerminateReply and has been this since some time. It used to be a BOOL in OpenStep. Could you please undo your change that prevents the value of NSTerminateLater from being passed on and we may check together what did go wrong in your original delegate. I reported this bug on #gnustep. You can try this simple example here : http://www.sonappart.net/gnustep/appdelegatebug.tar.gz You can not quit the application. Strange, this application works for me even with the old GNUstep code. Which environment are you on? To be honest I don't see, how this could have failed even on a 64 bit system, but then you never know. Does it work with Richard latest change? That code looks as save as possible to me. Fred ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] r26307 - /libs/gui/trunk/Source/NSApplication.m
Hi, On Wed, 26 Mar 2008, Fred Kiefer wrote: Riccardo Mottola wrote: Author: rmottola Date: Sun Mar 16 02:02:52 2008 New Revision: 26307 URL: http://svn.gna.org/viewcvs/gnustep?rev=26307view=rev Log: changed terminate type to BOOL since it is one and the value froma delegate got wrongly cast Modified: libs/gui/trunk/Source/NSApplication.m No it is not. The return value of applicationShouldTerminate: is of type NSApplicationTerminateReply and has been this since some time. It used to be a BOOL in OpenStep. Could you please undo your change that prevents the value of NSTerminateLater from being passed on and we may check together what did go wrong in your original delegate. I reported this bug on #gnustep. You can try this simple example here : http://www.sonappart.net/gnustep/appdelegatebug.tar.gz You can not quit the application. Fabien. ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] r26307 - /libs/gui/trunk/Source/NSApplication.m
Riccardo Mottola wrote: Author: rmottola Date: Sun Mar 16 02:02:52 2008 New Revision: 26307 URL: http://svn.gna.org/viewcvs/gnustep?rev=26307view=rev Log: changed terminate type to BOOL since it is one and the value froma delegate got wrongly cast Modified: libs/gui/trunk/Source/NSApplication.m No it is not. The return value of applicationShouldTerminate: is of type NSApplicationTerminateReply and has been this since some time. It used to be a BOOL in OpenStep. Could you please undo your change that prevents the value of NSTerminateLater from being passed on and we may check together what did go wrong in your original delegate. Fred ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: [Gnustep-cvs] r26307 - /libs/gui/trunk/Source/NSApplication.m
The change wasn't to the return type, but to what it's being compared to in the method. We changed the declaration of a local variable to BOOL so that the comparison would be done properly. You want this changed back? Gregory Casamento -- Principal Consultant - OLC, Inc # GNUstep Chief Maintainer - Original Message From: Fred Kiefer [EMAIL PROTECTED] To: Riccardo Mottola [EMAIL PROTECTED] Cc: GNUstep Developer gnustep-dev@gnu.org Sent: Wednesday, March 26, 2008 5:03:55 AM Subject: Re: [Gnustep-cvs] r26307 - /libs/gui/trunk/Source/NSApplication.m Riccardo Mottola wrote: Author: rmottola Date: Sun Mar 16 02:02:52 2008 New Revision: 26307 URL: http://svn.gna.org/viewcvs/gnustep?rev=26307view=rev Log: changed terminate type to BOOL since it is one and the value froma delegate got wrongly cast Modified: libs/gui/trunk/Source/NSApplication.m No it is not. The return value of applicationShouldTerminate: is of type NSApplicationTerminateReply and has been this since some time. It used to be a BOOL in OpenStep. Could you please undo your change that prevents the value of NSTerminateLater from being passed on and we may check together what did go wrong in your original delegate. Fred ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
