Re: [Fedora-packaging] Proposed Fedora packaging guideline: Forge-hosted projects packaging automation

2017-12-09 Thread Matthew Miller 
On Sat, Dec 09, 2017 at 09:33:17AM +0100, nicolas.mail...@laposte.net wrote:
> Since I'm a nice person I added GitLab support this morning (both
> gitlab.com and hosted gitlab). Releases are clearly an afterthought
> in GitLab, they depend on free-form tags and can't be used in rpm
> without knowing the corresponding hash (so worst-case, packaging a
> GitLab release requires declaration of version + tag + commit and not
> just version as on other forges).
> 
> As far as I've seen pagure.io does not allow direct download of
> release, tag or commit project archives, so it can not be supported
> right now. RFE: https://pagure.io/pagure/issue/2845

Cool -- thanks for both of these!

-- 
Matthew Miller

Fedora Project Leader
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org

Re: Proposed Fedora packaging guideline: Forge-hosted projects packaging automation

2017-12-09 Thread nicolas . mailhot 
De: "Zbigniew Jędrzejewski-Szmek" 

> Impressive! I just tested this on some random package using github and
> everything works great.

Thanks for the nice feedback

> Would it be possible to drop the requirement to have "/" at the end
> of a github URL? I think it's natural to paste the URL without the
> trailing slash...

Not having to handle special cases was easier for me, but ok done, the macro is 
now less pedantic.

> Your instructions say "just copy the file into /usr/lib/rpm/macros.d",
> suggesting that the name can by anything, but I think it has to start
> with "macros.".

You're right, it's documented now.

> Wouldn't it be better to recommend %autosetup instead of %setup?
> It's one less thing to change if patches are added.

I don't have a good history with %autosetup :) It tends to hate the patches I 
produce.

OTOH it would be nice if the macro could adjust %setup to mean %setup -n 
%{archivename} when necessary, but I couldn't figure how to do it cleanly.

> add a text like
> "See https://fedoraproject.org/wiki/Packaging:Versioning how to adjust
> Release tag for pre-/post- release commits.". 

Done, thank you for the review.

Regards,

-- 
Nicolas Mailhot
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org

Re: [Fedora-packaging] Proposed Fedora packaging guideline: Forge-hosted projects packaging automation

2017-12-09 Thread nicolas . mailhot 
De: "Matthew Miller" 

Hi

> Could open-source solutions pagure.io and gitlab.com be added, please?

Since I'm a nice person I added GitLab support this morning (both gitlab.com 
and hosted gitlab). Releases are clearly an afterthought in GitLab, they depend 
on free-form tags and can't be used in rpm without knowing the corresponding 
hash (so worst-case, packaging a GitLab release requires declaration of version 
+ tag + commit and not just version as on other forges).

As far as I've seen pagure.io does not allow direct download of release, tag or 
commit project archives, so it can not be supported right now.
RFE: https://pagure.io/pagure/issue/2845

Regards,

-- 
Nicolas Mailhot
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org