Re: Activities and Places - Ant compilation

2011-12-02 Thread Jeanpylone
My Bad!!!
Sorry, I think I should sleep longer sometimes...
In fact I was doing it right (class compiled before gwt compile and so on 
...) But my pathelement to class files was just wrong!

Thank you all for your answers !

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/FGDrGZwZME4J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Is there any way I can add a Chart widget into cells in a celltable?

2011-12-02 Thread Jian Lu
Thanks a bunch for pointing to the image charts, which seems quite
promising for solving my problem.

The reason I was trying to add a widget to the cell is I want to embed a
chart created by Google Chart Tools into my cell table, and the chart
created by Google Chart Tools is in the form of a widget, which will
eventually be rendered as an iframe with embeded js.

I will take a look at the image charts and report back. Thanks!

-Jian

On Thu, Dec 1, 2011 at 11:19 PM, -sowdri- sow...@gmail.com wrote:

 Cells and widgets are 2 different ways to render info on the screen. While
 the former uses innerHtml, the later uses DOM level manipulations for
 rendering the data.

 There is a proposal to come up with cell backed widgets, I'm not sure
 about the implementation roadmap.
 refer: http://code.google.com/p/google-web-toolkit/wiki/CellBackedWIdgets for
 details.

 I'm not sure why you are trying to embed widget in cell table. But if you
 really have to do it, try image charts (
 http://code.google.com/apis/chart/image/ ). You can create custom cells
 for each of the chart type you use and you can embed this into the
 celltable.

 But you will lose the interactivity though :(

 Hope this helps,
 -sowdri-

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To view this discussion on the web visit
 https://groups.google.com/d/msg/google-web-toolkit/-/4vFFCJpHv74J.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



RequestFactory Security: prevent the user from retrieving other users content

2011-12-02 Thread Alexander Orlov
A RF call retrieves bookings for the current user. How can I prevent the 
current user from opening Web Inspector, changing the *userId* of the RF 
call and retrive bookings from another user? A classic problem isn't it? :) 
Are there RF/GWT-specific solutions and/or best practices?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/NCtCHvkSSEQJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: RequestFactory Security: prevent the user from retrieving other users content

2011-12-02 Thread Jens
You should save the currently logged in user into a server side session 
(app server session or a general user session stored in your database) and 
use this user to fetch data from your database. Then you dont even have to 
send the userId to the server during the request. The server knows who is 
logged in.

In general you cant trust the client and its requests, so you have to 
validate them. So its up to the server to manage logged in users, 
(multi-)tenant information, access controls, etc. Basically everything that 
is security related.

-- J.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/pwQiB7wHkgQJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: RequestFactory Security: prevent the user from retrieving other users content

2011-12-02 Thread Alexander Orlov
That's what I had in mind too but I wanted to know if there is also a 
GWT-specific out-of-the-box solution.

Thx!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/Pj_a_I-ZapAJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: RequestFactory Security: prevent the user from retrieving other users content

2011-12-02 Thread Thomas Broyer
If you only look at the parameters sent with the request, you're basically 
login in everyone as an administrator.

The remedy is easy: authenticate your requests, and use the authenticated 
user to filter data on the server-side.

Either let the browser do it (using cookies or HTTP auth) or do it yourself 
(create a token for the client and associate it with a user on the 
server-side, the client sends the token with each request, which 
authenticates it on the server-side; this is basically mimicking a cookie, 
just at another level).
Only way to authenticate as another user is to steal his token (so make 
sure you make them expire).

This is only the *first* step though; security is hard, and the above is 
clearly not enough to declare your application secure.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/8tRecW0podcJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: transfer Objects between GWT and EJB

2011-12-02 Thread ph09
Hi,

but how should I represent the entities on my gwt Side?
When I create a Company Pojo there on the gwt side I would't anyway
not be able to transfer it.
Or you mean I should use Wrapper on the Servlet to transfer the
Entites from my EJB Project to Pojo's from the gwt side?

On 2 Dez., 02:53, Mark mdshol...@gmail.com wrote:
 I dont know that you can do that directly.  The best way I know of is
 to create a pojo to represent the entity on the gwt side and then
 translate back and forth between them.

 On Dec 1, 5:01 pm, ph09 ph.hei...@googlemail.com wrote:







  Hello,

  I have got a question because of the architectur of my project.
  At the one side there is a GWT Package with the Client Side and also a
  Servlet to communicate with an EJB Project.
  On the other Side there is a EJB Project with Session Beans and
  Entities which schould be stored in a database and send between GWT
  Client and the database. But I don't know how I can realize that. how
  can I send an Object from my Session Bean to the GWT Servlet, because
  the GWT Servlet don't know about the Entitities Classes.

  Thats my Project Structur:

  Entities + Session Bean:http://pastebin.com/anAbCqgd

  GWT Servlet:http://pastebin.com/Ujjka9vT

  I hope that it is clear where my problem is ;)

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: transfer Objects between GWT and EJB

2011-12-02 Thread ph09
Hi,

thank you for your answer, but this isn't my problem. I already know the 
links you have posted.
It wasn't a problem fpr me to send Strings between GWt client and a Session 
Bean and to store an entity in a database.
My problem is that I want to send Objects between GWT and EJB Project like 
the Example Company object above.
The communication between GWT servlet and Ejb project works fine. I can 
call methods and so on.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/p3l2_a2mslsJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: RequestFactory Security: prevent the user from retrieving other users content

2011-12-02 Thread Alexander Orlov
I'll go with the token approach because I assume, cookies require HTTP and 
if you want to use the same app over Web Sockets, the cookies approach 
would not work?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/QGaMBK2XUZsJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: RequestFactory Security: prevent the user from retrieving other users content

2011-12-02 Thread Thomas Broyer
According to http://www.rfc-editor.org/authors/rfc6455.txt and 
http://dev.w3.org/html5/websockets/ I'd say the cookies should be sent over 
WebSocket (for obvious reasons of authentication precisely; such as GMail 
authenticating automatically over WebSocket as it authenticates over HTTP 
when loading the web page –GMail isn't using WebSocket but I believe it's 
in the works at Google–), now in practice I guess it highly depends on both 
the browsers and the server implementations.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/uFOFjbkrytwJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT Locale does work in address bar, does not work in meta

2011-12-02 Thread Jesse
Yes, that did the trick. Thank you. What a stupid bug.

Jesse

On Dec 2, 8:53 am, kim young ill khi...@googlemail.com wrote:
 did you put it before title.
 at least it didnt work for me if i put it after title







 On Thu, Dec 1, 2011 at 5:13 PM, Jesse bek...@gmail.com wrote:
  Hi

  I have a gwt portlet with (for now) localization in English (default)
  and Dutch.

  If I put ?locale=nl in the address bar, I get nice Dutch texts.
  However, if I put meta name=gwt:property content=locale=nl  in
  the head of my html file, without any reference to locale in the
  address bar, I get the English texts. When I look into the rendered
  html source, I can see the meta tag. According to the documentation
  it should give Dutch texts.

  Does anybody have a suggestion about where I should look to fix this?
  Obviously my locale is working, but it disregards the meta property

  With kind regards

  Jesse van Bekkum

  --
  You received this message because you are subscribed to the Google Groups
  Google Web Toolkit group.
  To post to this group, send email to google-web-toolkit@googlegroups.com.
  To unsubscribe from this group, send email to
  google-web-toolkit+unsubscr...@googlegroups.com.
  For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



RE: Stuck in the StockWatch tutorial

2011-12-02 Thread Fat Charlie the Archangel

sowdri - 

 Looks like your host html is missing an element with id stockList, so 
 either add it to your host page or Use the following line, without the id 
 param, 

Bing! Ned Ryerson!

all of my commercial Java was serverside code - no UI stuff at all.
So I reckon I am still used to looking for Java errors in Java code.
You've redirected my thinking. Thanks!

jim p.
---
jim puckett
New River, Arizona

http://blog.fatcharliesdiary.com

Prayer may not change things for you,
but it for sure changes you for things.

-- Samuel M. Shoemaker




-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT in Google Products

2011-12-02 Thread Dimitrijević Ivan
A new one to add:

Google Web Fonts: http://www.google.com/webfonts

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/S3yGn1gXCMoJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT in Google Products

2011-12-02 Thread David Chandler
+ Blogger admin interface
+ AdSense

On Fri, Dec 2, 2011 at 9:30 AM, Dimitrijević Ivan dim...@gmail.com wrote:

 A new one to add:

 Google Web Fonts: http://www.google.com/webfonts

  --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To view this discussion on the web visit
 https://groups.google.com/d/msg/google-web-toolkit/-/S3yGn1gXCMoJ.

 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




-- 
David Chandler
Developer Programs Engineer
w: http://code.google.com/
b: http://turbomanage.wordpress.com/
t: @googledevtools

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT in Google Products

2011-12-02 Thread Karthik Reddy
Adding on to Thomas' list:

Google Offers  
https://www.google.com/offers/home#!details/c652fabcb4d6c381/IHN0D24723PKOO8X

Google Takeout   https://www.google.com/takeout/#custom

Google Pagespeed  https://developers.google.com/pagespeed/

Google WebFonts  http://www.google.com/webfonts

I would say the forecast for GWT is: 70 degrees (F) and Sunny. 

--
Karthik Reddy
https://plus.google.com/103243388366746199136

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/XrN6bSwDkr4J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT in Google Products

2011-12-02 Thread Karthik Reddy
[Google Groups really needs a edit answer feature like the way stack 
overflow does. Or am I missing something?]

Anyways, adding one more to the list:

Google Tables
https://www.google.com/fusiontables/DataSource?dsrcid=2049253   a table 
of countries and their citizens' wealth. 

(One could create a table from within Google docs)

--
Karthik Reddy
https://plus.google.com/103243388366746199136

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/LeQz8uK_nJ0J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Stumped: java.lang.AssertionError: No ImageRect ever computed for cellTableFooterBackground

2011-12-02 Thread laredotornado
Hi,

I'm building a Maven-GWT project using Maven 3.0.3 and GWT 2.4.  I
have included these dependencies in my pom.xml file,

dependency
groupIdcom.google.gwt/groupId
artifactIdgwt-servlet/artifactId
version${gwtVersion}/version
/dependency
dependency
groupIdcom.google.gwt/groupId
artifactIdgwt-user/artifactId
version${gwtVersion}/version
/dependency

but when I run my GWTTestCases, I get the following errors.
Specifically, the test dies at this line ...

final CellTableNode tableWidget = new
CellTableNode(KEY_PROVIDER);

Does anyone know what these are all about?  What additional steps can
I take to troubleshoot this problem?

Thanks, - Dave

Running
com.myco.clearing.product.client.xmltohtml.XmlToHtmlServiceTest
logging for HtmlUnit thread
   [WARN] Expected content type of 'application/javascript' or
'application/ecmascript' for remotely loaded JavaScript element at
'http://10.128.121.174:36346/
com.myco.clearing.product.ProductPlusJUnit.JUnit/
com.myco.clearing.product.ProductPlusJUnit.JUnit.nocache.js', but got
'application/x-javascript'.
Rebinding com.google.gwt.user.cellview.client.CellTable.Resources
   Invoking generator
com.google.gwt.resources.rebind.context.InlineClientBundleGenerator
  [ERROR] Generator
'com.google.gwt.resources.rebind.context.InlineClientBundleGenerator'
failed an assertion while rebinding
'com.google.gwt.user.cellview.client.CellTable.Resources'
java.lang.AssertionError: No ImageRect ever computed for
cellTableFooterBackground
at
com.google.gwt.resources.rg.ImageResourceGenerator.createAssignment(ImageResourceGenerator.java:
474)
at
com.google.gwt.resources.rebind.context.AbstractClientBundleGenerator.createFieldsAndAssignments(AbstractClientBundleGenerator.java:
785)
at
com.google.gwt.resources.rebind.context.AbstractClientBundleGenerator.createFieldsAndAssignments(AbstractClientBundleGenerator.java:
854)
at
com.google.gwt.resources.rebind.context.AbstractClientBundleGenerator.generateIncrementally(AbstractClientBundleGenerator.java:
460)
at
com.google.gwt.dev.javac.StandardGeneratorContext.runGeneratorIncrementally(StandardGeneratorContext.java:
647)
at
com.google.gwt.dev.cfg.RuleGenerateWith.realize(RuleGenerateWith.java:
41)
at com.google.gwt.dev.shell.StandardRebindOracle
$Rebinder.rebind(StandardRebindOracle.java:78)
at
com.google.gwt.dev.shell.StandardRebindOracle.rebind(StandardRebindOracle.java:
268)
at
com.google.gwt.dev.shell.ShellModuleSpaceHost.rebind(ShellModuleSpaceHost.java:
141)
at
com.google.gwt.dev.shell.ModuleSpace.rebind(ModuleSpace.java:585)
at
com.google.gwt.dev.shell.ModuleSpace.rebindAndCreate(ModuleSpace.java:
455)
at
com.google.gwt.dev.shell.GWTBridgeImpl.create(GWTBridgeImpl.java:49)
at com.google.gwt.core.client.GWT.create(GWT.java:97)
at
com.google.gwt.user.cellview.client.CellTable.getDefaultResources(CellTable.java:
468)
at
com.google.gwt.user.cellview.client.CellTable.init(CellTable.java:
549)
at
com.google.gwt.user.cellview.client.CellTable.init(CellTable.java:
526)
at
com.myco.clearing.product.client.xmltohtml.XmlToHtmlServiceImpl.getTableWidget(XmlToHtmlServiceImpl.java:
314)
at
com.myco.clearing.product.client.xmltohtml.XmlToHtmlServiceImpl.getWidget(XmlToHtmlServiceImpl.java:
82)
at
com.myco.clearing.product.client.xmltohtml.XmlToHtmlServiceTest
$12.onSuccess(XmlToHtmlServiceTest.java:605)
at
com.myco.clearing.product.client.xmltohtml.XmlToHtmlServiceTest
$12.onSuccess(XmlToHtmlServiceTest.java:1)
at
com.google.gwt.user.client.rpc.impl.RequestCallbackAdapter.onResponseReceived(RequestCallbackAdapter.java:
232)
at
com.google.gwt.http.client.Request.fireOnResponseReceived(Request.java:
287)
at com.google.gwt.http.client.RequestBuilder
$1.onReadyStateChange(RequestBuilder.java:395)
at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown
Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:
25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)
at
com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)
at
com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:
172)
at

Re: GWT in Google Products

2011-12-02 Thread anatoly techtonik
That's impressive, and it makes GWT look awesome. Thanks for the /webfonts 
- it's the next new thing I will definitely use in the nearest future. =)

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/J1BUZPhtRngJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: CellTable column and cell style

2011-12-02 Thread divStar
I still couldn't manage to find a way to hide the column header names.
Does noone really have an idea of how to solve this issue? I tried
everything I could, but I just can't seem to make it work. Please,
help me.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Need a sample application using channels

2011-12-02 Thread riyaz ahmed
Hi,
Can anyone help me out on creating an end to end channel application

Thanks in advance
-- 
Riyaz

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



[gwt-contrib] Re: FF8 Devmode Plugin (issue1589803)

2011-12-02 Thread conroy

On 2011/11/14 17:53:37, conroy wrote:

http://gwt-code-reviews.appspot.com/1589803/diff/1/plugins/xpcom/ExternalWrapper.cpp

File plugins/xpcom/ExternalWrapper.cpp (right):



http://gwt-code-reviews.appspot.com/1589803/diff/1/plugins/xpcom/ExternalWrapper.cpp#newcode28

plugins/xpcom/ExternalWrapper.cpp:28: #include

nsIDOMWindowInternal.h

I still see unguarded references to nsIDOMWindowInternal in this file.



http://gwt-code-reviews.appspot.com/1589803/diff/1/plugins/xpcom/Makefile

File plugins/xpcom/Makefile (right):



http://gwt-code-reviews.appspot.com/1589803/diff/1/plugins/xpcom/Makefile#newcode138

plugins/xpcom/Makefile:138: MOZALLOC_DLLFLAGS = -lmozalloc
On 2011/11/11 10:16:05, tbroyer wrote:
 In http://gwt-code-reviews.appspot.com/1560803/ we talked about

refactoring

the
 MOZALLOC_DLLFLAGS, MOZJS_DLLFLAGS and ALLARCHCFLAGS before the 'ifeq
 ($(BROWSER),FF40)' (just after line 94) instead of copy/pasting them

in each

 version.



indeed. please make this change.

FYI

ping!

http://gwt-code-reviews.appspot.com/1589803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: FF8 Devmode Plugin (issue1589803)

2011-12-02 Thread acleung

http://gwt-code-reviews.appspot.com/1589803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: FF8 Devmode Plugin (issue1589803)

2011-12-02 Thread acleung

On 2011/12/02 21:26:45, acleung wrote:

PTAL.

Thanks.

-Alan

http://gwt-code-reviews.appspot.com/1589803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: FF8 Devmode Plugin (issue1589803)

2011-12-02 Thread conroy

LGTM + nit


http://gwt-code-reviews.appspot.com/1589803/diff/7001/plugins/xpcom/Makefile
File plugins/xpcom/Makefile (right):

http://gwt-code-reviews.appspot.com/1589803/diff/7001/plugins/xpcom/Makefile#newcode141
plugins/xpcom/Makefile:141: endif
nit: you could make these all independent if statements (rather than
chained if-elses) and then check that the GECKO_VERSION is set to
something at the end.

If make weren't such an abomination of a syntax, this wouldn't be an
issue.

http://gwt-code-reviews.appspot.com/1589803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors