Re: GWT ui:style how big of a bad idea (or not) is it to use it?
Thank you all for your replies, And In general I tend to agree that you should not promote tight coupling between your app functionality and the presentation styles. On the other hand, Ryan Shillington, JQuery is javascript, but as you know most Great Jscript libraries jave wrappers for GWT. That is the case with jquery, http://code.google.com/p/gwt-jquery/. So yes, you can use JQuery from withing GWT. Another thing is, say, for example that in page that you are rendered you have a list of row and each of these rows has a cless ODD or EVEN. Say that you want to hide away all ODD rows. Why would it be best to have your GWT code traverse every single row in the set an based on your index % 2 decide weather or not collapse it, than have a CSS selector in gwt-jquery kill away all ODD rows? Much less code! I would normally live very well wich such a depencency, provided that if would be making my code use a CSS resource getter to find out the ODD classname. My kindest regards, Nuno. On Saturday, August 4, 2012 11:33:09 PM UTC+2, Joseph Lust wrote: To start with CSSResource is awesome and I highly recommend using it. It forces you to program *better*. Should you really be trying to pull elements out of the page depending on their CSS names? Seems like a bad day if you ever want to rebrand or dress up your UI. If CSS is the graphical dressing of the site, separate those concerns from the functional aspects. Further, using those CSSResource interfaces keeps you from ever using string literals in your Java code or UiBinders, which is a best practice. Additionally, with UI Automation tests our testers are tempted to use ugly selectors based on class names. This is a poor idea because then a class name changes a year later and 400 tests fail, even though functionally the site works just as well as before. The real question here is what you want to do with your CSS. If you want to apply rules the site over, then don't use ui:style, but rather a CSSResource interface. This way that interface can be used by many widgets' UiBinders. However bespoke, small CSS tweaks do fit nicely into ui:style and you can always move them out to a CSSResource interface in the future if you want to use them multiple places. Note, from my experience you cannot well handle CSS inheritance/overriding between widgets with ui:style, but you can with standalone CSSResource interfaces. Sincerely, Joseph -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/WyVpjyTcYf8J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: jQuery sortable list with GWT
On Sunday, August 5, 2012 6:40:13 PM UTC-4, CSchulz wrote: GWT doesn't have any native support for this sort of thing, that's why I'm trying to drop in some basic jquery code. gwt-dnd ( http://code.google.com/p/gwt-dnd/) works pretty well for this sort of thing. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/DgbiY4DS_pkJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: facebook authentication
https://github.com/fernandezpablo85/scribe-java/ On Tuesday, August 7, 2012 4:37:44 PM UTC+2, aamonten wrote: Hi, developing an app and would like to use facebook api to do user authentication. Does any has a pointer about how to do this integrated with GWT? thanks Alejandro -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/5lpNJMCAm0YJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: GWT future
gwtp should release a 0.8 or 1.0 version soon. See https://groups.google.com/d/topic/gwt-platform/h-4KPGKFIoM/discussion On Wednesday, August 8, 2012 10:23:04 PM UTC+2, David wrote: That would be gwt-platform as in gwtP http://code.google.com/p/gwt-platform. I'm not looking for comparisons to other MVP solutions. I'm just wondering if gwtP is something that will continue to be developed. thanks. On Wednesday, August 8, 2012 1:20:19 PM UTC-4, Stevko wrote: David, Its a BUY-long on my list. Seeing the huge line of peeps waiting for the history future session was a sure signal that there is a lot of interest (outside of google). The volume of GWT recruiter hits on my LinkedIn profile means there is new work being done, Moving to an external F/OSS respository and master commiters will increase the velocity of the framework rather than waiting months years for google to vet the commits to protect the stability of their internal systems. (see my signature for my philosophy) Not to say its a sure bet. Growing up is hard to do... On Wed, Aug 8, 2012 at 7:56 AM, David lev...@gmail.com wrote: Anyone have insight as to the future of gwt-platform? -- -- A. Stevko === If everything seems under control, you're just not going fast enough. M. Andretti -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/Nen0TW0U0G8J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: GWT ui:style how big of a bad idea (or not) is it to use it?
you have a list of row and each of these rows has a cless ODD or EVEN. Say
that you want to hide away all ODD rows.
Why would it be best to have your GWT code traverse every single row in
the set an based on your index % 2 decide weather or not collapse it, than
have a CSS selector in gwt-jquery kill away all ODD rows?
Set a class 'odd' and 'even' and place those on each row when you make
them. Then just use a CSS selector to show or hide all 'odd' rows by
element.addClassName('hideOdd') on the parent container. Just a single
operation in GWT.
Sincerely,
Joseph
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To view this discussion on the web visit
https://groups.google.com/d/msg/google-web-toolkit/-/YVauwMIIAaQJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Examples and implementation of Dynamic String Internationalization for UIBinder and its classes.
Nataraj, I know you don't want to redeploy you application each time a string changes, but calling an external service can also complicate things. I say this from experience as a group at my company did a very large (200K line, 400 screen) GWT app last year which had to work in many languages. They did not use the GWT i18n tools because the company wanted to use a service like you describe. However, the result was a much slower application because various parts of the GWT code had to wait for the i18n files to be loaded from the company's (very slow) i18n service before it could render anything on a given page or screen. In hindsight, they wish they had used the GWT i18n facilities since such strings rarely are ever changed in production. Hope that helps. Sincerely, Joseph -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/6r9JasqdCJ8J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
GWT Multi-Module Server Classpath Problem
I have a 2yo GWT project that's getting a little big for a single module, and we're bringing in a new project and we'd like to share some code. Accordingly, I've split the project into a 'common' codebase and a project-specific codebase. That split isn't perfect yet, but I can't seem to get Eclipse to launch the project. If I launch the project through mvn gwt:run, it launches successfully, but if I launch it through Eclipse (Run As Web Application) the server part fails to start up when a filter can't find the SLF4J LoggerFactory. If I do some introspection on the classpath from the servlet, it seems like all of the JARs in the project aren't on the classpath -- only the classes and dependent projects are there. The launch configuration classpath seems ok, and the command-line startup seems to work. It doesn't seem to matter if I use m2e (with its Maven Dependencies container) or mvn eclipse:eclipse, which adds the JARs to the project .classpath directly. I'm running low on ideas. So: 1. Anyone experience this or something like it and know what I should look for? 2. How does the server get its classpath -- from the launch configuration classpath or something different? 3. Is anyone using multiple eclipse projects with the Google Eclipse Plugin successfully? (from other threads, it sounded like there were people who had it working, but ...) Any other thoughts or suggestions welcome. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/ty-qiodo-4wJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Problems sorting Column in CellTable
Hi all, I am using GWT 2.5 to create a CellTable with a sortable Date column. All goes well until I click on the sortable column's header, but its not responsive. Details here: http://stackoverflow.com/questions/11883811/header-of-sortable-celltable-column-not-responsive Any help is greatly appreciated. Thanks! Pete -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/JXeEL1p4d4QJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
GWT and automated testing tools
I'm having some performance issues using Rational Functional Tester as an automated testing tool when testing a web app built on GWT. Can anyone recommend an automated tool that works and plays well with GWT? Thanks! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/g3DtPqxfvJwJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
GWT 2.0.0 DevMode: Strange warning when RPC with some object as parameter
Hi all, when I updated my project from GWT 2.0.0 to 2.4.0, noticed that in window GWT Development Mode at Jetty tab there is a warning: [WARN] Server class 'junit.framework.AssertionFailedError' could not be found in the web app, but was found on the system classpath [WARN] Adding classpath entry 'file:/C:/eclipse.Indigo/plugins/org.junit_4.8.2.v4_8_2_v20110321-1705/junit.jar' to the web app classpath for this session I found it appears when RPC method that takes an object, such as java.util.Date (not String and not null) or some my class. How to get rid of this warning? I do not think is a good idea to copy junit.jar into the directory war\WEB-INF\lib. (OS: Windows 7; IDE: Eclipse Indigo) Thank you in advance -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/0839-QvvhCQJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
DialogBox won't get CSS attribute box-shadow
Hi everyone, I have a DialogBox an want to add a box-shadow to it. So at the end it should look like endversion.png. But when I write my DialogBox class and use the method setStylePrimaryName() or setStyleName() the given String would be applied to the DialogBox. CSS attributes like border-radius or background-color are shown in FireBug but the attribute box-shadow is missing. Any sugesstions ? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/tPxuqfWgpr0J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. attachment: endversion.PNG
Re: DevMode not working in Chrome after update
Same here with Version 21.0.1180.57 Come on, Google! On Tuesday, July 17, 2012 7:16:03 AM UTC-7, Andy wrote: I updated Chrome this morning and now when I try to use DevMode I get an error Could not load GWT DevMode Plugin and an offer to Download the GWT Developer Plugin. When I try to download it (it's already installed), it says Extensions, apps, and user scripts can only be added from the Chrome Web Store. and there's no GWT plugin in the store. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/jc7Pcbel2rMJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Tree View
please specify is it the smartgwt tree grid or gwt cell tree? On Thu, Aug 9, 2012 at 2:12 AM, Thad thad.humphr...@gmail.com wrote: If you mean a CellTree, you're gonna need to generate a List for each level of your tree. See the second example in http://google-web-toolkit.googlecode.com/svn/javadoc/2.4/com/google/gwt/user/cellview/client/CellTree.html On Wednesday, August 8, 2012 2:18:30 AM UTC-4, Praveen Jesudoss wrote: HI, I want to show tree view in my application. From db i retrieved data like level,id,name,parent id. I stored this in array list. now i want to show the data in tree view. i am not able to get correct parent node and child. Please help me to achieve this. Thanks and Regards, Praveen J -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/39lqZsRvRCsJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: DevMode not working in Chrome after update
Same issue here - no GWT Developer extension in the App Store, and it won't install otherwise. This happens on both my Mac (OS X 10.7) and Linux machines (Fedora 16). Also, developer plugin apparently only supported in Firefox verisons 3-10.0, but current version is 14.0. Do I really have to regress four versions of Firefox just to install the plugin? On Tuesday, July 17, 2012 8:16:03 AM UTC-6, Andy wrote: I updated Chrome this morning and now when I try to use DevMode I get an error Could not load GWT DevMode Plugin and an offer to Download the GWT Developer Plugin. When I try to download it (it's already installed), it says Extensions, apps, and user scripts can only be added from the Chrome Web Store. and there's no GWT plugin in the store. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/C4RDO7TQk6IJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Can't get touch handlers to fire?
Hi,
I can't get touch handlers to fire:
RootPanel rp = RootPanel.get(dummy);
rp.sinkEvents(Event.TOUCHEVENTS);
rp.addHandler(new TouchStartHandler() {
@Override
public void onTouchStart(TouchStartEvent event) {
// touch down!
}
}, TouchStartEvent.getType());
What am I missing?
Thanks
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To view this discussion on the web visit
https://groups.google.com/d/msg/google-web-toolkit/-/ytcG1GLoQUIJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Can't get touch handlers to fire?
I can't get touch handlers to fire: see this http://stackoverflow.com/questions/11875484/how-to-use-touch-handlers-does-gwt-support-them/11875997#11875997 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: GWT and automated testing tools
Selenium is suggested in a book Essential GWT Building for web with Google Web Toolkit 2. I never touched. Can anyone give some samples if it is a good solution for GWT auto test? Thanks. 2012/8/9 Ocean_Living winteried...@gmail.com I'm having some performance issues using Rational Functional Tester as an automated testing tool when testing a web app built on GWT. Can anyone recommend an automated tool that works and plays well with GWT? Thanks! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/g3DtPqxfvJwJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- Gong Min gongmin...@gmail.com -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
YUIGWT - YUI 3 in GWT
I just started a YUI 3 http://yuilibrary.comJava GWT API. It is a GWT library for using YUI 3. Project home page: http://code.google.com/p/yuigwt/ http://code.google.com/p/yuigwt/ Example Gallery with online Java sources :http://cancerbero.vacau.com/yuigwt/ It is 99% overlay types, and the syntax try to emulate YUI JavaScript syntax statements as much as possible. (see JavaScript YUI code compared to its YUIGWT Java code equivalent: http://code.google.com/p/yuigwt/wiki/equivalentCodeCompared ) The project is very very new, but a general pattern for migrating all the YUI JavaScript API to Java was found, using 100% GWT Overlay types for a zero overhead Java API. A lot of components are already ready to be used, check the example gallery that will reflect current progress. I must say, I must to give thanks to eclipse java templates for writing GWT overlay methods; it is speeding my code a lot. Any suggestions or ideas are most welcome. Regards, -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/fVGkaVLc8ZEJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
[gwt-contrib] Re: Added SetSelectionModel interface and made Single- and MultiSelectionModels (issue1798806)
On 2012/08/08 22:25:10, skybrian wrote: Any reason clear() can't be moved into SelectionModel and not make SingleSelectionModel implement SetSelectionModel? It seems misleading to make SingleSelectionModel extend SetSelectionModel when it only deals with one element. http://gwt-code-reviews.appspot.com/1798806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Implemented a subset of the bootstrap configuration which allows for Validator customization. (issue1807803)
minor nit. LGTM http://gwt-code-reviews.appspot.com/1807803/diff/1/user/src/com/google/gwt/validation/client/impl/BaseGwtConfiguration.java File user/src/com/google/gwt/validation/client/impl/BaseGwtConfiguration.java (right): http://gwt-code-reviews.appspot.com/1807803/diff/1/user/src/com/google/gwt/validation/client/impl/BaseGwtConfiguration.java#newcode52 user/src/com/google/gwt/validation/client/impl/BaseGwtConfiguration.java:52: this.properties = new HashMapString, String(); move this to the declaration. http://gwt-code-reviews.appspot.com/1807803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Added SetSelectionModel interface and made Single- and MultiSelectionModels (issue1798806)
The idea is that any SingleSelectionModel can be thought of as a set that contains either zero or one items. So it seems appropriate that it should have the new methods - and after all, the whole point is to be able to treat them uniformly. SetSelectionModel isn't intended to imply that the SelectionModel can contain multiple items; if that's unclear, perhaps it needs to be clarified somehow? http://gwt-code-reviews.appspot.com/1798806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1806803)
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/pom.xml
File samples/mobilewebapp/pom.xml (right):
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/pom.xml#newcode183
samples/mobilewebapp/pom.xml:183: target1.6/target
Change tabs to spaces
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/pom.xml#newcode200
samples/mobilewebapp/pom.xml:200: version2.3.0-1/version
While you are at it, can we update this to a newer version?
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthenticationFailureEvent.java
File
samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthenticationFailureEvent.java
(right):
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthenticationFailureEvent.java#newcode2
samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthenticationFailureEvent.java:2:
* Copyright 2010 Google Inc.
Why the change in year?
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/client/ReloadOnAuthenticationFailure.java
File
samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/client/ReloadOnAuthenticationFailure.java
(right):
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/client/ReloadOnAuthenticationFailure.java#newcode29
samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/client/ReloadOnAuthenticationFailure.java:29:
public HandlerRegistration register(EventBus eventBus) {
Not in alphabetical order. Also, other than the order, changes in lines
26 to 32 seem to be unnecessary.
http://gwt-code-reviews.appspot.com/1806803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1806803)
If you implement login and logout link in a JSP, you can remove all the
user service wrapper stuff.
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/server/GaeAuthFilter.java
File
samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/server/GaeAuthFilter.java
(right):
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/server/GaeAuthFilter.java#newcode64
samples/mobilewebapp/src/main/java/com/google/gwt/sample/gaerequest/server/GaeAuthFilter.java:64:
private static String generateHomePageURL(String requestURL, String
queryString) {
A comment would be nice. What is this doing and why? So we don't lose
the rationale involving /gwtRequest
http://gwt-code-reviews.appspot.com/1806803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Changed package structure with the intention of keeping the client package clean of all classe... (issue1807804)
Reviewers: Nick Chalko, cromwellian, Description: Changed package structure with the intention of keeping the client package clean of all classes which the user should not see (implementation-specific). [JSR 303 TCK Result] 191 of 204 (93.63%) Pass with 12 Failures and 0 Errors. Please review this at http://gwt-code-reviews.appspot.com/1807804/ Affected files: D user/src/com/google/gwt/validation/client/Group.java D user/src/com/google/gwt/validation/client/GroupChain.java D user/src/com/google/gwt/validation/client/GroupChainGenerator.java D user/src/com/google/gwt/validation/client/GroupValidator.java D user/src/com/google/gwt/validation/client/ValidationGroupsMetadata.java M user/src/com/google/gwt/validation/client/impl/AbstractGwtSpecificValidator.java M user/src/com/google/gwt/validation/client/impl/AbstractGwtValidator.java D user/src/com/google/gwt/validation/client/impl/BeanMetadata.java M user/src/com/google/gwt/validation/client/impl/ConstraintFinderImpl.java M user/src/com/google/gwt/validation/client/impl/ConstraintValidatorContextImpl.java A user/src/com/google/gwt/validation/client/impl/Group.java A user/src/com/google/gwt/validation/client/impl/GroupChain.java A user/src/com/google/gwt/validation/client/impl/GroupChainGenerator.java A user/src/com/google/gwt/validation/client/impl/GroupValidator.java M user/src/com/google/gwt/validation/client/impl/GwtBeanDescriptor.java M user/src/com/google/gwt/validation/client/impl/GwtBeanDescriptorImpl.java M user/src/com/google/gwt/validation/client/impl/GwtSpecificValidator.java D user/src/com/google/gwt/validation/client/impl/MessageAndPath.java M user/src/com/google/gwt/validation/client/impl/PropertyDescriptorImpl.java A user/src/com/google/gwt/validation/client/impl/metadata/BeanMetadata.java A user/src/com/google/gwt/validation/client/impl/metadata/MessageAndPath.java A user/src/com/google/gwt/validation/client/impl/metadata/ValidationGroupsMetadata.java M user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java M user/src/com/google/gwt/validation/rebind/ValidatorCreator.java M user/test/com/google/gwt/validation/ValidationClientJreSuite.java D user/test/com/google/gwt/validation/client/ValidationGroupsMetadataTest.java A user/test/com/google/gwt/validation/client/impl/metadata/ValidationGroupsMetadataTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Changed package structure with the intention of keeping the client package clean of all classe... (issue1807804)
lgtm http://gwt-code-reviews.appspot.com/1807804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
