[gwt-contrib] Re: Add ProxySerializer API to provide EntityProxy persistence primitives. (issue1148801)

2010-11-24 Thread cramsdale 

LGTM

http://gwt-code-reviews.appspot.com/1148801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removing the Expenses sample from bikeshed now that it has been converted to a sample. I'm leav... (issue791801)

2010-08-23 Thread cramsdale 

LGTM

http://gwt-code-reviews.appspot.com/791801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Updated common.ant.xml to copy pom.xml (if found) to build/out (issue782801)

2010-08-19 Thread cramsdale 

Reviewers: rice_google.comm,

Description:
Updated common.ant.xml to copy pom.xml (if found) to  build/out
Added .place-holder to ensure war dir existence


Please review this at http://gwt-code-reviews.appspot.com/782801/show

Affected files:
  M samples/build.xml
  M samples/common.ant.xml
  A samples/expenses/war/.place-holder


Index: samples/build.xml
===
--- samples/build.xml   (revision 8573)
+++ samples/build.xml   (working copy)
@@ -61,6 +61,12 @@
 /antcall
   /target

+  target name=source description=Static analysis of GWT source
+antcall target=-do
+  param name=target value=source /
+/antcall
+  /target
+
   target name=test description=Test GWT
 antcall target=-do
   param name=target value=test /
Index: samples/common.ant.xml
===
--- samples/common.ant.xml  (revision 8573)
+++ samples/common.ant.xml  (working copy)
@@ -37,6 +37,12 @@
 copy todir=${sample.build}/war
   fileset dir=war excludes=WEB-INF/classes/**/
 /copy
+if
+  available file=pom.xml/
+  then
+copy tofile=${sample.build}/pom.xml file=pom.xml/
+  /then
+/if
   /target

   target name=compile description=Compile all java files
Index: samples/expenses/war/.place-holder
===
--- samples/expenses/war/.place-holder  (revision 0)
+++ samples/expenses/war/.place-holder  (revision 0)


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updated common.ant.xml to copy pom.xml (if found) to build/out (issue782801)

2010-08-19 Thread cramsdale 

http://gwt-code-reviews.appspot.com/782801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Tightened up datanucleus paths to include only **/domain/*.class (issue776802)

2010-08-19 Thread cramsdale 

Reviewers: Ray Ryan,

Description:
Tightened up datanucleus paths to include only **/domain/*.class

Merged over a few remaining changes from bikeshed


Please review this at http://gwt-code-reviews.appspot.com/776802/show

Affected files:
  M samples/expenses/pom.xml
  M  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java
  M  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseList.java
  M  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java
  M  
samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportList.java



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding missing package descriptions to javadoc

2010-03-11 Thread cramsdale 

LGTM

http://gwt-code-reviews.appspot.com/176801

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RichTextArea.BasicFormatter deprecated comment in JavaDocs

2010-01-11 Thread cramsdale 

LGTM

http://gwt-code-reviews.appspot.com/130801
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update IE plugin installer to install for the current user only (for real)

2009-11-19 Thread cramsdale 
I assume that uninstallation is handled by the .msi that installed the
components in the first place, and as such this patch does not need to
account for uninstallation of the RC plugin. Correct?

http://gwt-code-reviews.appspot.com/106804

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Dynatable still refers to hosted mode instead of development mode

2009-11-18 Thread cramsdale 
LGTM

http://gwt-code-reviews.appspot.com/103809

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update IE plugin installer to install for the current user only

2009-11-17 Thread cramsdale 
Meta installer omits the build number. You'll need to update the patch
number to be safe.

http://gwt-code-reviews.appspot.com/104805

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors