[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
Thanks for the patch! But do you mind reuploading it to https://gwt-review.googlesource.com/gwt so we can review and merge it there? http://gwt-code-reviews.appspot.com/1832803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
On 2013/05/16 19:35:21, mdempsky wrote: Thanks for the patch! But do you mind reuploading it to https://gwt-review.googlesource.com/gwt so we can review and merge it there? Oops, sorry, the link is just https://gwt-review.googlesource.com http://gwt-code-reviews.appspot.com/1832803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: corrects typos (issue1902803)
Face palm. Does this break backwards compatibility at all? E.g., are any of the permuation methods user accessible? Do we need to add @Deprecated forwarding methods for them? http://gwt-code-reviews.appspot.com/1902803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: corrects typos (issue1902803)
On 2013/04/17 23:12:34, mdempsky wrote: Face palm. (And that's at the typos being overlooked for so long, not at the patch!) http://gwt-code-reviews.appspot.com/1902803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Set visibility:hidden on the ruler element in LayoutImpl (issue1851803)
On 2013/04/01 14:36:56, bruno.ferreira wrote: Is this problem solved on GWT 2.5.1? I believe so. This patch was merged and included in GWT 2.5.1. http://gwt-code-reviews.appspot.com/1851803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
LGTM http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java
File user/src/com/google/gwt/animation/client/Animation.java (right):
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java#newcode203
user/src/com/google/gwt/animation/client/Animation.java:203: * Is the
animation running, even if it hasn't started yet.
Returns true if the animation is running, even if it hasn't started
yet.
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java#newcode205
user/src/com/google/gwt/animation/client/Animation.java:205: protected
boolean isRunning() {
Why protected? Since the running() and cancel() methods are public, I'd
imagine there are callers who would be interested in this method being
public.
http://gwt-code-reviews.appspot.com/1891804/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
On 2013/02/28 01:45:15, jtam wrote: Switched to Public. Not sure what you would like me to do in terms of unit tests. This is just exposing an internal which should be already tested. I think just adding appropriate asserts for isRunning()'s return value to AnimationTest would be sufficient. So that in the future if we refactor Animation, that we don't suddenly change the behavior inadvertently. http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Fix for typo in JsJsonString (issue1802804)
On 2013/01/29 22:54:41, goktug wrote: Can you add a test case? It looks like that line is not covered in any test cases. I think it should be covered by JsonUtilTest.java already, but it looks like we don't actually test that in production mode. Also, I think we don't run the elemental test suite internally at the moment. :/ http://gwt-code-reviews.appspot.com/1802804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Fix for typo in JsJsonString (issue1802804)
LGTM http://gwt-code-reviews.appspot.com/1802804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Issue 7112 (issue1649803)
On 2013/01/12 15:35:19, tbroyer wrote: We're in dev-time code so we can use Guava (the re-packaged one) and it's Objects.equal(a, b) which takes care of nulls. I don't think that's true. This code still needs to be translatable to JavaScript to support running tests in production mode, and I don't believe our thirdparty.guava package is available for translation. Maybe in the future we can utilize JDK7's Objects.equals(), but at the moment we have to resort to reimplementing it ourselves here I think. http://gwt-code-reviews.appspot.com/1649803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Devmode broken with elemental (#7481) (issue1801804)
http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java
File core/src/com/google/gwt/dev/shell/DispatchClassInfo.java (right):
http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java#newcode86
core/src/com/google/gwt/dev/shell/DispatchClassInfo.java:86: Integer id
= memberIdByMember.get(m);
Is this a very heavily used function and/or does memberBy[Member]Id get
very large normally? If not, would it be simpler to just do:
int id = memberById.indexOf(m);
if (id == -1) {
id = memberById.size();
memberById.add(m);
}
memberIdByName.put(StringInterner.get().intern(name), id);
http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java#newcode90
core/src/com/google/gwt/dev/shell/DispatchClassInfo.java:90:
memberIdByName.put(StringInterner.get().intern(name), id);
I know this was preexisting practice, but why are we interning strings
here? It doesn't seem to serve any purpose except to use use
interned-strings storage.
http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java#newcode237
core/src/com/google/gwt/dev/shell/DispatchClassInfo.java:237:
memberByMemberId = new HashMapInteger, Member(32767);
Why 32767? Won't it size up appropriately, or will the table very
frequently have 32767 members?
http://gwt-code-reviews.appspot.com/1801804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: GWT does not normalize IE mangling from http 204 code to 1223 (Issue 5031) (issue1875803)
Thanks for the patch. If you don't mind, could you try uploading the next revision to Gerrit insead? See instructions at: https://groups.google.com/d/msg/google-web-toolkit-contributors/fmHDlsnfdEQ/fc6lvNdxROQJ If that proves to be too much work though, you can continue using Rietveld. http://gwt-code-reviews.appspot.com/1875803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: GWT does not normalize IE mangling from http 204 code to 1223 (Issue 5031) (issue1875803)
http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml File user/src/com/google/gwt/http/HTTP.gwt.xml (right): http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml#newcode31 user/src/com/google/gwt/http/HTTP.gwt.xml:31: when-property-is Why is this wrapped? It looks like each when-property-is element should fit on a single line. http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImplIE69.java File user/src/com/google/gwt/http/client/RequestImplIE69.java (right): http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImplIE69.java#newcode28 user/src/com/google/gwt/http/client/RequestImplIE69.java:28: final Response original = super.createResponse(xmlHttpRequest); This requires two objects to be created instead of one. Could you instead change the anonymous Response classes into actual response classes so that RequestImplIE69's Response implementation can extend and override RequestImpl's Response implementation? Then RequestImplIE69.createResponse() should only need to create one object and not need so many boiler plate forwarding methods. http://gwt-code-reviews.appspot.com/1875803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update devmode Firefox plugin to support Firefox 17 on the Mac: (issue1872803)
LGTM http://gwt-code-reviews.appspot.com/1872803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add Windows DLL for Firefox 17 to dev mode plugin. (issue1871803)
LGTM http://gwt-code-reviews.appspot.com/1871803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update devmode Firefox plugin to support Firefox 17 on 64-bit Linux. (issue1870803)
LGTM http://gwt-code-reviews.appspot.com/1870803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Move non-GWTTestCase tests in RpcSuite to RpcSuiteNoBrowser, (issue1868803)
LGTM http://gwt-code-reviews.appspot.com/1868803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Minor cleanup in SerializableTypeOracleBuilder: (issue1869803)
LGTM too. http://gwt-code-reviews.appspot.com/1869803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: CSS Media types are comma separated. (issue1861804)
http://gwt-code-reviews.appspot.com/1861804/diff/1/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java File user/src/com/google/gwt/resources/css/CssGenerationVisitor.java (right): http://gwt-code-reviews.appspot.com/1861804/diff/1/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java#newcode192 user/src/com/google/gwt/resources/css/CssGenerationVisitor.java:192: spaceOpt(); I think the first space is mandatory, no? Otherwise won't compact output get something like @mediafoo,bar instead of @media foo,bar? http://gwt-code-reviews.appspot.com/1861804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: CSS Media types are comma separated. (issue1861804)
LGTM http://gwt-code-reviews.appspot.com/1861804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Thanks minichate! (issue1863803)
LGTM too http://gwt-code-reviews.appspot.com/1863803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Chrome devmode plugin: recompile Windows DLL to be statically linked. (issue1860803)
LGTM http://gwt-code-reviews.appspot.com/1860803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Chrome plugin: don't use an iterator after the underlying entry has been freed. (issue1861803)
LGTM, nice catch. http://gwt-code-reviews.appspot.com/1861803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)
http://gwt-code-reviews.appspot.com/1859803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)
http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java
File
user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java
(right):
http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java#newcode224
user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java:224:
if (args.length 2) {
On 2012/10/24 20:37:40, jtamplin wrote:
Should this be public so other tools have a way to run it in-process
without
having to worry about the System.exit call?
Sounds reasonable to me. I'll upload a revised patch set in a moment.
http://gwt-code-reviews.appspot.com/1859803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)
http://gwt-code-reviews.appspot.com/1859803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)
http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java
File
user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java
(right):
http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java#newcode216
user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java:216:
protected JavaCompiler getJavaCompiler() {
For no particular reason, I was trying to defer creating the
JavaCompiler until it's actually needed. If this code was already using
JSR330, I'd add a constructor that takes a ProviderJavaCompiler and
handle it that way. Since it's not and I don't expect to see too many
custom ValidationTool subclasses, just adding an override method seemed
the least intrusive solution.
http://gwt-code-reviews.appspot.com/1859803/diff/6001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java
File
user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java
(right):
http://gwt-code-reviews.appspot.com/1859803/diff/6001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java#newcode212
user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java:212:
public void run(String[] args) throws IOException {
On 2012/10/24 20:56:48, tbroyer wrote:
Er, why this method?
Mostly so that I can just write:
class FancyValidationTool extends ValidationTool {
public static void main(String[] args) throws IOException {
new FancyValidationTool().run(args);
}
protected JavaCompiler getJavaCompiler() { ... }
}
I could reproduce the System.exit() logic in FancyValidationTool too,
but this way just seemed simpler (and ValidationTool already does things
like write to System.err directly). I'm fine with making main()
responsible for calling System.exit() if you find this way distasteful.
http://gwt-code-reviews.appspot.com/1859803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)
Alternatively, take a look at Patch Set #1, which simply added an extra parameter to exec() to pass in a custom JavaCompiler instance. Would that patch (updated to make the exec() methods public) be preferable? http://gwt-code-reviews.appspot.com/1859803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)
http://gwt-code-reviews.appspot.com/1859803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Replace instances of element.setInnerHTML(safeHtml.asString()) (issue1857803)
Reviewers: skybrian, tbroyer,
Description:
Replace instances of element.setInnerHTML(safeHtml.asString())
with element.setInnerSafeHtml(safeHtml).
Please review this at http://gwt-code-reviews.appspot.com/1857803/
Affected files:
M
samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidgetView.java
M user/src/com/google/gwt/cell/client/AbstractCell.java
M user/src/com/google/gwt/cell/client/ImageLoadingCell.java
M user/src/com/google/gwt/dom/builder/client/DomBuilderImpl.java
M user/src/com/google/gwt/dom/builder/shared/HtmlBuilderImpl.java
M user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
M user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
M user/src/com/google/gwt/user/cellview/client/CellBrowser.java
M user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
M user/src/com/google/gwt/user/cellview/client/CellWidget.java
M user/src/com/google/gwt/user/client/ui/RenderablePanel.java
M user/src/com/google/gwt/user/client/ui/impl/ClippedImageImpl.java
M user/test/com/google/gwt/cell/client/ImageLoadingCellTest.java
M user/test/com/google/gwt/uibinder/test/client/UiRendererEventsTest.java
M user/test/com/google/gwt/uibinder/test/client/UiRendererTest.java
Index:
samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidgetView.java
===
---
samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidgetView.java
(revision 11343)
+++
samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidgetView.java
(working copy)
@@ -56,7 +56,7 @@
}
public void setDescription(SafeHtml html) {
-descElem.setInnerHTML(html.asString());
+descElem.setInnerSafeHtml(html);
}
public void setExample(Widget widget) {
Index: user/src/com/google/gwt/cell/client/AbstractCell.java
===
--- user/src/com/google/gwt/cell/client/AbstractCell.java (revision 11343)
+++ user/src/com/google/gwt/cell/client/AbstractCell.java (working copy)
@@ -135,7 +135,7 @@
public void setValue(Context context, Element parent, C value) {
SafeHtmlBuilder sb = new SafeHtmlBuilder();
render(context, value, sb);
-parent.setInnerHTML(sb.toSafeHtml().asString());
+parent.setInnerSafeHtml(sb.toSafeHtml());
}
/**
Index: user/src/com/google/gwt/cell/client/ImageLoadingCell.java
===
--- user/src/com/google/gwt/cell/client/ImageLoadingCell.java (revision
11343)
+++ user/src/com/google/gwt/cell/client/ImageLoadingCell.java (working copy)
@@ -195,8 +195,7 @@
imgWrapper.getStyle().setProperty(overflow, auto);
} else if (BrowserEvents.ERROR.equals(type)
eventOccurredOnImage(event, parent)) {
// Replace the loading indicator with an error message.
- parent.getFirstChildElement().setInnerHTML(
- errorRenderer.render(value).asString());
+
parent.getFirstChildElement().setInnerSafeHtml(errorRenderer.render(value));
}
}
Index: user/src/com/google/gwt/dom/builder/client/DomBuilderImpl.java
===
--- user/src/com/google/gwt/dom/builder/client/DomBuilderImpl.java
(revision 11343)
+++ user/src/com/google/gwt/dom/builder/client/DomBuilderImpl.java (working
copy)
@@ -568,7 +568,7 @@
@Override
protected void doHtmlImpl(SafeHtml html) {
-getCurrentElement().setInnerHTML(html.asString());
+getCurrentElement().setInnerSafeHtml(html);
}
@Override
Index: user/src/com/google/gwt/dom/builder/shared/HtmlBuilderImpl.java
===
--- user/src/com/google/gwt/dom/builder/shared/HtmlBuilderImpl.java
(revision 11343)
+++ user/src/com/google/gwt/dom/builder/shared/HtmlBuilderImpl.java
(working copy)
@@ -654,7 +654,7 @@
@Override
protected Element doFinishImpl() {
Element tmp = Document.get().createDivElement();
-tmp.setInnerHTML(asSafeHtml().asString());
+tmp.setInnerSafeHtml(asSafeHtml());
return tmp.getFirstChildElement();
}
Index: user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
===
--- user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
(revision 11343)
+++ user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
(working copy)
@@ -475,11 +475,11 @@
*/
sectionTag = sectionTag.toLowerCase();
if (tbody.equals(sectionTag)) {
-tmpElem.setInnerHTML(template.tbody(rowHtml).asString());
+tmpElem.setInnerSafeHtml(template.tbody(rowHtml));
} else if (thead.equals(sectionTag)) {
-tmpElem.setInnerHTML(template.thead(rowHtml).asString());
+tmpElem.setInnerSafeHtml(template.thead(rowHtml));
} else if
[gwt-contrib] Re: Update the DevMode Chrome plugin's Makefile to build a zip file to upload to the Chrome web store. (issue1858803)
LGTM http://gwt-code-reviews.appspot.com/1858803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update the DevMode Chrome plugin's Makefile to build a zip file to upload to the Chrome web store. (issue1858803)
http://gwt-code-reviews.appspot.com/1858803/diff/1/plugins/npapi/Makefile File plugins/npapi/Makefile (right): http://gwt-code-reviews.appspot.com/1858803/diff/1/plugins/npapi/Makefile#newcode57 plugins/npapi/Makefile:57: EXTENSION_FILES = *.html *.js *.png *.txt \ Oops, I did want to comment that this makes me a little nervous because people might get confused by when the globs are expanded, but I can't think of a better solution off hand and there's nothing technically wrong with this one. http://gwt-code-reviews.appspot.com/1858803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
