Re: CellTable height shrinks upon paging
I don't think performance is the main reason, but the fact that the current way the loading indicator works by taking the place of the current data until more data is loaded. However, when there's no indicator I think it should be (theoretically) possible to skip that "state", leave the data there until the new one is obtained, and then do the clean and re-populate immediately, in order to eliminate the flickering. Just like when using a (non-asynchronous) ListLoader, the paging doesn't show any flickering. On Jan 14, 9:10 am, Patrick Tucker wrote: > I agree. I think the number of rows should stay the same and when > needed, set the left over cells to empty. Unfortunately, they > probably had a good reason to remove the rows instead. I'm guessing > rendering is faster the way it is now. > > On Jan 13, 11:06 am, Raziel wrote: > > > > > > > > > The behaviour of a CellTable when paging is to show the loading > > indicator (nothing if no indicator is configured) and then fill the > > new retrieved data. > > > Whereas this sounds reasonably correct, I find it to be a problem the > > fact that the grid will momentarily shrink in height to accommodate > > only the loading indicator (or all the way up to the header if there's > > no indicator set). > > > I understand it is a feature of this grid to take as much space as it > > is required by its content. However, I think the better behaviour > > would for the height not to resize while showing the loading indicator > > (if that's at all possible), or at least that when we turn off the > > indicator - setLoadingIndicator(null) - the current page is not wiped > > out but right before replacing it with the new data. The latter would > > prevent that momentary flickering when paging, just like you can see > > the grid behave in the GWT > > Showcase:http://gwt.google.com/samples/Showcase/Showcase.html#!CwCellTable > > > Note that the Showcase doesn't present that flickering because the > > data is hardcoded in the provider (i.e. it's not asynchronously > > fetched). > > > I've debugged and taken a look at the underlying implementation and > > it's not that easy to follow. I see there are a few loading states > > (loaded, loading, partially loaded), but not exactly sure about how to > > modify the logic to achieve what I want without breaking something > > else. So I'm wondering if somebody can give me some pointers about how > > to go ahead and extend the CellTable to make it work the way I > > describe (at least setting the indicator to null to indicate that the > > current page will be removed when the new one is passed). > > > Also, does anybody know if this "feature" would be added soon to the > > celltable? I cannot imagine that this flickering is a desired effect, > > hence I'm also wondering if I should log a ticket? > > > Thanks -- You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: CellTable height shrinks upon paging
I agree. I think the number of rows should stay the same and when needed, set the left over cells to empty. Unfortunately, they probably had a good reason to remove the rows instead. I'm guessing rendering is faster the way it is now. On Jan 13, 11:06 am, Raziel wrote: > The behaviour of a CellTable when paging is to show the loading > indicator (nothing if no indicator is configured) and then fill the > new retrieved data. > > Whereas this sounds reasonably correct, I find it to be a problem the > fact that the grid will momentarily shrink in height to accommodate > only the loading indicator (or all the way up to the header if there's > no indicator set). > > I understand it is a feature of this grid to take as much space as it > is required by its content. However, I think the better behaviour > would for the height not to resize while showing the loading indicator > (if that's at all possible), or at least that when we turn off the > indicator - setLoadingIndicator(null) - the current page is not wiped > out but right before replacing it with the new data. The latter would > prevent that momentary flickering when paging, just like you can see > the grid behave in the GWT > Showcase:http://gwt.google.com/samples/Showcase/Showcase.html#!CwCellTable > > Note that the Showcase doesn't present that flickering because the > data is hardcoded in the provider (i.e. it's not asynchronously > fetched). > > I've debugged and taken a look at the underlying implementation and > it's not that easy to follow. I see there are a few loading states > (loaded, loading, partially loaded), but not exactly sure about how to > modify the logic to achieve what I want without breaking something > else. So I'm wondering if somebody can give me some pointers about how > to go ahead and extend the CellTable to make it work the way I > describe (at least setting the indicator to null to indicate that the > current page will be removed when the new one is passed). > > Also, does anybody know if this "feature" would be added soon to the > celltable? I cannot imagine that this flickering is a desired effect, > hence I'm also wondering if I should log a ticket? > > Thanks -- You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
CellTable height shrinks upon paging
The behaviour of a CellTable when paging is to show the loading indicator (nothing if no indicator is configured) and then fill the new retrieved data. Whereas this sounds reasonably correct, I find it to be a problem the fact that the grid will momentarily shrink in height to accommodate only the loading indicator (or all the way up to the header if there's no indicator set). I understand it is a feature of this grid to take as much space as it is required by its content. However, I think the better behaviour would for the height not to resize while showing the loading indicator (if that's at all possible), or at least that when we turn off the indicator - setLoadingIndicator(null) - the current page is not wiped out but right before replacing it with the new data. The latter would prevent that momentary flickering when paging, just like you can see the grid behave in the GWT Showcase: http://gwt.google.com/samples/Showcase/Showcase.html#!CwCellTable Note that the Showcase doesn't present that flickering because the data is hardcoded in the provider (i.e. it's not asynchronously fetched). I've debugged and taken a look at the underlying implementation and it's not that easy to follow. I see there are a few loading states (loaded, loading, partially loaded), but not exactly sure about how to modify the logic to achieve what I want without breaking something else. So I'm wondering if somebody can give me some pointers about how to go ahead and extend the CellTable to make it work the way I describe (at least setting the indicator to null to indicate that the current page will be removed when the new one is passed). Also, does anybody know if this "feature" would be added soon to the celltable? I cannot imagine that this flickering is a desired effect, hence I'm also wondering if I should log a ticket? Thanks -- You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
