Re: Code Splitting with Factory usage?

2013-09-24 Thread Ed Bras
@Jens: thanks, this was exactly the info I was looking for. Always wondered
how this code splitting works on method level in a share class.
Maybe you could copy/paste your info in the Code splitting doc snippet on
the gwt site ;)...
I will keep on digging...

-- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Code Splitting with Factory usage?

2013-09-23 Thread Jens
If the factory is shared it ends up in the left over fragment.

If the classes the factory creates also end up in the left over fragment 
probably somewhat depends on how you implement the factory. Classes that 
you use in static initializers and/or class/instance variables are likely 
to end up in the left over fragment as they are tied to the factory 
initialization. Anything that you create lazily inside your factory methods 
have a good chance to be exclusive to a single split point and thus end up 
in this split point.

If you don't trust the SOYC report then create a small proof of concept app 
and compile it in pretty mode. Then take a look at the JS code in each 
split point. I have once done this to debug a code splitting issue and from 
what I can tell the code splitter works on method/constructor level.

Also try GWT trunk. It contains quite some code splitting fixes.

-- J.

-- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Code Splitting with Factory usage?

2013-09-23 Thread Ed Bras
@fenyoapa: in my post I explain that I used the SOYC report you are
explaining and that it's included. But my question is: is hat expected
behavior or some bug in my code?

-- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Code Splitting with Factory usage?

2013-09-23 Thread fenyoapa
Hi, here are two links you should read:
http://www.gwtproject.org/doc/latest/DevGuideCodeSplitting.html
http://www.javabeat.net/2011/11/code-splitting-in-gwt/#

You are interested on this:

"To obtain a compile report for your application, simply compile your 
application with the -compileReport option added. Your application should 
then have an output directory named compileReport. Open index.html in that 
directory to view a Compile Report for your application."

In the report you will see the answer to your question.

-F

2013. szeptember 23., hétfő 14:13:38 UTC+2 időpontban Ed a következőt írta:
>
> I have a global Factory class to create instances.
> I have a code split A and code split B that both use this Factory to 
> create instance A1 that is only used in A and instance B1 that is only used 
> in B.
>
> Will code for object  A1 also end up in split point B, and code for object 
> B1 als end up in split point A? Or is the GWT compiler smart enough to 
> detect it's usage and ensure that code A1 is only present in split point A, 
> and code B1 is only present in split point B?
>
> I think so, but got my doubts, as the Factory is shared  between both 
> split points, and it also shows up in the SOYC report.
> - Ed
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/groups/opt_out.


Code Splitting with Factory usage?

2013-09-23 Thread Ed
I have a global Factory class to create instances.
I have a code split A and code split B that both use this Factory to create 
instance A1 that is only used in A and instance B1 that is only used in B.

Will code for object  A1 also end up in split point B, and code for object 
B1 als end up in split point A? Or is the GWT compiler smart enough to 
detect it's usage and ensure that code A1 is only present in split point A, 
and code B1 is only present in split point B?

I think so, but got my doubts, as the Factory is shared  between both split 
points, and it also shows up in the SOYC report.
- Ed

-- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/groups/opt_out.