[gwt-contrib] Code Review: gwt-google-apis Maps release notes
Hello Miguel, Here are changes to the release notes for the Maps RC1 release. The only thing we might add that might be release note worthy is the retrieval of the Google Earth plugin object. M maps/distro-source/src/release_notes.html -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- Index: maps/distro-source/src/release_notes.html === --- maps/distro-source/src/release_notes.html (revision 792) +++ maps/distro-source/src/release_notes.html (working copy) @@ -38,34 +38,35 @@ liThis library requires GWT 1.5 or later and Java 1.5 or later./li liThis library requires the use of the Google Maps API 2.89 or later. (Some features of the bindings require more recent versions of the Maps API version up to 2.113, see the Maps API developer website.)/li liRemoved Listener classes for events that were previously deprecated. Each removed class has an equivalent Handler class./li - liFixed problems initializing constants on IE6/7 in Hosted Mode/li + liChanged many classes to be subclasses of JavaScriptObject (JavaScript overlay types). This means that you can no longer use codenew/code to construct many types - you must use the factory method codeType.newInstance()/code instead./li + liFixed problems initializing constants on IE6/7 in Hosted Mode./li liRemoved MarkerManager, as Maps team is discontinuing support for it in deference to an open source version with more features./li liAdded checks to see that the JS API was properly loaded./li - liAdded support for Polyline and Polygon drawing/editing features/li - liUpdates to JSIO to support pre-release changes to GWT 1.5 hosted mode/li - liFixed GeocodeCache subclassing issues/i - liFixed many other issues noted in the a href=http://code.google.com/p/gwt-google-apis/issues/list?can=1q=API%3AMaps+Milestone%3A1_1_RC;Issue Tracker/a/li + liAdded support for Polyline and Polygon drawing/editing features./li + liUpdates to JSIO to support pre-release changes to GWT 1.5 hosted mode./li + liFixed GeocodeCache subclassing issues./li + liAdded many unit tests./li + liFixed many other issues noted in the a href=http://code.google.com/p/gwt-google-apis/issues/list?can=1q=API%3AMaps+Milestone%3A1_1_RC;Issue Tracker/a./li /ul h3Known Issues/h3 ul liNot all features in the Maps API are supported. The Maps API is constantly evolving./li - liPolygons that are not filled do not add/remove or deliver events properly (Issue 108. Maps API issue to be addressed in upcoming release.)/li /ul hr/ a name=Release_Notes_r290/a h2Release Notes for r290 (milestone release)/h2 h3Changes since r41/h3 ul - liAdded many Maps API features added since 2.83 up to 2.98/li + liAdded many Maps API features added since 2.83 up to 2.98./li liUpdated features now require Java 1.5 and GWT 1.5 or higher./li - liUpdated to use Java 1.5 generics, enum types, and annotations/li + liUpdated to use Java 1.5 generics, enum types, and annotations./li liMaps project placed in a separate tree so it can be built and distributed independently./li liNew event handling system that models each Maps API with a single Java Event and Handler class. Existing Listener classes are now deprecated./li - liAdded unit tests for event handing/li + liAdded unit tests for event handing./li liAdded javadoc comments to all classes./li - liUpdated to use JSIO r83/li + liUpdated to use JSIO r83./li liRemoved use of long values passed via JSNI and JSIO methods./li - liAdded styling and documentation to the HelloMaps sample project/li + liAdded styling and documentation to the HelloMaps sample project./li liAdded additional features to the HelloMaps sample project, partially as a way to manually test the newly added API features./li liChanged API to extract constant values from the Maps API instead of hard coding constants in Java./li liMany issues from the a href=http://code.google.com/p/gwt-google-apis/issues/list;issue tracker/a have been addressed, all marked as version 1.1_RC./li
[gwt-contrib] [google-web-toolkit commit] r3661 - changes/spoon/runAsync/samples/showcase/src/com/google/gwt/sample/sho wcase/client
Author: [EMAIL PROTECTED]
Date: Wed Sep 17 07:53:35 2008
New Revision: 3661
Modified:
changes/spoon/runAsync/samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidget.java
Log:
Don't put ContentWidget.onLoad behind runAsync; run it synchronously.
Modified:
changes/spoon/runAsync/samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidget.java
==
---
changes/spoon/runAsync/samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidget.java
(original)
+++
changes/spoon/runAsync/samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidget.java
Wed Sep 17 07:53:35 2008
@@ -15,8 +15,6 @@
*/
package com.google.gwt.sample.showcase.client;
-import com.google.gwt.core.client.GWT;
-import com.google.gwt.core.client.RunAsyncCallback;
import com.google.gwt.http.client.Request;
import com.google.gwt.http.client.RequestBuilder;
import com.google.gwt.http.client.RequestCallback;
@@ -321,21 +319,13 @@
@Override
protected void onLoad() {
-GWT.runAsync(new RunAsyncCallback() {
- public void onFailure(Throwable e) {
-Window.alert(Could not load fragment: + e);
- }
+// Initialize this widget if we haven't already
+initialize();
- public void onSuccess() {
-// Initialize this widget if we haven't already
-initialize();
-
-// Select the first tab
-if (getTabBar().getTabCount() 0) {
- tabBar.selectTab(0);
-}
- }
-});
+// Select the first tab
+if (getTabBar().getTabCount() 0) {
+ tabBar.selectTab(0);
+}
}
/**
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: Code Review: gwt-google-apis Maps update the DirectionsTest
LGTM On Tue, Sep 16, 2008 at 7:40 AM, Eric Ayers [EMAIL PROTECTED] wrote: I updated issue 171 - the 1.5.2 release is broken on this unit test, but has been subsequently fixed. See GWT issue 2841 http://code.google.com/p/google-web-toolkit/issues/detail?id=2841 On Mon, Sep 15, 2008 at 4:30 PM, Eric Ayers [EMAIL PROTECTED] wrote: Hello Miguel, This resolves issue 171 - which was apparently due to a core GWT issue. It also adds a few more tests to the DirectionsTest, and updates the Marker class to properly extract Markers from a list. M maps/maps/test/com/google/gwt/maps/client/geocode/DirectionsTest.java M maps/maps/src/com/google/gwt/maps/client/overlay/Marker.java -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ -- Miguel --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Code Review: gwt-google-apis Search LocalSearch.getCenterPoint() accepts Maps LatLng
Hello Miguel,
This patch adds an overload to LocalSearch.setCenterPoint() to accept a
JavaScriptObject parameter. It can be either a raw GLatLng or GMap2 object,
or it can be a LatLng object from the gwt-maps API (which is just a Java
overlay type for GLatLng). I tested this manually by creating a small demo
project.
M search/src/com/google/gwt/search/client/LocalSearch.java
M search/src/com/google/gwt/search/client/impl/GlocalSearch.java
--
Eric Z. Ayers - GWT Team - Atlanta, GA USA
http://code.google.com/webtoolkit/
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Index: search/src/com/google/gwt/search/client/LocalSearch.java
===
--- search/src/com/google/gwt/search/client/LocalSearch.java (revision 797)
+++ search/src/com/google/gwt/search/client/LocalSearch.java (working copy)
@@ -15,6 +15,7 @@
*/
package com.google.gwt.search.client;
+import com.google.gwt.core.client.JavaScriptObject;
import com.google.gwt.search.client.impl.GlocalSearch;
/**
@@ -34,11 +35,11 @@
* suppose the searcher is centered in Santa Barbara, CA and the user is
* searching for Cava. With co-mingled results, the first search result is
* actually an address match against Cava Close, Aberdeen City, AB15 UK. The
- * second result is Cava Restaurant amp; Bar. Using this method, applications
- * are able to disable and enable address lookup producing either strictly
- * search results, or address lookup results co-mingled with search results.
- * In this case, if address lookup is disabled, the first result would be
- * Cava Restaurant amp; Bar.
+ * second result is Cava Restaurant amp; Bar. Using this method,
+ * applications are able to disable and enable address lookup producing either
+ * strictly search results, or address lookup results co-mingled with search
+ * results. In this case, if address lookup is disabled, the first result
+ * would be Cava Restaurant amp; Bar.
*
* @param mode Supplies the desired address lookup mode.
*/
@@ -48,6 +49,18 @@
/**
* This method establishes a center point that is used to scope search
+ * results. You can pass a GLatLng or GMap2 object created by the Google Maps API.
+ * If you are using the gwt-maps project, pass an instance of the LatLng class.
+ *
+ * @param point Supply either a GLatLng object or a GMap2 object from the
+ * Google Maps API.
+ */
+ public void setCenterPoint(JavaScriptObject point) {
+IMPL.setCenterPoint(this, point);
+ }
+
+ /**
+ * This method establishes a center point that is used to scope search
* results.
*
* @param point a string which specifies an address by name. When this
Index: search/src/com/google/gwt/search/client/impl/GlocalSearch.java
===
--- search/src/com/google/gwt/search/client/impl/GlocalSearch.java (revision 797)
+++ search/src/com/google/gwt/search/client/impl/GlocalSearch.java (working copy)
@@ -24,17 +24,15 @@
/**
*/
public interface GlocalSearch extends GSearch {
- JSOpaque RESULT_CLASS = new JSOpaque($wnd.GlocalSearch.RESULT_CLASS);
GlocalSearch IMPL = GWT.create(GlocalSearch.class);
+ JSOpaque RESULT_CLASS = new JSOpaque($wnd.GlocalSearch.RESULT_CLASS);
@Constructor($wnd.GlocalSearch)
JavaScriptObject construct();
- // XXX Possible integration with Maps API. Consider code bloat before adding
- // public void setCenterPoint(GMap point);
- // public void setCenterPoint(GPoint point);
+ void setAddressLookupMode(Search jso, JSOpaque mode);
- void setAddressLookupMode(Search jso, JSOpaque mode);
-
+ void setCenterPoint(Search jso, JavaScriptObject point);
+
void setCenterPoint(Search jso, String point);
}
[gwt-contrib] Re: GWT Issue 343 and the JSR-303 Draft (Implementing in GWT)
I wasn't including the source files. Disregard. Release should be soon. On Sep 17, 3:38 pm, chris.ruffalo [EMAIL PROTECTED] wrote: One final bit of help. I'm having problems building a jar that will work with the modules to compile under a normal project. If I export the jar with Eclipse everything works fine (add directory entries and all that) and the compile and shell modes work. If I use an ant task to build the jar then it will not work with the compiled mode or the shell mode. I've never been able to have ant (1.7.1) do this in the past either, on other projects. Any help would be appreciated. On Sep 12, 11:08 pm, chris.ruffalo [EMAIL PROTECTED] wrote: I see. That worked, I guess I was expecting something bad to happen if I didn't write new source. In retrospect why would that happen? Fortunately I don't have to do anything different (per user agent) yet. On Sep 12, 3:39 pm, BobV [EMAIL PROTECTED] wrote: Namely: Hosted mode works fine but compiling tries to rebind twice (even though I only have one GWT.create()) and it can't create the printwriter because the class it is trying to write already exists. I guess I need a smarter generator. (?) This is expected behavior. The generator gets called once per permutation. If the PrintWriter is null, just return the name of the implementation class that you were tryping to create. It works this way because you may want to generate different code for different user.agent values or along some other deferred-binding axis. In this case, you would name the implementation classes differently. -- Bob Vawter Google Web Toolkit Team --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r3663 - in changes/jat/oophm-trunk-r3274/plugins/xpcom: . VisualStudio
Author: [EMAIL PROTECTED]
Date: Wed Sep 17 17:16:17 2008
New Revision: 3663
Added:
changes/jat/oophm-trunk-r3274/plugins/xpcom/VisualStudio/
changes/jat/oophm-trunk-r3274/plugins/xpcom/VisualStudio/firefox-xpcom.sln
(contents, props changed)
changes/jat/oophm-trunk-r3274/plugins/xpcom/VisualStudio/firefox-xpcom.vcproj
(contents, props changed)
changes/jat/oophm-trunk-r3274/plugins/xpcom/xpOOPHM.def
changes/jat/oophm-trunk-r3274/plugins/xpcom/xpOOPHM.rc
Modified:
changes/jat/oophm-trunk-r3274/plugins/xpcom/ModuleOOPHM.cpp
Log:
Windows portability changes, MSVC project - basically working but not tested
significantly.
Modified: changes/jat/oophm-trunk-r3274/plugins/xpcom/ModuleOOPHM.cpp
==
--- changes/jat/oophm-trunk-r3274/plugins/xpcom/ModuleOOPHM.cpp (original)
+++ changes/jat/oophm-trunk-r3274/plugins/xpcom/ModuleOOPHM.cpp Wed Sep 17
17:16:17 2008
@@ -26,6 +26,21 @@
#include nsIClassInfoImpl.h // 1.9 only
#endif
+#ifdef _WINDOWS
+#include windows.h
+
+BOOL APIENTRY DllMain(HMODULE hModule, DWORD ulReasonForCall, LPVOID
lpReserved) {
+ switch (ulReasonForCall) {
+case DLL_PROCESS_ATTACH:
+case DLL_THREAD_ATTACH:
+case DLL_THREAD_DETACH:
+case DLL_PROCESS_DETACH:
+ break;
+ }
+ return TRUE;
+}
+#endif
+
NS_GENERIC_FACTORY_CONSTRUCTOR(ExternalWrapper)
NS_DECL_CLASSINFO(ExternalWrapper)
Added:
changes/jat/oophm-trunk-r3274/plugins/xpcom/VisualStudio/firefox-xpcom.sln
==
--- (empty file)
+++
changes/jat/oophm-trunk-r3274/plugins/xpcom/VisualStudio/firefox-xpcom.sln
Wed Sep 17 17:16:17 2008
@@ -0,0 +1,26 @@
+
+Microsoft Visual Studio Solution File, Format Version 9.00
+# Visual C++ Express 2005
+Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942})
= firefox-xpcom, firefox-xpcom.vcproj,
{6BF0C2CE-CB0C-421B-A67C-1E448371D24A}
+EndProject
+Global
+ GlobalSection(SolutionConfigurationPlatforms) = preSolution
+ Debug|Win32 = Debug|Win32
+ Debug|Win64 = Debug|Win64
+ Release|Win32 = Release|Win32
+ Release|Win64 = Release|Win64
+ EndGlobalSection
+ GlobalSection(ProjectConfigurationPlatforms) = postSolution
+ {6BF0C2CE-CB0C-421B-A67C-1E448371D24A}.Debug|Win32.ActiveCfg =
Debug|
Win32
+ {6BF0C2CE-CB0C-421B-A67C-1E448371D24A}.Debug|Win32.Build.0 =
Debug|Win32
+ {6BF0C2CE-CB0C-421B-A67C-1E448371D24A}.Debug|Win64.ActiveCfg =
Debug|
Win32
+ {6BF0C2CE-CB0C-421B-A67C-1E448371D24A}.Debug|Win64.Build.0 =
Debug|Win32
+ {6BF0C2CE-CB0C-421B-A67C-1E448371D24A}.Release|Win32.ActiveCfg
= Release|
Win32
+ {6BF0C2CE-CB0C-421B-A67C-1E448371D24A}.Release|Win32.Build.0 =
Release|
Win32
+ {6BF0C2CE-CB0C-421B-A67C-1E448371D24A}.Release|Win64.ActiveCfg
= Release|
Win32
+ {6BF0C2CE-CB0C-421B-A67C-1E448371D24A}.Release|Win64.Build.0 =
Release|
Win32
+ EndGlobalSection
+ GlobalSection(SolutionProperties) = preSolution
+ HideSolutionNode = FALSE
+ EndGlobalSection
+EndGlobal
Added:
changes/jat/oophm-trunk-r3274/plugins/xpcom/VisualStudio/firefox-xpcom.vcproj
==
--- (empty file)
+++
changes/jat/oophm-trunk-r3274/plugins/xpcom/VisualStudio/firefox-xpcom.vcproj
Wed Sep 17 17:16:17 2008
@@ -0,0 +1,759 @@
+?xml version=1.0 encoding=UTF-8?
+VisualStudioProject
+ ProjectType=Visual C++
+ Version=8.00
+ Name=firefox-xpcom
+ ProjectGUID={6BF0C2CE-CB0C-421B-A67C-1E448371D24A}
+ RootNamespace=firefox-xpcom
+ Keyword=Win32Proj
+
+ Platforms
+ Platform
+ Name=Win32
+ /
+ /Platforms
+ ToolFiles
+ /ToolFiles
+ Configurations
+ Configuration
+ Name=Debug|Win32
+ OutputDirectory=Debug
+ IntermediateDirectory=Debug
+ ConfigurationType=2
+ UseOfMFC=1
+
+ Tool
+ Name=VCPreBuildEventTool
+ /
+ Tool
+ Name=VCCustomBuildTool
+ /
+ Tool
+ Name=VCXMLDataGeneratorTool
+ /
+ Tool
+ Name=VCWebServiceProxyGeneratorTool
+ /
+ Tool
+ Name=VCMIDLTool
+ /
+ Tool
+ Name=VCCLCompilerTool
+ Optimization=0
+
[gwt-contrib] Re: GWT Issue 343 and the JSR-303 Draft (Implementing in GWT)
Released here : http://code.google.com/p/google-web-toolkit/issues/detail?id=343 Let me know what you think. On Sep 17, 6:42 pm, chris.ruffalo [EMAIL PROTECTED] wrote: I wasn't including the source files. Disregard. Release should be soon. On Sep 17, 3:38 pm, chris.ruffalo [EMAIL PROTECTED] wrote: One final bit of help. I'm having problems building a jar that will work with the modules to compile under a normal project. If I export the jar with Eclipse everything works fine (add directory entries and all that) and the compile and shell modes work. If I use an ant task to build the jar then it will not work with the compiled mode or the shell mode. I've never been able to have ant (1.7.1) do this in the past either, on other projects. Any help would be appreciated. On Sep 12, 11:08 pm, chris.ruffalo [EMAIL PROTECTED] wrote: I see. That worked, I guess I was expecting something bad to happen if I didn't write new source. In retrospect why would that happen? Fortunately I don't have to do anything different (per user agent) yet. On Sep 12, 3:39 pm, BobV [EMAIL PROTECTED] wrote: Namely: Hosted mode works fine but compiling tries to rebind twice (even though I only have one GWT.create()) and it can't create the printwriter because the class it is trying to write already exists. I guess I need a smarter generator. (?) This is expected behavior. The generator gets called once per permutation. If the PrintWriter is null, just return the name of the implementation class that you were tryping to create. It works this way because you may want to generate different code for different user.agent values or along some other deferred-binding axis. In this case, you would name the implementation classes differently. -- Bob Vawter Google Web Toolkit Team --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
