[gwt-contrib] [google-web-toolkit commit] r5318 - Merging in r5317 from trunk to snapshot-2009.04.28-r5307. Merge command:

2009-05-01 Thread codesite-noreply

Author: sp...@google.com
Date: Fri May  1 11:05:36 2009
New Revision: 5318

Modified:
 
branches/snapshot-2009.04.28-r5307/user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
 
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/propertyMerging_expected.css
 
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/propertyMerging_test.css
 
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/selectorMerging_expected.css
 
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/selectorMerging_test.css

Log:
Merging in r5317 from trunk to snapshot-2009.04.28-r5307.  Merge command:

svn merge -r5316:5317   
https://google-web-toolkit.googlecode.com/svn/trunk  .



Modified:  
branches/snapshot-2009.04.28-r5307/user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
==
---  
branches/snapshot-2009.04.28-r5307/user/src/com/google/gwt/resources/rg/CssResourceGenerator.java

(original)
+++  
branches/snapshot-2009.04.28-r5307/user/src/com/google/gwt/resources/rg/CssResourceGenerator.java

Fri May  1 11:05:36 2009
@@ -309,7 +309,7 @@

  private void visitInNewContext(List nodes) {
MergeIdenticalSelectorsVisitor v = new  
MergeIdenticalSelectorsVisitor();
-  v.accept(nodes);
+  v.acceptWithInsertRemove(nodes);
rulesInOrder.addAll(v.rulesInOrder);
  }
}
@@ -371,7 +371,7 @@

  private void visitInNewContext(List nodes) {
MergeRulesByContentVisitor v = new MergeRulesByContentVisitor();
-  v.accept(nodes);
+  v.acceptWithInsertRemove(nodes);
rulesInOrder.addAll(v.rulesInOrder);
  }
}

Modified:  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/propertyMerging_expected.css
==
---  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/propertyMerging_expected.css

(original)
+++  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/propertyMerging_expected.css

Fri May  1 11:05:36 2009
@@ -103,3 +103,12 @@
  .media3 {
group: media;
  }
+
+/* Make sure merging inside sub-contexts works */
+...@if (true) {
+  .a , .b {group: one;}
+}
+
+...@media print {
+  .a , .b {group: one;}
+}

Modified:  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/propertyMerging_test.css
==
---  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/propertyMerging_test.css

(original)
+++  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/propertyMerging_test.css

Fri May  1 11:05:36 2009
@@ -116,7 +116,17 @@
group2: mediaOk;
  }

-
  .media3 {
group: media;
+}
+
+/* Make sure merging inside sub-contexts works */
+...@if (true) {
+  .a {group: one;}
+  .b {group: one;}
+}
+
+...@media print {
+  .a {group: one;}
+  .b {group: one;}
  }

Modified:  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/selectorMerging_expected.css
==
---  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/selectorMerging_expected.css

(original)
+++  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/selectorMerging_expected.css

Fri May  1 11:05:36 2009
@@ -61,7 +61,7 @@
media5 : true;
  }

-...@if (true) {
+...@media print {
media {
  media3 : true;
}
@@ -69,4 +69,15 @@

  media {
media3-block : false;
+}
+
+/* Make sure merging inside sub-contexts works */
+...@if (true) {
+  .a {propOne: one;
+  propTwo: one;}
+}
+
+...@media print {
+  .a {propOne: one;
+  propTwo: one;}
  }

Modified:  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/selectorMerging_test.css
==
---  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/selectorMerging_test.css

(original)
+++  
branches/snapshot-2009.04.28-r5307/user/test/com/google/gwt/resources/rg/selectorMerging_test.css

Fri May  1 11:05:36 2009
@@ -63,7 +63,7 @@
media1 : true;
  }

-...@if (true) {
+...@media print {
media {
  media3 : true;
}
@@ -76,3 +76,14 @@
  media {
media3-block : false;
  }
+
+/* Make sure merging inside sub-contexts works */
+...@if (true) {
+  .a {propOne: one;}
+  .a {propTwo: one;}
+}
+
+...@media print {
+  .a {propOne: one;}
+  .a {propTwo: one;}
+}
\ No newline at end of file

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] [google-web-toolkit commit] r5320 - Fixes missing module inherits (core uses xhr for runAsync)

2009-05-01 Thread codesite-noreply

Author: j...@google.com
Date: Fri May  1 13:23:02 2009
New Revision: 5320

Modified:
trunk/user/src/com/google/gwt/core/Core.gwt.xml

Log:
Fixes missing module inherits (core uses xhr for runAsync)
Review by: spoon (desk check)


Modified: trunk/user/src/com/google/gwt/core/Core.gwt.xml
==
--- trunk/user/src/com/google/gwt/core/Core.gwt.xml (original)
+++ trunk/user/src/com/google/gwt/core/Core.gwt.xml Fri May  1 13:23:02 2009
@@ -20,6 +20,7 @@
  


+  




--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Comment on UsingOOPHM in google-web-toolkit

2009-05-01 Thread codesite-noreply

Comment by thad.humphries:

Excellent!  Thanks for this and thanks for the prebuilt pieces for the  
platforms.  I develop on Linux, and must test on IE and Safari.  After  
installing their plugins, I could access the OOPHM app via

{{{
http://linuxdev:/MyApplication.html?gwt.hosted=linuxdev:9997&;
}}}

from IE and Safari 3 and 4.

Also, for those wishing to run OOPHM from Eclipse Run, open the Run  
Configurations dialog, select your project, select the Classpath tab, and  
add gwt-dev-oophm.jar via the "Add External JARs..." button.


For more information:
http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] [google-web-toolkit commit] r5317 - Fix a CssResource bug where selector and rule merging did not work inside of @if or @medi...

2009-05-01 Thread codesite-noreply

Author: b...@google.com
Date: Fri May  1 10:46:39 2009
New Revision: 5317

Modified:
trunk/user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
trunk/user/test/com/google/gwt/resources/rg/propertyMerging_expected.css
trunk/user/test/com/google/gwt/resources/rg/propertyMerging_test.css
trunk/user/test/com/google/gwt/resources/rg/selectorMerging_expected.css
trunk/user/test/com/google/gwt/resources/rg/selectorMerging_test.css

Log:
Fix a CssResource bug where selector and rule merging did not work inside  
of @if or @media blocks.

Patch by: bobv
Review by: rjrjr (desk)


Modified:  
trunk/user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
==
--- trunk/user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
 
(original)
+++ trunk/user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
 
Fri May  1 10:46:39 2009
@@ -309,7 +309,7 @@

  private void visitInNewContext(List nodes) {
MergeIdenticalSelectorsVisitor v = new  
MergeIdenticalSelectorsVisitor();
-  v.accept(nodes);
+  v.acceptWithInsertRemove(nodes);
rulesInOrder.addAll(v.rulesInOrder);
  }
}
@@ -371,7 +371,7 @@

  private void visitInNewContext(List nodes) {
MergeRulesByContentVisitor v = new MergeRulesByContentVisitor();
-  v.accept(nodes);
+  v.acceptWithInsertRemove(nodes);
rulesInOrder.addAll(v.rulesInOrder);
  }
}

Modified:  
trunk/user/test/com/google/gwt/resources/rg/propertyMerging_expected.css
==
---  
trunk/user/test/com/google/gwt/resources/rg/propertyMerging_expected.css
 
(original)
+++  
trunk/user/test/com/google/gwt/resources/rg/propertyMerging_expected.css
 
Fri May  1 10:46:39 2009
@@ -103,3 +103,12 @@
  .media3 {
group: media;
  }
+
+/* Make sure merging inside sub-contexts works */
+...@if (true) {
+  .a , .b {group: one;}
+}
+
+...@media print {
+  .a , .b {group: one;}
+}

Modified:  
trunk/user/test/com/google/gwt/resources/rg/propertyMerging_test.css
==
--- trunk/user/test/com/google/gwt/resources/rg/propertyMerging_test.css
 
(original)
+++ trunk/user/test/com/google/gwt/resources/rg/propertyMerging_test.css
 
Fri May  1 10:46:39 2009
@@ -116,7 +116,17 @@
group2: mediaOk;
  }

-
  .media3 {
group: media;
+}
+
+/* Make sure merging inside sub-contexts works */
+...@if (true) {
+  .a {group: one;}
+  .b {group: one;}
+}
+
+...@media print {
+  .a {group: one;}
+  .b {group: one;}
  }

Modified:  
trunk/user/test/com/google/gwt/resources/rg/selectorMerging_expected.css
==
---  
trunk/user/test/com/google/gwt/resources/rg/selectorMerging_expected.css
 
(original)
+++  
trunk/user/test/com/google/gwt/resources/rg/selectorMerging_expected.css
 
Fri May  1 10:46:39 2009
@@ -61,7 +61,7 @@
media5 : true;
  }

-...@if (true) {
+...@media print {
media {
  media3 : true;
}
@@ -69,4 +69,15 @@

  media {
media3-block : false;
+}
+
+/* Make sure merging inside sub-contexts works */
+...@if (true) {
+  .a {propOne: one;
+  propTwo: one;}
+}
+
+...@media print {
+  .a {propOne: one;
+  propTwo: one;}
  }

Modified:  
trunk/user/test/com/google/gwt/resources/rg/selectorMerging_test.css
==
--- trunk/user/test/com/google/gwt/resources/rg/selectorMerging_test.css
 
(original)
+++ trunk/user/test/com/google/gwt/resources/rg/selectorMerging_test.css
 
Fri May  1 10:46:39 2009
@@ -63,7 +63,7 @@
media1 : true;
  }

-...@if (true) {
+...@media print {
media {
  media3 : true;
}
@@ -76,3 +76,14 @@
  media {
media3-block : false;
  }
+
+/* Make sure merging inside sub-contexts works */
+...@if (true) {
+  .a {propOne: one;}
+  .a {propTwo: one;}
+}
+
+...@media print {
+  .a {propOne: one;}
+  .a {propTwo: one;}
+}
\ No newline at end of file

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] [google-web-toolkit commit] r5315 - Merging r5314 from trunk to snapshot-2009.04.28-r5307. Merge command:

2009-05-01 Thread codesite-noreply

Author: sp...@google.com
Date: Fri May  1 08:17:30 2009
New Revision: 5315

Modified:
 
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/core/ext/soyc/impl/MemberFactory.java
 
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java
 
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/dev/jjs/Correlation.java

Log:
Merging r5314 from trunk to snapshot-2009.04.28-r5307.  Merge command:

  svn merge -r5313:5314   
https://google-web-toolkit.googlecode.com/svn/trunk  .


Modified:  
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/core/ext/soyc/impl/MemberFactory.java
==
---  
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/core/ext/soyc/impl/MemberFactory.java
 
(original)
+++  
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/core/ext/soyc/impl/MemberFactory.java
 
Fri May  1 08:17:30 2009
@@ -16,6 +16,7 @@
  package com.google.gwt.core.ext.soyc.impl;

  import com.google.gwt.core.ext.soyc.Member;
+import com.google.gwt.dev.jjs.ast.JDeclaredType;
  import com.google.gwt.dev.jjs.ast.JField;
  import com.google.gwt.dev.jjs.ast.JMethod;
  import com.google.gwt.dev.jjs.ast.JReferenceType;
@@ -42,8 +43,8 @@
  return getOrCreate(method, StandardMethodMember.class, JMethod.class);
}

-  public StandardClassMember get(JReferenceType type) {
-return getOrCreate(type, StandardClassMember.class,  
JReferenceType.class);
+  public StandardClassMember get(JDeclaredType type) {
+return getOrCreate(type, StandardClassMember.class,  
JDeclaredType.class);
}

public StandardFunctionMember get(JsFunction function) {

Modified:  
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java
==
---  
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java
 
(original)
+++  
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java
 
Fri May  1 08:17:30 2009
@@ -27,6 +27,7 @@
  import com.google.gwt.dev.jjs.Correlation;
  import com.google.gwt.dev.jjs.SourceInfo;
  import com.google.gwt.dev.jjs.Correlation.Axis;
+import com.google.gwt.dev.jjs.ast.JDeclaredType;
  import com.google.gwt.dev.jjs.ast.JField;
  import com.google.gwt.dev.jjs.ast.JMethod;
  import com.google.gwt.dev.jjs.ast.JProgram;
@@ -230,7 +231,7 @@

switch (c.getAxis()) {
  case CLASS: {
-  JReferenceType type = c.getType();
+  JDeclaredType type = c.getType();
StandardClassMember member = memberFactory.get(type);
membersByCorrelation.put(c, member);
classesMutable.add(member);
@@ -238,7 +239,7 @@
  }
  case FIELD: {
JField field = c.getField();
-  JReferenceType type = c.getType();
+  JDeclaredType type = c.getType();
StandardFieldMember member = memberFactory.get(field);
memberFactory.get(type).addField(member);
membersByCorrelation.put(c, member);
@@ -253,7 +254,7 @@
  }
  case METHOD: {
JMethod method = c.getMethod();
-  JReferenceType type = c.getType();
+  JDeclaredType type = c.getType();
StandardMethodMember member = memberFactory.get(method);
memberFactory.get(type).addMethod(member);
membersByCorrelation.put(c, member);

Modified:  
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/dev/jjs/Correlation.java
==
---  
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/dev/jjs/Correlation.java
  
(original)
+++  
branches/snapshot-2009.04.28-r5307/dev/core/src/com/google/gwt/dev/jjs/Correlation.java
  
Fri May  1 08:17:30 2009
@@ -15,9 +15,9 @@
   */
  package com.google.gwt.dev.jjs;

+import com.google.gwt.dev.jjs.ast.JDeclaredType;
  import com.google.gwt.dev.jjs.ast.JField;
  import com.google.gwt.dev.jjs.ast.JMethod;
-import com.google.gwt.dev.jjs.ast.JReferenceType;
  import com.google.gwt.dev.js.ast.JsFunction;
  import com.google.gwt.dev.js.ast.JsName;

@@ -270,9 +270,9 @@
  }
}

-  public JReferenceType getType() {
+  public JDeclaredType getType() {
  if (axis == Axis.CLASS) {
-  return (JReferenceType) astReference;
+  return (JDeclaredType) astReference;
  } else if (axis == Axis.METHOD) {
return ((JMethod) astReference).getEnclosingType();
  } else if (axis == Axis.FIELD) {

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~

[gwt-contrib] [google-web-toolkit commit] r5319 - Updating branch-info.txt.

2009-05-01 Thread codesite-noreply

Author: sp...@google.com
Date: Fri May  1 11:07:03 2009
New Revision: 5319

Modified:
branches/snapshot-2009.04.28-r5307/branch-info.txt

Log:
Updating branch-info.txt.


Modified: branches/snapshot-2009.04.28-r5307/branch-info.txt
==
--- branches/snapshot-2009.04.28-r5307/branch-info.txt  (original)
+++ branches/snapshot-2009.04.28-r5307/branch-info.txt  Fri May  1 11:07:03  
2009
@@ -8,3 +8,6 @@
  Merges:
  Merged in r5314 from trunk (r5315):
   svn merge -r5313:5314   
https://google-web-toolkit.googlecode.com/svn/trunk  .
+Merged in r5317 from trunk (r5318):
+ svn merge -r5316:5317   
https://google-web-toolkit.googlecode.com/svn/trunk  .
+

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: How to build a big GWT application

2009-05-01 Thread Scott Blum
There's also a not-yet-shipped fix to 1.6.4 that drastically reduces stack
consumption.

http://code.google.com/p/google-web-toolkit/issues/detail?id=3510

On Fri, May 1, 2009 at 1:33 AM, Gilles B  wrote:

>
> I don't know if it's a good idea, building a 100% GWT monolithic
> application but I reach the compiler bounds with a medium application
> (400 java sources in client directory and some gwt modules). It's
> possible to increase java memory or factorize some java code parts,
> but it's not a solution. Soon you reach another error with the
> message:
>   [ERROR] Unexpected internal compiler error
>   java.lang.StackOverflowError: null
> If this is not only a memory issue considering the growing size of
> generated java script application page.
> Furthermore running in host mode become longer when your app is
> growing.
>
> I am sure in GWT framework team, you have done a very good job. I
> don't want to misuse it !
>
> What is a good strategy if I want such application ?
>
> An idea I try is to split the application but I need an extra Html
> page to embed all parts. This page is a pure html page or an another
> gwt application. But I need to extract some shared parts as libraries
> and to implement an extra mechanism to share context information
> between parts. Then I notice that the historic management doesnt
> fit...
>
> I also imagine to extract some java code as a separated javascript but
> I choose GWT to avoid dealing with JS and appreciate the Eclipse dev
> cycle, with debug... and java is realy cool.
>
> Not so easy ! If someone have a good idea to share... ?
>
> Gilles.
>
> >
>

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] [google-web-toolkit commit] r5316 - updating branch-info.txt

2009-05-01 Thread codesite-noreply

Author: sp...@google.com
Date: Fri May  1 08:28:05 2009
New Revision: 5316

Modified:
branches/snapshot-2009.04.28-r5307/branch-info.txt

Log:
updating branch-info.txt

Modified: branches/snapshot-2009.04.28-r5307/branch-info.txt
==
--- branches/snapshot-2009.04.28-r5307/branch-info.txt  (original)
+++ branches/snapshot-2009.04.28-r5307/branch-info.txt  Fri May  1 08:28:05  
2009
@@ -6,4 +6,5 @@
  /branches/snapshot-2009.04.14-r5307 was created (r5309) as a straight copy  
from /trunk/@5307

  Merges:
-
+Merged in r5314 from trunk (r5315):
+ svn merge -r5313:5314   
https://google-web-toolkit.googlecode.com/svn/trunk  .

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Incubator Questions

2009-05-01 Thread jay

Is this the best forum for providing feedback on these widgets? (I've
looked high & low, and found nothing better, but it's entirely
possible I've managed to miss the obvious ;-)

thanks!

jay

On May 1, 7:03 am, Bruce Johnson  wrote:
> We do expect to start moving a cluster of the most popular widgets from the
> incubator into the GWT trunk this quarter, so things like the paging table,
> etc. will almost certainly be in the next GWT major release.
>
>
>
> On Fri, May 1, 2009 at 1:53 AM, Gilles B  wrote:
>
> > I am currently using gen2 tables. It's realy a good stuff and this
> > part realy miss in GWT widgets with paging (or not), columns sort and
> > such cool mechanisms.
>
> > I have tried other tables implementations but this one is not so big
> > and work fine for me. As example, Smart GWT offers a realy good and
> > more beautifull component but I doesn't want to include such full
> > framework implying some js library extra dependance (half commercial).
> > The gwt as a toolkit approach seems better and its avoid the big
> > library syndrom (Including hundred of script, css, resources, javacode
> > in your app if you only want a single component)
>
> > As 1.6 only provide an additionnal calendar I was a little bit
> > disappointed expected more widgets in this version. Is there a plan to
> > add such widgets in future releases or is it a choice to provide a
> > basic set and opening the field to third party libraries ?
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Incubator Questions

2009-05-01 Thread Bruce Johnson
We do expect to start moving a cluster of the most popular widgets from the
incubator into the GWT trunk this quarter, so things like the paging table,
etc. will almost certainly be in the next GWT major release.

On Fri, May 1, 2009 at 1:53 AM, Gilles B  wrote:

>
> I am currently using gen2 tables. It's realy a good stuff and this
> part realy miss in GWT widgets with paging (or not), columns sort and
> such cool mechanisms.
>
> I have tried other tables implementations but this one is not so big
> and work fine for me. As example, Smart GWT offers a realy good and
> more beautifull component but I doesn't want to include such full
> framework implying some js library extra dependance (half commercial).
> The gwt as a toolkit approach seems better and its avoid the big
> library syndrom (Including hundred of script, css, resources, javacode
> in your app if you only want a single component)
>
> As 1.6 only provide an additionnal calendar I was a little bit
> disappointed expected more widgets in this version. Is there a plan to
> add such widgets in future releases or is it a choice to provide a
> basic set and opening the field to third party libraries ?
>
> >
>

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] [google-web-toolkit commit] r5314 - Modifies c.g.g.core.ext.soyc.impl.MemberFactory to have the correct

2009-05-01 Thread codesite-noreply

Author: sp...@google.com
Date: Fri May  1 06:41:53 2009
New Revision: 5314

Modified:
trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/MemberFactory.java
 
trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java
trunk/dev/core/src/com/google/gwt/dev/jjs/Correlation.java

Log:
Modifies c.g.g.core.ext.soyc.impl.MemberFactory to have the correct
new constructor paramater type (JDeclarationType versus JReferenceType).
This allows -soyc compiles to again succeed.

Review by: scottb



Modified:  
trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/MemberFactory.java
==
--- trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/MemberFactory.java 
 
(original)
+++ trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/MemberFactory.java 
 
Fri May  1 06:41:53 2009
@@ -16,6 +16,7 @@
  package com.google.gwt.core.ext.soyc.impl;

  import com.google.gwt.core.ext.soyc.Member;
+import com.google.gwt.dev.jjs.ast.JDeclaredType;
  import com.google.gwt.dev.jjs.ast.JField;
  import com.google.gwt.dev.jjs.ast.JMethod;
  import com.google.gwt.dev.jjs.ast.JReferenceType;
@@ -42,8 +43,8 @@
  return getOrCreate(method, StandardMethodMember.class, JMethod.class);
}

-  public StandardClassMember get(JReferenceType type) {
-return getOrCreate(type, StandardClassMember.class,  
JReferenceType.class);
+  public StandardClassMember get(JDeclaredType type) {
+return getOrCreate(type, StandardClassMember.class,  
JDeclaredType.class);
}

public StandardFunctionMember get(JsFunction function) {

Modified:  
trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java
==
---  
trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java 
 
(original)
+++  
trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java 
 
Fri May  1 06:41:53 2009
@@ -27,6 +27,7 @@
  import com.google.gwt.dev.jjs.Correlation;
  import com.google.gwt.dev.jjs.SourceInfo;
  import com.google.gwt.dev.jjs.Correlation.Axis;
+import com.google.gwt.dev.jjs.ast.JDeclaredType;
  import com.google.gwt.dev.jjs.ast.JField;
  import com.google.gwt.dev.jjs.ast.JMethod;
  import com.google.gwt.dev.jjs.ast.JProgram;
@@ -230,7 +231,7 @@

switch (c.getAxis()) {
  case CLASS: {
-  JReferenceType type = c.getType();
+  JDeclaredType type = c.getType();
StandardClassMember member = memberFactory.get(type);
membersByCorrelation.put(c, member);
classesMutable.add(member);
@@ -238,7 +239,7 @@
  }
  case FIELD: {
JField field = c.getField();
-  JReferenceType type = c.getType();
+  JDeclaredType type = c.getType();
StandardFieldMember member = memberFactory.get(field);
memberFactory.get(type).addField(member);
membersByCorrelation.put(c, member);
@@ -253,7 +254,7 @@
  }
  case METHOD: {
JMethod method = c.getMethod();
-  JReferenceType type = c.getType();
+  JDeclaredType type = c.getType();
StandardMethodMember member = memberFactory.get(method);
memberFactory.get(type).addMethod(member);
membersByCorrelation.put(c, member);

Modified: trunk/dev/core/src/com/google/gwt/dev/jjs/Correlation.java
==
--- trunk/dev/core/src/com/google/gwt/dev/jjs/Correlation.java  (original)
+++ trunk/dev/core/src/com/google/gwt/dev/jjs/Correlation.java  Fri May  1  
06:41:53 2009
@@ -15,9 +15,9 @@
   */
  package com.google.gwt.dev.jjs;

+import com.google.gwt.dev.jjs.ast.JDeclaredType;
  import com.google.gwt.dev.jjs.ast.JField;
  import com.google.gwt.dev.jjs.ast.JMethod;
-import com.google.gwt.dev.jjs.ast.JReferenceType;
  import com.google.gwt.dev.js.ast.JsFunction;
  import com.google.gwt.dev.js.ast.JsName;

@@ -270,9 +270,9 @@
  }
}

-  public JReferenceType getType() {
+  public JDeclaredType getType() {
  if (axis == Axis.CLASS) {
-  return (JReferenceType) astReference;
+  return (JDeclaredType) astReference;
  } else if (axis == Axis.METHOD) {
return ((JMethod) astReference).getEnclosingType();
  } else if (axis == Axis.FIELD) {

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: How to build a big GWT application

2009-05-01 Thread Joel Webber
Gilles,
You're definitely on the right track (in my mind, at least) building a
monolithic application, as that's precisely what GWT was designed for. As
you suggest, trying to split an application up into lots of modules on one
page can be a real headache, for precisely the reasons you describe. As with
any large Javascript app, there will likely come a time when you want to
divide it into a couple of large sections, but the dividing line between
these parts will tend to be pretty obvious (user-facing vs. management
interfaces, separate settings pages, and so forth).

400 java sources is far from the largest application we've run the compiler
on. I haven't run into a stack overflow in the compiler in a while, but if
you're seeing this, you might want to try bumping up the -Xss on the
compiler's command line. If the problem persists, definitely let us know.

Cheers,
joel.

On Fri, May 1, 2009 at 1:33 AM, Gilles B  wrote:

>
> I don't know if it's a good idea, building a 100% GWT monolithic
> application but I reach the compiler bounds with a medium application
> (400 java sources in client directory and some gwt modules). It's
> possible to increase java memory or factorize some java code parts,
> but it's not a solution. Soon you reach another error with the
> message:
>   [ERROR] Unexpected internal compiler error
>   java.lang.StackOverflowError: null
> If this is not only a memory issue considering the growing size of
> generated java script application page.
> Furthermore running in host mode become longer when your app is
> growing.
>
> I am sure in GWT framework team, you have done a very good job. I
> don't want to misuse it !
>
> What is a good strategy if I want such application ?
>
> An idea I try is to split the application but I need an extra Html
> page to embed all parts. This page is a pure html page or an another
> gwt application. But I need to extract some shared parts as libraries
> and to implement an extra mechanism to share context information
> between parts. Then I notice that the historic management doesnt
> fit...
>
> I also imagine to extract some java code as a separated javascript but
> I choose GWT to avoid dealing with JS and appreciate the Eclipse dev
> cycle, with debug... and java is realy cool.
>
> Not so easy ! If someone have a good idea to share... ?
>
> Gilles.
>
> >
>

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---