[gwt-contrib] [google-web-toolkit] r6035 committed - Add changes to prompt the user if we don't find the current web server...

[codesite-noreply]

Revision: 6035
Author: j...@google.com
Date: Sat Aug 29 22:15:21 2009
Log: Add changes to prompt the user if we don't find the current web server  
in
the access list, cleanup old libraries, changes from review feedback.

http://code.google.com/p/google-web-toolkit/source/detail?r=6035

Added:
  /changes/jat/plugins/plugins/xpcom/UserAgents.txt
   
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3/platform/Linux_x86_64-gcc3/components/libgwt_dmp_ff3.so
   
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3+/platform/Linux_x86_64-gcc3/components/libgwt_dmp_ff3+.so
Deleted:
  /changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff2/install.rdf
   
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff2/platform/Linux_x86-gcc3/components/liboophm_ff2.so
   
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff2/platform/Linux_x86_64-gcc3/components/liboophm_ff2.so
  /changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3/chrome.manifest
  /changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3/install.rdf
   
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3/platform/Darwin_x86-gcc3/components/liboophm.dylib
   
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3/platform/Linux_x86-gcc3/components/liboophm_ff3.so
   
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3/platform/Linux_x86_64-gcc3/components/liboophm_ff3.so
  /changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3+/chrome.manifest
  /changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3+/install.rdf
   
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3+/platform/Linux_x86_64-gcc3/components/liboophm_ff3+.so
   
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff35/platform/Linux_x86_64-gcc3/components/liboophm_ff35.so
  /changes/jat/plugins/plugins/xpcom/prebuilt/oophm-xpcom-ff2.xpi
  /changes/jat/plugins/plugins/xpcom/prebuilt/oophm-xpcom-ff3+.xpi
  /changes/jat/plugins/plugins/xpcom/prebuilt/oophm-xpcom-ff3.xpi
  /changes/jat/plugins/plugins/xpcom/prebuilt/oophm-xpcom-ff35.xpi
Modified:
  /changes/jat/plugins/plugins/xpcom/ExternalWrapper.cpp
  /changes/jat/plugins/plugins/xpcom/ExternalWrapper.h
  /changes/jat/plugins/plugins/xpcom/FFSessionHandler.cpp
  /changes/jat/plugins/plugins/xpcom/FFSessionHandler.h
  /changes/jat/plugins/plugins/xpcom/Makefile
  /changes/jat/plugins/plugins/xpcom/ModuleOOPHM.cpp
  /changes/jat/plugins/plugins/xpcom/Preferences.cpp
  /changes/jat/plugins/plugins/xpcom/Preferences.h
  /changes/jat/plugins/plugins/xpcom/prebuilt/extension/content/options.xul
  /changes/jat/plugins/plugins/xpcom/prebuilt/extension/content/prefScript.js

===
--- /dev/null
+++ /changes/jat/plugins/plugins/xpcom/UserAgents.txt   Sat Aug 29 22:15:21  
2009
@@ -0,0 +1,8 @@
+User agents that work with ff3 XPI:
+===
+Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.13) Gecko/2009080315  
Ubuntu/9.04 (jaunty) Firefox/3.08
+
+User agents that work with ff3+ XPI:
+
+Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.12) Gecko/2009072110  
Fedora/3.0.12-1.fc10 Firefox/3.0.12
+
===
--- /dev/null   
+++  
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3/platform/Linux_x86_64-gcc3/components/libgwt_dmp_ff3.so

Sat Aug 29 22:15:21 2009
File is too large to display a diff.
===
--- /dev/null   
+++  
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3+/platform/Linux_x86_64-gcc3/components/libgwt_dmp_ff3+.so
  
Sat Aug 29 22:15:21 2009
File is too large to display a diff.
===
--- /changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff2/install.rdf   
 
Mon Aug  3 08:30:11 2009
+++ /dev/null
@@ -1,46 +0,0 @@
-
-http://www.w3.org/1999/02/22-rdf-syntax-ns#";
- xmlns:em="http://www.mozilla.org/2004/em-rdf#";>
-
-  
-oophm-xpcom-...@gwt.google.com
-GWT Hosted Mode Plugin (XPCOM) for FF v1.5-2.x
-0.0.-1M.20090803104826
-2
-
-  
-{ec8030f7-c20a-464f-9b0e-13a3a9e97384}
-1.5
-2.*
-  
-
-
-
-A plugin to support hosted-mode development of GWT  
applications
-Google, Inc.
-http://code.google.com/webtoolkit/
-chrome://gwt-oophm/skin/icon.png
-
-Linux_x86-gcc3
-Linux_x86_64-gcc3
-Darwin_x86-gcc3
-
-
-
-  
-
===
---  
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff2/platform/Linux_x86-gcc3/components/liboophm_ff2.so
 
Sat Aug 22 16:59:24 2009
+++ /dev/null   
Binary file, no diff available.
===
---  
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff2/platform/Linux_x86_64-gcc3/components/liboophm_ff2.so
  
Sat Aug 22 16:59:24 2009
+++ /dev/null   
Binary file, no diff available.
===
---  
/changes/jat/plugins/plugins/xpcom/prebuilt/extension-ff3/c

[gwt-contrib] [google-web-toolkit] r6032 committed - Create a temporary change branch for OOPHM plugin work.

[codesite-noreply]

Revision: 6032
Author: j...@google.com
Date: Sat Aug 29 12:11:51 2009
Log: Create a temporary change branch for OOPHM plugin work.

http://code.google.com/p/google-web-toolkit/source/detail?r=6032

Added:
  /changes/jat/plugins


--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] [google-web-toolkit] r6034 committed - Created wiki page through web user interface.

[codesite-noreply]

Revision: 6034
Author: tamplinjohn
Date: Sat Aug 29 20:14:35 2009
Log: Created wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=6034

Added:
  /wiki/TroubleshootingOOPHM.wiki

===
--- /dev/null
+++ /wiki/TroubleshootingOOPHM.wiki Sat Aug 29 20:14:35 2009
@@ -0,0 +1,6 @@
+#summary Troubleshooting Guide for the GWT Development Mode browser plugin
+#labels Phase-Implementation
+
+= Introduction =
+
+This is just a placeholder, content to be added.

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Hello UiBinder

[Xijiang Miao]

Yes. That's what I did. Thanks!

I have to enable the animation to use two nested DisclosurePanel. Otherwise,
the parent disclosure panel does not resize properly when the child panel is
opening/closing.


On Sun, Aug 23, 2009 at 1:57 PM, Amir Kashani  wrote:

> Xijiang,
> Take a look at com.google.gwt.uibinder.sample.client.WidgetBasedUi &
> WidgetBasedUi.ui.xml (part of gwt-user.jar). That test template uses
> DisclosurePanel along with the other supported custom panel types.
>
> - Amir
>
>
> On Fri, Aug 21, 2009 at 7:13 PM, puttyshell  wrote:
>
>>
>> Ray,
>>
>> You mentioned that DisclosurePanel is supported by Uibinder. Do you
>> know how to config the *.ui.xml?
>>
>> UiBinder greatly bridges the gap between traditional html design and
>> the java coding. I am already very happy just using HTMLPanel + normal
>> html + ui:field + styleName. :)
>>
>> ~Xijiang
>>
>>
>> On Aug 6, 9:39 am, Andrés Testi  wrote:
>> > UiBinder is awesome!
>> >
>> > An extra degree of decoupling, could be done by adding the next stuff
>> > to the UiBinder interface:
>> >
>> > public interface UiBinder {
>> >
>> >U createAndBindUi(O owner);
>> >
>> >   public static interface Pair{
>> > R getRoot();
>> > O getOwner();
>> >   }
>> >
>> >   Pair createAndBindUi();
>> >
>> > }
>> >
>> > where createAndBind() without parameters could instantiate an owner
>> > class, enabling injection by constructor for UiField for more robust
>> > code.
>> >
>> > - Andrés
>> >
>> > On 5 ago, 10:32, Ray Ryan  wrote:> The GWT standard
>> widgets already have custom parsers built for them.
>> > > DockPanel, DisclosurePanel, Menubar, etc. all work just fine despite
>> their
>> > > wonky api needs. The bug here is that you can't indulge in similar
>> glue for
>> > > your custom widgets yet. No Google team has found that to be a problem
>> with
>> > > their custom widgets, which is I why I felt like I could get away with
>> > > ducking that issue a bit longer.
>> >
>> > > On Wed, Aug 5, 2009 at 1:31 AM, brett.wooldridge <
>> brett.wooldri...@gmail.com
>> >
>> > > > wrote:
>> >
>> > > > Just a question, and a comment.  First the comment.  Thank you for
>> > > > getting this up into the repo, in whatever state.  Second, it was
>> > > > commented that Adwords and a few other projects have vetted this
>> over
>> > > > the past year.  How does this jibe with the deficiencies outlined?
>> > > > For example, not being able to markup for DockPanel, etc?  Did those
>> > > > projects just have to go "off-roading" and create custom parsers
>> based
>> > > > on an API they knew they would eventually have to fix/rewrite?
>> >
>> > > > -Brett
>> >
>> > > > On Aug 5, 5:49 am, Ray Ryan  wrote:
>> > > > > I share your concern, Amir, but I'm even more afraid of a)
>> providing an
>> > > > ill
>> > > > > considered API for custom parsers and b) delaying 2.0. I'm pretty
>> > > > confident
>> > > > > we can limp along without them for a dot release.
>> >
>> > > > > On Tue, Aug 4, 2009 at 1:36 PM, Amir Kashani <
>> amirkash...@gmail.com>
>> > > > wrote:
>> > > > > > As Ray mentioned, one has a pretty simple workaround and two is
>> pretty
>> > > > > > uncommon. I'm a little more concerned about the third case. A
>> few
>> > > > examples
>> > > > > > of issue with internally used widgets I've created:
>> >
>> > > > > > - A StackPanel replacement that adds animation support. The only
>> > > > workaround
>> > > > > > I can think of is having the add() method take a StackPanelItem
>> or
>> > > > similar
>> > > > > > that contains the header text or widget.
>> > > > > > - TitledPanel, which supports a header, content and footer area.
>> In
>> > > > this
>> > > > > > case, the widget could expect several calls to add, and
>> determine the
>> > > > > > context based on number of previous calls. This would get a bit
>> hairy
>> > > > if
>> > > > > > headers and footers were optional, though.
>> >
>> > > > > > These scenarios are a bit inconvenient without a custom parser,
>> but far
>> > > > > > from a deal breaker. The concern is that people develop a set of
>> > > > hackish
>> > > > > > workarounds that aren't easily fixed when custom parsers are
>> supported.
>> >
>> > > > > > - Amir
>> >
>> > > > > > On Tue, Aug 4, 2009 at 12:47 PM, Joel Webber 
>> wrote:
>> >
>> > > > > >> There are three cases where custom parsers come up:1. Widgets
>> without
>> > > > a
>> > > > > >> default constructor.
>> > > > > >> 2. Non-widget UIObjects that need an XML representation.
>> > > > > >> 3. Panels that need more than the default add() method to deal
>> > > > properly
>> > > > > >> with child widgets.
>> >
>> > > > > >> The former is usually pretty easy to work around, and it seldom
>> comes
>> > > > up
>> > > > > >> much in practice (I think it came up for MenuBar, because it
>> wants its
>> > > > > >> 'direction' as an invariant -- that wasn't even a good design
>> anyway).
>> >
>> > > > > >> The second case doesn't come up all that often, but it's
>> important for
>> > > > > >> m

[gwt-contrib] [google-web-toolkit] r6030 committed - Adds more detailed assertions to RunAsyncMetricsIntegrationTest....

[codesite-noreply]

Revision: 6030
Author: sp...@google.com
Date: Fri Aug 28 14:08:33 2009
Log: Adds more detailed assertions to RunAsyncMetricsIntegrationTest.

Review by: jlabanca (desk check)

http://code.google.com/p/google-web-toolkit/source/detail?r=6030

Modified:
   
/trunk/user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java

===
---  
/trunk/user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java
 
Thu Aug 20 11:38:19 2009
+++  
/trunk/user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java
 
Fri Aug 28 14:08:33 2009
@@ -164,7 +164,7 @@
private void checkMetricsWithCodeSplitting() {
  int lastMillis;
  {
-  LightweightMetricsEvent event = lwmObserver.events.remove();
+  LightweightMetricsEvent event = nextEvent("leftoversDownload-begin");
assertEquals(getJunitModuleName(), event.getModuleName());
assertEquals("leftoversDownload", event.getEvtGroup());
assertEquals("begin", event.getType());
@@ -173,7 +173,7 @@
lastMillis = event.getMillis();
  }
  {
-  LightweightMetricsEvent event = lwmObserver.events.remove();
+  LightweightMetricsEvent event = nextEvent("leftoversDownload-end");
assertEquals(getJunitModuleName(), event.getModuleName());
assertEquals("leftoversDownload", event.getEvtGroup());
assertEquals("end", event.getType());
@@ -182,7 +182,7 @@
lastMillis = event.getMillis();
  }
  {
-  LightweightMetricsEvent event = lwmObserver.events.remove();
+  LightweightMetricsEvent event = nextEvent("download1-begin");
assertEquals(getJunitModuleName(), event.getModuleName());
assertEquals("download1", event.getEvtGroup());
assertEquals("begin", event.getType());
@@ -191,7 +191,7 @@
lastMillis = event.getMillis();
  }
  {
-  LightweightMetricsEvent event = lwmObserver.events.remove();
+  LightweightMetricsEvent event = nextEvent("download1-end");
assertEquals(getJunitModuleName(), event.getModuleName());
assertEquals("download1", event.getEvtGroup());
assertEquals("end", event.getType());
@@ -200,7 +200,7 @@
lastMillis = event.getMillis();
  }
  {
-  LightweightMetricsEvent event = lwmObserver.events.remove();
+  LightweightMetricsEvent event = nextEvent("runCallbacks1-begin");
assertEquals(getJunitModuleName(), event.getModuleName());
assertEquals("runCallbacks1", event.getEvtGroup());
assertEquals("begin", event.getType());
@@ -208,7 +208,7 @@
lastMillis = event.getMillis();
  }
  {
-  LightweightMetricsEvent event = lwmObserver.events.remove();
+  LightweightMetricsEvent event = nextEvent("runCallbacks1-end");
assertEquals(getJunitModuleName(), event.getModuleName());
assertEquals("runCallbacks1", event.getEvtGroup());
assertEquals("end", event.getType());
@@ -216,6 +216,15 @@
lastMillis = event.getMillis();
  }
}
+
+  /**
+   * Remove the next event from {...@link #lwmObserver}. If there are no more
+   * events, fail with the specified message.
+   */
+  private LightweightMetricsEvent nextEvent(String description) {
+assertTrue("Missing event: " +  
description, !lwmObserver.events.isEmpty());
+return lwmObserver.events.remove();
+  }

/**
 * Check the LWM assuming no code splitting happened.
@@ -224,7 +233,7 @@
  int lastMillis;

  {
-  LightweightMetricsEvent event = lwmObserver.events.remove();
+  LightweightMetricsEvent event = nextEvent("noDownloadNeeded-begin");
assertEquals(getJunitModuleName(), event.getModuleName());
assertEquals("noDownloadNeeded", event.getEvtGroup());
assertEquals("begin", event.getType());
@@ -232,7 +241,7 @@
lastMillis = event.getMillis();
  }
  {
-  LightweightMetricsEvent event = lwmObserver.events.remove();
+  LightweightMetricsEvent event = nextEvent("noDownloadNeeded-end");
assertEquals(getJunitModuleName(), event.getModuleName());
assertEquals("noDownloadNeeded", event.getEvtGroup());
assertEquals("end", event.getType());

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] [google-web-toolkit] r6023 committed - File.createTempFile() sometimes hangs on the build system while trying...

[codesite-noreply]

Revision: 6023
Author: jlaba...@google.com
Date: Thu Aug 27 11:09:46 2009
Log: File.createTempFile() sometimes hangs on the build system while trying  
to get an exclusive lock on a temp file.  This patch uses a custom method  
to create a temp file.

Patch by: jlabanca
Review by: fabbott


http://code.google.com/p/google-web-toolkit/source/detail?r=6023

Modified:
   
/trunk/build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java

===
---  
/trunk/build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java   
 
Tue Jun 16 08:28:58 2009
+++  
/trunk/build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java   
 
Thu Aug 27 11:09:46 2009
@@ -1,12 +1,12 @@
  /*
   * Copyright 2008 Google Inc.
- *
+ *
   * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
   * use this file except in compliance with the License. You may obtain a  
copy of
   * the License at
- *
+ *
   * http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
   * Unless required by applicable law or agreed to in writing, software
   * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT
   * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -28,12 +28,13 @@
  import java.io.InputStream;
  import java.io.OutputStream;
  import java.util.Map;
+import java.util.Random;
  import java.util.TreeMap;

  /**
   * A variation on Jar which handles duplicate entries by only archiving  
the most
   * recent of any given path. This is done by keeping a map of paths (as  
shown in
- * the jar file) against {...@link #EntryInfo} objects identifying the input  
source
+ * the jar file) against {...@link EntryInfo} objects identifying the input  
source
   * and its timestamp. Most of the actual archiving is deferred until  
archive
   * finalization, when we've decided on the actual de-duplicated set of  
entries.
   */
@@ -54,7 +55,7 @@

  /**
   * Called to actually add the entry to a given zip stream.
- *
+ *
   * @param out
   * @param path
   * @throws IOException
@@ -101,7 +102,7 @@
  public FileEntryInfo(InputStream in, long lastModified, File  
fromArchive,
  int mode) throws IOException {
super(lastModified, mode);
-  tmpFile = File.createTempFile("gwtjar", "");
+  tmpFile = createTempFile("gwtjar", "");
tmpFile.deleteOnExit();
OutputStream fos = new FileOutputStream(tmpFile);
int readLen = in.read(buffer);
@@ -124,6 +125,54 @@
}
  }
}
+
+  /**
+   * Used to generate temporary file names.
+   */
+  private static long counter = -1;
+
+  /**
+   * Creates a temporary file.
+   *
+   * @param prefix the file prefix
+   * @param suffix the file suffix
+   * @return the new file
+   * @throws IOException if the file cannot be created
+   */
+  private static File createTempFile(String prefix, String suffix)
+  throws IOException {
+if (suffix == null) {
+  suffix = ".tmp";
+}
+
+// Get the temp file directory.
+File tmpDir = new File(System.getProperty("java.io.tmpdir"));
+tmpDir.mkdirs();
+
+// Generate a random name.
+if (counter == -1) {
+  counter = new Random().nextLong();
+}
+boolean created = false;
+File tmpFile;
+do {
+  counter++;
+  tmpFile = new File(tmpDir, prefix + Long.toString(counter) + suffix);
+  if (!tmpFile.exists()) {
+created = tmpFile.createNewFile();
+if (!created) {
+  // If we fail the create the temp file, it must have been  
created by
+  // another thread between lines 161 and 162.  We re-seed to avoid
+  // further race conditions.
+  counter = new Random().nextLong();
+}
+  }
+} while (!created);
+
+// Create the file.
+tmpFile.createNewFile();
+return tmpFile;
+  }

private byte buffer[] = new byte[16 * 1024];
private Map paths = new TreeMap();
@@ -188,10 +237,10 @@
/**
 * Checks whether an entry should be replaced, by touch dates and  
duplicates
 * setting.
-   *
+   *
 * @param path the path of an entry being considered
 * @param touchTime the lastModified of the candiate replacement
-   * @return
+   * @return true if the file should be replaced
 */
private boolean shouldReplace(String path, long touchTime) {
  EntryInfo oldInfo = paths.get(path);

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Prettier GWT version names for upcoming 2.0 releases

[Cameron Braid]

JBoss use a naming scheme that sorts alphabetically, maybe it is worth
considering

http://www.jboss.org/jbossas/downloads/

Applied to the names in the original email

1) gwt-2.0.0-m1.zip
2) gwt-2.0.0-m2.zip
3) gwt-2.0.0-rc1.zip
4) gwt-2.0.0.zip

They could be :

1) gwt-2.0.0-Beta1.zip (or could just use B1)
2) gwt-2.0.0-Beta2.zip
3) gwt-2.0.0-CR1.zip  (candidate for release)
4) gwt-2.0.0-GA.zip

Cam




2009/8/28 Andrew Bowers 

> The current problem we are trying to solve is that it is hard to know which
> build is a major release for those who aren't intimate.
> For 1.6, the golden release was 1.6.4, which is thoroughly confusing to a
> general user who doesn't follow the development cycle. If you only care
> about the final release, you expect that you would migrate to 1.6.0 as the
> final release and 1.6.1 would be an update to that.
>
> If someone is commenting
> on a bug in a pre-release build, something labeled 1.6.0-RC1, then they will 
> know what build they are using. If they don't, then they probably shouldn't 
> be using it.
>
> I strongly believe this use case trumps the other issues.
>
> On Thu, Aug 13, 2009 at 12:01 PM, Scott Blum  wrote:
>
>> On Thu, Aug 13, 2009 at 2:41 PM, Kelly Norton  wrote:
>>
>>> fwiw, I've never found myself sorting GWT distros but I do find myself
>>> wanting to uniquely identify them all the time. Why do you think people will
>>> be so eager to ignore part of the label? I would actually be surprised if
>>> any form of naming fixes the few incidences of the conversation you mention.
>>> I tend to think those are because people really do think they are using the
>>> release ... only to realize later they never updated their project.
>>>
>>
>> Heh, sorry, that was probably not the best way of making this point: I
>> think more obvious is usually better, because you don't have to think about
>> it.  This means less wasted time, and less chance of confusion.
>>
>> Don't get me wrong, I'm not saying the current system is perfect or that
>> we shouldn't change it.  I'm sure there are better things than we're doing
>> right now, which might help with the problem of identifying a release vs. a
>> milestone or rc.  But I do think a system where the numeric portion of the
>> version is non-unique invites confusion.
>>
>> What if we were more consistent with the parentheticals, like in the GWT 
>> release
>> notes
>> ?
>>
>
>
> >
>

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] [google-web-toolkit] r6031 committed - Disabling test because it is flaky on HtmlUnit....

[codesite-noreply]

Revision: 6031
Author: jlaba...@google.com
Date: Fri Aug 28 14:37:20 2009
Log: Disabling test because it is flaky on HtmlUnit.

Patch by: jlabanca
Review by: spoon (desk)


http://code.google.com/p/google-web-toolkit/source/detail?r=6031

Modified:
   
/trunk/user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java

===
---  
/trunk/user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java
 
Fri Aug 28 14:08:33 2009
+++  
/trunk/user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java
 
Fri Aug 28 14:37:20 2009
@@ -18,6 +18,8 @@
  import com.google.gwt.core.client.GWT;
  import com.google.gwt.core.client.JavaScriptObject;
  import com.google.gwt.core.client.RunAsyncCallback;
+import com.google.gwt.junit.DoNotRunWith;
+import com.google.gwt.junit.Platform;
  import com.google.gwt.junit.client.GWTTestCase;
  import com.google.gwt.user.client.Command;
  import com.google.gwt.user.client.DeferredCommand;
@@ -31,7 +33,10 @@
   * lightweight metrics make it all the way out to the JavaScript LWM  
system. A
   * number of more detailed tests are in
   * {...@link com.google.gwt.core.client.impl.AsyncFragmentLoaderTest}.
+ *
+ * This test is flaky on HtmlUnit.
   */
+...@donotrunwith(Platform.Htmlunit)
  public class RunAsyncMetricsIntegrationTest extends GWTTestCase {
private static final class LightweightMetricsEvent extends  
JavaScriptObject {
  protected LightweightMetricsEvent() {

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---