[gwt-contrib] Re: No more massive copy paste between our request (issue250801)

2010-03-21 Thread amitmanjhi

LGTM. Thanks for the patch, the code is much cleaner now.


http://gwt-code-reviews.appspot.com/250801/diff/2001/18
File
bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java
(right):

http://gwt-code-reviews.appspot.com/250801/diff/2001/18#newcode3
bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java:3:
*
unnecessary change (in other lines as well).

http://gwt-code-reviews.appspot.com/250801/diff/2001/18#newcode33
bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java:33:

is this method necessary? Seems like a convenience method that can be
removed to keep the api surface area low.

http://gwt-code-reviews.appspot.com/250801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

To unsubscribe from this group, send email to 
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with 
the words "REMOVE ME" as the subject.


[gwt-contrib] Re: IE9 preview support ?

2010-03-21 Thread Brendan Kenny
I get the same DOMContentLoaded error, but that's as expected. Check
out the "addEventListener event registration" section in the release
notes:

http://ie.microsoft.com/testdrive/info/ReleaseNotes/Default.html#WPKI

My applications all work as well--even while throwing that error--
which is weird. I wouldn't think the bootstrap script would work if
the event is detected as implemented but never fires, but there it is.

I'm a big fan of Microsoft's choice of chrome for the preview...no one
will be using this as their default browser and complaining
accordingly.

On Mar 21, 2:32 pm, Matt Mastracci  wrote:
> I'm seeing the same thing in our application. I haven't had time to dig into 
> it, but I'm seeing 'unknown event DOMContentLoaded' in the developer tools 
> console.  The GWT Showcase example works, however.  Maybe some sort of 
> doctype issue?
>
> On 2010-03-20, at 4:53 AM, nicolas.deloof wrote:
>
>
>
> > Hi,
>
> > I tried my GWT 2.0 webapp with the recent test build of IE9 and it
> > doesn't display. I wonder IE9 is not recognized as IE, event whit "IE8
> > mode" set.
>
> > The browser may use a unsuported user-agent ID, is there allready any
> > test done on this "new" browser ? roadmap to support its better
> > support for standards ?
>
> > Cheers,
> > Nicolas
>
> > --
> >http://groups.google.com/group/Google-Web-Toolkit-Contributors
>
> > To unsubscribe from this group, send email to 
> > google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to 
> > this email with the words "REMOVE ME" as the subject.

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

To unsubscribe from this group, send email to 
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this 
email with the words "REMOVE ME" as the subject.


Re: [gwt-contrib] IE9 preview support ?

2010-03-21 Thread John LaBanca
@Joel -

I don't know if there is a release date set for IE9, but we should test it
out pretty soon.

Thanks,
John LaBanca
jlaba...@google.com


On Sun, Mar 21, 2010 at 3:32 PM, Matt Mastracci wrote:

> I'm seeing the same thing in our application. I haven't had time to dig
> into it, but I'm seeing 'unknown event DOMContentLoaded' in the developer
> tools console.  The GWT Showcase example works, however.  Maybe some sort of
> doctype issue?
>
> On 2010-03-20, at 4:53 AM, nicolas.deloof wrote:
>
> > Hi,
> >
> > I tried my GWT 2.0 webapp with the recent test build of IE9 and it
> > doesn't display. I wonder IE9 is not recognized as IE, event whit "IE8
> > mode" set.
> >
> > The browser may use a unsuported user-agent ID, is there allready any
> > test done on this "new" browser ? roadmap to support its better
> > support for standards ?
> >
> > Cheers,
> > Nicolas
> >
> > --
> > http://groups.google.com/group/Google-Web-Toolkit-Contributors
> >
> > To unsubscribe from this group, send email to
> google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to
> this email with the words "REMOVE ME" as the subject.
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>
> To unsubscribe from this group, send email to
> google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to
> this email with the words "REMOVE ME" as the subject.
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

To unsubscribe from this group, send email to 
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this 
email with the words "REMOVE ME" as the subject.


Re: [gwt-contrib] IE9 preview support ?

2010-03-21 Thread Matt Mastracci
I'm seeing the same thing in our application. I haven't had time to dig into 
it, but I'm seeing 'unknown event DOMContentLoaded' in the developer tools 
console.  The GWT Showcase example works, however.  Maybe some sort of doctype 
issue?

On 2010-03-20, at 4:53 AM, nicolas.deloof wrote:

> Hi,
> 
> I tried my GWT 2.0 webapp with the recent test build of IE9 and it
> doesn't display. I wonder IE9 is not recognized as IE, event whit "IE8
> mode" set.
> 
> The browser may use a unsuported user-agent ID, is there allready any
> test done on this "new" browser ? roadmap to support its better
> support for standards ?
> 
> Cheers,
> Nicolas
> 
> -- 
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> 
> To unsubscribe from this group, send email to 
> google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this 
> email with the words "REMOVE ME" as the subject.

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

To unsubscribe from this group, send email to 
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this 
email with the words "REMOVE ME" as the subject.


[gwt-contrib] Re: IE9 preview support ?

2010-03-21 Thread Thomas Broyer

On Mar 20, 11:53 am, "nicolas.deloof" 
wrote:
> Hi,
>
> I tried my GWT 2.0 webapp with the recent test build of IE9 and it
> doesn't display. I wonder IE9 is not recognized as IE, event whit "IE8
> mode" set.

I tested our two apps and they (seem to) work OK. Developer tools tell
me document mode is IE9 (and browser mode unknown !?), so given the
property-provider it should use the ie8 permutation (though I haven't
checked).

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

To unsubscribe from this group, send email to 
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this 
email with the words "REMOVE ME" as the subject.