[gwt-contrib] GWT Locale using the Browser's language preference

2010-10-06 Thread Bernie1953
I was looking at a way for a GWT application to use the Browser's
language preference without having to either provide the parameter
(locale=fr) on the URL or to add the metatag for the locale in the
HTML.

The solution is quite easy to implement as long as the GWT application
is running within a Servlet container (e.g. Jetty, Tomcat).

The first step is to have the GWT application localized for the
language you want to use.  I will not explain how to do that since the
documentation of GWT is quite clear.

The second step is to create a JSP from the HTML, i.e. copy the HTML
as JSP.
For example: copy TestLocale.html to TestLocale.jsp

You add the following lines at top of the JSP:
%@ page language=java contentType=text/html; charset=UTF-8
pageEncoding=UTF-8
import=java.util.Locale %

You add the following metatag within the head tag of the html
contained in the JSP
meta name=gwt:property content=locale=%=request.getLocale()
%

The third step is to replace html by jsp in the welcome-file tag
within web.xml:
For example:
  welcome-file-list
welcome-fileTestLocale.html/welcome-file
  /welcome-file-list
become
  welcome-file-list
welcome-fileTestLocale.jsp/welcome-file
  /welcome-file-list

The fourth step .. testing by replacing html by jsp in the URL.

I have an Eclipse project where I internalionalized (English and
French) the default GWT project created by the Eclipse plugin.  I
could share the project if required.

You are free to incorporate my humble contribution in the GWT
documentation unless there is something wrong with it, in which case I
would like to know what.

Regards,

Bernie1953

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] DeRPC works with draftCompile, but not when optimized

2010-10-06 Thread stuckagain
I have a rather large codebase where we decided to tryout DeRPC for a
request that was too complex for the standard RPC.

Everything looked good until I removed the draftCompile switch.

The RpcServlet serializes the response but the client fails with a
Incompatible Remote Service.

Is this a known problem ? Is there a pattern that could be causing
this ?
I am using an overridden findClientOracleData because the URL is
mapped, but that one is working fine.

David

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8950 committed - Correct the servlet URL mapping in the LogExample sample

2010-10-06 Thread codesite-noreply

Revision: 8950
Author: zun...@google.com
Date: Wed Oct  6 05:17:48 2010
Log: Correct the servlet URL mapping in the LogExample sample

http://code.google.com/p/google-web-toolkit/source/detail?r=8950

Modified:
 /trunk/samples/logexample/war/WEB-INF/web.xml

===
--- /trunk/samples/logexample/war/WEB-INF/web.xml   Mon Sep 13 08:42:16 2010
+++ /trunk/samples/logexample/war/WEB-INF/web.xml   Wed Oct  6 05:17:48 2010
@@ -9,7 +9,7 @@

   servlet-mapping
 servlet-namemyServlet/servlet-name
-url-pattern/logexample/log/url-pattern
+url-patternlogexample/my_service/url-pattern
   /servlet-mapping

   servlet

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Updating the doc build file to include the new examples for Cells. Fixing the links in the assoc... (issue964801)

2010-10-06 Thread jlabanca

Reviewers: fabbott,

Description:
Updating the doc build file to include the new examples for Cells.
Fixing the links in the associated JavaDoc.


Please review this at http://gwt-code-reviews.appspot.com/964801/show

Affected files:
  M doc/build.xml
  M user/src/com/google/gwt/cell/client/AbstractCell.java
  M user/src/com/google/gwt/cell/client/AbstractEditableCell.java
  M user/src/com/google/gwt/cell/client/Cell.java
  M user/src/com/google/gwt/user/cellview/client/CellBrowser.java
  M user/src/com/google/gwt/user/cellview/client/CellList.java
  M user/src/com/google/gwt/user/cellview/client/CellTable.java
  M user/src/com/google/gwt/user/cellview/client/CellTree.java
  M user/src/com/google/gwt/user/cellview/client/SimplePager.java
  M user/src/com/google/gwt/view/client/AsyncDataProvider.java
  M user/src/com/google/gwt/view/client/ListDataProvider.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: GWT Locale using the Browser's language preference

2010-10-06 Thread Thomas Broyer


On Oct 6, 2:24 pm, Bernie1953 swtbclem...@gmail.com wrote:
 I was looking at a way for a GWT application to use the Browser's
 language preference without having to either provide the parameter
 (locale=fr) on the URL or to add the metatag for the locale in the
 HTML.

 The solution is quite easy to implement as long as the GWT application
 is running within a Servlet container (e.g. Jetty, Tomcat).

 The first step is to have the GWT application localized for the
 language you want to use.  I will not explain how to do that since the
 documentation of GWT is quite clear.

 The second step is to create a JSP from the HTML, i.e. copy the HTML
 as JSP.
 For example: copy TestLocale.html to TestLocale.jsp

 You add the following lines at top of the JSP:
 %@ page language=java contentType=text/html; charset=UTF-8
     pageEncoding=UTF-8
     import=java.util.Locale %

 You add the following metatag within the head tag of the html
 contained in the JSP
     meta name=gwt:property content=locale=%=request.getLocale()
 %

That's not enough, you should do content negotiation against the
list of locales supported by the GWT app. If the app is available in
Spanish and English and my browser is configured to send French as the
preferred language and Spanish as the second, then I should get the
app in Spanish, not in the default locale (which is likely to be
English).
Have a look at:
http://code.google.com/docreader/#p=google-web-toolkit-incubatort=ServerSideLocaleSelection

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8952 committed - Public: First take at GWT validation that actually validates on the c...

2010-10-06 Thread codesite-noreply

Revision: 8952
Author: ncha...@google.com
Date: Wed Oct  6 06:53:06 2010
Log: Public:  First take at GWT validation that actually validates on the  
client side.


Review at http://gwt-code-reviews.appspot.com/863801

Review by: robertvaw...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8952

Added:
  
/trunk/samples/validation/src/com/google/gwt/sample/validation/shared/NoOp.java
  
/trunk/samples/validation/src/com/google/gwt/sample/validation/shared/NoOpValidator.java

 /trunk/samples/validation/war/WEB-INF/lib
 /trunk/samples/validation/war/WEB-INF/lib/gwt-servlet.jar
  
/trunk/user/src/com/google/gwt/validation/client/constraints/NotGwtCompatibleValidator.java

 /trunk/user/src/org
 /trunk/user/src/org/hibernate
 /trunk/user/src/org/hibernate/validator
 /trunk/user/src/org/hibernate/validator/HibernateValidator.gwt.xml
 /trunk/user/src/org/hibernate/validator/README.txt
 /trunk/user/src/org/hibernate/validator/super
 /trunk/user/src/org/hibernate/validator/super/org
 /trunk/user/src/org/hibernate/validator/super/org/hibernate
 /trunk/user/src/org/hibernate/validator/super/org/hibernate/validator
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/ScriptAssert.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/EmailValidator.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/FutureValidatorForCalendar.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/PastValidatorForCalendar.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/PatternValidator.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/ScriptAssertValidator.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/SizeValidatorForArray.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/SizeValidatorForArraysOfBoolean.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/SizeValidatorForArraysOfByte.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/SizeValidatorForArraysOfChar.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/SizeValidatorForArraysOfDouble.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/SizeValidatorForArraysOfFloat.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/SizeValidatorForArraysOfInt.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/SizeValidatorForArraysOfLong.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/SizeValidatorForArraysOfShort.java
  
/trunk/user/src/org/hibernate/validator/super/org/hibernate/validator/constraints/impl/URLValidator.java

Modified:
 /trunk/build.xml
 /trunk/eclipse/samples/Validation/.classpath
 /trunk/eclipse/user/.classpath
 /trunk/samples/common.ant.xml
  
/trunk/samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml
  
/trunk/samples/validation/src/com/google/gwt/sample/validation/client/GreetingService.java
  
/trunk/samples/validation/src/com/google/gwt/sample/validation/client/GreetingServiceAsync.java
  
/trunk/samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java
  
/trunk/samples/validation/src/com/google/gwt/sample/validation/client/Validation.java
  
/trunk/samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java
  
/trunk/samples/validation/src/com/google/gwt/sample/validation/shared/Person.java

 /trunk/samples/validation/war/favicon.ico
 /trunk/user/build.xml
  
/trunk/user/src/com/google/gwt/validation/client/impl/AbstractGwtSpecificValidator.java
  
/trunk/user/src/com/google/gwt/validation/client/impl/AbstractGwtValidator.java
  
/trunk/user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java

 /trunk/user/src/com/google/gwt/validation/rebind/AbstractCreator.java
 /trunk/user/src/com/google/gwt/validation/rebind/BeanHelper.java
  
/trunk/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
  
/trunk/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorGenerator.java

 /trunk/user/src/com/google/gwt/validation/rebind/ValidatorCreator.java
  
/trunk/user/test/com/google/gwt/validation/example/ValidationExample.gwt.xml

 /trunk/user/test/com/google/gwt/validation/example/client/Author.java
 /trunk/user/test/com/google/gwt/validation/example/client/AuthorTest.java
  

[gwt-contrib] [google-web-toolkit] r8953 committed - Remove validation packagse from the GWT 2.1 branch....

2010-10-06 Thread codesite-noreply

Revision: 8953
Author: b...@google.com
Date: Wed Oct  6 07:46:04 2010
Log: Remove validation packagse from the GWT 2.1 branch.
Patch by: bobv
Review by: rjrjr

http://code.google.com/p/google-web-toolkit/source/detail?r=8953

Deleted:
 /releases/2.1/samples/validation
 /releases/2.1/user/src/com/google/gwt/validation
 /releases/2.1/user/src/javax
 /releases/2.1/user/test/com/google/gwt/validation
Modified:
 /releases/2.1/samples/build.xml
 /releases/2.1/user/build.xml

===
--- /releases/2.1/samples/build.xml Thu Sep 23 09:41:08 2010
+++ /releases/2.1/samples/build.xml Wed Oct  6 07:46:04 2010
@@ -38,10 +38,6 @@
 gwt.ant dir=showcase /
   /target

-  target name=validation description=Build validation
-gwt.ant dir=validation /
-  /target
-
   target name=-do description=Run all subprojects 
 antcall target=dynatable /
 antcall target=dynatablerf /
@@ -51,7 +47,6 @@
 antcall target=logexample /
 antcall target=mail /
 antcall target=showcase /
-antcall target=validation /
   /target

   target name=build description=Builds GWT
===
--- /releases/2.1/user/build.xmlWed Sep  8 15:25:08 2010
+++ /releases/2.1/user/build.xmlWed Oct  6 07:46:04 2010
@@ -136,13 +136,7 @@

   target name=checkstyle description=Static analysis of source
 gwt.checkstyle
-  fileset dir=src 
-exclude  
name=javax/validation/super/javax/validation/constraints/Pattern.java/
-exclude  
name=javax/validation/super/javax/validation/spi/ConfigurationState.java/
-exclude  
name=javax/validation/super/javax/validation/MessageInterpolator.java/
-exclude  
name=javax/validation/super/javax/validation/Configuration.java/
-exclude  
name=javax/validation/super/javax/validation/Validation.java/

-  /fileset
+  fileset dir=src /
   fileset dir=super/com/google/gwt/emul /
   fileset dir=super/com/google/gwt/junit/translatable /
 /gwt.checkstyle

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8954 committed - Creating 2.1.0-rc1

2010-10-06 Thread codesite-noreply

Revision: 8954
Author: p...@google.com
Date: Wed Oct  6 11:13:08 2010
Log: Creating 2.1.0-rc1

http://code.google.com/p/google-web-toolkit/source/detail?r=8954

Added:
 /tags/2.1.0-rc1

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8956 committed - reduce -Xmx to 1G as it is enough for now and 32-bit Windows does not ...

2010-10-06 Thread codesite-noreply

Revision: 8956
Author: k...@google.com
Date: Wed Oct  6 08:16:40 2010
Log: reduce -Xmx to 1G as it is enough for now and 32-bit Windows does not  
support -Xmx2G


http://code.google.com/p/google-web-toolkit/source/detail?r=8956

Modified:
 /trunk/common.ant.xml

===
--- /trunk/common.ant.xml   Tue Oct  5 11:17:27 2010
+++ /trunk/common.ant.xml   Wed Oct  6 08:16:40 2010
@@ -134,7 +134,7 @@
   /presetdef

   presetdef name=gwt.javac
-javac srcdir=src destdir=${javac.out} debug=${javac.debug}  
debuglevel=${javac.debuglevel} source=${javac.source}  
target=${javac.target} nowarn=${javac.nowarn}  
encoding=${javac.encoding} fork=true memoryMaximumSize=2048m /
+javac srcdir=src destdir=${javac.out} debug=${javac.debug}  
debuglevel=${javac.debuglevel} source=${javac.source}  
target=${javac.target} nowarn=${javac.nowarn}  
encoding=${javac.encoding} fork=true memoryMaximumSize=1024m /

   /presetdef

   macrodef name=gwt.jar

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Adding examples for cell widgets and data providers. (issue955801)

2010-10-06 Thread jlabanca

committed as r8944.  A follow on patch will fix the links in the
JavaDoc.

http://gwt-code-reviews.appspot.com/955801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Resolves ROO-1508 by requiring CompositeEditors to return a canonical component Editor instance ... (issue965801)

2010-10-06 Thread bobv

Reviewers: rjrjr,

Description:
Resolves ROO-1508 by requiring CompositeEditors to return a canonical
component Editor instance for path traversal.
Patch by: bobv
Review by: rjrjr


Please review this at http://gwt-code-reviews.appspot.com/965801/show

Affected files:
  M user/src/com/google/gwt/editor/client/CompositeEditor.java
  M user/src/com/google/gwt/editor/client/adapters/ListEditor.java
  M user/src/com/google/gwt/editor/client/adapters/OptionalFieldEditor.java
  M user/src/com/google/gwt/editor/rebind/AbstractEditorDriverGenerator.java
  M user/src/com/google/gwt/editor/rebind/model/EditorModel.java
  M user/test/com/google/gwt/requestfactory/client/ui/EditorTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Resolves ROO-1508 by requiring CompositeEditors to return a canonical component Editor instance ... (issue965801)

2010-10-06 Thread rjrjr

LGTM

http://gwt-code-reviews.appspot.com/965801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8957 committed - Avoid an infinite loop in toString() for collections that directly inc...

2010-10-06 Thread codesite-noreply

Revision: 8957
Author: r...@google.com
Date: Wed Oct  6 09:35:36 2010
Log: Avoid an infinite loop in toString() for collections that directly  
include themselves


Review at http://gwt-code-reviews.appspot.com/962801

http://code.google.com/p/google-web-toolkit/source/detail?r=8957

Modified:
 /trunk/user/super/com/google/gwt/emul/java/util/AbstractCollection.java

===
--- /trunk/user/super/com/google/gwt/emul/java/util/AbstractCollection.java	 
Fri Jun 13 17:45:25 2008
+++ /trunk/user/super/com/google/gwt/emul/java/util/AbstractCollection.java	 
Wed Oct  6 09:35:36 2010

@@ -142,7 +142,8 @@
   } else {
 comma = , ;
   }
-  sb.append(String.valueOf(iter.next()));
+  E value = iter.next();
+  sb.append(value == this ? (this Collection) :  
String.valueOf(value));

 }
 sb.append(]);
 return sb.toString();

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8958 committed - Updating the doc build file to include the new examples for Cells. Fix...

2010-10-06 Thread codesite-noreply

Revision: 8958
Author: jlaba...@google.com
Date: Wed Oct  6 10:05:51 2010
Log: Updating the doc build file to include the new examples for Cells.  
Fixing the links in the associated JavaDoc.


Review at http://gwt-code-reviews.appspot.com/964801

Review by: fabb...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8958

Modified:
 /trunk/doc/build.xml
 /trunk/user/src/com/google/gwt/cell/client/AbstractCell.java
 /trunk/user/src/com/google/gwt/cell/client/AbstractEditableCell.java
 /trunk/user/src/com/google/gwt/cell/client/Cell.java
 /trunk/user/src/com/google/gwt/user/cellview/client/CellBrowser.java
 /trunk/user/src/com/google/gwt/user/cellview/client/CellList.java
 /trunk/user/src/com/google/gwt/user/cellview/client/CellTable.java
 /trunk/user/src/com/google/gwt/user/cellview/client/CellTree.java
 /trunk/user/src/com/google/gwt/user/cellview/client/SimplePager.java
 /trunk/user/src/com/google/gwt/view/client/AsyncDataProvider.java
 /trunk/user/src/com/google/gwt/view/client/ListDataProvider.java

===
--- /trunk/doc/build.xmlTue Oct  5 19:40:24 2010
+++ /trunk/doc/build.xmlWed Oct  6 10:05:51 2010
@@ -92,7 +92,7 @@
   arg value=-sourcepath /
   arg pathref=USER_SOURCE_PATH /
   arg value=-examplepackages /
-  arg  
value=com.google.gwt.examples;com.google.gwt.examples.i18n;com.google.gwt.examples.http.client;com.google.gwt.examples.rpc.server;com.google.gwt.examples.benchmarks  
/
+  arg  
value=com.google.gwt.examples;com.google.gwt.examples.i18n;com.google.gwt.examples.http.client;com.google.gwt.examples.rpc.server;com.google.gwt.examples.benchmarks;com.google.gwt.examples.cell;com.google.gwt.examples.cellview;com.google.gwt.examples.view  
/

   arg value=-packages /
   arg value=${USER_PKGS};${USER_CLASSES} /
 /java
===
--- /trunk/user/src/com/google/gwt/cell/client/AbstractCell.java	Tue Oct  5  
19:40:24 2010
+++ /trunk/user/src/com/google/gwt/cell/client/AbstractCell.java	Wed Oct  6  
10:05:51 2010

@@ -31,11 +31,11 @@
  * h3Examples/h3
  * dl
  * dtRead only cell/dt
- * ddTODO example com.google.gwt.examples.cell.CellExample/dd
+ * dd{...@example com.google.gwt.examples.cell.CellExample}/dd
  * dtInteractive cell/dt
- * ddTODO example  
com.google.gwt.examples.cell.InteractionCellExample/dd

+ * dd{...@example com.google.gwt.examples.cell.InteractionCellExample}/dd
  * dtEditable cell/dt
- * ddTODO example com.google.gwt.examples.cell.EditableCellExample/dd
+ * dd{...@example com.google.gwt.examples.cell.EditableCellExample}/dd
  * /dl
  * /p
  *
===
--- /trunk/user/src/com/google/gwt/cell/client/AbstractEditableCell.java	 
Tue Oct  5 19:40:24 2010
+++ /trunk/user/src/com/google/gwt/cell/client/AbstractEditableCell.java	 
Wed Oct  6 10:05:51 2010

@@ -27,7 +27,7 @@
  *
  * p
  * h3Example/h3
- * TODO example com.google.gwt.examples.cell.EditableCellExample
+ * {...@example com.google.gwt.examples.cell.EditableCellExample}
  * /p
  *
  * @param C the type that this Cell represents
===
--- /trunk/user/src/com/google/gwt/cell/client/Cell.java	Tue Oct  5  
19:40:24 2010
+++ /trunk/user/src/com/google/gwt/cell/client/Cell.java	Wed Oct  6  
10:05:51 2010

@@ -26,7 +26,7 @@
  *
  * p
  * h3Example/h3
- * TODO example com.google.gwt.examples.cell.CellExample
+ * {...@example com.google.gwt.examples.cell.CellExample}
  * /p
  *
  * @param C the type that this Cell represents
===
--- /trunk/user/src/com/google/gwt/user/cellview/client/CellBrowser.java	 
Tue Oct  5 19:40:24 2010
+++ /trunk/user/src/com/google/gwt/user/cellview/client/CellBrowser.java	 
Wed Oct  6 10:05:51 2010

@@ -74,9 +74,9 @@
  * h3Example/h3
  * dl
  * dtTrivial example/dt
- * ddTODO example  
com.google.gwt.examples.cellview.CellBrowserExample/dd

+ * dd{...@example com.google.gwt.examples.cellview.CellBrowserExample}/dd
  * dtComplex example/dt
- * ddTODO example  
com.google.gwt.examples.cellview.CellBrowserExample2/dd

+ * dd{...@example com.google.gwt.examples.cellview.CellBrowserExample2}/dd
  * /dl
  */
 public class CellBrowser extends AbstractCellTree implements  
ProvidesResize,

===
--- /trunk/user/src/com/google/gwt/user/cellview/client/CellList.java	Tue  
Oct  5 19:40:24 2010
+++ /trunk/user/src/com/google/gwt/user/cellview/client/CellList.java	Wed  
Oct  6 10:05:51 2010

@@ -47,15 +47,14 @@
  *
  * p
  * h3Examples/h3
- * p
- * TODO example com.google.gwt.examples.cellview.CellListExample
- * /p
- * p
- * TODO example  
com.google.gwt.examples.cellview.CellListValueUpdaterExample

- * /p
- * p
- * TODO example com.google.gwt.examples.view.KeyProviderExample
- * /p
+ * dl
+ * dtTrivial example/dt
+ * dd{...@example com.google.gwt.examples.cellview.CellListExample}/dd
+ * dtValueUpdater example/dt
+ * 

[gwt-contrib] Create the list of packages to javadoc dynamically (issue944802)

2010-10-06 Thread rice

Reviewers: jat,

Description:
Create the list of packages to javadoc dynamically
Link out to JSON and JSR 303 javadoc on the Web


Please review this at http://gwt-code-reviews.appspot.com/944802/show

Affected files:
  M doc/build.xml
  A doc/find-packages.sh
  A doc/json-package-list/package-list
  D doc/packages.properties
  A doc/validation-package-list/package-list


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Add Support for server side script selection in linker (issue941802)

2010-10-06 Thread unnurg

http://gwt-code-reviews.appspot.com/941802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Create the list of packages to javadoc dynamically (issue944802)

2010-10-06 Thread jat


http://gwt-code-reviews.appspot.com/944802/diff/1/3
File doc/find-packages.sh (right):

http://gwt-code-reviews.appspot.com/944802/diff/1/3#newcode38
doc/find-packages.sh:38: LANG_PKGS=\\
What does the double-backslash do here?  I would expect it to just leave
a backslash at the end of the line, which doesn't make sense.

http://gwt-code-reviews.appspot.com/944802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Create the list of packages to javadoc dynamically (issue944802)

2010-10-06 Thread rice


http://gwt-code-reviews.appspot.com/944802/diff/1/3
File doc/find-packages.sh (right):

http://gwt-code-reviews.appspot.com/944802/diff/1/3#newcode38
doc/find-packages.sh:38: LANG_PKGS=\\
We are generating a file that will have backslashes at the end of its
lines.

On 2010/10/06 20:19:10, jat wrote:

What does the double-backslash do here?  I would expect it to just

leave a

backslash at the end of the line, which doesn't make sense.


http://gwt-code-reviews.appspot.com/944802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Updating the doc build file to include the new examples for Cells. Fixing the links in the assoc... (issue964801)

2010-10-06 Thread jlabanca

committed as r8958

http://gwt-code-reviews.appspot.com/964801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Create the list of packages to javadoc dynamically (issue944802)

2010-10-06 Thread jat

On 2010/10/06 20:23:04, rice wrote:

http://gwt-code-reviews.appspot.com/944802/diff/1/3
File doc/find-packages.sh (right):



http://gwt-code-reviews.appspot.com/944802/diff/1/3#newcode38
doc/find-packages.sh:38: LANG_PKGS=\\
We are generating a file that will have backslashes at the end of its

lines.

LGTM assuming it works :).

http://gwt-code-reviews.appspot.com/944802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8960 committed - Create the list of packages to javadoc dynamically...

2010-10-06 Thread codesite-noreply

Revision: 8960
Author: gwt.mirror...@gmail.com
Date: Wed Oct  6 13:42:42 2010
Log: Create the list of packages to javadoc dynamically
Link out to JSON and JSR 303 javadoc on the Web

Review at http://gwt-code-reviews.appspot.com/944802

Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8960

Added:
 /trunk/doc/find-packages.sh
 /trunk/doc/json-package-list
 /trunk/doc/json-package-list/package-list
 /trunk/doc/validation-package-list
 /trunk/doc/validation-package-list/package-list
Deleted:
 /trunk/doc/packages.properties
Modified:
 /trunk/doc/build.xml

===
--- /dev/null
+++ /trunk/doc/find-packages.sh Wed Oct  6 13:42:42 2010
@@ -0,0 +1,93 @@
+#!/bin/bash
+set noglob
+
+OUTFILE=packages.properties
+TMPFILE=/tmp/gwt-javadoc-packages$$
+
+# Regex patterns to exclude from the list of packages
+EXCLUSIONS=\
+^com\.example\.|\
+^com\.google\.gwt\.dev(\.|$)|\
+^com\.google\.gwt\.emul\.|\
+^com\.google\.gwt\.examples(\.|$)|\
+^com\.google\.gwt\.i18n\.server(\.|$)|\
+^com\.google\.gwt\.i18n\.tools|\
+^com\.google\.gwt\.lang|\
+^com\.google\.gwt\.junit(\.|$)|\
+^com\.google\.gwt\.resources\.css(\.|$)|\
+^com\.google\.gwt\.resources\.rg(\.|$)|\
+^com\.google\.gwt\.rpc\.client\.ast(\.|$)|\
+^com\.google\.gwt\.soyc(\.|$)|\
+^com\.google\.gwt\.validation(.|$)|\
+^com\.google\.gwt\.user\.client\.rpc\.core\.|\
+^javax\.|\
+^junit\.|\
+^org\.|\
+\.impl(\.|$)|\
+\.rebind(\.|$)
+
+# Generate the packages.properties file
+# Changes to LANG_PKGS and USER_CLASSES go here
+# Note that line continuation backslashes must be escaped
+cat  ${OUTFILE} EOF
+# THIS FILE IS AUTOMATICALLY GENERATED
+#
+# This file contains all of the user javadoc packages
+#
+# JRE emulation packages
+LANG_PKGS=\\
+java.lang;\\
+java.lang.annotation;\\
+java.io;\\
+java.sql;\\
+java.util
+# The last package should not have a trailing semicolon
+
+# Individual classes to include when we don't want to include an entire  
package

+USER_CLASSES=\\
+\${gwt.root}/user/src/com/google/gwt/junit/tools/GWTTestSuite.java:\\
+\${gwt.root}/user/src/com/google/gwt/i18n/rebind/LocaleUtils.java:\\
+\${gwt.root}/user/src/com/google/gwt/i18n/server/GwtLocaleFactoryImpl.java:\\
+\${gwt.root}/user/src/com/google/gwt/i18n/server/GwtLocaleImpl.java
+
+# Packages to include
+USER_PKGS=\\
+EOF
+
+rm -f ${TMPFILE}
+
+# Create a list of all packages with at least one Java source file
+# List all source files
+for dir  
in ../user/src ../user/javadoc ../user/super ../dev/core/src ../dev/core/super

+do
+(cd ${dir}; find . -name '*.java')  ${TMPFILE}
+done
+
+cat ${TMPFILE} | \
+# Remove source file names
+sed 's@/[-A-Za-z0-9_]*\.java$@@'| \
+# Removce initial './'
+sed s...@^\./@@ | \
+# Remove .../super/ and .../translatable prefixes
+sed s...@^.*/super/@@ | \
+sed s...@^.*/translatable/@@ | \
+# Change slashes to dots
+sed s@/@@g | \
+# Remove excluded patters
+egrep -v ${EXCLUSIONS}  ${TMPFILE}-2
+mv ${TMPFILE}-2 ${TMPFILE}
+
+# Re-add whitelisted packages that would otherwise be excluded
+echo com.google.gwt.i18n.rebind.format  ${TMPFILE}
+echo com.google.gwt.i18n.rebind.keygen  ${TMPFILE}
+echo com.google.gwt.junit.client  ${TMPFILE}
+
+# Sort, uniqify, and add ';\' to each line except the last
+cat ${TMPFILE} | \
+sort | \
+uniq | \
+sed '$q;s...@$@;\\@'  ${OUTFILE}
+echo '# The last package should not have a trailing semicolon'   
${OUTFILE}

+
+# Clean up
+rm -f ${TMPFILE}
===
--- /dev/null
+++ /trunk/doc/json-package-list/package-list   Wed Oct  6 13:42:42 2010
@@ -0,0 +1,1 @@
+org.json
===
--- /dev/null
+++ /trunk/doc/validation-package-list/package-list Wed Oct  6 13:42:42 2010
@@ -0,0 +1,2 @@
+javax.validation
+javax.validation.constraints
===
--- /trunk/doc/packages.properties  Tue Oct  5 11:17:27 2010
+++ /dev/null
@@ -1,87 +0,0 @@
-# This file contains all of the user javadoc packages.
-LANG_PKGS=\
-java.lang;\
-java.lang.annotation;\
-java.io;\
-java.sql;\
-java.util
-# The last package should not have a trailing semicolon
-
-# Individual classes to include when we don't want to include an entire  
package.

-USER_CLASSES=\
-${gwt.root}/user/src/com/google/gwt/junit/tools/GWTTestSuite.java:\
-${gwt.root}/user/src/com/google/gwt/i18n/rebind/LocaleUtils.java:\
-${gwt.root}/user/src/com/google/gwt/i18n/server/GwtLocaleFactoryImpl.java:\
-${gwt.root}/user/src/com/google/gwt/i18n/server/GwtLocaleImpl.java
-
-USER_PKGS=\
-com.google.gwt.animation.client;\
-com.google.gwt.app.client;\
-com.google.gwt.app.place;\
-com.google.gwt.benchmarks;\
-com.google.gwt.benchmarks.client;\
-com.google.gwt.cell.client;\
-com.google.gwt.core.client;\
-com.google.gwt.core.client.prefetch;\
-com.google.gwt.core.ext;\
-com.google.gwt.core.ext.linker;\
-com.google.gwt.core.ext.soyc;\
-com.google.gwt.core.ext.typeinfo;\
-com.google.gwt.core.linker;\
-com.google.gwt.debug.client;\

[gwt-contrib] [google-web-toolkit] r8959 committed - Adding tools files missed from r8952.

2010-10-06 Thread codesite-noreply

Revision: 8959
Author: fabb...@google.com
Date: Wed Oct  6 13:41:45 2010
Log: Adding tools files missed from r8952.

http://code.google.com/p/google-web-toolkit/source/detail?r=8959

Added:
 /tools/lib/hibernate/validator/hibernate-validator-4.1.0.Final-sources.jar
 /tools/lib/javax/activation
 /tools/lib/javax/activation/activation-1.1.jar
 /tools/lib/javax/xml
 /tools/lib/javax/xml/bind
 /tools/lib/javax/xml/bind/jaxb-api-2.1.jar
 /tools/lib/javax/xml/stream
 /tools/lib/javax/xml/stream/stax-api-1.0-2.jar
 /tools/lib/sun/jaxb
 /tools/lib/sun/jaxb/jaxb-impl-2.1.3.jar

===
--- /dev/null   
+++  
/tools/lib/hibernate/validator/hibernate-validator-4.1.0.Final-sources.jar	 
Wed Oct  6 13:41:45 2010

Binary file, no diff available.
===
--- /dev/null   
+++ /tools/lib/javax/activation/activation-1.1.jar  Wed Oct  6 13:41:45 2010
Binary file, no diff available.
===
--- /dev/null   
+++ /tools/lib/javax/xml/bind/jaxb-api-2.1.jar  Wed Oct  6 13:41:45 2010
Binary file, no diff available.
===
--- /dev/null   
+++ /tools/lib/javax/xml/stream/stax-api-1.0-2.jar  Wed Oct  6 13:41:45 2010
Binary file, no diff available.
===
--- /dev/null   
+++ /tools/lib/sun/jaxb/jaxb-impl-2.1.3.jar Wed Oct  6 13:41:45 2010
Binary file, no diff available.

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] 2 questions about TabBar internals

2010-10-06 Thread jay
While debugging my code I ran across two things within the TabBar
class that I seemed strange... (Line numbers are from svn 8960.)

1.
com.google.gwt.user.client.ui.TabBar.ClickDelegatePanel#onBrowserEvent
-- There's a comment on line 149: // No need for call to super., and
yet there *is* a call to super.onBrowserEvent. I assume the comment
should be deleted?

2. com.google.gwt.user.client.ui.TabBar#TabBar -- Line 201 is
first.setHeight(100%); and guess what's on line 206? The same
thing! I'm guessing one of these is not necessary.


Thanks,

jay

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Clean up Cell-related javadoc (issue966801)

2010-10-06 Thread rice

Reviewers: jlabanca,

Description:
Clean up Cell-related javadoc


Please review this at http://gwt-code-reviews.appspot.com/966801/show

Affected files:
  M user/javadoc/com/google/gwt/examples/cellview/CellBrowserExample2.java
  M user/javadoc/com/google/gwt/examples/cellview/CellTreeExample2.java
  M user/src/com/google/gwt/cell/client/AbstractSafeHtmlCell.java
  M user/src/com/google/gwt/cell/client/ActionCell.java
  M user/src/com/google/gwt/cell/client/ButtonCell.java
  M user/src/com/google/gwt/cell/client/Cell.java
  M user/src/com/google/gwt/cell/client/CheckboxCell.java
  M user/src/com/google/gwt/cell/client/ClickableTextCell.java
  M user/src/com/google/gwt/cell/client/CompositeCell.java
  M user/src/com/google/gwt/cell/client/DateCell.java
  M user/src/com/google/gwt/cell/client/DatePickerCell.java
  M user/src/com/google/gwt/cell/client/EditTextCell.java
  M user/src/com/google/gwt/cell/client/FieldUpdater.java
  M user/src/com/google/gwt/cell/client/HasCell.java
  M user/src/com/google/gwt/cell/client/IconCellDecorator.java
  M user/src/com/google/gwt/cell/client/ImageCell.java
  M user/src/com/google/gwt/cell/client/ImageLoadingCell.java
  M user/src/com/google/gwt/cell/client/ImageResourceCell.java
  M user/src/com/google/gwt/cell/client/SafeHtmlCell.java
  M user/src/com/google/gwt/cell/client/SelectionCell.java
  M user/src/com/google/gwt/cell/client/TextCell.java
  M user/src/com/google/gwt/cell/client/TextInputCell.java
  M user/src/com/google/gwt/cell/client/ValueUpdater.java
  M user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
  M user/src/com/google/gwt/user/cellview/client/CellBrowser.java
  M user/src/com/google/gwt/user/cellview/client/CellList.java
  M user/src/com/google/gwt/user/cellview/client/CellTable.java
  M user/src/com/google/gwt/user/cellview/client/CellTree.java
  M user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
  M user/src/com/google/gwt/user/cellview/client/Column.java
  M user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java
  M user/src/com/google/gwt/user/cellview/client/Header.java
  M user/src/com/google/gwt/user/cellview/client/IdentityColumn.java
  M user/src/com/google/gwt/user/cellview/client/PageSizePager.java
  M user/src/com/google/gwt/user/cellview/client/SafeHtmlHeader.java
  M user/src/com/google/gwt/user/cellview/client/TextColumn.java
  M user/src/com/google/gwt/user/cellview/client/TextHeader.java
  M user/src/com/google/gwt/view/client/AbstractDataProvider.java
  M user/src/com/google/gwt/view/client/DefaultSelectionModel.java
  M user/src/com/google/gwt/view/client/HasData.java
  M user/src/com/google/gwt/view/client/HasKeyProvider.java
  M user/src/com/google/gwt/view/client/HasRows.java
  M user/src/com/google/gwt/view/client/ListDataProvider.java
  M user/src/com/google/gwt/view/client/MultiSelectionModel.java
  M user/src/com/google/gwt/view/client/NoSelectionModel.java
  M user/src/com/google/gwt/view/client/ProvidesKey.java
  M user/src/com/google/gwt/view/client/Range.java
  M user/src/com/google/gwt/view/client/RangeChangeEvent.java
  M user/src/com/google/gwt/view/client/RowCountChangeEvent.java
  M user/src/com/google/gwt/view/client/SelectionChangeEvent.java
  M user/src/com/google/gwt/view/client/SelectionModel.java
  M user/src/com/google/gwt/view/client/SimpleKeyProvider.java
  M user/src/com/google/gwt/view/client/SingleSelectionModel.java
  M user/src/com/google/gwt/view/client/TreeViewModel.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Miscellaneous Javadoc fixes: (issue967801)

2010-10-06 Thread rice

Reviewers: rchandia,

Description:
Miscellaneous Javadoc fixes:
Use 'Returns X.' instead of @return X by itself in order to have
something appear in the summary field.
Spelling


Please review this at http://gwt-code-reviews.appspot.com/967801/show

Affected files:
  M user/javadoc/com/google/gwt/examples/i18n/NumberFormatConstants.java
  M  
user/javadoc/com/google/gwt/examples/i18n/NumberFormatConstantsAnnot.java
  M  
user/javadoc/com/google/gwt/examples/i18n/NumberFormatConstantsWithAltKey.java
  M  
user/javadoc/com/google/gwt/examples/i18n/NumberFormatConstantsWithLookup.java

  M user/src/com/google/gwt/activity/shared/Activity.java
  M user/src/com/google/gwt/activity/shared/ActivityManager.java
  M user/src/com/google/gwt/dom/client/TagName.java
  M user/src/com/google/gwt/event/dom/client/HasErrorHandlers.java
  M user/src/com/google/gwt/event/logical/shared/AttachEvent.java
  M user/src/com/google/gwt/event/logical/shared/HasAttachHandlers.java
  M user/src/com/google/gwt/event/logical/shared/HasInitializeHandlers.java
  M user/src/com/google/gwt/event/logical/shared/HasOpenHandlers.java
  M user/src/com/google/gwt/i18n/client/BidiPolicy.java
  M user/src/com/google/gwt/i18n/client/CurrencyData.java
  M user/src/com/google/gwt/i18n/client/DateTimeFormatInfo.java
  M user/src/com/google/gwt/i18n/client/LocaleInfo.java
  M user/src/com/google/gwt/i18n/client/NumberFormat.java
  M user/src/com/google/gwt/i18n/client/PluralRule.java
  M user/src/com/google/gwt/i18n/client/TimeZone.java
  M user/src/com/google/gwt/i18n/client/impl/CldrImpl.java
  M user/src/com/google/gwt/i18n/client/impl/LocaleInfoImpl.java
  M user/src/com/google/gwt/i18n/rebind/AbstractResource.java
  M user/src/com/google/gwt/i18n/rebind/LocaleUtils.java
  M user/src/com/google/gwt/i18n/rebind/LookupMethodCreator.java
  M user/src/com/google/gwt/i18n/rebind/MessageFormatParser.java
  M user/src/com/google/gwt/i18n/rebind/MessagesMethodCreator.java
  M user/src/com/google/gwt/i18n/rebind/format/MessageCatalogFormat.java
  M user/src/com/google/gwt/i18n/shared/BidiFormatter.java
  M user/src/com/google/gwt/i18n/shared/GwtLocale.java
  M user/src/com/google/gwt/i18n/shared/GwtLocaleFactory.java
  M user/src/com/google/gwt/i18n/shared/HasDirectionEstimator.java
  M user/src/com/google/gwt/jsonp/client/JsonpRequest.java
  M user/src/com/google/gwt/jsonp/client/JsonpRequestBuilder.java
  M user/src/com/google/gwt/junit/GWTDummyBridge.java
  M user/src/com/google/gwt/junit/client/GWTTestCase.java
  M user/src/com/google/gwt/place/shared/PlaceChangeRequestEvent.java
  M user/src/com/google/gwt/place/shared/PlaceController.java
  M user/src/com/google/gwt/regexp/shared/MatchResult.java
  M user/src/com/google/gwt/regexp/shared/RegExp.java
  M user/src/com/google/gwt/regexp/shared/SplitResult.java
  M  
user/src/com/google/gwt/regexp/super/com/google/gwt/regexp/shared/MatchResult.java
  M  
user/src/com/google/gwt/regexp/super/com/google/gwt/regexp/shared/RegExp.java

  M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java
  M user/src/com/google/gwt/requestfactory/shared/EntityProxyChange.java
  M user/src/com/google/gwt/requestfactory/shared/impl/Property.java
  M user/src/com/google/gwt/resources/ext/ResourceGeneratorUtil.java
  M  
user/src/com/google/gwt/resources/rebind/context/ClientBundleContext.java

  M user/src/com/google/gwt/safehtml/rebind/HtmlTemplateParser.java
  M user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java
  M user/src/com/google/gwt/text/client/DoubleParser.java
  M user/src/com/google/gwt/text/client/DoubleRenderer.java
  M user/src/com/google/gwt/text/client/IntegerParser.java
  M user/src/com/google/gwt/text/client/IntegerRenderer.java
  M user/src/com/google/gwt/text/client/LongParser.java
  M user/src/com/google/gwt/text/client/LongRenderer.java
  M user/src/com/google/gwt/text/shared/testing/PassthroughParser.java
  M user/src/com/google/gwt/text/shared/testing/PassthroughRenderer.java
  M  
user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java

  M user/src/com/google/gwt/uibinder/client/UiTemplate.java
  M user/src/com/google/gwt/uibinder/rebind/DesignTimeUtils.java
  M user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsImpl.java
  M user/src/com/google/gwt/uibinder/rebind/FieldReference.java
  M user/src/com/google/gwt/uibinder/rebind/FieldWriter.java
  M user/src/com/google/gwt/uibinder/rebind/MonitoredLogger.java
  M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
  M user/src/com/google/gwt/uibinder/rebind/XMLElement.java
  M user/src/com/google/gwt/uibinder/rebind/messages/MessagesWriter.java
  M user/src/com/google/gwt/uibinder/rebind/model/ImplicitCssResource.java
  M user/src/com/google/gwt/user/client/WindowCloseListener.java
  M user/src/com/google/gwt/user/client/ui/AcceptsOneWidget.java
  M user/src/com/google/gwt/user/client/ui/CaptionPanel.java
  M user/src/com/google/gwt/user/client/ui/FormHandlerCollection.java
 

[gwt-contrib] Re: Clean up Cell-related javadoc (issue966801)

2010-10-06 Thread jlabanca

LGTM


http://gwt-code-reviews.appspot.com/966801/diff/1/2
File
user/javadoc/com/google/gwt/examples/cellview/CellBrowserExample2.java
(right):

http://gwt-code-reviews.appspot.com/966801/diff/1/2#newcode64
user/javadoc/com/google/gwt/examples/cellview/CellBrowserExample2.java:64:
* Return the list of songs in the playlist.
Whats wrong with @return?

http://gwt-code-reviews.appspot.com/966801/diff/1/12
File user/src/com/google/gwt/cell/client/DatePickerCell.java (right):

http://gwt-code-reviews.appspot.com/966801/diff/1/12#newcode40
user/src/com/google/gwt/cell/client/DatePickerCell.java:40: * using the
{...@code DatePicker}, the new date is passed to the
These @code can become @link.

http://gwt-code-reviews.appspot.com/966801/diff/1/38
File user/src/com/google/gwt/user/cellview/client/TextHeader.java
(right):

http://gwt-code-reviews.appspot.com/966801/diff/1/38#newcode28
user/src/com/google/gwt/user/cellview/client/TextHeader.java:28: *
Construct a new TextColumn.
TextColumn - TextHeader

http://gwt-code-reviews.appspot.com/966801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Miscellaneous Javadoc fixes: (issue967801)

2010-10-06 Thread jat


http://gwt-code-reviews.appspot.com/967801/diff/1/2
File
user/javadoc/com/google/gwt/examples/i18n/NumberFormatConstants.java
(right):

http://gwt-code-reviews.appspot.com/967801/diff/1/2#newcode8
user/javadoc/com/google/gwt/examples/i18n/NumberFormatConstants.java:8:
* Return the localized decimal separator.
Why change @Return to return?  Our normal convention for one-line
javadoc on getters is @return whatever., so I think you should just
add the period.

http://gwt-code-reviews.appspot.com/967801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8961 committed - Add ICU4J 4.4.2 jars - updates to GWT build/project files will come...

2010-10-06 Thread codesite-noreply

Revision: 8961
Author: j...@google.com
Date: Wed Oct  6 14:31:57 2010
Log: Add ICU4J 4.4.2 jars - updates to GWT build/project files will come
separately.

Patch by: jat
Review by: pdr

http://code.google.com/p/google-web-toolkit/source/detail?r=8961

Added:
 /tools/lib/icu4j/4.4.2
 /tools/lib/icu4j/4.4.2/README.txt
 /tools/lib/icu4j/4.4.2/icu4j-charsets.jar
 /tools/lib/icu4j/4.4.2/icu4j-localespi.jar
 /tools/lib/icu4j/4.4.2/icu4j.jar
 /tools/lib/icu4j/4.4.2/icu4jsrc.jar
 /tools/lib/icu4j/4.4.2/license.html
 /tools/lib/icu4j/4.4.2/unicode-license.txt
 /tools/lib/icu4j/4.4.2/utilities.jar

===
--- /dev/null
+++ /tools/lib/icu4j/4.4.2/README.txt   Wed Oct  6 14:31:57 2010
@@ -0,0 +1,5 @@
+Built from the ICU4J public repository, tags/release-4-4-2
+
+ant jar jarSrc cldrUtil
+cp main/shared/licenses/*.{txt,html} icu4j*.jar \
+  out/cldr_util/lib/utilities.jar $GWT_TOOLS/lib/icu4j/4.4.2
===
--- /dev/null   
+++ /tools/lib/icu4j/4.4.2/icu4j-charsets.jar   Wed Oct  6 14:31:57 2010
File is too large to display a diff.
===
--- /dev/null   
+++ /tools/lib/icu4j/4.4.2/icu4j-localespi.jar  Wed Oct  6 14:31:57 2010
Binary file, no diff available.
===
--- /dev/null   
+++ /tools/lib/icu4j/4.4.2/icu4j.jarWed Oct  6 14:31:57 2010
File is too large to display a diff.
===
--- /dev/null   
+++ /tools/lib/icu4j/4.4.2/icu4jsrc.jar Wed Oct  6 14:31:57 2010
File is too large to display a diff.
===
--- /dev/null
+++ /tools/lib/icu4j/4.4.2/license.html Wed Oct  6 14:31:57 2010
@@ -0,0 +1,51 @@
+html
+
+head
+meta http-equiv=Content-Type content=text/html;  
charset=us-ascii/meta

+titleICU License - ICU 1.8.1 and later/title
+/head
+
+body BGCOLOR=#ff
+h2ICU License - ICU 1.8.1 and later/h2
+
+pCOPYRIGHT AND PERMISSION NOTICE/p
+
+p
+Copyright (c) 1995-2010 International Business Machines Corporation and  
others

+/p
+p
+All rights reserved.
+/p
+p
+Permission is hereby granted, free of charge, to any person obtaining a  
copy

+of this software and associated documentation files (the Software),
+to deal in the Software without restriction, including without limitation
+the rights to use, copy, modify, merge, publish, distribute, and/or sell
+copies of the Software, and to permit persons
+to whom the Software is furnished to do so, provided that the above
+copyright notice(s) and this permission notice appear in all copies
+of the Software and that both the above copyright notice(s) and this
+permission notice appear in supporting documentation.
+/p
+p
+THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR  
IMPLIED,
+INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS  
FOR A
+PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS. IN NO EVENT  
SHALL
+THE COPYRIGHT HOLDER OR HOLDERS INCLUDED IN THIS NOTICE BE LIABLE FOR ANY  
CLAIM,

+OR ANY SPECIAL INDIRECT OR CONSEQUENTIAL DAMAGES, OR ANY DAMAGES WHATSOEVER
+RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF  
CONTRACT,
+NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH  
THE

+USE OR PERFORMANCE OF THIS SOFTWARE.
+/p
+p
+Except as contained in this notice, the name of a copyright holder shall  
not be
+used in advertising or otherwise to promote the sale, use or other  
dealings in

+this Software without prior written authorization of the copyright holder.
+/p
+
+hr
+psmall
+All trademarks and registered trademarks mentioned herein are the property  
of their respective owners.

+/small/p
+/body
+/html
===
--- /dev/null
+++ /tools/lib/icu4j/4.4.2/unicode-license.txt  Wed Oct  6 14:31:57 2010
@@ -0,0 +1,48 @@
+UNICODE, INC. LICENSE AGREEMENT - DATA FILES AND SOFTWARE
+
+Unicode Data Files include all data files under the directories
+http://www.unicode.org/Public/, http://www.unicode.org/reports/, and
+http://www.unicode.org/cldr/data/ . Unicode Software includes any source  
code

+published in the Unicode Standard or under the directories
+http://www.unicode.org/Public/, http://www.unicode.org/reports/, and
+http://www.unicode.org/cldr/data/.
+
+NOTICE TO USER: Carefully read the following legal agreement. BY
+DOWNLOADING, INSTALLING, COPYING OR OTHERWISE USING UNICODE INC.'S DATA  
FILES

+(DATA FILES), AND/OR SOFTWARE (SOFTWARE), YOU UNEQUIVOCALLY ACCEPT, AND
+AGREE TO BE BOUND BY, ALL OF THE TERMS AND CONDITIONS OF THIS AGREEMENT.  
IF YOU
+DO NOT AGREE, DO NOT DOWNLOAD, INSTALL, COPY, DISTRIBUTE OR USE THE DATA  
FILES

+OR SOFTWARE.
+
+COPYRIGHT AND PERMISSION NOTICE
+
+Copyright © 1991-2009 Unicode, Inc. All rights reserved. Distributed  
under

+the Terms of Use in http://www.unicode.org/copyright.html.
+
+Permission is hereby granted, free of charge, to any person obtaining  
a copy
+of the Unicode data 

Re: [gwt-contrib] CellTable headersStale

2010-10-06 Thread Stephen Haberman

 I'm using CellTable to render a table with a total footer. However,
 the footer is not redrawn when I change the rows in the table, so the
 total always says $0.00. Looking at the code, it looks like
 headersStale is only set true if I add/remove a column.

Having footers update when the rows change really seems like a pretty
common use case.

Should I file a bug over in the ROO tracker to get a response for this?

Thanks,
Stephen

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors


Re: [gwt-contrib] CellTable headersStale

2010-10-06 Thread John LaBanca
That sounds reasonable.  We should either have a boolean to refresh the
headers, or just refresh them all the time.  Please open an issue in jira
and assign it to me.

Thanks,
John LaBanca
jlaba...@google.com


On Wed, Oct 6, 2010 at 6:45 PM, Stephen Haberman
step...@exigencecorp.comwrote:


  I'm using CellTable to render a table with a total footer. However,
  the footer is not redrawn when I change the rows in the table, so the
  total always says $0.00. Looking at the code, it looks like
  headersStale is only set true if I add/remove a column.

 Having footers update when the rows change really seems like a pretty
 common use case.

 Should I file a bug over in the ROO tracker to get a response for this?

 Thanks,
 Stephen

 --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8962 committed - Cherry picks from trunk to releases/2.1:...

2010-10-06 Thread codesite-noreply

Revision: 8962
Author: gwt.mirror...@gmail.com
Date: Wed Oct  6 16:38:47 2010
Log: Cherry picks from trunk to releases/2.1:

r8958 Updating the doc build file to include the new examples for Cells
rTBD Resolves ROO-1508 by requiring CompositeEditors to return a canonical  
component Editor instance for path traversal



http://code.google.com/p/google-web-toolkit/source/detail?r=8962

Added:
 /releases/2.1/doc/find-packages.sh
 /releases/2.1/doc/json-package-list
 /releases/2.1/doc/json-package-list/package-list
 /releases/2.1/doc/validation-package-list
 /releases/2.1/doc/validation-package-list/package-list
Deleted:
 /releases/2.1/doc/packages.properties
Modified:
 /releases/2.1/doc/build.xml
 /releases/2.1/user/src/com/google/gwt/editor/client/CompositeEditor.java
  
/releases/2.1/user/src/com/google/gwt/editor/client/adapters/ListEditor.java
  
/releases/2.1/user/src/com/google/gwt/editor/client/adapters/OptionalFieldEditor.java
  
/releases/2.1/user/src/com/google/gwt/editor/rebind/AbstractEditorDriverGenerator.java

 /releases/2.1/user/src/com/google/gwt/editor/rebind/model/EditorModel.java
  
/releases/2.1/user/test/com/google/gwt/requestfactory/client/ui/EditorTest.java


===
--- /dev/null
+++ /releases/2.1/doc/find-packages.sh  Wed Oct  6 16:38:47 2010
@@ -0,0 +1,93 @@
+#!/bin/bash
+set noglob
+
+OUTFILE=packages.properties
+TMPFILE=/tmp/gwt-javadoc-packages$$
+
+# Regex patterns to exclude from the list of packages
+EXCLUSIONS=\
+^com\.example\.|\
+^com\.google\.gwt\.dev(\.|$)|\
+^com\.google\.gwt\.emul\.|\
+^com\.google\.gwt\.examples(\.|$)|\
+^com\.google\.gwt\.i18n\.server(\.|$)|\
+^com\.google\.gwt\.i18n\.tools|\
+^com\.google\.gwt\.lang|\
+^com\.google\.gwt\.junit(\.|$)|\
+^com\.google\.gwt\.resources\.css(\.|$)|\
+^com\.google\.gwt\.resources\.rg(\.|$)|\
+^com\.google\.gwt\.rpc\.client\.ast(\.|$)|\
+^com\.google\.gwt\.soyc(\.|$)|\
+^com\.google\.gwt\.validation(.|$)|\
+^com\.google\.gwt\.user\.client\.rpc\.core\.|\
+^javax\.|\
+^junit\.|\
+^org\.|\
+\.impl(\.|$)|\
+\.rebind(\.|$)
+
+# Generate the packages.properties file
+# Changes to LANG_PKGS and USER_CLASSES go here
+# Note that line continuation backslashes must be escaped
+cat  ${OUTFILE} EOF
+# THIS FILE IS AUTOMATICALLY GENERATED
+#
+# This file contains all of the user javadoc packages
+#
+# JRE emulation packages
+LANG_PKGS=\\
+java.lang;\\
+java.lang.annotation;\\
+java.io;\\
+java.sql;\\
+java.util
+# The last package should not have a trailing semicolon
+
+# Individual classes to include when we don't want to include an entire  
package

+USER_CLASSES=\\
+\${gwt.root}/user/src/com/google/gwt/junit/tools/GWTTestSuite.java:\\
+\${gwt.root}/user/src/com/google/gwt/i18n/rebind/LocaleUtils.java:\\
+\${gwt.root}/user/src/com/google/gwt/i18n/server/GwtLocaleFactoryImpl.java:\\
+\${gwt.root}/user/src/com/google/gwt/i18n/server/GwtLocaleImpl.java
+
+# Packages to include
+USER_PKGS=\\
+EOF
+
+rm -f ${TMPFILE}
+
+# Create a list of all packages with at least one Java source file
+# List all source files
+for dir  
in ../user/src ../user/javadoc ../user/super ../dev/core/src ../dev/core/super

+do
+(cd ${dir}; find . -name '*.java')  ${TMPFILE}
+done
+
+cat ${TMPFILE} | \
+# Remove source file names
+sed 's@/[-A-Za-z0-9_]*\.java$@@'| \
+# Removce initial './'
+sed s...@^\./@@ | \
+# Remove .../super/ and .../translatable prefixes
+sed s...@^.*/super/@@ | \
+sed s...@^.*/translatable/@@ | \
+# Change slashes to dots
+sed s@/@@g | \
+# Remove excluded patters
+egrep -v ${EXCLUSIONS}  ${TMPFILE}-2
+mv ${TMPFILE}-2 ${TMPFILE}
+
+# Re-add whitelisted packages that would otherwise be excluded
+echo com.google.gwt.i18n.rebind.format  ${TMPFILE}
+echo com.google.gwt.i18n.rebind.keygen  ${TMPFILE}
+echo com.google.gwt.junit.client  ${TMPFILE}
+
+# Sort, uniqify, and add ';\' to each line except the last
+cat ${TMPFILE} | \
+sort | \
+uniq | \
+sed '$q;s...@$@;\\@'  ${OUTFILE}
+echo '# The last package should not have a trailing semicolon'   
${OUTFILE}

+
+# Clean up
+rm -f ${TMPFILE}
===
--- /dev/null
+++ /releases/2.1/doc/json-package-list/package-list	Wed Oct  6 16:38:47  
2010

@@ -0,0 +1,1 @@
+org.json
===
--- /dev/null
+++ /releases/2.1/doc/validation-package-list/package-list	Wed Oct  6  
16:38:47 2010

@@ -0,0 +1,2 @@
+javax.validation
+javax.validation.constraints
===
--- /releases/2.1/doc/packages.properties   Tue Sep 21 03:59:38 2010
+++ /dev/null
@@ -1,65 +0,0 @@
-# This file contains all of the user javadoc packages.
-LANG_PKGS=\
-java.lang;\
-java.lang.annotation;\
-java.io;\
-java.sql;\
-java.util
-# The last package should not have a trailing semicolon
-
-# Individual classes to include when we don't want to include an entire  
package.

-USER_CLASSES=\
-${gwt.root}/user/src/com/google/gwt/junit/tools/GWTTestSuite.java:\

[gwt-contrib] [google-web-toolkit] r8963 committed - Removing 2.1.0-rc1 tag

2010-10-06 Thread codesite-noreply

Revision: 8963
Author: p...@google.com
Date: Wed Oct  6 17:26:23 2010
Log: Removing 2.1.0-rc1 tag

http://code.google.com/p/google-web-toolkit/source/detail?r=8963

Deleted:
 /tags/2.1.0-rc1

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r8964 committed - Creating new, fixed 2.1.0-rc1 tag.

2010-10-06 Thread codesite-noreply

Revision: 8964
Author: p...@google.com
Date: Wed Oct  6 17:27:25 2010
Log: Creating new, fixed 2.1.0-rc1 tag.

http://code.google.com/p/google-web-toolkit/source/detail?r=8964

Added:
 /tags/2.1.0-rc1

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Fix the DevMode Swing UI to avoid clipping buttons when the URL (issue952802)

2010-10-06 Thread jat

Reviewers: fredsa,

Description:
Fix the DevMode Swing UI to avoid clipping buttons when the URL
is too large or the window is resized.

Patch by: jat
Review by: fredsa


Please review this at http://gwt-code-reviews.appspot.com/952802/show

Affected files:
  M dev/core/src/com/google/gwt/dev/ModuleTabPanel.java
  M dev/core/src/com/google/gwt/dev/WebServerPanel.java
  M dev/core/src/com/google/gwt/dev/shell/ShellMainWindow.java
  A dev/core/src/com/google/gwt/dev/shell/WrapLayout.java
  M dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors